Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609 )
Change subject: bsc: cbsp: Expect one Reset/Failure Ind for each Bcast Msg Type
......................................................................
Patch Set 2:
(1 comment)
File bsc/BSC_Tests_CBSP.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609/comment/80a5adc9_d84a…
PS1, Line 570: [not received_cbs] CBSP[0].receive(tr_CBSP_Recv(g_cbsp_conn_id[0], rx_cbs)) {
> this kind of construct looks like a prime use case for 'interleave' instead of 'alt. […]
Yeah I thought about the interleave but indeed I didn't know how to handle the "received unexpected BSP" case then. Good to know about the activate also working in interlave. Not sure it's worth to invest time change that anyway, we can simply merge imho.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05da2f61d26a1124d30793184d81aabf212cddda
Gerrit-Change-Number: 28609
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 15 Jul 2022 13:50:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder, laforge, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28608
to look at the new patch set (#2).
Change subject: bsc_cbsp: Support receiving CGI as cellID in CBSP Reset and Failure Ind
......................................................................
bsc_cbsp: Support receiving CGI as cellID in CBSP Reset and Failure Ind
New versions of osmo-bsc send CGI instead of LAC+CI, which provides more
information (PLMN).
Related: SYS#5910
Change-Id: I48e86150f499f0f458f75f132087319d80f86448
---
M bsc/BSC_Tests_CBSP.ttcn
M library/CBSP_Templates.ttcn
2 files changed, 31 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/28608/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I48e86150f499f0f458f75f132087319d80f86448
Gerrit-Change-Number: 28608
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609 )
Change subject: bsc: cbsp: Expect one Reset/Failure Ind for each Bcast Msg Type
......................................................................
Patch Set 1:
(1 comment)
File bsc/BSC_Tests_CBSP.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609/comment/877e2cab_2d97…
PS1, Line 570: [not received_cbs] CBSP[0].receive(tr_CBSP_Recv(g_cbsp_conn_id[0], rx_cbs)) {
this kind of construct looks like a prime use case for 'interleave' instead of 'alt. That way you don't need those received_{cbs,emerg} variables and the related checks. The "received unexpected CBSP" could then become an altstep that you acttivate before the interleave statement.
Not super-critical, just wanted to clarify that there is a TTCN3-native mechanism for "wait for each of those things to happen [once], in any order".
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28609
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05da2f61d26a1124d30793184d81aabf212cddda
Gerrit-Change-Number: 28609
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 15 Jul 2022 13:36:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28608 )
Change subject: bsc_cbsp: Support receiving CGI as cellID in CBSP Reset and Failure Ind
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I48e86150f499f0f458f75f132087319d80f86448
Gerrit-Change-Number: 28608
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 15 Jul 2022 13:34:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28611 )
Change subject: smscb: Tx Failure and Restart Ind for each Bcast Msg Type
......................................................................
smscb: Tx Failure and Restart Ind for each Bcast Msg Type
As described in 3GPP TS 48.049:
7.8.2: "The RESTART message is sent once per broadcast message type as
indicated by the Broadcast Message Type IE."
7.9.2: "The FAILURE message is sent once per broadcast message type as
indicated by the Broadcast Message Type IE."
Related: SYS#5910
Change-Id: I6668b55868cf534a3b59da5e11542abb8131d604
---
M src/osmo-bsc/smscb.c
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c
index 32f8f98..8e1c634 100644
--- a/src/osmo-bsc/smscb.c
+++ b/src/osmo-bsc/smscb.c
@@ -1131,6 +1131,7 @@
bts_cbch_timer_schedule(trx->bts);
/* Start ETWS/PWS Primary Notification, if active */
bts_etws_bootstrap(trx->bts);
+ cbsp_tx_restart_bts(bts->network->cbc, true, bts);
cbsp_tx_restart_bts(bts->network->cbc, false, bts);
}
} else {
@@ -1138,6 +1139,7 @@
/* If timer is ongoing it means CBCH was available */
LOG_BTS(bts, DCBS, LOGL_INFO, "BTS becomes unavailable for CBCH\n");
osmo_timer_del(&bts->cbch_timer);
+ cbsp_tx_failure_bts(bts->network->cbc, true, bts);
cbsp_tx_failure_bts(bts->network->cbc, false, bts);
} /* else: CBCH was already unavailable before */
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28611
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6668b55868cf534a3b59da5e11542abb8131d604
Gerrit-Change-Number: 28611
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged