- gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: mtp: Improve mtp_sap/ss7_user APIs
by pespin 14 Nov '25

14 Nov '25

Attention is currently required from: osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: mtp: Improve mtp_sap/ss7_user APIs ...................................................................... mtp: Improve mtp_sap/ss7_user APIs * The ss7_user API was so far never used externally, and internally only by SCCP and a unit test. It has several bad practices like first passing a inst parent ptr to allocate it, and then require a inst pointer again to operate on it (eg. register/unregister, send a primitive, etc.). This only makes the API more complex than needed and creates potential problems where a isnt differnet than the one ss7_user was allocated on is passed. Instead, the ss7_user is pinned to its parent inst during alloction, and all MTP-SAP always happens uniquely through the ss7_user. This follows much more closely the already sanitized and much more used sccp_sap/sccp_user APIs. * Move more primitive/SAP related code to mtp_sap.c, to make it easier to spot where the inter-layer communication happens. This way we also have the same disposition as with sccp_sap/sccp_user. * Clean up some primitive related APIs to unify naming with other usual SAP/primitive osmocom code. Change-Id: If320db2bcec7ccbbc2cdac0cbf018fd8be7bde22 --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/mtp_sap.c M src/sccp_instance.c M src/sccp_scrc.c M src/ss7_hmrt.c M src/ss7_instance.h M src/ss7_user.c M src/ss7_user.h M src/xua_internal.h M tests/ss7/ss7_test.c 11 files changed, 133 insertions(+), 115 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/41411/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If320db2bcec7ccbbc2cdac0cbf018fd8be7bde22 Gerrit-Change-Number: 41411 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: mtp: Improve mtp_sap/ss7_user APIs
by pespin 14 Nov '25

14 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email ) Change subject: mtp: Improve mtp_sap/ss7_user APIs ...................................................................... Patch Set 3: (1 comment) File src/mtp_sap.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411/comment/52b29d62_526c0… : PS3, Line 100: rc = -1; > maybe add a break here for consistency? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If320db2bcec7ccbbc2cdac0cbf018fd8be7bde22 Gerrit-Change-Number: 41411 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 13:32:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: mtp: Improve mtp_sap/ss7_user APIs
by pespin 14 Nov '25

14 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email ) Change subject: mtp: Improve mtp_sap/ss7_user APIs ...................................................................... Patch Set 3: (1 comment) File TODO-RELEASE: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411/comment/46f7e1f8_ae74b… : PS3, Line 13: libosmo-sigtran add osmo_ss7_user_mtp_sap_prim_down() > maybe note here that ss7_user APIs (that were not used by anyone yet) were reworked? I'm pretty sure they were unused, so imho no need to pollute here even more. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If320db2bcec7ccbbc2cdac0cbf018fd8be7bde22 Gerrit-Change-Number: 41411 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 13:32:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: nplab-m3ua-test: Configure Network Indicator as International
by laforge 14 Nov '25

14 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/41431?usp=email ) Change subject: nplab-m3ua-test: Configure Network Indicator as International ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41431?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iae825ebc588524c7a3761c80392940733f3887a6 Gerrit-Change-Number: 41431 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 13:29:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: mtp: Introduce osmo_ss7_user_find_by_si() public API
by osmith 14 Nov '25

14 Nov '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41429?usp=email ) Change subject: mtp: Introduce osmo_ss7_user_find_by_si() public API ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7db659dc443148f3aab70d2c6229c2271346cf38 Gerrit-Change-Number: 41429 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 13:26:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: mtp: Submit MTP-STATUS.ind up over MTP SAP
by osmith 14 Nov '25

14 Nov '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41419?usp=email ) Change subject: mtp: Submit MTP-STATUS.ind up over MTP SAP ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5e810451481e50f2942b3a1bf88212326b8d124e Gerrit-Change-Number: 41419 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 13:25:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: mtp: Submit MTP-RESUME/PAUSE.ind up over MTP SAP
by osmith 14 Nov '25

14 Nov '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41418?usp=email ) Change subject: mtp: Submit MTP-RESUME/PAUSE.ind up over MTP SAP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41418?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If4360f07aa199e84c57820957ddde4259d1c92ce Gerrit-Change-Number: 41418 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 13:22:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: mtp: Introduce mtp_prim_* API helpers
by osmith 14 Nov '25

14 Nov '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41417?usp=email ) Change subject: mtp: Introduce mtp_prim_* API helpers ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4af154a65b8c23b9e8647845337ad1b5aa3901aa Gerrit-Change-Number: 41417 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 13:17:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in docker-playground[master]: nplab-m3ua-test: Parametrize git branch and change it to osmocom/master
by osmith 14 Nov '25

14 Nov '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email ) Change subject: nplab-m3ua-test: Parametrize git branch and change it to osmocom/master ...................................................................... Patch Set 1: (1 comment) File nplab-m3ua-test/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/41430/comment/b3b8907d_f67… : PS1, Line 12: cp runtest-junitxml.py /usr/local/bin/ > No idea, but I don't really want to spend further time on this now :D Acknowledged -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I78b2a27b355f11ba64476216bc7ef76713e8f61e Gerrit-Change-Number: 41430 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 13:11:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in docker-playground[master]: nplab-m3ua-test: Parametrize git branch and change it to osmocom/master
by pespin 14 Nov '25

14 Nov '25

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email ) Change subject: nplab-m3ua-test: Parametrize git branch and change it to osmocom/master ...................................................................... Patch Set 1: (1 comment) File nplab-m3ua-test/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/41430/comment/e72bce08_a44… : PS1, Line 12: cp runtest-junitxml.py /usr/local/bin/ > not sure if only this one file is needed. but if that is the case, you could also directly do this: […] No idea, but I don't really want to spend further time on this now :D -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I78b2a27b355f11ba64476216bc7ef76713e8f61e Gerrit-Change-Number: 41430 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Nov 2025 13:10:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log