- gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: main: show just a brief talloc report for vty
by neels 10 Aug '22

10 Aug '22

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28984 ) Change subject: main: show just a brief talloc report for vty ...................................................................... main: show just a brief talloc report for vty Upon ^C, do not barf a huge amount of full talloc report for the entire VTY config tree. Show a brief report on VTY instead. Related: SYS#5599 Change-Id: I038951c6d62679e3cfcda51512768d1fbacaa0d1 --- M src/osmo-upf/osmo_upf_main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/src/osmo-upf/osmo_upf_main.c b/src/osmo-upf/osmo_upf_main.c index 81102dd..b4888af 100644 --- a/src/osmo-upf/osmo_upf_main.c +++ b/src/osmo-upf/osmo_upf_main.c @@ -377,7 +377,7 @@ talloc_report_full(tall_infra_ctx, stderr); talloc_free(tall_infra_ctx); - talloc_report_full(tall_vty_ctx, stderr); + talloc_report(tall_vty_ctx, stderr); talloc_free(tall_vty_ctx); talloc_report_full(NULL, stderr); 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I038951c6d62679e3cfcda51512768d1fbacaa0d1 Gerrit-Change-Number: 28984 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-upf[master]: add comment about fd cleanup
by neels 10 Aug '22

10 Aug '22

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28985 ) Change subject: add comment about fd cleanup ...................................................................... add comment about fd cleanup Clarify that calling osmo_fd_close() is fine if no fd is open. Related: SYS#5599 Change-Id: Ibd471485fde90a14fe19f558b38a49b0b7d62909 --- M src/osmo-upf/upf_gtp.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index 4a430cb..6280e45 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -449,6 +449,7 @@ while ((t = llist_first_entry_or_null(&dev->tunnels, struct upf_gtp_tun, entry))) talloc_free(t); llist_del(&dev->entry); + /* osmo_fd_close() is a noop if ofd.fd == -1 */ osmo_fd_close(&dev->gtpv0.ofd); osmo_fd_close(&dev->gtpv1.ofd); if (dev->created) 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ibd471485fde90a14fe19f558b38a49b0b7d62909 Gerrit-Change-Number: 28985 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-upf[master]: log: fix/tweak log msg about nft/mockup
by neels 10 Aug '22

10 Aug '22

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28983 ) Change subject: log: fix/tweak log msg about nft/mockup ...................................................................... log: fix/tweak log msg about nft/mockup There is no cmdline option --mockup-nft, that was an earlier stage of the nftables mockup patch. Related: SYS#5599 Change-Id: I2f77cfe727649bbdcebb4a656ebf97b186134ee8 --- M src/osmo-upf/upf_nft.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-upf/upf_nft.c b/src/osmo-upf/upf_nft.c index c035016..bcb6a70 100644 --- a/src/osmo-upf/upf_nft.c +++ b/src/osmo-upf/upf_nft.c @@ -40,7 +40,7 @@ int rc; if (g_upf->nft.mockup) { - LOGP(DNFT, LOGL_NOTICE, "--mockup-gtp active, not running nft ruleset: '%s'\n", ruleset); + LOGP(DNFT, LOGL_NOTICE, "nft/mockup active: not running nft ruleset: '%s'\n", ruleset); return 0; } @@ -63,7 +63,8 @@ { int rc; if (g_upf->nft.mockup) { - LOGP(DNFT, LOGL_NOTICE, "--mockup-gtp active, not allocating libnftables nft_ctx\n"); + LOGP(DNFT, LOGL_NOTICE, + "nft/mockup active: not allocating libnftables nft_ctx. FOR TESTING PURPOSES ONLY.\n"); return 0; } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I2f77cfe727649bbdcebb4a656ebf97b186134ee8 Gerrit-Change-Number: 28983 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-upf[master]: vty doc tweaks
by neels 10 Aug '22

10 Aug '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29020 ) Change subject: vty doc tweaks ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial change, let's spare you guys the review -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I918e0a9a332e4dd4b71965614c19481eb41004d6 Gerrit-Change-Number: 29020 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 12:17:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: detect MNCC failure explicitly
by neels 10 Aug '22

10 Aug '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 ) Change subject: msc: f_tc_mt_t310: detect MNCC failure explicitly ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: re-adding previous +2 after trivial change -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1 Gerrit-Change-Number: 28971 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 12:14:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: mgcp_e1: fix apidoc
by dexter 10 Aug '22

10 Aug '22

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29025 ) Change subject: mgcp_e1: fix apidoc ...................................................................... mgcp_e1: fix apidoc Change-Id: Iaccb9b67e72d113483160e61f660ea9c4c2f53a5 --- M src/libosmo-mgcp/mgcp_e1.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/25/29025/1 diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index 9a6efe2..7f30c1d 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -496,7 +496,7 @@ } } -/* !Equip E1 endpoint with I.460 mux resources. +/*! Equip E1 endpoint with I.460 mux resources. * \param[in] endp endpoint to equip * \param[in] ts E1 timeslot number. * \param[in] ss E1 subslot number. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaccb9b67e72d113483160e61f660ea9c4c2f53a5 Gerrit-Change-Number: 29025 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP
by neels 10 Aug '22

10 Aug '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 ) Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: my s/ rule missed quite a few of them in the last patch set, i've put all possible modifiers for templates now, afaict. In other news, i already find it annoying as hell that my ctags jumps no longer work for PFCP templates :/ guess i need to do universal-ctags hacking -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 12:12:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP
by neels 10 Aug '22

10 Aug '22

Attention is currently required from: neels, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 to look at the new patch set (#5). Change subject: add library/PFCP_*, deps/PFCP ...................................................................... add library/PFCP_*, deps/PFCP Will soon be used by new subdir 'upf' (test osmo-upf), and by 'hnbgw' (test GTP mapping via UPF). Related: SYS#5599 Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f --- M deps/Makefile M library/General_Types.ttcn A library/PFCP_CodecPort.ttcn A library/PFCP_CodecPort_CtrlFunct.ttcn A library/PFCP_CodecPort_CtrlFunctDef.cc A library/PFCP_Emulation.ttcn A library/PFCP_Templates.ttcn 7 files changed, 926 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/28817/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: allow CRCX in either order
by neels 10 Aug '22

10 Aug '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024 ) Change subject: msc: f_tc_mt_t310: allow CRCX in either order ...................................................................... msc: f_tc_mt_t310: allow CRCX in either order continued from Id0c98bc267daff352fc7db7712f967111970fd4d Upcoming changes to osmo-msc move the CN side CRCX to an earlier point in time, reversing that order. Introduce an 'interleave' to not care about the ordering of MGCP and BSSAP messages. Related: SYS#5066 Related: Ie433db1ba0c46d4b97538a969233c155cefac21c (osmo-msc) Change-Id: I0ec348df08aa49ed58b3465de51b259fb74c0aea --- M msc/MSC_Tests.ttcn 1 file changed, 18 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/29024/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 79221d7..d6e0aba 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -1771,25 +1771,31 @@ /* NOTE: MSC is expected to start T310 here */ + interleave { /* MSC->MGW: CRCX (first) */ - MGCP.receive(tr_CRCX) -> value mgcp_cmd; - f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */ + [] MGCP.receive(tr_CRCX) -> value mgcp_cmd { + f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */ + } /* BSC->BSC: BSSMAP ASSIGNMENT REQ */ - BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, ?)) -> value bssap; - BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, - aoip := f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, cpars.bss_rtp_port), - speechCodec := ts_BSSMAP_IE_SpeechCodec({ ts_CodecFR }))); + [] BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, ?)) -> value bssap { + BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, + aoip := f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, cpars.bss_rtp_port), + speechCodec := ts_BSSMAP_IE_SpeechCodec({ ts_CodecFR }))); + } /* MSC->MGW: MDCX */ - MGCP.receive(tr_MDCX) -> value mgcp_cmd; - MGCP.send(ts_MDCX_ACK(mgcp_cmd.line.trans_id, cpars.mgw_conn_1.mgcp_connection_id, - sdp := omit)); + [] MGCP.receive(tr_MDCX) -> value mgcp_cmd { + MGCP.send(ts_MDCX_ACK(mgcp_cmd.line.trans_id, cpars.mgw_conn_1.mgcp_connection_id, + sdp := omit)); + } /* MSC->MGW: CRCX (second) */ - MGCP.receive(tr_CRCX) -> value mgcp_cmd; - f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */ - MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref)); + [] MGCP.receive(tr_CRCX) -> value mgcp_cmd { + f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */ + MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref)); + } + } /* Reschedule the guard timeout */ g_Tguard.start(30.0 + 10.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0ec348df08aa49ed58b3465de51b259fb74c0aea Gerrit-Change-Number: 29024 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: detect MNCC failure explicitly
by neels 10 Aug '22

10 Aug '22

Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 to look at the new patch set (#3). Change subject: msc: f_tc_mt_t310: detect MNCC failure explicitly ...................................................................... msc: f_tc_mt_t310: detect MNCC failure explicitly Helped me find a failure cause: instead of T_guard timeout, immediately show an unexpected MNCC event. Related: SYS#5066 Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1 --- M msc/MSC_Tests.ttcn 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/28971/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1 Gerrit-Change-Number: 28971 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log