- gerrit-log - lists.osmocom.org

Change in osmo-e1d[master]: e1oip: Add rate_ctr for rx + tx packet / byte count
by laforge 01 May '22

01 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27899 ) Change subject: e1oip: Add rate_ctr for rx + tx packet / byte count ...................................................................... e1oip: Add rate_ctr for rx + tx packet / byte count This allows to monitor the traffic utilization of each e1oip line. Change-Id: Ifde6be0b7d3c5767b684cb8fbbc58bbd5cfb0714 --- M src/octoi/e1oip.c M src/octoi/e1oip.h M src/octoi/octoi_fsm.c M src/octoi/octoi_sock.c M src/octoi/octoi_sock.h 5 files changed, 63 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/octoi/e1oip.c b/src/octoi/e1oip.c index cd07178..608a5e0 100644 --- a/src/octoi/e1oip.c +++ b/src/octoi/e1oip.c @@ -51,6 +51,10 @@ [LINE_CTR_E1oIP_RX_OUT_OF_ORDER] = { "e1oip:rx:pkt_out_of_order", "Packets out-of-order in IP->E1 direction"}, [LINE_CTR_E1oIP_RX_OUT_OF_WIN] = { "e1oip:rx:pkt_out_of_win", "Packets out-of-rx-window in IP->E1 direction"}, [LINE_CTR_E1oIP_CONNECT_ACCEPT] = { "e1oip:connect_accepted", "OCTOI connections entering accepted state" }, + [LINE_CTR_E1oIP_RX_BYTES] = { "e1oip:rx:bytes", "Number of bytes received including UDP+IP header" }, + [LINE_CTR_E1oIP_RX_PACKETS] = { "e1oip:rx:packets", "Number of UDP packets received" }, + [LINE_CTR_E1oIP_TX_BYTES] = { "e1oip:tx:bytes", "Number of bytes transmitted including UDP+IP header" }, + [LINE_CTR_E1oIP_TX_PACKETS] = { "e1oip:tx:packets", "Number of UDP packets transmitted" }, }; static const struct rate_ctr_group_desc iline_ctrg_desc = { @@ -82,6 +86,7 @@ static void fifo_threshold_cb(struct frame_fifo *fifo, unsigned int frames, void *priv) { struct e1oip_line *iline = priv; + struct octoi_peer *peer = iline->peer; struct msgb *msg; struct e1oip_tdm_hdr *eith; unsigned int n_frames = fifo->threshold; @@ -108,7 +113,7 @@ /* this situation cannot really happen: The FIFO called us that * a certain threshold is reached, but now it cannot provide * frames? */ - LOGPEER(iline->peer, LOGL_ERROR, + LOGPEER(peer, LOGL_ERROR, "frame_fifo_out failure for frame %u/%u\n", iline->e1o.next_seq + i, i); } } @@ -146,7 +151,9 @@ } /* send the packet to the peer */ - octoi_tx(iline->peer, E1OIP_MSGT_TDM_DATA, 0, msgb_data(msg), msgb_length(msg)); + octoi_tx(peer, E1OIP_MSGT_TDM_DATA, 0, msgb_data(msg), msgb_length(msg)); + iline_ctr_add(iline, LINE_CTR_E1oIP_TX_PACKETS, 1); + iline_ctr_add(iline, LINE_CTR_E1oIP_TX_BYTES, peer->sock->iph_udph_size + msgb_length(msg)); msgb_free(msg); /* update the local state */ diff --git a/src/octoi/e1oip.h b/src/octoi/e1oip.h index 3c5a478..da4716b 100644 --- a/src/octoi/e1oip.h +++ b/src/octoi/e1oip.h @@ -23,6 +23,10 @@ LINE_CTR_E1oIP_RX_OUT_OF_ORDER, LINE_CTR_E1oIP_RX_OUT_OF_WIN, LINE_CTR_E1oIP_CONNECT_ACCEPT, + LINE_CTR_E1oIP_RX_BYTES, + LINE_CTR_E1oIP_RX_PACKETS, + LINE_CTR_E1oIP_TX_BYTES, + LINE_CTR_E1oIP_TX_PACKETS, }; enum e1oip_line_stat { diff --git a/src/octoi/octoi_fsm.c b/src/octoi/octoi_fsm.c index 3431587..37d0259 100644 --- a/src/octoi/octoi_fsm.c +++ b/src/octoi/octoi_fsm.c @@ -26,6 +26,7 @@ #include "octoi_sock.h" #include "octoi_fsm.h" +#include "e1oip.h" const struct value_string octoi_fsm_event_names[] = { @@ -158,6 +159,12 @@ OSMO_ASSERT(msgb_l1(msg)); OSMO_ASSERT(msgb_l2(msg)); + if (peer->iline) { + iline_ctr_add(peer->iline, LINE_CTR_E1oIP_RX_PACKETS, 1); + iline_ctr_add(peer->iline, LINE_CTR_E1oIP_RX_BYTES, + peer->sock->iph_udph_size + msgb_length(msg)); + } + if (!octoi_msg_validate(fi, msg)) return -1; diff --git a/src/octoi/octoi_sock.c b/src/octoi/octoi_sock.c index 4805d7e..4245d80 100644 --- a/src/octoi/octoi_sock.c +++ b/src/octoi/octoi_sock.c @@ -40,6 +40,44 @@ #include "octoi_sock.h" #include "e1oip.h" +/* determine domain / AF of socket */ +static int sock_get_domain(int fd) +{ + int domain; + socklen_t dom_len = sizeof(domain); + int rc; + + rc = getsockopt(fd, SOL_SOCKET, SO_DOMAIN, &domain, &dom_len); + if (rc < 0) + return rc; + + return domain; +} + +/* typical number of bytes in IP + UDP header for given socket */ +static int sock_get_iph_udph_overhead(int fd) +{ + int rc = sock_get_domain(fd); + if (rc < 0) { + LOGP(DLINP, LOGL_ERROR, "Unable to determine domain of socket %d: %s\n", + fd, strerror(errno)); + goto assume_ipv4; + } + + switch (rc) { + case AF_INET6: + return 40 + 8; + case AF_INET: + return 20 + 8; + default: + LOGP(DLINP, LOGL_ERROR, "Unknown domain %d of socket %d\n", rc, fd); + break; + } + +assume_ipv4: + return 20 + 8; +} + /*********************************************************************** * transmit to remote peer ***********************************************************************/ @@ -400,6 +438,8 @@ LOGP(DLINP, LOGL_NOTICE, "OCTOI server socket at "OSMO_SOCKADDR_STR_FMT"\n", OSMO_SOCKADDR_STR_FMT_ARGS(local)); + sock->iph_udph_size = sock_get_iph_udph_overhead(sock->ofd.fd); + return sock; } @@ -441,6 +481,8 @@ LOGP(DLINP, LOGL_NOTICE, "OCTOI client socket to "OSMO_SOCKADDR_STR_FMT"\n", OSMO_SOCKADDR_STR_FMT_ARGS(remote)); + sock->iph_udph_size = sock_get_iph_udph_overhead(sock->ofd.fd); + /* create [the only] peer */ peer = alloc_peer(sock, (struct sockaddr *) &sa_remote, sizeof(sa_remote)); peer->cfg.remote = *remote; diff --git a/src/octoi/octoi_sock.h b/src/octoi/octoi_sock.h index b251864..17385e1 100644 --- a/src/octoi/octoi_sock.h +++ b/src/octoi/octoi_sock.h @@ -31,6 +31,7 @@ struct osmo_fd ofd; /* file descriptor */ struct llist_head peers; /* list of peers */ void *priv; + unsigned int iph_udph_size; /* size of IP + UDP header */ int (*rx_cb)(struct octoi_peer *peer, struct msgb *msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ifde6be0b7d3c5767b684cb8fbbc58bbd5cfb0714 Gerrit-Change-Number: 27899 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

Change in osmo-e1d[master]: octoi: Support setting IP DSCP and socket priority via VTY
by laforge 01 May '22

01 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27857 ) Change subject: octoi: Support setting IP DSCP and socket priority via VTY ...................................................................... octoi: Support setting IP DSCP and socket priority via VTY Let's allow setting IP DSCP and socket priority via the VTY. Note that you must still manually add a kernel egress QoS map from socket priority to IEEE P802.1p PCP (Priority Code Point) like this: ip link set dev eth0.7 type vlan egress-qos-map 0:0 1:1 5:5 6:6 7:7 This will create 1:1 mappings for socket priorities 0, 1, 5, 6 and 7 to the respective IEEE PCP. A higher PCP typically means higher priority, where voice is traditionally using "5". Change-Id: Ic5a6c5a0ec67beb40be4ca95326aca5072a28958 --- M include/osmocom/octoi/octoi.h M src/octoi/octoi_clnt_vty.c M src/octoi/octoi_sock.c M src/octoi/octoi_sock.h M src/octoi/octoi_srv_vty.c 5 files changed, 155 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/octoi/octoi.h b/include/osmocom/octoi/octoi.h index 48ec122..e7ebcaa 100644 --- a/include/osmocom/octoi/octoi.h +++ b/include/osmocom/octoi/octoi.h @@ -42,6 +42,8 @@ struct { struct llist_head accounts; /* list of octoi_account */ struct osmo_sockaddr_str local; /* local socket bind address/port */ + uint8_t dscp; /* IP DSCP value */ + uint8_t priority; /* Socket Priority value */ } cfg; }; @@ -54,6 +56,9 @@ struct osmo_sockaddr_str local; /* local socket bind address/port */ struct octoi_account *account; + + uint8_t dscp; /* IP DSCP value */ + uint8_t priority; /* Socket Priority value */ } cfg; }; diff --git a/src/octoi/octoi_clnt_vty.c b/src/octoi/octoi_clnt_vty.c index 1f8f7d1..756cc9a 100644 --- a/src/octoi/octoi_clnt_vty.c +++ b/src/octoi/octoi_clnt_vty.c @@ -148,6 +148,68 @@ } clnt->sock->rx_cb = octoi_clnt_fsm_rx_cb; + if (clnt->cfg.dscp) { + rc = octoi_sock_set_dscp(clnt->sock, clnt->cfg.dscp); + if (rc < 0) { + vty_out(vty, "%% failed to set DSCP on socket: %s%s", strerror(errno), VTY_NEWLINE); + return CMD_WARNING; + } + } + + if (clnt->cfg.priority) { + rc = octoi_sock_set_priority(clnt->sock, clnt->cfg.priority); + if (rc < 0) { + vty_out(vty, "%% failed to set priority on socket: %s%s", strerror(errno), VTY_NEWLINE); + return CMD_WARNING; + } + } + + return CMD_SUCCESS; +} + +DEFUN(cfg_clnt_dscp, cfg_clnt_dscp_cmd, + "ip-dscp <0-63>", + "Set IP DSCP value for outbound packets\n" + "IP DSCP Value to use\n") +{ + struct octoi_client *clnt = vty->index; + int rc; + + clnt->cfg.dscp = atoi(argv[0]); + + if (!clnt->sock) + return CMD_SUCCESS; + + /* apply to already-existing server */ + rc = octoi_sock_set_dscp(clnt->sock, clnt->cfg.dscp); + if (rc < 0) { + vty_out(vty, "%% failed to set DSCP on socket: %s%s", strerror(errno), VTY_NEWLINE); + return CMD_WARNING; + } + + return CMD_SUCCESS; +} + +DEFUN(cfg_clnt_prio, cfg_clnt_prio_cmd, + "socket-priority <0-255>", + "Set socket priority value for outbound packets\n" + "Socket Priority\n") +{ + struct octoi_client *clnt = vty->index; + int rc; + + clnt->cfg.priority = atoi(argv[0]); + + if (!clnt->sock) + return CMD_SUCCESS; + + /* apply to already-existing server */ + rc = octoi_sock_set_priority(clnt->sock, clnt->cfg.priority); + if (rc < 0) { + vty_out(vty, "%% failed to set priority on socket: %s%s", strerror(errno), VTY_NEWLINE); + return CMD_WARNING; + } + return CMD_SUCCESS; } @@ -197,6 +259,11 @@ vty_out(vty, " local-bind %s %u%s", clnt->cfg.local.ip, clnt->cfg.local.port, VTY_NEWLINE); } + if (clnt->cfg.dscp) + vty_out(vty, " ip-dscp %u%s", clnt->cfg.dscp, VTY_NEWLINE); + if (clnt->cfg.priority) + vty_out(vty, " socket-priority %u%s", clnt->cfg.priority, VTY_NEWLINE); + octoi_vty_write_one_account(vty, clnt->cfg.account); } @@ -215,5 +282,7 @@ install_node(&clnt_node, config_write_octoi_clnt); install_element(CONFIG_NODE, &cfg_client_cmd); install_element(OCTOI_CLNT_NODE, &cfg_clnt_local_cmd); + install_element(OCTOI_CLNT_NODE, &cfg_clnt_dscp_cmd); + install_element(OCTOI_CLNT_NODE, &cfg_clnt_prio_cmd); install_element(OCTOI_CLNT_NODE, &cfg_clnt_account_cmd); } diff --git a/src/octoi/octoi_sock.c b/src/octoi/octoi_sock.c index 943270a..4805d7e 100644 --- a/src/octoi/octoi_sock.c +++ b/src/octoi/octoi_sock.c @@ -450,6 +450,16 @@ return sock; } +int octoi_sock_set_dscp(struct octoi_sock *sock, uint8_t dscp) +{ + return osmo_sock_set_dscp(sock->ofd.fd, dscp); +} + +int octoi_sock_set_priority(struct octoi_sock *sock, uint8_t priority) +{ + return osmo_sock_set_priority(sock->ofd.fd, priority); +} + void octoi_sock_destroy(struct octoi_sock *sock) { struct octoi_peer *p1, *p2; diff --git a/src/octoi/octoi_sock.h b/src/octoi/octoi_sock.h index cf7b74b..b251864 100644 --- a/src/octoi/octoi_sock.h +++ b/src/octoi/octoi_sock.h @@ -66,6 +66,9 @@ struct octoi_peer *octoi_sock_client_get_peer(struct octoi_sock *sock); +int octoi_sock_set_dscp(struct octoi_sock *sock, uint8_t dscp); +int octoi_sock_set_priority(struct octoi_sock *sock, uint8_t priority); + void octoi_peer_destroy(struct octoi_peer *peer); int octoi_tx(struct octoi_peer *peer, uint8_t msg_type, uint8_t flags, diff --git a/src/octoi/octoi_srv_vty.c b/src/octoi/octoi_srv_vty.c index c9f63cb..f616af5 100644 --- a/src/octoi/octoi_srv_vty.c +++ b/src/octoi/octoi_srv_vty.c @@ -182,6 +182,68 @@ } srv->sock->rx_cb = octoi_srv_fsm_rx_cb; + if (srv->cfg.dscp) { + rc = octoi_sock_set_dscp(srv->sock, srv->cfg.dscp); + if (rc < 0) { + vty_out(vty, "%% failed to set DSCP on socket: %s%s", strerror(errno), VTY_NEWLINE); + return CMD_WARNING; + } + } + + if (srv->cfg.priority) { + rc = octoi_sock_set_priority(srv->sock, srv->cfg.priority); + if (rc < 0) { + vty_out(vty, "%% failed to set priority on socket: %s%s", strerror(errno), VTY_NEWLINE); + return CMD_WARNING; + } + } + + return CMD_SUCCESS; +} + +DEFUN(cfg_srv_dscp, cfg_srv_dscp_cmd, + "ip-dscp <0-63>", + "Set IP DSCP value for outbound packets\n" + "IP DSCP Value to use\n") +{ + struct octoi_server *srv = vty->index; + int rc; + + srv->cfg.dscp = atoi(argv[0]); + + if (!srv->sock) + return CMD_SUCCESS; + + /* apply to already-existing server */ + rc = octoi_sock_set_dscp(srv->sock, srv->cfg.dscp); + if (rc < 0) { + vty_out(vty, "%% failed to set DSCP on socket: %s%s", strerror(errno), VTY_NEWLINE); + return CMD_WARNING; + } + + return CMD_SUCCESS; +} + +DEFUN(cfg_srv_prio, cfg_srv_prio_cmd, + "socket-priority <0-255>", + "Set socket priority value for outbound packets\n" + "Socket Priority\n") +{ + struct octoi_server *srv = vty->index; + int rc; + + srv->cfg.priority = atoi(argv[0]); + + if (!srv->sock) + return CMD_SUCCESS; + + /* apply to already-existing server */ + rc = octoi_sock_set_priority(srv->sock, srv->cfg.priority); + if (rc < 0) { + vty_out(vty, "%% failed to set priority on socket: %s%s", strerror(errno), VTY_NEWLINE); + return CMD_WARNING; + } + return CMD_SUCCESS; } @@ -347,6 +409,10 @@ vty_out(vty, " local-bind %s %u%s", srv->cfg.local.ip, srv->cfg.local.port, VTY_NEWLINE); } + if (srv->cfg.dscp) + vty_out(vty, " ip-dscp %u%s", srv->cfg.dscp, VTY_NEWLINE); + if (srv->cfg.priority) + vty_out(vty, " socket-priority %u%s", srv->cfg.priority, VTY_NEWLINE); llist_for_each_entry(acc, &srv->cfg.accounts, list) octoi_vty_write_one_account(vty, acc); @@ -385,6 +451,8 @@ install_element(CONFIG_NODE, &cfg_server_cmd); //install_element(CONFIG_NODE, &cfg_no_server_cmd); install_element(OCTOI_SRV_NODE, &cfg_srv_local_cmd); + install_element(OCTOI_SRV_NODE, &cfg_srv_dscp_cmd); + install_element(OCTOI_SRV_NODE, &cfg_srv_prio_cmd); install_element(OCTOI_SRV_NODE, &cfg_srv_account_cmd); //install_element(CONFIG_SRV_NODE, &cfg_srv_no_account_cmd); } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ic5a6c5a0ec67beb40be4ca95326aca5072a28958 Gerrit-Change-Number: 27857 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

Change in osmo-e1d[master]: octoi: Send ECHO_REQ every 10s and update the related stat_item
by laforge 01 May '22

01 May '22

Attention is currently required from: manawyrm, roox, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27989 ) Change subject: octoi: Send ECHO_REQ every 10s and update the related stat_item ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id331319bff1cf6896fee37acc45846a2491ca92d Gerrit-Change-Number: 27989 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Sun, 01 May 2022 09:23:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: e1oip: Add rate_ctr for rx + tx packet / byte count
by laforge 01 May '22

01 May '22

Attention is currently required from: manawyrm, roox, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27899 ) Change subject: e1oip: Add rate_ctr for rx + tx packet / byte count ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/octoi/e1oip.c: https://gerrit.osmocom.org/c/osmo-e1d/+/27899/comment/5800d637_ad4f9f56 PS1, Line 54: [LINE_CTR_E1oIP_RX_BYTES] = { "e1oip:rx:packets", "Number of bytes received including UDP+IP header" }, > rx:packets should be rx_bytes […] thanks,fixed. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ifde6be0b7d3c5767b684cb8fbbc58bbd5cfb0714 Gerrit-Change-Number: 27899 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Sun, 01 May 2022 09:23:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: tnt <tnt(a)246tNt.com> Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: e1oip: fix line counter descriptions
by laforge 01 May '22

01 May '22

Attention is currently required from: manawyrm, roox, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27898 ) Change subject: e1oip: fix line counter descriptions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ia294af4b30eec1b32c4b15892751d360608c8333 Gerrit-Change-Number: 27898 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Sun, 01 May 2022 09:23:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: octoi: Support setting IP DSCP and socket priority via VTY
by laforge 01 May '22

01 May '22

Attention is currently required from: manawyrm, roox, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27857 ) Change subject: octoi: Support setting IP DSCP and socket priority via VTY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ic5a6c5a0ec67beb40be4ca95326aca5072a28958 Gerrit-Change-Number: 27857 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Sun, 01 May 2022 09:23:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: octoi: Send ECHO_REQ every 10s and update the related stat_item
by laforge 01 May '22

01 May '22

Attention is currently required from: manawyrm, roox, tnt. Hello Jenkins Builder, manawyrm, roox, tnt, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/27989 to look at the new patch set (#2). Change subject: octoi: Send ECHO_REQ every 10s and update the related stat_item ...................................................................... octoi: Send ECHO_REQ every 10s and update the related stat_item As soon as an OCTOI connection gets into ACTIVE state, send a ECHO_REQ every 10s and compute the RTT at the time of receiving the response. Contrary to the initial idea, the stat item contains the RTT (round trip time) measured in micro-seconds. Changing this is not a problem as so far the RTT was always reported as '0', and 0ms == 0us. Change-Id: Id331319bff1cf6896fee37acc45846a2491ca92d --- M src/octoi/e1oip.c M src/octoi/octoi_clnt_fsm.c M src/octoi/octoi_fsm.c M src/octoi/octoi_fsm.h M src/octoi/octoi_srv_fsm.c 5 files changed, 83 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/89/27989/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id331319bff1cf6896fee37acc45846a2491ca92d Gerrit-Change-Number: 27989 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newpatchset

1 0

Change in osmo-e1d[master]: e1oip: Add rate_ctr for rx + tx packet / byte count
by laforge 01 May '22

01 May '22

Attention is currently required from: manawyrm, roox, laforge. Hello Jenkins Builder, manawyrm, roox, tnt, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/27899 to look at the new patch set (#2). Change subject: e1oip: Add rate_ctr for rx + tx packet / byte count ...................................................................... e1oip: Add rate_ctr for rx + tx packet / byte count This allows to monitor the traffic utilization of each e1oip line. Change-Id: Ifde6be0b7d3c5767b684cb8fbbc58bbd5cfb0714 --- M src/octoi/e1oip.c M src/octoi/e1oip.h M src/octoi/octoi_fsm.c M src/octoi/octoi_sock.c M src/octoi/octoi_sock.h 5 files changed, 63 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/99/27899/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ifde6be0b7d3c5767b684cb8fbbc58bbd5cfb0714 Gerrit-Change-Number: 27899 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

Change in osmo-e1d[master]: e1oip: Add rate_ctr for rx + tx packet / byte count
by tnt 01 May '22

01 May '22

Attention is currently required from: manawyrm, roox, laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27899 ) Change subject: e1oip: Add rate_ctr for rx + tx packet / byte count ...................................................................... Patch Set 1: (1 comment) File src/octoi/e1oip.c: https://gerrit.osmocom.org/c/osmo-e1d/+/27899/comment/4e982c25_eda6c564 PS1, Line 54: [LINE_CTR_E1oIP_RX_BYTES] = { "e1oip:rx:packets", "Number of bytes received including UDP+IP header" }, rx:packets should be rx_bytes Same for tx a bit later. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ifde6be0b7d3c5767b684cb8fbbc58bbd5cfb0714 Gerrit-Change-Number: 27899 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 01 May 2022 05:35:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: CM Serv Rej: do not crash on use count mismatch
by neels 30 Apr '22

30 Apr '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/27916 ) Change subject: CM Serv Rej: do not crash on use count mismatch ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > That's my point, this shutdown is done because something is wrong in the code. […] I know, but still, *let's not crash osmo-msc*. the conn is being released, a use count confusion is not critical -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/27916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2009df42d1f27ec0d011e22bfc46dbc17afe7239 Gerrit-Change-Number: 27916 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 30 Apr 2022 20:34:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log