- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: abis_rsl.c: Drop unused function
by pespin 02 May '22

02 May '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27999 ) Change subject: abis_rsl.c: Drop unused function ...................................................................... abis_rsl.c: Drop unused function Change-Id: I14457608aba799eccf9db6983d72fe0a5343be5c --- M src/osmo-bsc/abis_rsl.c 1 file changed, 0 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/27999/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index bacfa64..43c38e6 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -926,23 +926,6 @@ return rsl_data_request(msg, 0); } -int imsi_str2bcd(uint8_t *bcd_out, const char *str_in) -{ - int i, len = strlen(str_in); - - for (i = 0; i < len; i++) { - int num = str_in[i] - 0x30; - if (num < 0 || num > 9) - return -1; - if (i % 2 == 0) - bcd_out[i/2] = num; - else - bcd_out[i/2] |= (num << 4); - } - - return 0; -} - /* Chapter 8.5.6 */ struct msgb *rsl_imm_assign_cmd_common(struct gsm_bts *bts, uint8_t len, uint8_t *val) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27999 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I14457608aba799eccf9db6983d72fe0a5343be5c Gerrit-Change-Number: 27999 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: tests: Order tests alphabetically
by pespin 02 May '22

02 May '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27997 to look at the new patch set (#3). Change subject: tests: Order tests alphabetically ...................................................................... tests: Order tests alphabetically Change-Id: Ic7507c90854a1c953f4c016b1b0e569bca570b37 --- M configure.ac M tests/Makefile.am M tests/testsuite.at 3 files changed, 24 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/27997/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic7507c90854a1c953f4c016b1b0e569bca570b37 Gerrit-Change-Number: 27997 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-bsc[master]: tests/acc: Remove unused var
by fixeria 02 May '22

02 May '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27998 ) Change subject: tests/acc: Remove unused var ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b56b4f8d3c3901cdf9a971e9ed95a6ebbbc1cca Gerrit-Change-Number: 27998 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 May 2022 10:56:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: ttcn3-ggsn-test-ogs: set CAP_NET_RAW for open5gs-upfd
by fixeria 02 May '22

02 May '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27996 ) Change subject: ttcn3-ggsn-test-ogs: set CAP_NET_RAW for open5gs-upfd ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I51ee6954a6c019a41cfcd50b2d99166316989d9b Gerrit-Change-Number: 27996 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 May 2022 10:56:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: tests/acc: Remove unused var
by pespin 02 May '22

02 May '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27998 ) Change subject: tests/acc: Remove unused var ...................................................................... tests/acc: Remove unused var Change-Id: I1b56b4f8d3c3901cdf9a971e9ed95a6ebbbc1cca --- M tests/acc/acc_test.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/98/27998/1 diff --git a/tests/acc/acc_test.c b/tests/acc/acc_test.c index 12124d3..1e78f73 100644 --- a/tests/acc/acc_test.c +++ b/tests/acc/acc_test.c @@ -33,9 +33,7 @@ static void clock_debug(char* str) { - struct timespec ts; struct timeval tv; - osmo_clock_gettime(CLOCK_MONOTONIC, &ts); osmo_gettimeofday(&tv, NULL); fprintf(stderr, "sys={%lu.%06lu}: %s\n", tv.tv_sec, tv.tv_usec, str); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b56b4f8d3c3901cdf9a971e9ed95a6ebbbc1cca Gerrit-Change-Number: 27998 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: tests: Order tests alphabetically
by pespin 02 May '22

02 May '22

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/27997 ) Change subject: tests: Order tests alphabetically ...................................................................... tests: Order tests alphabetically Change-Id: Ic7507c90854a1c953f4c016b1b0e569bca570b37 --- M tests/Makefile.am M tests/testsuite.at 2 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/27997/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic7507c90854a1c953f4c016b1b0e569bca570b37 Gerrit-Change-Number: 27997 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-bsc[master]: tests: Order tests alphabetically
by pespin 02 May '22

02 May '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27997 ) Change subject: tests: Order tests alphabetically ...................................................................... tests: Order tests alphabetically Change-Id: Ic7507c90854a1c953f4c016b1b0e569bca570b37 --- M tests/Makefile.am M tests/testsuite.at 2 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/27997/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index a5f92ef..77c621f 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,12 +1,12 @@ SUBDIRS = \ + abis \ acc \ bsc \ codec_pref \ gsm0408 \ - abis \ - subscr \ - nanobts_omlattr \ handover \ + nanobts_omlattr \ + subscr \ $(NULL) # The `:;' works around a Bash 3.2 bug when the output is not writeable. diff --git a/tests/testsuite.at b/tests/testsuite.at index e7eb76b..0c64699 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -1,19 +1,6 @@ AT_INIT AT_BANNER([Regression tests.]) -AT_SETUP([gsm0408]) -AT_KEYWORDS([gsm0408]) -cat $abs_srcdir/gsm0408/gsm0408_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/gsm0408/gsm0408_test], [], [expout], [ignore]) -AT_CLEANUP - -AT_SETUP([bsc_subscr]) -AT_KEYWORDS([bsc_subscr]) -cat $abs_srcdir/subscr/bsc_subscr_test.ok > expout -cat $abs_srcdir/subscr/bsc_subscr_test.err > experr -AT_CHECK([$abs_top_builddir/tests/subscr/bsc_subscr_test], [], [expout], [experr]) -AT_CLEANUP - AT_SETUP([abis]) AT_KEYWORDS([abis]) cat $abs_srcdir/abis/abis_test.ok > expout @@ -32,16 +19,23 @@ AT_CHECK([$abs_top_builddir/tests/bsc/bsc_test], [], [expout], [ignore]) AT_CLEANUP +AT_SETUP([bsc_subscr]) +AT_KEYWORDS([bsc_subscr]) +cat $abs_srcdir/subscr/bsc_subscr_test.ok > expout +cat $abs_srcdir/subscr/bsc_subscr_test.err > experr +AT_CHECK([$abs_top_builddir/tests/subscr/bsc_subscr_test], [], [expout], [experr]) +AT_CLEANUP + AT_SETUP([codec_pref]) AT_KEYWORDS([codec_pref]) cat $abs_srcdir/codec_pref/codec_pref_test.ok > expout AT_CHECK([$abs_top_builddir/tests/codec_pref/codec_pref_test], [], [expout], [ignore]) AT_CLEANUP -AT_SETUP([nanobts_omlattr]) -AT_KEYWORDS([nanobts_omlattr]) -cat $abs_srcdir/nanobts_omlattr/nanobts_omlattr_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/nanobts_omlattr/nanobts_omlattr_test], [], [expout], [ignore]) +AT_SETUP([gsm0408]) +AT_KEYWORDS([gsm0408]) +cat $abs_srcdir/gsm0408/gsm0408_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/gsm0408/gsm0408_test], [], [expout], [ignore]) AT_CLEANUP AT_SETUP([handover_tests]) @@ -49,3 +43,9 @@ cat $abs_srcdir/handover/handover_tests.ok > expout AT_CHECK([$abs_srcdir/handover/handover_tests.sh $abs_srcdir/handover $abs_builddir/handover], [], [expout], [ignore]) AT_CLEANUP + +AT_SETUP([nanobts_omlattr]) +AT_KEYWORDS([nanobts_omlattr]) +cat $abs_srcdir/nanobts_omlattr/nanobts_omlattr_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/nanobts_omlattr/nanobts_omlattr_test], [], [expout], [ignore]) +AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic7507c90854a1c953f4c016b1b0e569bca570b37 Gerrit-Change-Number: 27997 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in docker-playground[master]: ttcn3-ggsn-test-ogs: set CAP_NET_RAW for open5gs-upfd
by pespin 02 May '22

02 May '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/27996 ) Change subject: ttcn3-ggsn-test-ogs: set CAP_NET_RAW for open5gs-upfd ...................................................................... ttcn3-ggsn-test-ogs: set CAP_NET_RAW for open5gs-upfd The SO_BINDTODEVICE feature (used for VRF) requires CAP_NET_RAW. Since we run open5gs-upfd as user "osmocom", that seems to be causing some permission problems under some systems (like jenkins). Let's make sure we add the capabilitites to the binary before launching it as user "osmocom". Change-Id: I51ee6954a6c019a41cfcd50b2d99166316989d9b --- M open5gs-master/Dockerfile M ttcn3-ggsn-test/ogs/upfd.sh 2 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/96/27996/1 diff --git a/open5gs-master/Dockerfile b/open5gs-master/Dockerfile index dd6cfd8..0e73559 100644 --- a/open5gs-master/Dockerfile +++ b/open5gs-master/Dockerfile @@ -12,6 +12,7 @@ sudo \ iproute2 \ iputils-ping \ + libcap2-bin \ net-tools && \ apt-get clean diff --git a/ttcn3-ggsn-test/ogs/upfd.sh b/ttcn3-ggsn-test/ogs/upfd.sh index 694df35..9089701 100755 --- a/ttcn3-ggsn-test/ogs/upfd.sh +++ b/ttcn3-ggsn-test/ogs/upfd.sh @@ -2,5 +2,7 @@ set -e set -x /data/upfd-setup.sh -#du -lha / | grep freeDiameter -su - osmocom -c "open5gs-upfd $*" +upfd_bin="$(command -v open5gs-upfd)" +# so_bindtodevice cfg requires CAP_NET_RAW: +setcap cap_net_raw+ep "$upfd_bin" +su - osmocom -c "$upfd_bin $*" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I51ee6954a6c019a41cfcd50b2d99166316989d9b Gerrit-Change-Number: 27996 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add TC_ipa_crcx_ack_addr reproducing OS#5242
by pespin 02 May '22

02 May '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27995 ) Change subject: BTS_Tests: add TC_ipa_crcx_ack_addr reproducing OS#5242 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic85904c967238555a6243a3df2d9225b957d5a5c Gerrit-Change-Number: 27995 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 May 2022 08:43:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: workaround addr='0.0.0.0' in f_rtpem_activate()
by pespin 02 May '22

02 May '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27994 ) Change subject: BTS_Tests: workaround addr='0.0.0.0' in f_rtpem_activate() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I03453e72f62819989dfe6aa12d8bd889fced1046 Gerrit-Change-Number: 27994 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 May 2022 08:42:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log