- gerrit-log - lists.osmocom.org

Change in osmo-bsc-nat[master]: Add bsc_nat fsm

by osmith

Attention is currently required from: neels, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Patch Set 8: (1 comment) Patchset: PS7: > Still no jenkins build verification jobs for this repository? What is the plan for that? Right, added now. https://gerrit.osmocom.org/c/osmo-ci/+/27022 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jan 2022 13:31:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-bsc-nat[master]: osmo-bsc-nat/bsc_nat.c: fix missing include

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27023 ) Change subject: osmo-bsc-nat/bsc_nat.c: fix missing include ...................................................................... osmo-bsc-nat/bsc_nat.c: fix missing include Related: SYS#5560 Change-Id: Ibd30d36eed1a734da25ab3491a4846dd6b70a244 --- M src/osmo-bsc-nat/bsc_nat.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/23/27023/1 diff --git a/src/osmo-bsc-nat/bsc_nat.c b/src/osmo-bsc-nat/bsc_nat.c index 149e7cb..f3a6748 100644 --- a/src/osmo-bsc-nat/bsc_nat.c +++ b/src/osmo-bsc-nat/bsc_nat.c @@ -20,6 +20,7 @@ #include "config.h" #include <osmocom/core/talloc.h> +#include <osmocom/core/utils.h> #include <osmocom/bsc_nat/bsc_nat.h> struct bsc_nat *bsc_nat_alloc(void *tall_ctx) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ibd30d36eed1a734da25ab3491a4846dd6b70a244 Gerrit-Change-Number: 27023 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in osmo-bsc-nat[master]: Add bsc_nat fsm

by osmith

Attention is currently required from: osmith, neels, pespin. Hello neels, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 to look at the new patch set (#8). Change subject: Add bsc_nat fsm ...................................................................... Add bsc_nat fsm Create the initial FSM that starts and stops two SS7 instances (one for CN, one for RAN), and binds an sccp user to each. Related: SYS#5560 Depends: libosmocore I81c64a7ae440304522c2179c212023a566ddced8 Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 --- M doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg M include/osmocom/bsc_nat/Makefile.am M include/osmocom/bsc_nat/bsc_nat.h A include/osmocom/bsc_nat/bsc_nat_fsm.h M src/osmo-bsc-nat/Makefile.am M src/osmo-bsc-nat/bsc_nat.c A src/osmo-bsc-nat/bsc_nat_fsm.c M src/osmo-bsc-nat/main.c M src/osmo-bsc-nat/vty.c 9 files changed, 327 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/62/26662/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/{master-builds,gerrit-*}: add osmo-bsc-nat

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27022 ) Change subject: jobs/{master-builds,gerrit-*}: add osmo-bsc-nat ...................................................................... jobs/{master-builds,gerrit-*}: add osmo-bsc-nat Related: SYS#5560 Change-Id: I240cb614bf3905d04bccc6a00c72567a2ad722d8 --- M jobs/gerrit-lint.yml M jobs/gerrit-verifications.yml M jobs/master-builds.yml 3 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/22/27022/1 diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml index 45db681..0d98d9d 100644 --- a/jobs/gerrit-lint.yml +++ b/jobs/gerrit-lint.yml @@ -26,6 +26,7 @@ - openbsc - openggsn - osmo-bsc + - osmo-bsc-nat - osmo-bts - osmo-hnodeb - osmo-hnbgw diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index a1fce4d..84fe805 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -89,6 +89,7 @@ cmd: '{timeout_cmd} ./contrib/jenkins.sh' - osmo-bsc + - osmo-bsc-nat - osmo-bts: slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian10] diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 0c2be30..0b226d1 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -107,6 +107,7 @@ trigger: > master-openbsc, master-osmo-bsc, + master-osmo-bsc-nat, master-osmo-iuh, master-osmo-msc, master-osmo-sgsn @@ -130,6 +131,7 @@ # -> master-libosmo-sccp # -> master-openbsc # -> master-osmo-bsc + # -> master-osmo-bsc-nat # -> master-osmo-iuh # -> master-osmo-msc # -> master-osmo-sgsn @@ -181,6 +183,7 @@ {docker_img} /build/contrib/jenkins.sh - osmo-bsc + - osmo-bsc-nat - osmo-bts: slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian10] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I240cb614bf3905d04bccc6a00c72567a2ad722d8 Gerrit-Change-Number: 27022 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb: Move GPS-DO USB control to separate USB interface

by tnt

Attention is currently required from: roox, laforge, roh. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017 ) Change subject: icE1usb: Move GPS-DO USB control to separate USB interface ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > protocols: Yes, I figured the same, but thought that 0x00... […] Ack makes sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Icd6555a14896c38626fb147b78af44ff719f2254 Gerrit-Change-Number: 27017 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: roh <jsteiger(a)sysmocom.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: roh <jsteiger(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jan 2022 12:06:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: tnt <tnt(a)246tNt.com> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-e1d[master]: Allow configuration of interfaces/lines via VTY

by tnt

Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27016 ) Change subject: Allow configuration of interfaces/lines via VTY ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: It fails to re-read the config files it write. <0000> intf_line.c:154 (I0) Created <0000> intf_line.c:251 (I0:L0) Created There is no such command. Error occurred during reading the below line: mode CHANNELIZED <0000> osmo-e1d.c:183 Failed to parse the config file 'osmo-e1d.cfg' The watchdog running for interfaces that are in the config but not connected is also kind of annoying, but then again it's the same for when the link is down, I think there is another issue for that. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I89b57b688b68901f87d9683ab9294772ee747d77 Gerrit-Change-Number: 27016 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 31 Jan 2022 12:03:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in pysim[master]: implement shell command to update PLMN in IMSI

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26959 ) Change subject: implement shell command to update PLMN in IMSI ...................................................................... implement shell command to update PLMN in IMSI Add file specific command `update_imsi_plmn` to EF_IMSI to replace the mcc and mnc part of the imsi for use in bulk_script(s) Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc --- M pySim/ts_51_011.py 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 0f7e737..a4e3507 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -470,10 +470,34 @@ class EF_IMSI(TransparentEF): def __init__(self, fid='6f07', sfid=None, name='EF.IMSI', desc='IMSI', size={9,9}): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size) + # add those commands to the general commands of a TransparentEF + self.shell_commands += [self.AddlShellCommands(self)] def _decode_hex(self, raw_hex): return {'imsi': dec_imsi(raw_hex)} def _encode_hex(self, abstract): return enc_imsi(abstract['imsi']) + @with_default_category('File-Specific Commands') + class AddlShellCommands(CommandSet): + def __init__(self,ef:TransparentEF): + super().__init__() + self._ef=ef + + def do_update_imsi_plmn(self, arg: str): + """Change the plmn part of the IMSI""" + plmn = arg.strip() + if len(plmn) == 5 or len(plmn) == 6: + (data, sw) = self._cmd.rs.read_binary_dec() + if sw == '9000' and len(data['imsi'])-len(plmn) == 10: + imsi = data['imsi'] + msin = imsi[len(plmn):] + (data, sw) = self._cmd.rs.update_binary_dec({'imsi': plmn+msin}) + if sw == '9000' and data: + self._cmd.poutput_json(self._cmd.rs.selected_file.decode_hex(data)) + else: + raise ValueError("PLMN length does not match IMSI length") + else: + raise ValueError("PLMN has wrong length!") + # TS 51.011 Section 10.3.4 class EF_PLMNsel(TransRecEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc Gerrit-Change-Number: 26959 Gerrit-PatchSet: 3 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in pysim[master]: implement shell command to update PLMN in IMSI

by laforge

Attention is currently required from: bjoern, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26959 ) Change subject: implement shell command to update PLMN in IMSI ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: I personally also wouldn't have a use case for this, but given that it is very non-intrusive and you have a use case for it, I think it should be merged. Somehow I didn't notice this patch at all until today. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc Gerrit-Change-Number: 26959 Gerrit-PatchSet: 2 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jan 2022 11:54:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb: Move GPS-DO USB control to separate USB interface

by laforge

Attention is currently required from: roox, tnt, roh. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017 ) Change subject: icE1usb: Move GPS-DO USB control to separate USB interface ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Looks good. The minor details I'm not sure about : […] protocols: Yes, I figured the same, but thought that 0x00... 0xcf is by far sufficient for new frame formats, so 0xD0 ("DO") can be used for the GPS-DO? requests: I thought it's good if they don't overlap with the interface requests to the E1 interface so we possibly more easily catch them if sent to the wrong interface. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Icd6555a14896c38626fb147b78af44ff719f2254 Gerrit-Change-Number: 27017 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: roh <jsteiger(a)sysmocom.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: roh <jsteiger(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jan 2022 11:46:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <tnt(a)246tNt.com> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in pysim[master]: implement shell command to update PLMN in IMSI

by fixeria

Attention is currently required from: laforge, bjoern, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26959 ) Change subject: implement shell command to update PLMN in IMSI ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > is this an desirable feature? if yes how do we continue, is there anything i should change? […] I don't use pySim that often, so I don't have a strong opinion here. Not sure why would one need to change the PLMN part but keep the rest unchanged? I guess you're brute-forcing some hard-coded MNC/MNC lists in order to unlock some functionality in the UE? Let's see what the others think. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc Gerrit-Change-Number: 26959 Gerrit-PatchSet: 2 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jan 2022 11:41:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: bjoern <bjoern.c3(a)nixda.biz> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log