- gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: Log more details in osmo_stream_srv_write()
by laforge 20 Aug '22

20 Aug '22

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29082 ) Change subject: Log more details in osmo_stream_srv_write() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I580c00f3b5ade05ecb20a92ce4ece2854334a41f Gerrit-Change-Number: 29082 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Aug 2022 08:37:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: improve manual: PFCP and GTP interfaces
by laforge 20 Aug '22

20 Aug '22

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29143 ) Change subject: improve manual: PFCP and GTP interfaces ...................................................................... Patch Set 1: (1 comment) File doc/manuals/chapters/overview.adoc: https://gerrit.osmocom.org/c/osmo-upf/+/29143/comment/1e0685a6_fa35c034 PS1, Line 162: requires Linux kernel features > ... requires *the following* Linux kernel features ... I think it would make sense to be more specific, like stating the CONFIG options for the kernel. For encaps/decaps that is CONFIG_GTP. For the required ntftables features, it might make sense to ask pablo which of the many CONFIG_NFT_* options we need. That could be added in a separate patch later on, to avoid blocking the merge of this patch -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iccb3f0f52bd5006bc94d0ca06ac5d3271ea89eb9 Gerrit-Change-Number: 29143 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Aug 2022 08:34:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence
by laforge 20 Aug '22

20 Aug '22

Attention is currently required from: neels, fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Aug 2022 08:26:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SCCP: Log more data on CR size error
by laforge 20 Aug '22

20 Aug '22

Attention is currently required from: neels, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 ) Change subject: SCCP: Log more data on CR size error ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Aug 2022 08:25:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: example cfg: tweak logging
by laforge 20 Aug '22

20 Aug '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29145 ) Change subject: example cfg: tweak logging ...................................................................... example cfg: tweak logging Change-Id: Idaf75d64d28264a29b67439c6bbcae8ad6981f7e --- M doc/examples/osmo-hnbgw/osmo-hnbgw.cfg 1 file changed, 4 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg index 53b5508..b7f41e1 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg @@ -1,24 +1,12 @@ -! -! OsmoHNBGW (0) configuration saved from vty -!! -! log stderr logging filter all 1 logging color 1 + logging print level 1 logging print category 1 - logging timestamp 1 + logging print category-hex 0 + logging print file basename last logging print extended-timestamp 1 - logging level all debug - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl notice - logging level lgtp notice - logging level lstats notice + logging level set-all notice hnbgw iuh local-ip 0.0.0.0 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idaf75d64d28264a29b67439c6bbcae8ad6981f7e Gerrit-Change-Number: 29145 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-hnbgw[master]: manual: update IuCS/IuPS protocol stack chart
by laforge 20 Aug '22

20 Aug '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29093 ) Change subject: manual: update IuCS/IuPS protocol stack chart ...................................................................... manual: update IuCS/IuPS protocol stack chart We use SCCP/M3UA now, not SUA. Change-Id: I4496a6ffdda511875208bebbe68dbc9e69541fc0 --- M doc/manuals/chapters/overview.adoc 1 file changed, 12 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved dexter: Looks good to me, approved diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index 47cfc37..278b8ca 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -72,17 +72,18 @@ ---- Iuh IuCS/IuPS - -NAS +----+----+ +----+----+ -Non-Access Stratum | CC | MM | | CC | MM | -- - - - - - - - - - - +----+----+-------+ +----+----+ - | RANAP | | H | RANAP | -Access Stratum +---------+ HNBAP | N +---------+ - - SCCP USER SAP - | RUA | | B | SUA | \ - +---------+-------+ - +---------+ | - | SCTP | G | SCTP | } SIGTRAN - +-----------------+ W +---------+ | - | IP | | IP | / + +----+----+ + | CC | MM | +NAS +----+----+ . . +----+----+ +Non-Access Stratum | CC | MM | . | RANAP | +- - - - - - - - - - - +----+----+-------+ +---------+ + | RANAP | | H | SCCP | +Access Stratum +---------+ HNBAP | N +---------+ + | RUA | | B | M3UA | + +---------+-------+ - +---------+ + | SCTP | G | SCTP | + +-----------------+ W +---------+ + | IP | | IP | +-----------------+ +---------+ ---- 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4496a6ffdda511875208bebbe68dbc9e69541fc0 Gerrit-Change-Number: 29093 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-hnbgw[master]: manual: explain the PFCP port
by laforge 20 Aug '22

20 Aug '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 ) Change subject: manual: explain the PFCP port ...................................................................... manual: explain the PFCP port Change-Id: I383befb226caa49e4a2577657806aef1ee11faa3 --- M doc/manuals/chapters/running.adoc 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved dexter: Looks good to me, but someone else must approve diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 0bcca70..e575215 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -70,6 +70,7 @@ - The SCCP/M3UA links are established by OsmoHNBGW contacting an STP. - The MGCP link is established by OsmoHNBGW contacting an MGW. +- The PFCP link is established by OsmoHNBGW contacting a UPF. To run multiple OsmoHNBGW instances on the same SCCP routing, each HNBGW has to configure a distinct point-code, see <<configure_iucs_iups>>. @@ -140,3 +141,36 @@ mgw remote-port 2427 mgw reset-endpoint rtpbridge/* ---- + +==== Configure co-located User Plane Function + +OsmoHNBGW optionally supports relaying the GTP user plane via a co-located UPF, +which is controlled by the PFCP protocol. + +PFCP support is optional at compile time, as well as run time. To use a co-located UPF, + +* osmo-hnbgw needs to be compiled with 'configure --enable-pfcp', +* and osmo-hnbgw.cfg needs to configure a 'pfcp' / 'remote-addr' and + 'local-addr'. + +The following example configures OsmoHNBGW to associate via PFCP with a UPF +listening on UDP 127.0.0.2:8805, ready to setup GTP tunnel relays. + +---- +hnbgw + pfcp + remote-addr 127.0.0.2 + local-addr 127.0.0.1 +---- + +3GPP TS 29.244 4.2.2 specifies that PFCP Request messages shall be sent to UDP +port 8805, i.e. the PFCP port is fixed as 8805 and currently not configurable in +osmo-hnbgw. + +Setting a 'local-addr' is required: the PFCP protocol features a Node ID, which +uniquely identifies PFCP peers across different interfaces. According to the +PFCP specification, the Node ID can be a fully-qualified domain name (FQDN) or +an IP address. Currently, osmo-hnbgw has no support for using an FQDN as Node +ID, and so far uses the 'local-addr' as local Node ID -- hence the 'local-addr' +must not be "0.0.0.0", which is an unfortunate consequence. This is likely to +improve in the future, see https://osmocom.org/issues/5647 . -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I383befb226caa49e4a2577657806aef1ee11faa3 Gerrit-Change-Number: 29075 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-hnbgw[master]: manual: update overview chart with PFCP
by laforge 20 Aug '22

20 Aug '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076 ) Change subject: manual: update overview chart with PFCP ...................................................................... manual: update overview chart with PFCP Change from ascii art to the dotty chart, taken from the osmocom.org wiki. No need to keep a separate representation here. Change-Id: Ifd8843aeb8ff28fec53323c8fb37b10d4d1f2f9b --- M doc/manuals/chapters/overview.adoc 1 file changed, 51 insertions(+), 15 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index aecb21a..47cfc37 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -9,26 +9,62 @@ as a gateway between the classic 3G core network (CN) domain with its IuCS and IuPS interface and the femtocell based RAN. -A typical 3G network consisting of Osmocom components will look as illustrated in the following +A typical 3G network consisting of Osmocom components is illustrated in the following diagram: [[fig-3g]] .Typical 3G network architecture used with OsmoHNBGW +[graphviz] ---- - +------------+ +----------+ +---------+ +---------+ - UE <-->| hNodeB |<----Iuh----->| HNB-GW |<--IuCS-->| OsmoMSC |<--GSUP-->| OsmoHLR | - UE <-->| femto cell | | | | | | | - | | | | +---------+ +---------+ - | |<---IuUP--\ | | - | |<-------. | | | +---------+ +------+ - +------------+ | | | |<--IuPS-->| SGSN |<--GTP-C-->| GGSN | - | | +----------+ | | .------>| | - | | +---------+ | +------+ - | | +----------+ +---------+ | - | \-->| MGW |<--IuUP-->| MGW | | - | | (HNB-GW) | | (MSC) | | - | +----------+ +---------+ | - `--------------------GTP-U----------------' +digraph G { + rankdir = LR; + + UE [label="UE\n(3G phone)"] + PBX [label="PBX\nAsterisk, FreeSwitch,\nKamailio, Yate, ..."] + + subgraph cluster_msc_mgw { + style=dotted + MSC + MGW1 [label="MGW"] + MSC -> MGW1 [label="MGCP",constraint=false] + } + + subgraph cluster_hnbgw_mgw_upf { + style=dotted + MGW3 [label="MGW"] + UPF + HNBGW [label=HNBGW,style=bold] + HNBGW -> MGW3 [label="MGCP",constraint=false] + HNBGW -> UPF [label="PFCP",constraint=false] + } + + hNodeB [shape="box",label="hNodeB\n(3G femto cell)"] + + MSC -> HLR [label="\nGSUP",style=bold] + SGSN -> HLR [label="GSUP",style="dashed,bold"] + UE -> hNodeB [label="Uu",style=bold] + UE -> hNodeB [style="dashed,bold"] + hNodeB -> HNBGW [label="Iuh",style="bold"] + STP2 [label="STP\n(SCCP/M3UA)"] + HNBGW -> STP2 -> SGSN [label="IuPS",style="dashed,bold"] + HNBGW -> STP2 -> MSC [label="IuCS",style="bold"] + SGSN -> GGSN [label="GTP-C",style="dashed,bold"] + hNodeB -> UPF -> GGSN [label="GTP-U(3G)",style="dashed"] + GGSN -> internet [label="tun",style="dashed"] + + hNodeB -> MGW3 [label="IuUP/RTP",constraint=false] + MGW3 -> MGW1 [label="IuUP/RTP"] + + MSC -> SIPConnector [label="MNCC socket",style=bold] + + SIPConnector -> PBX [label="SIP",style=bold] + MGW1 -> PBX [label="RTP"] + + A, B, C, D [style="invisible"] + A -> B [label="data (PS)",style="dashed"] + C -> D [label="voice/SMS/USSD (CS)"] + +} ---- The HNB-GW performs a translation interface between the IuCS/IuPS interfaces on the one hand 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ifd8843aeb8ff28fec53323c8fb37b10d4d1f2f9b Gerrit-Change-Number: 29076 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-hnbgw[master]: manual: add missing bit on the MGCP port
by laforge 20 Aug '22

20 Aug '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074 ) Change subject: manual: add missing bit on the MGCP port ...................................................................... manual: add missing bit on the MGCP port Change-Id: Ic18180793f0c1497b020e5f4a8cd34d6b519b85f --- M doc/manuals/chapters/running.adoc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 6ad59a5..0bcca70 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -69,6 +69,7 @@ running on the same interface: - The SCCP/M3UA links are established by OsmoHNBGW contacting an STP. +- The MGCP link is established by OsmoHNBGW contacting an MGW. To run multiple OsmoHNBGW instances on the same SCCP routing, each HNBGW has to configure a distinct point-code, see <<configure_iucs_iups>>. 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic18180793f0c1497b020e5f4a8cd34d6b519b85f Gerrit-Change-Number: 29074 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-hnbgw[master]: add example osmo-hnbgw-pfcp.cfg
by laforge 20 Aug '22

20 Aug '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 ) Change subject: add example osmo-hnbgw-pfcp.cfg ...................................................................... add example osmo-hnbgw-pfcp.cfg Change-Id: I62c4935bcc7f684bfe850f88f1b80e8970e0e098 --- A doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved dexter: Looks good to me, approved diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg new file mode 100644 index 0000000..619b29b --- /dev/null +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg @@ -0,0 +1,21 @@ +log stderr + logging filter all 1 + logging color 1 + logging print level 1 + logging print category 1 + logging print category-hex 0 + logging print file basename last + logging print extended-timestamp 1 + logging level set-all notice +hnbgw + iuh + local-ip 0.0.0.0 + hnbap-allow-tmsi 1 + mgcp + mgw remote-ip 127.0.0.1 + mgw local-port 2729 + mgw remote-port 2427 + mgw reset-endpoint rtpbridge/* + pfcp + remote-addr 127.0.0.2 + local-addr 127.0.0.1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I62c4935bcc7f684bfe850f88f1b80e8970e0e098 Gerrit-Change-Number: 29073 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log