- gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SUB frame
by laforge 15 May '22

15 May '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27941 ) Change subject: osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SUB frame ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46f32bbbcb6284615d05b8703945c5ca4da55b92 Gerrit-Change-Number: 27941 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 May 2022 08:10:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-abis[master]: input/unixsocket: Remove write delay timer
by laforge 15 May '22

15 May '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28064 ) Change subject: input/unixsocket: Remove write delay timer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I642d2e4495a08ce45e9a4492e98255aacd0be39a Gerrit-Change-Number: 28064 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 May 2022 08:09:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: do not BSSMAP Clear on lchan rel when LCS is still ongoing
by laforge 15 May '22

15 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28093 ) Change subject: do not BSSMAP Clear on lchan rel when LCS is still ongoing ...................................................................... do not BSSMAP Clear on lchan rel when LCS is still ongoing The proper way to fix this is having a use count on the SCCP conn, one each for a busy lchan and a busy Location Request. That would require a bunch more work and testing. This patch is the least-effort way to avoid the following scenario: Emergency call is started; Location Request is started to locate the emergency; lchan releases early for any reason; Perfectly fine Location Request gets canceled by Clear Request; The information was there, but we did not forward the location; No help at emergency because of my code. Allow Location Request to complete for these cases: - rx RLL REL IND (or any other reason for gscon_lchan_releasing()) - rx RSL CONN FAIL Related: SYS#5912 Related: Idea690a4aa4aecbe4642a16e96d086cc0538564a (osmo-ttcn3-hacks) Change-Id: Ib44dd05b0adee84234f671313b156ff6625357cc --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index 428d200..54d3975 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -878,8 +878,9 @@ lchan_forget_conn(conn->lchan); conn->lchan = NULL; } - /* If the conn has no lchan anymore, it was released by the BTS and needs to Clear towards MSC. */ - if (!conn->lchan) { + /* If the conn has no lchan anymore, it was released by the BTS and needs to Clear towards MSC. + * However, if a Location Request is still busy, do not send Clear Request. */ + if (!conn->lchan && !conn->lcs.loc_req) { switch (conn->fi->state) { case ST_WAIT_CC: /* The SCCP connection was not yet confirmed by a CC, the BSSAP is not fully established @@ -984,7 +985,9 @@ conn->lchan->release.rr_cause = bsc_gsm48_rr_cause_from_rsl_cause(conn->lchan->release.rsl_error_cause); } - gscon_bssmap_clear(conn, GSM0808_CAUSE_RADIO_INTERFACE_FAILURE); + /* Request BSSMAP Clear, but do not abort an ongoing Location Request */ + if (!conn->lcs.loc_req) + gscon_bssmap_clear(conn, GSM0808_CAUSE_RADIO_INTERFACE_FAILURE); break; case GSCON_EV_MGW_MDCX_RESP_MSC: LOGPFSML(fi, LOGL_DEBUG, "Rx MDCX of MSC side (LCLS?)\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib44dd05b0adee84234f671313b156ff6625357cc Gerrit-Change-Number: 28093 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: do not BSSMAP Clear on lchan rel when LCS is still ongoing
by laforge 15 May '22

15 May '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28093 ) Change subject: do not BSSMAP Clear on lchan rel when LCS is still ongoing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib44dd05b0adee84234f671313b156ff6625357cc Gerrit-Change-Number: 28093 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 May 2022 08:09:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: jobs: TTCN3-centos: set OSMOCOM_REPO_TESTSUITE_MIRROR
by laforge 15 May '22

15 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28100 ) Change subject: jobs: TTCN3-centos: set OSMOCOM_REPO_TESTSUITE_MIRROR ...................................................................... jobs: TTCN3-centos: set OSMOCOM_REPO_TESTSUITE_MIRROR In previous patch Id114d55edc2ba92f7851243ab7df51db332079c4, only the OSMOCOM_REPO_MIRROR should have been overridden. However OSMOCOM_REPO_TESTSUITE_MIRROR defaults to OSMOCOM_REPO_MIRROR, so explicitly set it in this patch to the opensuse mirror. This fixes problems while building debian-bullseye-titan caused by the different directory structure of both mirrors, and OSMOCOM_REPO_PATH intentionally not taken into account while building the testsuite docker image. This is part 2/2 of fixing TTCN3-centos-bts-test, which has been failing since OSMOCOM_REPO_MIRROR was changed in osmo-ci.git. Part 1 is in docker-playground I78e0445a1b82e5cd72ecaa86e8fe25516b19f485. Change-Id: I8201f34a0f9747eea78c358a626cc3981d7407c4 --- M jobs/ttcn3-testsuites.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index af6e482..5de6310 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -491,6 +491,7 @@ ;; TTCN3-centos-*) DIR="$(echo "{job-name}" | sed s/^TTCN3-centos\-/ttcn3-/)" + export OSMOCOM_REPO_TESTSUITE_MIRROR="http://download.opensuse.org" export OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" export OSMOCOM_REPO_PATH="obs-mirror/.previous" export IMAGE_SUFFIX="master-centos8" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8201f34a0f9747eea78c358a626cc3981d7407c4 Gerrit-Change-Number: 28100 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ci[master]: jobs: TTCN3-centos: set OSMOCOM_REPO_TESTSUITE_MIRROR
by laforge 15 May '22

15 May '22

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28100 ) Change subject: jobs: TTCN3-centos: set OSMOCOM_REPO_TESTSUITE_MIRROR ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8201f34a0f9747eea78c358a626cc3981d7407c4 Gerrit-Change-Number: 28100 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 May 2022 08:09:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: firmware/layer1: clarify L1CTL_DM_EST_REQ related logging
by laforge 15 May '22

15 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28109 ) Change subject: firmware/layer1: clarify L1CTL_DM_EST_REQ related logging ...................................................................... firmware/layer1: clarify L1CTL_DM_EST_REQ related logging Change-Id: I7a7fb32eab0ab20672a47861c3b66da92bd83015 --- M src/target/firmware/layer1/l23_api.c 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/target/firmware/layer1/l23_api.c b/src/target/firmware/layer1/l23_api.c index 275043b..a133c62 100644 --- a/src/target/firmware/layer1/l23_api.c +++ b/src/target/firmware/layer1/l23_api.c @@ -257,8 +257,8 @@ struct l1ctl_info_ul *ul = (struct l1ctl_info_ul *) l1h->data; struct l1ctl_dm_est_req *est_req = (struct l1ctl_dm_est_req *) ul->payload; - printd("L1CTL_DM_EST_REQ (arfcn=%u, chan_nr=0x%02x, tsc=%u)\n", - ntohs(est_req->h0.band_arfcn), ul->chan_nr, est_req->tsc); + printd("L1CTL_DM_EST_REQ (chan_nr=0x%02x, tsc=%u)\n", + ul->chan_nr, est_req->tsc); /* disable neighbour cell measurement of C0 TS 0 */ mframe_disable(MF_TASK_NEIGH_PM51_C0T0); @@ -276,8 +276,12 @@ l1s.dedicated.h1.n = est_req->h1.n; for (i=0; i<est_req->h1.n; i++) l1s.dedicated.h1.ma[i] = ntohs(est_req->h1.ma[i]); + printd("L1CTL_DM_EST_REQ indicates H1 (HSN=%u, MAIO=%u, chans=%u)\n", + est_req->h1.hsn, est_req->h1.maio, est_req->h1.n); } else { l1s.dedicated.h0.arfcn = ntohs(est_req->h0.band_arfcn); + printd("L1CTL_DM_EST_REQ indicates H0 (ARFCN=%u)\n", + l1s.dedicated.h0.arfcn & ~ARFCN_FLAG_MASK); } /* TCH config */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7a7fb32eab0ab20672a47861c3b66da92bd83015 Gerrit-Change-Number: 28109 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: layer23: chantype_rsl2gsmtap() is deprecated, use chantype_rsl2gsmtap2()
by laforge 15 May '22

15 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28111 ) Change subject: layer23: chantype_rsl2gsmtap() is deprecated, use chantype_rsl2gsmtap2() ...................................................................... layer23: chantype_rsl2gsmtap() is deprecated, use chantype_rsl2gsmtap2() Change-Id: Id54b973cec8479fc32775be260f8a9fac8f09bae --- M src/host/layer23/src/common/l1ctl.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/common/l1ctl.c b/src/host/layer23/src/common/l1ctl.c index 9af6167..5e02dbe 100644 --- a/src/host/layer23/src/common/l1ctl.c +++ b/src/host/layer23/src/common/l1ctl.c @@ -82,7 +82,7 @@ static uint8_t chantype_rsl2gsmtap_ext(uint8_t rsl_chantype, uint8_t link_id, uint32_t fn, uint8_t num_agch) { - uint8_t ret = chantype_rsl2gsmtap(rsl_chantype, link_id); + uint8_t ret = chantype_rsl2gsmtap2(rsl_chantype, link_id, false); if (ret != GSMTAP_CHANNEL_PCH) return ret; @@ -387,7 +387,7 @@ /* send copy via GSMTAP */ rsl_dec_chan_nr(chan_nr, &chan_type, &chan_ss, &chan_ts); - gsmtap_chan_type = chantype_rsl2gsmtap(chan_type, link_id); + gsmtap_chan_type = chantype_rsl2gsmtap2(chan_type, link_id, false); gsmtap_send(gsmtap_inst, ms->rrlayer.cd_now.arfcn | GSMTAP_ARFCN_F_UPLINK, chan_ts, gsmtap_chan_type, chan_ss, 0, 127, 255, msg->l2h, msgb_l2len(msg)); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id54b973cec8479fc32775be260f8a9fac8f09bae Gerrit-Change-Number: 28111 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: trxcon: clarify L1CTL_DM_REL_REQ related logging
by laforge 15 May '22

15 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28110 ) Change subject: trxcon: clarify L1CTL_DM_REL_REQ related logging ...................................................................... trxcon: clarify L1CTL_DM_REL_REQ related logging In reality, trxcon does not switch back to BCCH itself. Neither the firmware does, so let's correct this confusing log message. Change-Id: Iad308ad980af4caa7d7d1b358ba7288885f96e04 --- M src/host/trxcon/l1ctl.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c index 95ba9b6..94a4d18 100644 --- a/src/host/trxcon/l1ctl.c +++ b/src/host/trxcon/l1ctl.c @@ -687,8 +687,7 @@ static int l1ctl_rx_dm_rel_req(struct l1ctl_link *l1l, struct msgb *msg) { - LOGP(DL1C, LOGL_NOTICE, "Received L1CTL_DM_REL_REQ, " - "switching back to CCCH\n"); + LOGP(DL1C, LOGL_NOTICE, "Received L1CTL_DM_REL_REQ, resetting scheduler\n"); /* Reset scheduler */ sched_trx_reset(l1l->trx, false); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iad308ad980af4caa7d7d1b358ba7288885f96e04 Gerrit-Change-Number: 28110 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: layer23: chantype_rsl2gsmtap() is deprecated, use chantype_rsl2gsmtap2()
by laforge 15 May '22

15 May '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28111 ) Change subject: layer23: chantype_rsl2gsmtap() is deprecated, use chantype_rsl2gsmtap2() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id54b973cec8479fc32775be260f8a9fac8f09bae Gerrit-Change-Number: 28111 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 May 2022 08:08:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log