- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: stats: new trackers for lchan life duration
by iedemam 12 May '22

12 May '22

iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: I am starting on this now. I will rework the patch to have one timer per BTS instead of one timer per lchan. My instinct to use one per BTS instead of one global for the entire BSC is so that stat summation activity is spread out in smaller chunks instead of in one large task for potentially thousands of lchans. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 22 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 May 2022 07:32:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Build failure of network:osmocom:nightly/osmo-bsc-nat in Debian_11/aarch64
by OBS Notification 12 May '22

12 May '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-bsc-nat failed to build in Debian_11/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc-nat Last lines of build log: connect to src-opensuse:5353: Connection refused (worker was obs-arm-9:5) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration
by pespin 11 May '22

11 May '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: > I agree. […] I agree with Harald the main point is avoid having so many timers. So I'd start by migrating to having 1 timer per BTS, or 1 main BSC timer which triggers ever 500ms-1s and which then iterates to update the data for all its depending lchans. Counting for SDCCH on top of TCH shouldn't make a big different imho if calculated in the same iteration. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 22 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 May 2022 17:12:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: iedemam <michael(a)kapsulate.com> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration
by iedemam 11 May '22

11 May '22

iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: I agree. Some things which would still keep this feature useful to us but will reduce the performance impact: 1) reduce granularity from 0.1s to 1s: While I'd like to keep 100ms resolution, maybe there's no way to do it efficiently. 2) only start timers and track stats on TCH lchans: We're primarily using this to gather Erlang stats and secondarily to glance site health. Even if it's only TCH it still serves that purpose. The biggest BSC we're talking about has 4480 SDCCH lchans defined and 3200 TCH. The combination of 1 and 2 above gives us a full order of magnitude drop and then cuts that in half. Maybe a better starting point? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 22 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 May 2022 17:06:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration
by pespin 11 May '22

11 May '22

Attention is currently required from: iedemam. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: > So due to severe performance regressions, I think we will have to re-open the discussion about this […] I also think having subsecond granularity may not be that interesting given the amount of extra performance penalty induced. Maybe if at all have it at 500ms minimum. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 22 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Wed, 11 May 2022 17:00:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration
by laforge 11 May '22

11 May '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: So due to severe performance regressions, I think we will have to re-open the discussion about this code. It adds one osmo_timer for each lchan, and that timer expires every 100ms. So thinking of a system with 80 BTS and each BTS having a single trx with ~ 16 lchan, we end up with 12800 (!) timers expiring each second! This is certainly the single biggest performance hog in osmo-bsc for any setup larger than the most trivial one. Whatever we do, we have to do better than that. Like one timer expiring every 100ms iteratinng over the lchans? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 22 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 May 2022 16:39:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: smscb: fix meaningless condition in etws_primary_to_bts()
by pespin 11 May '22

11 May '22

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28088 ) Change subject: smscb: fix meaningless condition in etws_primary_to_bts() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id369bb3676ba279bafc234378fbe21dbc7b0614b Gerrit-Change-Number: 28088 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 May 2022 11:39:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: smscb: fix meaningless condition in etws_primary_to_bts()
by fixeria 11 May '22

11 May '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28088 ) Change subject: smscb: fix meaningless condition in etws_primary_to_bts() ...................................................................... smscb: fix meaningless condition in etws_primary_to_bts() Found by GCC 12.1.0: smscb.c: In function 'etws_primary_to_bts': smscb.c:537:13: warning: the comparison will always evaluate as 'true' for the address of 'warning_sec_info' will never be NULL [-Waddress] 537 | if (wrepl->u.emergency.warning_sec_info) { | ^~~~~ In file included from smscb.c:31: /usr/local/include/osmocom/gsm/cbsp.h:99:33: note: 'warning_sec_info' declared here 99 | uint8_t warning_sec_info[50]; | ^~~~~~~~~~~~~~~~ Indeed, address of &warning_sec_info[0] is always not NULL. Change-Id: Id369bb3676ba279bafc234378fbe21dbc7b0614b --- M src/osmo-bsc/smscb.c 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/28088/1 diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 8a6a705..b614852 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -534,11 +534,9 @@ bes->input.msg_id = wrepl->msg_id; bes->input.serial_nr = wrepl->new_serial_nr; bes->input.warn_type = wrepl->u.emergency.warning_type; - if (wrepl->u.emergency.warning_sec_info) { - bes->input.sec_info = talloc_named_const(bts, ETWS_SEC_INFO_SIZE, "etws_sec_info"); - if (bes->input.sec_info) - memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, ETWS_SEC_INFO_SIZE); - } + bes->input.sec_info = talloc_named_const(bts, ETWS_SEC_INFO_SIZE, "etws_sec_info"); + if (bes->input.sec_info) + memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, ETWS_SEC_INFO_SIZE); /* generate the encoded ETWS PN */ gen_etws_primary_notification(bes->primary, bes->input.serial_nr, bes->input.msg_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id369bb3676ba279bafc234378fbe21dbc7b0614b Gerrit-Change-Number: 28088 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-e1d[master]: e1oip: Make batching-factor and prefill-frame-count configurable
by laforge 10 May '22

10 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/28066 ) Change subject: e1oip: Make batching-factor and prefill-frame-count configurable ...................................................................... e1oip: Make batching-factor and prefill-frame-count configurable This adds VTY commands at the 'account' level to configure those settings. They will only become active on the next [re]connect of the line. Change-Id: Ic455ef0ef82867db512e2ffdff24d9dd42d47eeb --- M include/osmocom/octoi/octoi.h M src/octoi/e1oip.c M src/octoi/e1oip.h M src/octoi/octoi_clnt_fsm.c M src/octoi/octoi_clnt_vty.c M src/octoi/octoi_srv_fsm.c M src/octoi/octoi_srv_vty.c M src/octoi/octoi_vty.h 8 files changed, 64 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified manawyrm: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/octoi/octoi.h b/include/osmocom/octoi/octoi.h index e7ebcaa..c9fa3d5 100644 --- a/include/osmocom/octoi/octoi.h +++ b/include/osmocom/octoi/octoi.h @@ -21,6 +21,8 @@ struct llist_head list; /* member in octoi_server.cfg.accounts */ char *user_id; /* user ID (IMSI) */ enum octoi_account_mode mode; + uint8_t batching_factor; /* E1 frames per UDP packet (Tx) */ + uint32_t prefill_frame_count; /* FIFO prefill/preseed count (Rx) */ union { struct { char *usb_serial; /* USB serial string (ASCII) of icE1usb */ diff --git a/src/octoi/e1oip.c b/src/octoi/e1oip.c index a577a92..c4bf054 100644 --- a/src/octoi/e1oip.c +++ b/src/octoi/e1oip.c @@ -313,6 +313,13 @@ return iline; } +void e1oip_line_configure(struct e1oip_line *iline, uint8_t batching_factor, + uint32_t prefill_frame_count) +{ + iline->cfg.batching_factor = batching_factor; + iline->cfg.prefill_frame_count = prefill_frame_count; +} + void e1oip_line_reset(struct e1oip_line *iline) { frame_fifo_init(&iline->e1o.fifo, iline->cfg.batching_factor, fifo_threshold_cb, iline); diff --git a/src/octoi/e1oip.h b/src/octoi/e1oip.h index 2c88346..ccdebd5 100644 --- a/src/octoi/e1oip.h +++ b/src/octoi/e1oip.h @@ -83,6 +83,8 @@ struct e1oip_line *e1oip_line_alloc(struct octoi_peer *peer); void e1oip_line_set_name(struct e1oip_line *line, const char *name); void e1oip_line_reset(struct e1oip_line *iline); +void e1oip_line_configure(struct e1oip_line *iline, uint8_t batching_factor, + uint32_t prefill_frame_count); void e1oip_line_destroy(struct e1oip_line *iline); int e1oip_rcvmsg_tdm_data(struct e1oip_line *iline, struct msgb *msg); diff --git a/src/octoi/octoi_clnt_fsm.c b/src/octoi/octoi_clnt_fsm.c index c4117d2..2ec5c8c 100644 --- a/src/octoi/octoi_clnt_fsm.c +++ b/src/octoi/octoi_clnt_fsm.c @@ -122,6 +122,8 @@ { struct clnt_state *st = fi->priv; + e1oip_line_configure(st->peer->iline, st->acc->batching_factor, + st->acc->prefill_frame_count); /* reset RIFO/FIFO etc. */ e1oip_line_reset(st->peer->iline); iline_ctr_add(st->peer->iline, LINE_CTR_E1oIP_CONNECT_ACCEPT, 1); diff --git a/src/octoi/octoi_clnt_vty.c b/src/octoi/octoi_clnt_vty.c index 756cc9a..ff50ddb 100644 --- a/src/octoi/octoi_clnt_vty.c +++ b/src/octoi/octoi_clnt_vty.c @@ -242,6 +242,7 @@ llist_for_each_entry(clnt, &g_octoi->clients, list) { struct octoi_sock *sock = clnt->sock; + octoi_vty_show_one_account(vty, "", clnt->cfg.account); vty_show_octoi_sock(vty, sock); } @@ -278,6 +279,8 @@ install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_ice1_serno_cmd); install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_ice1_line_cmd); install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_mode_cmd); + install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_batching_factor_cmd); + install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_prefill_frame_count_cmd); install_node(&clnt_node, config_write_octoi_clnt); install_element(CONFIG_NODE, &cfg_client_cmd); diff --git a/src/octoi/octoi_srv_fsm.c b/src/octoi/octoi_srv_fsm.c index 1af3805..469436e 100644 --- a/src/octoi/octoi_srv_fsm.c +++ b/src/octoi/octoi_srv_fsm.c @@ -174,6 +174,8 @@ { struct srv_state *st = fi->priv; + e1oip_line_configure(st->peer->iline, st->acc->batching_factor, + st->acc->prefill_frame_count); /* reset RIFO/FIFO etc. */ e1oip_line_reset(st->peer->iline); iline_ctr_add(st->peer->iline, LINE_CTR_E1oIP_CONNECT_ACCEPT, 1); diff --git a/src/octoi/octoi_srv_vty.c b/src/octoi/octoi_srv_vty.c index f616af5..58d18bc 100644 --- a/src/octoi/octoi_srv_vty.c +++ b/src/octoi/octoi_srv_vty.c @@ -34,6 +34,7 @@ #include <osmocom/vty/stats.h> #include <osmocom/vty/misc.h> +#include "e1oip.h" #include "octoi.h" #include "octoi_sock.h" #include "octoi_fsm.h" @@ -63,6 +64,9 @@ return NULL; } + ac->batching_factor = DEFAULT_BATCHING_FACTOR; + ac->prefill_frame_count = DEFAULT_PREFILL_FRAME_COUNT; + return ac; } @@ -367,6 +371,35 @@ return CMD_SUCCESS; } +gDEFUN(cfg_account_batching_factor, cfg_account_batching_factor_cmd, + "batching-factor <1-256>", + "E1oIP batching factor (E1 frames per Tx UDP packet)\n" + "E1oIP batching factor (E1 frames per Tx UDP packet)\n") +{ + struct octoi_account *acc = vty->index; + + acc->batching_factor = atoi(argv[0]); + return CMD_SUCCESS; +} + +gDEFUN(cfg_account_prefill_frame_count, cfg_account_prefill_frame_count_cmd, + "prefill-frame-count <0-8000>", + "Number of E1 frames to pre-fill/pre-seed in Rx RIFO\n" + "Number of E1 frames to pre-fill/pre-seed in Rx RIFO\n") +{ + struct octoi_account *acc = vty->index; + + acc->prefill_frame_count = atoi(argv[0]); + return CMD_SUCCESS; +} + +void octoi_vty_show_one_account(struct vty *vty, const char *pfx, struct octoi_account *acc) +{ + vty_out(vty, "%sAccount '%s': Mode=%s, Batching=%u, Prefill=%u%s", pfx, + acc->user_id, get_value_string(octoi_account_mode_name, acc->mode), + acc->batching_factor, acc->prefill_frame_count, VTY_NEWLINE); +} + void octoi_vty_write_one_account(struct vty *vty, const struct octoi_account *acc) { if (!acc) @@ -375,6 +408,10 @@ vty_out(vty, " account %s%s", acc->user_id, VTY_NEWLINE); vty_out(vty, " mode %s%s", get_value_string(octoi_account_mode_name, acc->mode), VTY_NEWLINE); + if (acc->batching_factor != DEFAULT_BATCHING_FACTOR) + vty_out(vty, " batching-factor %u%s", acc->batching_factor, VTY_NEWLINE); + if (acc->prefill_frame_count != DEFAULT_PREFILL_FRAME_COUNT) + vty_out(vty, " prefill-frame-count %u%s", acc->prefill_frame_count, VTY_NEWLINE); switch (acc->mode) { case ACCOUNT_MODE_NONE: @@ -425,6 +462,7 @@ SHOW_STR "Display information about the OCTOI Server\n") { struct octoi_server *srv = g_octoi->server; + struct octoi_account *acc; if (!srv) { vty_out(vty, "%% No OCTOI server present%s", VTY_NEWLINE); @@ -433,6 +471,9 @@ vty_show_octoi_sock(vty, srv->sock); + llist_for_each_entry(acc, &srv->cfg.accounts, list) + octoi_vty_show_one_account(vty, "", acc); + return CMD_SUCCESS; } @@ -446,6 +487,8 @@ install_element(OCTOI_ACCOUNT_NODE, &cfg_account_ice1_serno_cmd); install_element(OCTOI_ACCOUNT_NODE, &cfg_account_ice1_line_cmd); install_element(OCTOI_ACCOUNT_NODE, &cfg_account_redir_cmd); + install_element(OCTOI_ACCOUNT_NODE, &cfg_account_batching_factor_cmd); + install_element(OCTOI_ACCOUNT_NODE, &cfg_account_prefill_frame_count_cmd); install_node(&srv_node, config_write_octoi_srv); install_element(CONFIG_NODE, &cfg_server_cmd); diff --git a/src/octoi/octoi_vty.h b/src/octoi/octoi_vty.h index 6f18802..16c5337 100644 --- a/src/octoi/octoi_vty.h +++ b/src/octoi/octoi_vty.h @@ -7,9 +7,12 @@ extern struct cmd_element cfg_account_mode_cmd; extern struct cmd_element cfg_account_ice1_serno_cmd; extern struct cmd_element cfg_account_ice1_line_cmd; +extern struct cmd_element cfg_account_batching_factor_cmd; +extern struct cmd_element cfg_account_prefill_frame_count_cmd; struct octoi_account *octoi_client_account_create(struct octoi_client *clnt, const char *user_id); +void octoi_vty_show_one_account(struct vty *vty, const char *pfx, struct octoi_account *acc); void octoi_vty_write_one_account(struct vty *vty, const struct octoi_account *acc); void vty_show_octoi_sock(struct vty *vty, struct octoi_sock *sock); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/28066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ic455ef0ef82867db512e2ffdff24d9dd42d47eeb Gerrit-Change-Number: 28066 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

Change in osmo-e1d[master]: e1oip: Make batching-factor and prefill-frame-count configurable
by laforge 10 May '22

10 May '22

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/28066 ) Change subject: e1oip: Make batching-factor and prefill-frame-count configurable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/28066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ic455ef0ef82867db512e2ffdff24d9dd42d47eeb Gerrit-Change-Number: 28066 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 10 May 2022 18:09:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log