fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libsmpp34/+/29219 )
Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE
......................................................................
contrib/jenkins.sh: actually build with $PARALLEL_MAKE
Executing $MAKE without $PARALLEL_MAKE builds the project with -j1.
Executing $MAKE with $PARALLEL_MAKE after that makes no sense,
because everything is already compiled and there is nothing to do.
Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334
---
M contrib/jenkins.sh
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/19/29219/1
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 3b4e639..7a75e25 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -7,7 +7,6 @@
autoreconf --install --force
./configure --enable-sanitize --enable-werror
-$MAKE
$MAKE $PARALLEL_MAKE
$MAKE distcheck || cat-testlogs.sh
$MAKE maintainer-clean
--
To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334
Gerrit-Change-Number: 29219
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002 )
Change subject: debian,RPM: package with PFCP support
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
libosmo-pfcp shows as succeeded in obs for nightly and latest;
it is disabled on CentOS7, but so is osmo-hnbgw.
my "home" build on obs worked, so this should succeed now...
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I54dfe600d45541fecbb4c05bf75f147934c230f0
Gerrit-Change-Number: 29002
Gerrit-PatchSet: 10
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sat, 27 Aug 2022 16:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29217 )
Change subject: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY
......................................................................
osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY
The PRIM_INFO_MODIFY is sent on receipt of the RSL MODE MODIFY message,
which may optionally contain new ciphering parameters. Before this
patch, osmo-bts-trx would ignore the new parameters and continue using
the old ciphering key/algorithm.
* Modify l1if_set_ciphering() to allow updating ciphering params.
* Call l1if_set_ciphering() when handling PRIM_INFO_MODIFY.
This problem was uncovered by BTS_Tests.TC_rsl_modify_encr, which has
been failing ever since it was introduced [1]. This patch makes it pass.
Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589
Related: [1] I4cbea499bb6a331d314e6573548a4540945208b5 osmo-ttcn3-hacks.git
Related: OS#3750
---
M src/osmo-bts-trx/l1_if.c
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/29217/1
diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c
index 92180b5..8c364c3 100644
--- a/src/osmo-bts-trx/l1_if.c
+++ b/src/osmo-bts-trx/l1_if.c
@@ -326,8 +326,8 @@
/* enable ciphering */
static int l1if_set_ciphering(struct gsm_lchan *lchan, uint8_t chan_nr, int downlink)
{
- /* ciphering already enabled in both directions */
- if (lchan->ciph_state == LCHAN_CIPH_RXTX_CONF)
+ /* ignore the request when the channel is not active */
+ if (lchan->state != LCHAN_S_ACTIVE)
return -EINVAL;
if (!downlink) {
@@ -463,6 +463,13 @@
lchan->tch.amr_mr.mode[3].mode,
amr_get_initial_mode(lchan),
0);
+ /* update ciphering params */
+ l1if_set_ciphering(lchan, chan_nr, 0);
+ l1if_set_ciphering(lchan, chan_nr, 1);
+ if (lchan->encr.alg_id)
+ lchan->ciph_state = LCHAN_CIPH_RXTX_CONF;
+ else
+ lchan->ciph_state = LCHAN_CIPH_NONE;
break;
}
/* here, type == PRIM_INFO_DEACTIVATE */
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29217
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589
Gerrit-Change-Number: 29217
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29164 )
Change subject: packate the new osmo-hnbgw-pfcp.cfg example config file
......................................................................
packate the new osmo-hnbgw-pfcp.cfg example config file
In I62c4935bcc7f684bfe850f88f1b80e8970e0e098 we added a new example
config file, but didn't actually package it in dpkg or rpm packages
yet. This also lead to package build failures like:
[ 39s] RPM build errors:
[ 39s] Installed (but unpackaged) file(s) found:
[ 39s] /usr/share/doc/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg
Change-Id: I7c5c346f67f003b2cc5d74e812441c3704b133ef
---
M debian/osmo-hnbgw.install
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
neels: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/debian/osmo-hnbgw.install b/debian/osmo-hnbgw.install
index ac1f931..daf1f1a 100644
--- a/debian/osmo-hnbgw.install
+++ b/debian/osmo-hnbgw.install
@@ -2,3 +2,4 @@
lib/systemd/system/osmo-hnbgw.service
usr/bin/osmo-hnbgw
usr/share/doc/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw.cfg usr/share/doc/osmo-hnbgw/examples
+usr/share/doc/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg usr/share/doc/osmo-hnbgw/examples
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29164
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I7c5c346f67f003b2cc5d74e812441c3704b133ef
Gerrit-Change-Number: 29164
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: laforge.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29164 )
Change subject: packate the new osmo-hnbgw-pfcp.cfg example config file
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29164
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I7c5c346f67f003b2cc5d74e812441c3704b133ef
Gerrit-Change-Number: 29164
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 26 Aug 2022 11:53:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment