Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 )
Change subject: bsc: Add testscase & infra to validate Osmux support BTS<->BSC
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/c74120fb_36a1…
PS6, Line 13: sides (towards BTS and CN).
I wonder if in general it makes more sense to not replace existing tests with different new tests, as this may lead to confusion when looking at the test history.
File bsc/MSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/67e8260f_d8c3…
PS6, Line 255: CRCX
MDCX, same 3x below
File library/RSL_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/d1694650_068d…
PS6, Line 2310: //tr_RSL_IE_OSMO_Osmux_CID(osmux_cid);
left this intentionally?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6e82eb9d995de988b812001e1c4cf6923509de66
Gerrit-Change-Number: 29010
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Sep 2022 09:50:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331 )
Change subject: Abort if processing SCTP connection without HNB context
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I intentionally did not want to ASSERT in my original patch as my branch doesn't fix all of the causes of hnb being NULL. AFAIR the de-registration was only one code path leading to the situation, there was at least one other path, AFAIR?
So let's either fix all of those code paths + ASSERT, or not assert.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I1eedab6f3ac974e942b02eaae41556f87dd8b6ba
Gerrit-Change-Number: 29331
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Sep 2022 09:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331 )
Change subject: Abort if processing SCTP connection without HNB context
......................................................................
Removed Code-Review+2 by laforge <laforge(a)osmocom.org>
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I1eedab6f3ac974e942b02eaae41556f87dd8b6ba
Gerrit-Change-Number: 29331
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: deleteVote
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29333 )
Change subject: Don't process RUA messages if HNB is not registered
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29333
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I85442e8adfefadc3bf3ed795eaef7677eb0b36e9
Gerrit-Change-Number: 29333
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Sep 2022 09:48:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334
to look at the new patch set (#2).
Change subject: Don't permit anything but HNB (de)registration until HNB is registered
......................................................................
Don't permit anything but HNB (de)registration until HNB is registered
UE registration or other HNBAP procedures should only happen once the
HNB is registered.
Change-Id: Iaa62ce89f4ffbff868309bfb8b1df7ebcca5c44a
---
M src/osmo-hnbgw/hnbgw_hnbap.c
1 file changed, 42 insertions(+), 26 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/34/29334/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Iaa62ce89f4ffbff868309bfb8b1df7ebcca5c44a
Gerrit-Change-Number: 29334
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset