- gerrit-log - lists.osmocom.org

Change in docker-playground[master]: ttcn3-bts: Add osmux configurations
by fixeria 14 Sep '22

14 Sep '22

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29338 ) Change subject: ttcn3-bts: Add osmux configurations ...................................................................... Patch Set 3: (1 comment) File ttcn3-bts-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/29338/comment/1cb4bfae_25c… PS2, Line 148: image_suffix_is_latest > good point, this can be used instead: […] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I185b77eb4fa05501f098d89b80b66168349175bb Gerrit-Change-Number: 29338 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Sep 2022 10:05:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: ttcn3-bts: Add osmux configurations
by pespin 14 Sep '22

14 Sep '22

Attention is currently required from: fixeria, pespin. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/29338 to look at the new patch set (#3). Change subject: ttcn3-bts: Add osmux configurations ...................................................................... ttcn3-bts: Add osmux configurations Requires: osmo-ttcn3-hacks.git I1af23c7a60b05edc3b544f1fea0023f48e89f7a7 Requires: osmo-bts.git Ib80be434c06d07b3611bd18ae25dff8b14a7aad9 Related: SYS#5987 Change-Id: I185b77eb4fa05501f098d89b80b66168349175bb --- M ttcn3-bts-test/generic/BTS_Tests.cfg M ttcn3-bts-test/generic/osmo-bts.confmerge M ttcn3-bts-test/jenkins.sh 3 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/38/29338/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I185b77eb4fa05501f098d89b80b66168349175bb Gerrit-Change-Number: 29338 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_osmux_cn: use c_mr_conf_5_90
by fixeria 14 Sep '22

14 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29345 ) Change subject: BSC_Tests: fix TC_assignment_osmux_cn: use c_mr_conf_5_90 ...................................................................... BSC_Tests: fix TC_assignment_osmux_cn: use c_mr_conf_5_90 Currently this testcase fails: RSL MR CONFIG IE does not match expectation. Expected: { other := { len := 2, payload := '2804'O } } Change-Id: Icc5381eccb924803b1117b46d2b4c47cee6dabd7 --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index f6f8c9c..cd9514e 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -5251,18 +5251,10 @@ var TestHdlrParams pars := f_gen_test_hdlr_pars(); var MSC_ConnHdlr vc_conn; - /* See note above */ - var RSL_IE_Body mr_conf := { - other := { - len := 2, - payload := '2804'O - } - }; - pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H})); pars.ass_codec_list.codecElements[0].s0_7 := '00000100'B; /* 5,90k */ pars.ass_codec_list.codecElements[0].s8_15 := '00000111'B; - pars.expect_mr_conf_ie := mr_conf; + pars.expect_mr_conf_ie := c_mr_conf_5_90; pars.use_osmux_cn := true; g_osmux_enabled_cn := true; 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icc5381eccb924803b1117b46d2b4c47cee6dabd7 Gerrit-Change-Number: 29345 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add params argument to ts_RSL_MultirateCfg
by fixeria 14 Sep '22

14 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29346 ) Change subject: library/RSL_Types: add params argument to ts_RSL_MultirateCfg ...................................................................... library/RSL_Types: add params argument to ts_RSL_MultirateCfg Change-Id: Ia85339a9c268abc84f9b4228f8d418f1dac786e6 --- M library/RSL_Types.ttcn 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 6681024..acf7d40 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -830,7 +830,8 @@ variant (len) "LENGTHTO(mr_speech_ver,nscb,icmi,spare,start_mode,codec_modes,parameters)" }; template (value) RSL_IE_MultirateCfg ts_RSL_MultirateCfg(boolean icmi := true, uint2_t start_mode := 0, - BIT8 codec_modes := '00000100'B /* 5,90k */) := { + BIT8 codec_modes := '00000100'B /* 5,90k */, + octetstring params := ''O) := { len := 2, mr_speech_ver := 1, nscb := false, @@ -838,7 +839,7 @@ spare := '0'B, start_mode := start_mode, codec_modes := codec_modes, - parameters := ''O + parameters := params } /* 9.3.53 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29346 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia85339a9c268abc84f9b4228f8d418f1dac786e6 Gerrit-Change-Number: 29346 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: use c_mr_conf_5_90 in TC_assignment_codec_amr_startmode_cruft
by fixeria 14 Sep '22

14 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29344 ) Change subject: BSC_Tests: use c_mr_conf_5_90 in TC_assignment_codec_amr_startmode_cruft ...................................................................... BSC_Tests: use c_mr_conf_5_90 in TC_assignment_codec_amr_startmode_cruft This way it's easier to see that the only difference from other tests using c_mr_conf_5_90 is the ICMI field set to false. Change-Id: If7b491fa55a9366520c2d665a700c5badb187fae --- M bsc/BSC_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 3ed901a..f6f8c9c 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -4610,8 +4610,8 @@ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F})); pars.ass_codec_list.codecElements[0].s0_7 := '00000100'B; /* 5,90k */ pars.ass_codec_list.codecElements[0].s8_15 := '01010111'B; - /* expect ICMI=0, smod=00: */ - pars.expect_mr_conf_ie := valueof(RSL_IE_Body:{multirate_cfg := ts_RSL_MultirateCfg(false, 0, '00000100'B /* 5,90k */)}); + pars.expect_mr_conf_ie := c_mr_conf_5_90; + pars.expect_mr_conf_ie.multirate_cfg.icmi := false; /* expect ICMI=0, smod=00: */ f_init(1, true); f_sleep(1.0); 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29344 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If7b491fa55a9366520c2d665a700c5badb187fae Gerrit-Change-Number: 29344 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: cosmetic: s/mr_conf_amr_5_90/c_mr_conf_5_90/
by fixeria 14 Sep '22

14 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29343 ) Change subject: BSC_Tests: cosmetic: s/mr_conf_amr_5_90/c_mr_conf_5_90/ ...................................................................... BSC_Tests: cosmetic: s/mr_conf_amr_5_90/c_mr_conf_5_90/ * This is a global constant, so prefix with 'c_' for consistency. * The RSL_IE_MultirateCfg is all about AMR, remove redundant 'amr'. Change-Id: I72405b7139fcfd0dbe90afc469ed4db71b43a87c --- M bsc/BSC_Tests.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 6418b4b..3ed901a 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -111,7 +111,7 @@ /* BTS3 */ { trx_num := 1, tsc := 4 } } -private const RSL_IE_Body mr_conf_amr_5_90 := +private const RSL_IE_Body c_mr_conf_5_90 := valueof(RSL_IE_Body:{multirate_cfg := ts_RSL_MultirateCfg(true, 0, '00000100'B /* 5,90k */)}); /* per-BTS state which we keep */ @@ -4530,7 +4530,7 @@ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F})); pars.ass_codec_list.codecElements[0].s0_7 := '00000100'B; /* 5,90k */ pars.ass_codec_list.codecElements[0].s8_15 := '01010111'B; - pars.expect_mr_conf_ie := mr_conf_amr_5_90; + pars.expect_mr_conf_ie := c_mr_conf_5_90; f_init(1, true); f_sleep(1.0); @@ -4558,7 +4558,7 @@ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H})); pars.ass_codec_list.codecElements[0].s0_7 := '00000100'B; /* 5,90k */ pars.ass_codec_list.codecElements[0].s8_15 := '00000111'B; - pars.expect_mr_conf_ie := mr_conf_amr_5_90; + pars.expect_mr_conf_ie := c_mr_conf_5_90; f_init(1, true); f_sleep(1.0); @@ -5285,7 +5285,7 @@ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H})); pars.ass_codec_list.codecElements[0].s0_7 := '00000100'B; /* 5,90k */ pars.ass_codec_list.codecElements[0].s8_15 := '00000111'B; - pars.expect_mr_conf_ie := mr_conf_amr_5_90; + pars.expect_mr_conf_ie := c_mr_conf_5_90; pars.use_osmux_bts := true; g_osmux_enabled_bts := true; @@ -5308,7 +5308,7 @@ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H})); pars.ass_codec_list.codecElements[0].s0_7 := '00000100'B; /* 5,90k */ pars.ass_codec_list.codecElements[0].s8_15 := '00000111'B; - pars.expect_mr_conf_ie := mr_conf_amr_5_90; + pars.expect_mr_conf_ie := c_mr_conf_5_90; pars.use_osmux_cn := true; pars.use_osmux_bts := true; 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I72405b7139fcfd0dbe90afc469ed4db71b43a87c Gerrit-Change-Number: 29343 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: library/RSL_Types: s/amr_codec_modes/codec_modes/ in RSL_IE_MultirateCfg
by fixeria 14 Sep '22

14 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29342 ) Change subject: library/RSL_Types: s/amr_codec_modes/codec_modes/ in RSL_IE_MultirateCfg ...................................................................... library/RSL_Types: s/amr_codec_modes/codec_modes/ in RSL_IE_MultirateCfg The RSL MultiRate configuration IE is all about AMR (Adaptive Multi Rate) codec, so there is no need for 'amr_' prefix in field names. Change-Id: If63ee50e8681ad4e0a202f142f2fca2268d55079 --- M bts/BTS_Tests.ttcn M library/RSL_Types.ttcn 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index fed45a9..c6ce115 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2540,7 +2540,7 @@ case (RSL_CMOD_SP_GSM1) { tch_mode := L1CTL_CHAN_MODE_SPEECH_V1; } case (RSL_CMOD_SP_GSM2) { tch_mode := L1CTL_CHAN_MODE_SPEECH_V2; } case (RSL_CMOD_SP_GSM3) { tch_mode := L1CTL_CHAN_MODE_SPEECH_V3; - amr_codecs_bitmask := g_pars.mr_conf.amr_codec_modes; + amr_codecs_bitmask := g_pars.mr_conf.codec_modes; } case else { log("RSL channel mode := ", g_pars.chan_mode.coding_alg_rate, @@ -2568,7 +2568,7 @@ var integer n := 0; for (var integer i:= 7; i >= 0; i := i - 1) { - if (g_pars.mr_conf.amr_codec_modes[i] == '1'B) { + if (g_pars.mr_conf.codec_modes[i] == '1'B) { if (n == start_nth) { return 7 - i; } diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index a86be86..6681024 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -824,20 +824,20 @@ boolean icmi, BIT1 spare, uint2_t start_mode, - BIT8 amr_codec_modes, + BIT8 codec_modes, octetstring parameters } with { - variant (len) "LENGTHTO(mr_speech_ver,nscb,icmi,spare,start_mode,amr_codec_modes,parameters)" + variant (len) "LENGTHTO(mr_speech_ver,nscb,icmi,spare,start_mode,codec_modes,parameters)" }; template (value) RSL_IE_MultirateCfg ts_RSL_MultirateCfg(boolean icmi := true, uint2_t start_mode := 0, - BIT8 amr_codec_modes := '00000100'B /* 5,90k */) := { + BIT8 codec_modes := '00000100'B /* 5,90k */) := { len := 2, mr_speech_ver := 1, nscb := false, icmi := icmi, spare := '0'B, start_mode := start_mode, - amr_codec_modes := amr_codec_modes, + codec_modes := codec_modes, parameters := ''O } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If63ee50e8681ad4e0a202f142f2fca2268d55079 Gerrit-Change-Number: 29342 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: fixup: bsc: Add testscase & infra to validate Osmux support BTS<->BSC
by fixeria 14 Sep '22

14 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29340 ) Change subject: fixup: bsc: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... fixup: bsc: Add testscase & infra to validate Osmux support BTS<->BSC The per-BTS VTY command 'osmux (on|off|only)' was added to osmo-bsc.git recently, and is not available in -latest yet. Use it conditionally. Change-Id: Id501d3f4b5eb18b096d8baffcb5f38e583f7a3d8 Fixes: I6e82eb9d995de988b812001e1c4cf6923509de66 --- M bsc/BSC_Tests.ttcn 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index d4a7b20..6418b4b 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1273,13 +1273,15 @@ f_wait_oml(bts_idx, "connected", 5.0); /* Set up BTS with VTY commands: */ - f_vty_enter_cfg_bts(BSCVTY, bts_idx); - if (g_osmux_enabled_bts) { - f_vty_transceive(BSCVTY, "osmux on"); - } else { - f_vty_transceive(BSCVTY, "osmux off"); + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + f_vty_enter_cfg_bts(BSCVTY, bts_idx); + if (g_osmux_enabled_bts) { + f_vty_transceive(BSCVTY, "osmux on"); + } else { + f_vty_transceive(BSCVTY, "osmux off"); + } + f_vty_transceive(BSCVTY, "end"); } - f_vty_transceive(BSCVTY, "end"); } function f_init_bts_and_check_sysinfo(integer bts_idx := 0, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id501d3f4b5eb18b096d8baffcb5f38e583f7a3d8 Gerrit-Change-Number: 29340 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests[_VAMOS]: use default param values for ts_RSL_MultirateCfg
by fixeria 14 Sep '22

14 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29341 ) Change subject: BTS_Tests[_VAMOS]: use default param values for ts_RSL_MultirateCfg ...................................................................... BTS_Tests[_VAMOS]: use default param values for ts_RSL_MultirateCfg There is no real need to pass the multi-rate parameters explicitly in each invocation of ts_RSL_MultirateCfg. The exact multi-rate configuration does not matter in scope of BTS specific tests. Change-Id: I24117af8c5b7b11fe4b8f24fca5279ad97b46fab --- M bts/BTS_Tests.ttcn M bts/BTS_Tests_VAMOS.ttcn 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index e71aed9..fed45a9 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -8264,7 +8264,7 @@ /* TS1, TCH/F, V3 (AMR codec) */ pars := valueof(t_Pars(ts_RslChanNr_Bm(1), ts_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_SP_GSM3))); - pars.mr_conf := valueof(ts_RSL_MultirateCfg(false, 0, '00000100'B /* 5,90k */)); + pars.mr_conf := valueof(ts_RSL_MultirateCfg); vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); vc_conn.done; @@ -8283,7 +8283,7 @@ /* TS1, TCH/H0, V3 (AMR codec) */ pars := valueof(t_Pars(ts_RslChanNr_Lm(5, 0), ts_RSL_ChanMode(RSL_CHRT_TCH_H, RSL_CMOD_SP_GSM3))); - pars.mr_conf := valueof(ts_RSL_MultirateCfg(false, 0, '00000100'B /* 5,90k */)); + pars.mr_conf := valueof(ts_RSL_MultirateCfg); vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); vc_conn.done; @@ -8383,7 +8383,7 @@ /* TS5, TCH/H0, V3 (AMR codec) */ pars := valueof(t_Pars(ts_RslChanNr_Bm(1), ts_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_SP_GSM3))); - pars.mr_conf := valueof(ts_RSL_MultirateCfg(false, 0, '00000100'B /* 5,90k */)); + pars.mr_conf := valueof(ts_RSL_MultirateCfg); vc_conn := f_start_handler(refers(f_TC_speech_osmux), pars); vc_conn.done; @@ -8397,7 +8397,7 @@ /* TS5, TCH/H0, V3 (AMR codec) */ pars := valueof(t_Pars(ts_RslChanNr_Lm(5, 0), ts_RSL_ChanMode(RSL_CHRT_TCH_H, RSL_CMOD_SP_GSM3))); - pars.mr_conf := valueof(ts_RSL_MultirateCfg(false, 0, '00000100'B /* 5,90k */)); + pars.mr_conf := valueof(ts_RSL_MultirateCfg); vc_conn := f_start_handler(refers(f_TC_speech_osmux), pars); vc_conn.done; diff --git a/bts/BTS_Tests_VAMOS.ttcn b/bts/BTS_Tests_VAMOS.ttcn index 637a256..2d03411 100644 --- a/bts/BTS_Tests_VAMOS.ttcn +++ b/bts/BTS_Tests_VAMOS.ttcn @@ -175,7 +175,7 @@ pars[ch] := valueof(t_Pars(test[i][ch].chan_nr, test[i][ch].chan_mode)); if (test[i][ch].chan_mode.coding_alg_rate == RSL_CMOD_SP_GSM3) { - pars[ch].mr_conf := valueof(ts_RSL_MultirateCfg(false, 0, '00000100'B /* 5,90k */)); + pars[ch].mr_conf := valueof(ts_RSL_MultirateCfg); } vc_conn[ch] := f_start_handler(handler, pars[ch], l1ctl := false); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I24117af8c5b7b11fe4b8f24fca5279ad97b46fab Gerrit-Change-Number: 29341 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: fixup: bsc: Add testscase & infra to validate Osmux support BTS<->BSC
by pespin 14 Sep '22

14 Sep '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29340 ) Change subject: fixup: bsc: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id501d3f4b5eb18b096d8baffcb5f38e583f7a3d8 Gerrit-Change-Number: 29340 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Sep 2022 09:57:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log