pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27063 )
Change subject: Add ttcn3-ggsn-ogs testsuite
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> BTW, I submitted a patch changing the installation paths: […]
I'm merging this one now, see my comment in your patch for a possible improvement.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27063
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ia6c122fce951d369a5d2362cbe99d10d61c15f49
Gerrit-Change-Number: 27063
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Feb 2022 08:47:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27076 )
Change subject: open5gs-master: ensure consistent install paths with '-latest'
......................................................................
Patch Set 1:
(1 comment)
File open5gs-master/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/27076/comment/256bebd1_bc0…
PS1, Line 53: --libdir=lib/x86_64-linux-gnu \
Given that we set it, I'd say better use a architecture/platform agnostic path (if present in /etc/ld.so.conf), so that the same image works in all platforms.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27076
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ib4dcf3a9f77205dcdd0ff4932763e202cb89001c
Gerrit-Change-Number: 27076
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Feb 2022 08:46:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/27075 )
Change subject: debian: add new 'libosmo-mslookup-utils' package
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File debian/control:
https://gerrit.osmocom.org/c/osmo-hlr/+/27075/comment/34574cba_7a31bd6e
PS2, Line 83: Package: libosmo-mslookup-utils
I'd rather call it osmo-mslookup-utils, since this is not really packaging a library, but a set of utils/tools (exectuables).
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/27075
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I9dbe00187678a5032fb4ae32b496892fdc86ddb7
Gerrit-Change-Number: 27075
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Feb 2022 08:43:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/27074 )
Change subject: fixup: debian: remove unneeded dependency libdbd-sqlite3
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Why do you say it's not needed? Can you argument that?
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/27074
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I3ece7c32151f6f334d0595fdbf9099c930b22bb9
Gerrit-Change-Number: 27074
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Feb 2022 08:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27063 )
Change subject: Add ttcn3-ggsn-ogs testsuite
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
BTW, I submitted a patch changing the installation paths:
https://gerrit.osmocom.org/c/docker-playground/+/27076
so that we can run test cases against both '-master' and '-latest'.
Would be good to have this patch rebased on top of it (requires changes to freediameter.conf). I can also just wait until this patch is merged, and then rebase my patch on top of yours.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27063
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ia6c122fce951d369a5d2362cbe99d10d61c15f49
Gerrit-Change-Number: 27063
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 06 Feb 2022 10:56:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment