Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28229 )
Change subject: use osmo_select_main_ctx(), tweak log in handle_cn_conn_conf()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28229
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I1e0ea0a883e8cf65e6cfb45ed9b6f3d8fb7c59eb
Gerrit-Change-Number: 28229
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Jun 2022 16:14:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 )
Change subject: add option to send SCCP CR without payload
......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/a7c7c2e8_3a6f3f86
PS1, Line 27: a separate SCCP CR without payload.
Not sure if it really makes sense to use any value != 0 here,so it probably makes more sense to have a VTY config option which actually defines whether a SCCP CR is decoupled from the RANAP message?
File include/osmocom/hnbgw/context_map.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/03f890cf_72f69335
PS1, Line 42: RUA_CN_DomainIndicator_t cached_domain_indicator;
isn't this the same as is_ps?
File src/osmo-hnbgw/context_map.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/0f559f07_86e7368f
PS1, Line 139: rc = rua_to_scu(map->hnb_ctx, map->cached_domain_indicator, OSMO_SCU_PRIM_N_DATA,
you can probably use map->is_ps here instead of adding map->cached_domain_indicator
File src/osmo-hnbgw/hnbgw.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/eb050eae_42e69692
PS1, Line 93: gw->config.max_sccp_cr_payload_len = 999999;
this really looks like a hack. Use -1 value and a "no sccp..." VTY command. Or rather simply change the VTY command to be a boolean.
File src/osmo-hnbgw/hnbgw_rua.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/45f577fb_681f7d16
PS1, Line 274: if (data && len && map && !map->is_ps && !release_context_map) {
This new check looks non related? why did you add it?
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/17cb745e_9e7573b2
PS1, Line 417: map->cached_domain_indicator = ies.cN_DomainIndicator;
as mentioned, this is not needed, the info is in "is_ps".
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328
Gerrit-Change-Number: 28230
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Jun 2022 16:13:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28229
to look at the new patch set (#2).
Change subject: use osmo_select_main_ctx(), tweak log in handle_cn_conn_conf()
......................................................................
use osmo_select_main_ctx(), tweak log in handle_cn_conn_conf()
Upcoming patch adds to this function. Let me first combine those four
LOGP() to a single one, use proper osmo_sccp_addr_to_str_c(OTC_SELECT).
To be able to use OTC_SELECT, switch hnbgw.c to osmo_select_main_ctx().
Related: SYS#5968
Change-Id: I1e0ea0a883e8cf65e6cfb45ed9b6f3d8fb7c59eb
---
M src/osmo-hnbgw/hnbgw.c
M src/osmo-hnbgw/hnbgw_cn.c
2 files changed, 9 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/29/28229/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28229
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I1e0ea0a883e8cf65e6cfb45ed9b6f3d8fb7c59eb
Gerrit-Change-Number: 28229
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28229 )
Change subject: use osmo_select_main_ctx(), tweak log in handle_cn_conn_conf()
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28229
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I1e0ea0a883e8cf65e6cfb45ed9b6f3d8fb7c59eb
Gerrit-Change-Number: 28229
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Jun 2022 16:06:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28229 )
Change subject: use osmo_select_main_ctx(), tweak log in handle_cn_conn_conf()
......................................................................
use osmo_select_main_ctx(), tweak log in handle_cn_conn_conf()
Upcoming patch adds to this function. Let me first combine those four
LOGP() to a single one, use proper osmo_sccp_addr_to_str_c(OTC_SELECT).
To be able to use OTC_SELECT, switch hnbgw.c to osmo_select_main_ctx().
Related: SYS#5968
Change-Id: I1e0ea0a883e8cf65e6cfb45ed9b6f3d8fb7c59eb
---
M src/osmo-hnbgw/hnbgw.c
M src/osmo-hnbgw/hnbgw_cn.c
2 files changed, 9 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/29/28229/1
diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c
index 833486c..96c7ad1 100644
--- a/src/osmo-hnbgw/hnbgw.c
+++ b/src/osmo-hnbgw/hnbgw.c
@@ -713,7 +713,7 @@
}
while (1) {
- rc = osmo_select_main(0);
+ rc = osmo_select_main_ctx(0);
if (rc < 0)
exit(3);
}
diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c
index 5ee5fd4..9c06497 100644
--- a/src/osmo-hnbgw/hnbgw_cn.c
+++ b/src/osmo-hnbgw/hnbgw_cn.c
@@ -329,18 +329,15 @@
const struct osmo_scu_connect_param *param,
struct osmo_prim_hdr *oph)
{
- /* we don't actually need to do anything, as RUA towards the HNB
- * doesn't seem to know any confirmations to its CONNECT
- * operation */
+ struct osmo_ss7_instance *ss7 = osmo_sccp_get_ss7(cnlink->gw->sccp.client);
+ LOGP(DMAIN, LOGL_DEBUG, "handle_cn_conn_conf() conn_id=%d, addrs: called=%s calling=%s responding=%s",
+ param->conn_id,
+ osmo_sccp_addr_to_str_c(OTC_SELECT, ss7, ¶m->called_addr),
+ osmo_sccp_addr_to_str_c(OTC_SELECT, ss7, ¶m->calling_addr),
+ osmo_sccp_addr_to_str_c(OTC_SELECT, ss7, ¶m->responding_addr));
- LOGP(DMAIN, LOGL_DEBUG, "handle_cn_conn_conf() conn_id=%d\n",
- param->conn_id);
- LOGP(DMAIN, LOGL_DEBUG, "handle_cn_conn_conf() called_addr=%s\n",
- inet_ntoa(param->called_addr.ip.v4));
- LOGP(DMAIN, LOGL_DEBUG, "handle_cn_conn_conf() calling_addr=%s\n",
- inet_ntoa(param->calling_addr.ip.v4));
- LOGP(DMAIN, LOGL_DEBUG, "handle_cn_conn_conf() responding_addr=%s\n",
- inet_ntoa(param->responding_addr.ip.v4));
+ /* Nothing needs to happen for RUA, RUA towards the HNB doesn't seem to know any confirmations to its CONNECT
+ * operation. */
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28229
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I1e0ea0a883e8cf65e6cfb45ed9b6f3d8fb7c59eb
Gerrit-Change-Number: 28229
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newchange