Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 ) Change subject: add option to send SCCP CR without payload ...................................................................... Patch Set 2: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/a7c7c2e8_3a6f3f86 PS1, Line 27: a separate SCCP CR without payload. Not sure if it really makes sense to use any value != 0 here,so it probably makes more sense to have a VTY config option which actually defines whether a SCCP CR is decoupled from the RANAP message? File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/03f890cf_72f69335 PS1, Line 42: RUA_CN_DomainIndicator_t cached_domain_indicator; isn't this the same as is_ps? File src/osmo-hnbgw/context_map.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/0f559f07_86e7368f PS1, Line 139: rc = rua_to_scu(map->hnb_ctx, map->cached_domain_indicator, OSMO_SCU_PRIM_N_DATA, you can probably use map->is_ps here instead of adding map->cached_domain_indicator File src/osmo-hnbgw/hnbgw.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/eb050eae_42e69692 PS1, Line 93: gw->config.max_sccp_cr_payload_len = 999999; this really looks like a hack. Use -1 value and a "no sccp..." VTY command. Or rather simply change the VTY command to be a boolean. File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/45f577fb_681f7d16 PS1, Line 274: if (data && len && map && !map->is_ps && !release_context_map) { This new check looks non related? why did you add it? https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/17cb745e_9e7573b2 PS1, Line 417: map->cached_domain_indicator = ies.cN_DomainIndicator; as mentioned, this is not needed, the info is in "is_ps". -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328 Gerrit-Change-Number: 28230 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jun 2022 16:13:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment