Attention is currently required from: neels.

View Change

6 comments:

• Commit Message:

  • Patch Set #1, Line 27: a separate SCCP CR without payload.

    Not sure if it really makes sense to use any value != 0 here,so it probably makes more sense to have a VTY config option which actually defines whether a SCCP CR is decoupled from the RANAP message?

• File include/osmocom/hnbgw/context_map.h:

  • Patch Set #1, Line 42: RUA_CN_DomainIndicator_t cached_domain_indicator;

    isn't this the same as is_ps?

• File src/osmo-hnbgw/context_map.c:

  • Patch Set #1, Line 139: rc = rua_to_scu(map->hnb_ctx, map->cached_domain_indicator, OSMO_SCU_PRIM_N_DATA,

    you can probably use map->is_ps here instead of adding map->cached_domain_indicator

• File src/osmo-hnbgw/hnbgw.c:

  • Patch Set #1, Line 93: gw->config.max_sccp_cr_payload_len = 999999;

    this really looks like a hack. Use -1 value and a "no sccp..." VTY command. Or rather simply change the VTY command to be a boolean.

• File src/osmo-hnbgw/hnbgw_rua.c:

  • Patch Set #1, Line 274: if (data && len && map && !map->is_ps && !release_context_map) {

    This new check looks non related? why did you add it?

  • Patch Set #1, Line 417: map->cached_domain_indicator = ies.cN_DomainIndicator;

    as mentioned, this is not needed, the info is in "is_ps".

To view, visit change 28230. To unsubscribe, or for help writing mail filters, visit settings.