- gerrit-log - lists.osmocom.org

Change in osmo-tetra[master]: Reformatting to prevent linter warnings
by fixeria 19 Sep '22

19 Sep '22

Attention is currently required from: wbokslag. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29407 ) Change subject: Reformatting to prevent linter warnings ...................................................................... Patch Set 1: (5 comments) File src/tetra_cmce_pdu.c: https://gerrit.osmocom.org/c/osmo-tetra/+/29407/comment/36a57e8b_43b572d4 PS1, Line 27: { TCMCE_PDU_T_D_ALERT, "D-ALERT" }, You're breaking alignment here. File src/tetra_mac_pdu.c: https://gerrit.osmocom.org/c/osmo-tetra/+/29407/comment/f4f5cdbb_d85e4253 PS1, Line 97: cad->type = bits_to_uint(cur, 2); cur += 2; You're breaking alignment here. https://gerrit.osmocom.org/c/osmo-tetra/+/29407/comment/3d98475d_1ff234fb PS1, Line 387: { ADDR_TYPE_NULL, "Null PDU" }, You're breaking alignment here. File src/tetra_mm_pdu.h: https://gerrit.osmocom.org/c/osmo-tetra/+/29407/comment/9aac566f_a4d41d17 PS1, Line 6: TMM_PDU_T_D_OTAR = 0x0, You're breaking alignment here. File src/tetra_mm_pdu.c: https://gerrit.osmocom.org/c/osmo-tetra/+/29407/comment/fcf59a5e_8b3f9e4c PS1, Line 27: { TMM_PDU_T_D_OTAR, "D-OTAR" }, You're breaking alignment here. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I0dc35e7d536900b4beed19042183838857b7dac7 Gerrit-Change-Number: 29407 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Sun, 18 Sep 2022 15:44:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-gprs[master]: tests: reorganize llc/rlcmac specific dirs and files
by fixeria 19 Sep '22

19 Sep '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29408 ) Change subject: tests: reorganize llc/rlcmac specific dirs and files ...................................................................... tests: reorganize llc/rlcmac specific dirs and files Change-Id: I8592cea020dbbf64940266cd6af14b14d34be3a6 --- M configure.ac M tests/Makefile.am R tests/llc/Makefile.am R tests/llc/pdu_codec_test.c R tests/llc/pdu_codec_test.err R tests/llc/pdu_codec_test.ok R tests/rlcmac/Makefile.am R tests/rlcmac/ts_44_018_test.c R tests/rlcmac/ts_44_018_test.err R tests/rlcmac/ts_44_018_test.ok R tests/rlcmac/ts_44_060_test.c R tests/rlcmac/ts_44_060_test.err R tests/rlcmac/ts_44_060_test.ok M tests/testsuite.at D tests/ts_44_060/Makefile.am 15 files changed, 24 insertions(+), 42 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/08/29408/1 diff --git a/configure.ac b/configure.ac index b9b2d81..84824fc 100644 --- a/configure.ac +++ b/configure.ac @@ -86,9 +86,8 @@ src/llc/Makefile src/rlcmac/Makefile tests/Makefile - tests/llc_pdu_codec/Makefile - tests/ts_44_018/Makefile - tests/ts_44_060/Makefile + tests/llc/Makefile + tests/rlcmac/Makefile Makefile contrib/libosmo-gprs.spec]) AC_OUTPUT diff --git a/tests/Makefile.am b/tests/Makefile.am index 15660c9..98ffe09 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,7 +1,6 @@ SUBDIRS = \ - llc_pdu_codec \ - ts_44_018 \ - ts_44_060 \ + llc \ + rlcmac \ $(NULL) # The `:;' works around a Bash 3.2 bug when the output is not writeable. diff --git a/tests/llc_pdu_codec/Makefile.am b/tests/llc/Makefile.am similarity index 100% rename from tests/llc_pdu_codec/Makefile.am rename to tests/llc/Makefile.am diff --git a/tests/llc_pdu_codec/pdu_codec_test.c b/tests/llc/pdu_codec_test.c similarity index 100% rename from tests/llc_pdu_codec/pdu_codec_test.c rename to tests/llc/pdu_codec_test.c diff --git a/tests/llc_pdu_codec/pdu_codec_test.err b/tests/llc/pdu_codec_test.err similarity index 100% rename from tests/llc_pdu_codec/pdu_codec_test.err rename to tests/llc/pdu_codec_test.err diff --git a/tests/llc_pdu_codec/pdu_codec_test.ok b/tests/llc/pdu_codec_test.ok similarity index 100% rename from tests/llc_pdu_codec/pdu_codec_test.ok rename to tests/llc/pdu_codec_test.ok diff --git a/tests/ts_44_018/Makefile.am b/tests/rlcmac/Makefile.am similarity index 67% rename from tests/ts_44_018/Makefile.am rename to tests/rlcmac/Makefile.am index 13c0afa..b840b1f 100644 --- a/tests/ts_44_018/Makefile.am +++ b/tests/rlcmac/Makefile.am @@ -10,16 +10,25 @@ check_PROGRAMS = \ ts_44_018_test \ + ts_44_060_test \ $(NULL) EXTRA_DIST = \ ts_44_018_test.ok \ ts_44_018_test.err \ + ts_44_060_test.ok \ + ts_44_060_test.err \ $(NULL) -ts_44_018_test_SOURCES = ts_44_018_test.c -ts_44_018_test_LDADD = \ +# Common LDADD entries +LDADD = \ $(LIBOSMOCORE_LIBS) \ $(top_builddir)/src/csn1/libosmo-csn1.la \ $(top_builddir)/src/rlcmac/libosmo-gprs-rlcmac.la \ $(NULL) + +ts_44_018_test_SOURCES = ts_44_018_test.c +ts_44_018_test_LDADD = $(LDADD) + +ts_44_060_test_SOURCES = ts_44_060_test.c +ts_44_060_test_LDADD = $(LDADD) diff --git a/tests/ts_44_018/ts_44_018_test.c b/tests/rlcmac/ts_44_018_test.c similarity index 100% rename from tests/ts_44_018/ts_44_018_test.c rename to tests/rlcmac/ts_44_018_test.c diff --git a/tests/ts_44_018/ts_44_018_test.err b/tests/rlcmac/ts_44_018_test.err similarity index 100% rename from tests/ts_44_018/ts_44_018_test.err rename to tests/rlcmac/ts_44_018_test.err diff --git a/tests/ts_44_018/ts_44_018_test.ok b/tests/rlcmac/ts_44_018_test.ok similarity index 100% rename from tests/ts_44_018/ts_44_018_test.ok rename to tests/rlcmac/ts_44_018_test.ok diff --git a/tests/ts_44_060/ts_44_060_test.c b/tests/rlcmac/ts_44_060_test.c similarity index 100% rename from tests/ts_44_060/ts_44_060_test.c rename to tests/rlcmac/ts_44_060_test.c diff --git a/tests/ts_44_060/ts_44_060_test.err b/tests/rlcmac/ts_44_060_test.err similarity index 100% rename from tests/ts_44_060/ts_44_060_test.err rename to tests/rlcmac/ts_44_060_test.err diff --git a/tests/ts_44_060/ts_44_060_test.ok b/tests/rlcmac/ts_44_060_test.ok similarity index 100% rename from tests/ts_44_060/ts_44_060_test.ok rename to tests/rlcmac/ts_44_060_test.ok diff --git a/tests/testsuite.at b/tests/testsuite.at index 703fd7a..de69bf4 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -3,21 +3,21 @@ AT_SETUP([llc/pdu_codec]) AT_KEYWORDS([llc pdu codec]) -cat $abs_srcdir/llc_pdu_codec/pdu_codec_test.ok > expout -cat $abs_srcdir/llc_pdu_codec/pdu_codec_test.err > experr -AT_CHECK([$abs_top_builddir/tests/llc_pdu_codec/pdu_codec_test], [0], [expout], [experr]) +cat $abs_srcdir/llc/pdu_codec_test.ok > expout +cat $abs_srcdir/llc/pdu_codec_test.err > experr +AT_CHECK([$abs_top_builddir/tests/llc/pdu_codec_test], [0], [expout], [experr]) AT_CLEANUP AT_SETUP([rlcmac/ts_44_018]) AT_KEYWORDS([rlcmac ts_44_018]) -cat $abs_srcdir/ts_44_018/ts_44_018_test.ok > expout -cat $abs_srcdir/ts_44_018/ts_44_018_test.err > experr -AT_CHECK([$abs_top_builddir/tests/ts_44_018/ts_44_018_test], [0], [expout], [experr]) +cat $abs_srcdir/rlcmac/ts_44_018_test.ok > expout +cat $abs_srcdir/rlcmac/ts_44_018_test.err > experr +AT_CHECK([$abs_top_builddir/tests/rlcmac/ts_44_018_test], [0], [expout], [experr]) AT_CLEANUP AT_SETUP([rlcmac/ts_44_060]) AT_KEYWORDS([rlcmac ts_44_060]) -cat $abs_srcdir/ts_44_060/ts_44_060_test.ok > expout -cat $abs_srcdir/ts_44_060/ts_44_060_test.err > experr -AT_CHECK([$abs_top_builddir/tests/ts_44_060/ts_44_060_test], [0], [expout], [experr]) +cat $abs_srcdir/rlcmac/ts_44_060_test.ok > expout +cat $abs_srcdir/rlcmac/ts_44_060_test.err > experr +AT_CHECK([$abs_top_builddir/tests/rlcmac/ts_44_060_test], [0], [expout], [experr]) AT_CLEANUP diff --git a/tests/ts_44_060/Makefile.am b/tests/ts_44_060/Makefile.am deleted file mode 100644 index fb953e3..0000000 --- a/tests/ts_44_060/Makefile.am +++ /dev/null @@ -1,25 +0,0 @@ -AM_CFLAGS = \ - -Wall \ - $(LIBOSMOCORE_CFLAGS) \ - -I$(top_srcdir)/include/ \ - $(NULL) - -AM_LDFLAGS = \ - -no-install \ - $(NULL) - -check_PROGRAMS = \ - ts_44_060_test \ - $(NULL) - -EXTRA_DIST = \ - ts_44_060_test.ok \ - ts_44_060_test.err \ - $(NULL) - -ts_44_060_test_SOURCES = ts_44_060_test.c -ts_44_060_test_LDADD = \ - $(LIBOSMOCORE_LIBS) \ - $(top_builddir)/src/csn1/libosmo-csn1.la \ - $(top_builddir)/src/rlcmac/libosmo-gprs-rlcmac.la \ - $(NULL) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8592cea020dbbf64940266cd6af14b14d34be3a6 Gerrit-Change-Number: 29408 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git
by fixeria 19 Sep '22

19 Sep '22

fixeria has removed Jenkins Builder from this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Removed reviewer Jenkins Builder with the following votes: * Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: deleteReviewer

1 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git
by fixeria 19 Sep '22

19 Sep '22

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Sep 2022 15:19:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git
by Jenkins Builder 19 Sep '22

19 Sep '22

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Patch Set 2: (3 comments) File include/osmocom/gprs/llc/llc.h: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-52): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/a49e0afa_7e0b76fe PS2, Line 135: #define OSMO_GPRS_LLC_PDU_F_ACK_REQ (1 << 2) /* 6.3.5.2 Acknowledgement request bit (A) */ 'Acknowledgement' may be misspelled - perhaps 'Acknowledgment'? File src/llc/llc_pdu.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-52): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/7a83904f_718eb53f PS2, Line 277: #define check_len(len, text) \ Macros with flow control statements should be avoided File tests/llc_pdu_codec/pdu_codec_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-52): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/732d7332_585aed2e PS2, Line 31: static const char *testData[] = { static const char * array should probably be static const char * const -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 18 Sep 2022 15:08:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-gprs[master]: llc: check-in basic LLC definitions from osmo-sgsn.git
by fixeria 19 Sep '22

19 Sep '22

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29393 to look at the new patch set (#2). Change subject: llc: check-in basic LLC definitions from osmo-sgsn.git ...................................................................... llc: check-in basic LLC definitions from osmo-sgsn.git osmo-sgsn.git fb6cf3221ef4989441c09a650011e4a334c37d12 Change-Id: I6ed0f4820b3a12a00be71ce63757765551743101 --- M include/osmocom/gprs/llc/Makefile.am A include/osmocom/gprs/llc/llc.h 2 files changed, 97 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/93/29393/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6ed0f4820b3a12a00be71ce63757765551743101 Gerrit-Change-Number: 29393 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-gprs[master]: llc: ensure all symbols have 'osmo_gprs_llc_' prefix
by fixeria 19 Sep '22

19 Sep '22

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29394 to look at the new patch set (#2). Change subject: llc: ensure all symbols have 'osmo_gprs_llc_' prefix ...................................................................... llc: ensure all symbols have 'osmo_gprs_llc_' prefix Change-Id: I569d8023d701bd14ee78baa9394b6983d9cafca8 --- M include/osmocom/gprs/llc/llc.h 1 file changed, 62 insertions(+), 62 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/94/29394/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I569d8023d701bd14ee78baa9394b6983d9cafca8 Gerrit-Change-Number: 29394 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git
by fixeria 19 Sep '22

19 Sep '22

fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... llc: implement LLC PDU codec based on code from osmo-sgsn.git osmo-sgsn.git fb6cf3221ef4989441c09a650011e4a334c37d12 Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d --- M configure.ac M include/osmocom/gprs/llc/llc.h M src/llc/llc_pdu.c M tests/Makefile.am A tests/llc_pdu_codec/Makefile.am A tests/llc_pdu_codec/pdu_codec_test.c A tests/llc_pdu_codec/pdu_codec_test.err A tests/llc_pdu_codec/pdu_codec_test.ok M tests/testsuite.at 9 files changed, 618 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/02/29402/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git
by fixeria 19 Sep '22

19 Sep '22

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Sep 2022 15:00:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git
by fixeria 19 Sep '22

19 Sep '22

fixeria has removed Jenkins Builder from this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Removed reviewer Jenkins Builder with the following votes: * Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: deleteReviewer

1 0

2026

2025

2024

2023

2022

gerrit-log