Change in osmo-iuh[master]: Make logging message about received RANAP message more meaningful
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/28208 ) Change subject: Make logging message about received RANAP message more meaningful ...................................................................... Make logging message about received RANAP message more meaningful The message being used previously seemed to indicate something was wrong with the message. The reality is that we are simply not handling most of them, and they will end up being forwarded as they come in osmo-hnbgw. Related: SYS#5573 Change-Id: If63d942496491f1e9ee454034ec97d25764fde65 --- M src/ranap_common_cn.c M src/ranap_common_ran.c 2 files changed, 39 insertions(+), 37 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/src/ranap_common_cn.c b/src/ranap_common_cn.c index e7b8339..3f6f284 100644 --- a/src/ranap_common_cn.c +++ b/src/ranap_common_cn.c @@ -74,8 +74,8 @@ rc = ranap_decode_iu_releasecommandies(&message->msg.iu_ReleaseCommandIEs, &imsg->value); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " - "Procedure %s (CO, IM) from RNC, ignoring\n", + LOGP(DRANAP, LOGL_INFO, + "Received RANAP Procedure %s (CO, IM) from RNC. Decode not implemented\n", get_value_string(ranap_procedure_code_vals, imsg->procedureCode)); rc = -1; break; @@ -118,8 +118,8 @@ ranap_free_iu_releasecommandies(&message->msg.iu_ReleaseCommandIEs); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Not freeing suspicious RANAP " - "Procedure %s (CO, IM) from RNC\n", + LOGP(DRANAP, LOGL_INFO, + "Freeing RANAP Procedure %s (CO, IM) from RNC not implemented\n", get_value_string(ranap_procedure_code_vals, message->procedureCode)); break; } @@ -150,8 +150,8 @@ rc = ranap_decode_iu_releasecompleteies(&message->msg.iu_ReleaseCompleteIEs, &imsg->value); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " - "Procedure %s (SO) from RNC, ignoring\n", + LOGP(DRANAP, LOGL_INFO, + "Received RANAP Procedure %s (SO) from RNC. Decode not implemented\n", get_value_string(ranap_procedure_code_vals, imsg->procedureCode)); rc = -1; break; @@ -176,8 +176,8 @@ ranap_free_iu_releasecompleteies(&message->msg.iu_ReleaseCompleteIEs); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Not freeing suspicious RANAP " - "Procedure %s (SO) from RNC\n", + LOGP(DRANAP, LOGL_INFO, + "Freeing RANAP Procedure %s (SO) from RNC not implemented\n", get_value_string(ranap_procedure_code_vals, message->procedureCode)); break; } @@ -200,8 +200,8 @@ rc = ranap_decode_rab_assignmentresponseies(&message->msg.raB_AssignmentResponseIEs, &imsg->value); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " - "Procedure %s (O) from RNC, ignoring\n", + LOGP(DRANAP, LOGL_INFO, + "Received RANAP Procedure %s (O) from RNC. Decode not implemented\n", get_value_string(ranap_procedure_code_vals, imsg->procedureCode)); rc = -1; break; @@ -218,8 +218,8 @@ ranap_free_rab_assignmentresponseies(&message->msg.raB_AssignmentResponseIEs); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Not freeing suspicious RANAP " - "Procedure %s (O) from RNC\n", + LOGP(DRANAP, LOGL_INFO, + "Freeing RANAP Procedure %s (O) from RNC not implemented\n", get_value_string(ranap_procedure_code_vals, message->procedureCode)); break; } @@ -247,8 +247,8 @@ rc = cn_ranap_rx_outcome_msg_co(ctx, &pdu->choice.outcome, message); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " - "presence %s (CO) from RNC, ignoring\n", + LOGP(DRANAP, LOGL_INFO, + "Received RANAP Procedure %s (CO) from RNC. Decode not implemented\n", get_value_string(ranap_presence_vals, pdu->present)); rc = -1; break; @@ -268,15 +268,15 @@ cn_ranap_free_successful_msg_co(message); break; case RANAP_RANAP_PDU_PR_unsuccessfulOutcome: - LOGP(DRANAP, LOGL_NOTICE, "Not freeing unsupported RANAP " - "unsuccessful outcome procedure (CO) from RNC\n"); + LOGP(DRANAP, LOGL_INFO, + "Freeing RANAP unsuccessful outcome procedure (CO) from RNC not implemented\n"); break; case RANAP_RANAP_PDU_PR_outcome: cn_ranap_free_outcome_msg_co(message); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " - "presence %s (CO) from RNC, ignoring\n", + LOGP(DRANAP, LOGL_INFO, + "Freeing RANAP Procedure %s (CO) from RNC not implemented\n", get_value_string(ranap_presence_vals, message->direction)); break; } @@ -365,8 +365,8 @@ rc = ranap_decode_pagingies(&message->msg.pagingIEs, &imsg->value); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " - "Procedure %s (CL, IM) from RNC, ignoring\n", + LOGP(DRANAP, LOGL_INFO, + "Received RANAP Procedure %s (CL, IM) from RNC. Decode not implemented\n", get_value_string(ranap_procedure_code_vals, imsg->procedureCode)); break; } @@ -405,8 +405,8 @@ ranap_free_pagingies(&message->msg.pagingIEs); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Not freeing suspicious RANAP " - "Procedure %s (CL, IM)\n", + LOGP(DRANAP, LOGL_INFO, + "Freeing RANAP Procedure %s (CL, IM) not implemented\n", get_value_string(ranap_procedure_code_vals, message->procedureCode)); break; } @@ -440,8 +440,8 @@ rc = ranap_decode_uplinkinformationexchangeresponseies(&message->msg.uplinkInformationExchangeResponseIEs, &imsg->value); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " - "Procedure %s (CL, SO) from RNC, ignoring\n", + LOGP(DRANAP, LOGL_INFO, + "Received RANAP Procedure %s (CL, SO) from RNC. Decode not implemented\n", get_value_string(ranap_procedure_code_vals, imsg->procedureCode)); break; } @@ -468,8 +468,8 @@ ranap_free_uplinkinformationexchangeresponseies(&message->msg.uplinkInformationExchangeResponseIEs); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Not freeing suspicious RANAP " - "Procedure %s (CL, SO)\n", + LOGP(DRANAP, LOGL_INFO, + "Freeing RANAP Procedure %s (CL, SO) from RNC not implemented\n", get_value_string(ranap_procedure_code_vals, message->procedureCode)); break; } @@ -497,8 +497,8 @@ pdu->choice.unsuccessfulOutcome.procedureCode)); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " - "presence %s (CL) from RNC, ignoring\n", + LOGP(DRANAP, LOGL_INFO, + "Received RANAP Procedure %s (CL) from RNC. Decode not implemented\n", get_value_string(ranap_presence_vals, pdu->present)); break; } @@ -517,8 +517,8 @@ cn_ranap_free_successful_msg_cl(message); break; case RANAP_RANAP_PDU_PR_unsuccessfulOutcome: - LOGP(DRANAP, LOGL_NOTICE, "Not freeing unsupported RANAP " - "unsuccessful outcome procedure from RNC\n"); + LOGP(DRANAP, LOGL_INFO, + "Freeing RANAP unsuccessful outcome procedure from RNC not implemented\n"); break; default: LOGP(DRANAP, LOGL_NOTICE, "Suspicious RANAP " diff --git a/src/ranap_common_ran.c b/src/ranap_common_ran.c index f3fa519..b238021 100644 --- a/src/ranap_common_ran.c +++ b/src/ranap_common_ran.c @@ -50,7 +50,8 @@ rc = ranap_decode_iu_releasecommandies(&message->msg.iu_ReleaseCommandIEs, &imsg->value); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP Procedure %s (CO, IM) from CN, ignoring\n", + LOGP(DRANAP, LOGL_INFO, + "Received RANAP Procedure %s (CO, IM) from CN. Decode not implemented\n", get_value_string(ranap_procedure_code_vals, imsg->procedureCode)); rc = -1; break; @@ -69,8 +70,8 @@ ranap_free_iu_releasecommandies(&message->msg.iu_ReleaseCommandIEs); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Not freeing suspicious RANAP " - "Procedure %s (CO, IM) from CN\n", + LOGP(DRANAP, LOGL_INFO, + "Freeing RANAP Procedure %s (CO, IM) from CN not implemented\n", get_value_string(ranap_procedure_code_vals, message->procedureCode)); break; } @@ -103,8 +104,9 @@ rc = -1; break; default: - LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " - "presence %s (CO) from CN, ignoring\n", get_value_string(ranap_presence_vals, pdu->present)); + LOGP(DRANAP, LOGL_INFO, + "Received RANAP Procedure %s (CO) from CN. Decode not implemented\n", + get_value_string(ranap_presence_vals, pdu->present)); rc = -1; break; } @@ -132,8 +134,8 @@ "outcome procedure (CO) from CN\n"); break; default: - LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " - "presence %s (CO) from CN, ignoring\n", + LOGP(DRANAP, LOGL_INFO, + "Freeing RANAP Procedure %s (CO) from CN not implemented\n", get_value_string(ranap_presence_vals, message->direction)); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/28208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: If63d942496491f1e9ee454034ec97d25764fde65 Gerrit-Change-Number: 28208 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged
participants (1)
-
pespin