- gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: mobile app: Indicate ER-GSM band support in MS classmark 3
by laforge 25 Nov '25

25 Nov '25

Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email ) Change subject: mobile app: Indicate ER-GSM band support in MS classmark 3 ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 24 Nov 2025 23:20:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: sigtran: Fix potential null ptr derreference
by laforge 25 Nov '25

25 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41495?usp=email ) Change subject: sigtran: Fix potential null ptr derreference ...................................................................... sigtran: Fix potential null ptr derreference Related: Coverity CID#551476 Change-Id: Iab7c237dd0ab5d6e916ee0a680559cdf838c509f --- M src/osmo-bsc/osmo_bsc_sigtran.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, approved diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index db8b6f3..1fe7739 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -888,12 +888,12 @@ msc->a.mtp_user = osmo_ss7_user_find_by_si(s7i, MTP_SI_NI11_OSMO_IPA); if (!msc->a.mtp_user) { msc->a.mtp_user = osmo_ss7_user_create(s7i, "MGCP/CTRL-IPA"); + if (!msc->a.mtp_user) + return -EINVAL; osmo_ss7_user_set_prim_cb(msc->a.mtp_user, mtp_sap_up); osmo_ss7_user_set_priv(msc->a.mtp_user, s7i); osmo_ss7_user_register(msc->a.mtp_user, MTP_SI_NI11_OSMO_IPA); } - if (!msc->a.mtp_user) - return -EINVAL; } /* Start MSC-Reset procedure */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41495?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab7c237dd0ab5d6e916ee0a680559cdf838c509f Gerrit-Change-Number: 41495 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: sigtran: Fix potential null ptr derreference
by laforge 25 Nov '25

25 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41495?usp=email ) Change subject: sigtran: Fix potential null ptr derreference ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41495?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab7c237dd0ab5d6e916ee0a680559cdf838c509f Gerrit-Change-Number: 41495 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Nov 2025 23:19:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-pfcp[master]: Introduce API osmo_pfcp_cp_peer_free()
by laforge 25 Nov '25

25 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/41484?usp=email ) Change subject: Introduce API osmo_pfcp_cp_peer_free() ...................................................................... Introduce API osmo_pfcp_cp_peer_free() Change-Id: I31498c407a8fffd8b47cce8c6bf89dc6e3fcefd2 --- M TODO-RELEASE M include/osmocom/pfcp/pfcp_cp_peer.h M src/libosmo-pfcp/pfcp_cp_peer.c 3 files changed, 9 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 203a2fd..6bcdfb2 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmo-pfcp add osmo_pfcp_ie_node_id_cmp() +libosmo-pfcp add osmo_pfcp_cp_peer_free() diff --git a/include/osmocom/pfcp/pfcp_cp_peer.h b/include/osmocom/pfcp/pfcp_cp_peer.h index 739526e..ac73bc4 100644 --- a/include/osmocom/pfcp/pfcp_cp_peer.h +++ b/include/osmocom/pfcp/pfcp_cp_peer.h @@ -39,6 +39,7 @@ struct osmo_pfcp_cp_peer *osmo_pfcp_cp_peer_alloc(void *ctx, struct osmo_pfcp_endpoint *ep, const struct osmo_sockaddr *remote_addr); +void osmo_pfcp_cp_peer_free(struct osmo_pfcp_cp_peer *cp_peer); int osmo_pfcp_cp_peer_associate(struct osmo_pfcp_cp_peer *cp_peer); bool osmo_pfcp_cp_peer_is_associated(const struct osmo_pfcp_cp_peer *cp_peer); int osmo_pfcp_cp_peer_set_associated_cb(struct osmo_pfcp_cp_peer *cp_peer, osmo_pfcp_cp_peer_assoc_cb assoc_cb); diff --git a/src/libosmo-pfcp/pfcp_cp_peer.c b/src/libosmo-pfcp/pfcp_cp_peer.c index c88c6d1..403a474 100644 --- a/src/libosmo-pfcp/pfcp_cp_peer.c +++ b/src/libosmo-pfcp/pfcp_cp_peer.c @@ -120,6 +120,13 @@ return cp_peer; } +void osmo_pfcp_cp_peer_free(struct osmo_pfcp_cp_peer *cp_peer) +{ + if (!cp_peer) + return; + osmo_fsm_inst_term(cp_peer->fi, OSMO_FSM_TERM_REGULAR, NULL); +} + int osmo_pfcp_cp_peer_associate(struct osmo_pfcp_cp_peer *cp_peer) { struct osmo_fsm_inst *fi = cp_peer->fi; -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/41484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I31498c407a8fffd8b47cce8c6bf89dc6e3fcefd2 Gerrit-Change-Number: 41484 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-hnbgw[master]: Split UPF into its own object
by laforge 25 Nov '25

25 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email ) Change subject: Split UPF into its own object ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I624bafe2fa150f7480b6fb44433c34e83154e06c Gerrit-Change-Number: 41483 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Nov 2025 23:19:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format
by laforge 25 Nov '25

25 Nov '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41478?usp=email ) Change subject: trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format ...................................................................... trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format There exist 3 TRAU frame types (distinguished by sync pattern) for AMR on 8 kbit/s subslots: Low, 6k7 and 7k4. osmo_trau_frame_encode() and osmo_trau_frame_decode_8k() APIs support all 3 TRAU-AMR-8k frame types since the original 2020 implementation - however, encoding and decoding of 6k7 format was incorrect. Fix it. Correctness of the new implementation is verified by unit tests added with the next patch in this series. Change-Id: Ibb98b0c189ced5248dca217384ca34b6a5f8b210 --- M src/trau/trau_frame.c 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 896bc20..d8541c5 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1045,15 +1045,15 @@ /* D8 .. D11 */ memcpy(fr->d_bits + d_idx, trau_bits + 2 * 8 + 4, 4); d_idx += 4; - /* D12 .. D39 */ - for (i = 3; i < 7; i++) { + /* D12 .. D32 */ + for (i = 3; i < 6; i++) { int offset = i * 8; - memcpy(fr->d_bits + d_idx, trau_bits + offset + 2, 7); + memcpy(fr->d_bits + d_idx, trau_bits + offset + 1, 7); d_idx += 7; } - /* D40 .. D137 */ - for (i = 7; i < 20; i+= 2) { + /* D33 .. D137 */ + for (i = 6; i < 20; i += 2) { int offset = i * 8; memcpy(fr->d_bits + d_idx, trau_bits + offset + 1, 15); d_idx += 15; @@ -1074,7 +1074,7 @@ trau_bits[3 * 8] = 1; trau_bits[4 * 8] = 1; trau_bits[5 * 8] = 0; - for (i = 5; i < 20; i += 2) + for (i = 6; i < 20; i += 2) trau_bits[i * 8] = 1; /* D1 .. D7 */ @@ -1085,15 +1085,15 @@ /* D8 .. D11 */ memcpy(trau_bits + 2 * 8 + 4, fr->d_bits + d_idx, 4); d_idx += 4; - /* D12 .. D39 */ - for (i = 3; i < 7; i++) { + /* D12 .. D32 */ + for (i = 3; i < 6; i++) { int offset = i * 8; - memcpy(trau_bits + offset + 2, fr->d_bits + d_idx, 7); + memcpy(trau_bits + offset + 1, fr->d_bits + d_idx, 7); d_idx += 7; } - /* D40 .. D137 */ - for (i = 7; i < 20; i+= 2) { + /* D33 .. D137 */ + for (i = 6; i < 20; i += 2) { int offset = i * 8; memcpy(trau_bits + offset + 1, fr->d_bits + d_idx, 15); d_idx += 15; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ibb98b0c189ced5248dca217384ca34b6a5f8b210 Gerrit-Change-Number: 41478 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-abis[master]: trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format
by laforge 25 Nov '25

25 Nov '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41478?usp=email ) Change subject: trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ibb98b0c189ced5248dca217384ca34b6a5f8b210 Gerrit-Change-Number: 41478 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 24 Nov 2025 23:17:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-pfcp[master]: Introduce API osmo_pfcp_cp_peer_free()
by laforge 25 Nov '25

25 Nov '25

Attention is currently required from: fixeria, neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/41484?usp=email ) Change subject: Introduce API osmo_pfcp_cp_peer_free() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/41484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I31498c407a8fffd8b47cce8c6bf89dc6e3fcefd2 Gerrit-Change-Number: 41484 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Nov 2025 23:17:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: handle E-RAB SETUP Rsp during release
by laforge 25 Nov '25

25 Nov '25

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41493?usp=email ) Change subject: erab_fsm: handle E-RAB SETUP Rsp during release ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I17414aad42507b64e933c80a220bfbe3798a4ad0 Gerrit-Change-Number: 41493 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Nov 2025 23:17:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy_test: add TCs simulating late E-RAB SETUP Rsp
by laforge 25 Nov '25

25 Nov '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41492?usp=email ) Change subject: s1ap_proxy_test: add TCs simulating late E-RAB SETUP Rsp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I60882c728ff06fb71cc458e807a49ca8ba5adcff Gerrit-Change-Number: 41492 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Nov 2025 23:17:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log