- gerrit-log - lists.osmocom.org

Change in osmo-cbc[master]: Add unit tests for sbcap
by pespin 14 Jul '22

14 Jul '22

pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28601 ) Change subject: Add unit tests for sbcap ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d Gerrit-Change-Number: 28601 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 0

Change in osmo-cbc[master]: Add unit tests for sbcap
by pespin 14 Jul '22

14 Jul '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28601 ) Change subject: Add unit tests for sbcap ...................................................................... Patch Set 3: Verified+1 (1 comment) Patchset: PS3: I'm not sure I'm able to fix the 2 remaining linter warnings. It's probably due to having to use some tricks due to how asn1c defines those types only inline. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d Gerrit-Change-Number: 28601 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 16:18:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-cbc[master]: Add unit tests for sbcap
by pespin 14 Jul '22

14 Jul '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601 to look at the new patch set (#3). Change subject: Add unit tests for sbcap ...................................................................... Add unit tests for sbcap This commit adds some minimum unit tests to validate encoding and decoding of SBc-AP ASN.1 APER format is working properly. Related: OS#4945 Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d --- M configure.ac M tests/Makefile.am A tests/sbcap/Makefile.am A tests/sbcap/sbcap_test.c A tests/sbcap/sbcap_test.ok A tests/testsuite.at 6 files changed, 346 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/01/28601/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d Gerrit-Change-Number: 28601 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-cbc[master]: Add unit tests for sbcap
by pespin 14 Jul '22

14 Jul '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601 to look at the new patch set (#2). Change subject: Add unit tests for sbcap ...................................................................... Add unit tests for sbcap This commit adds some minimum unit tests to validate encoding and decoding of SBc-AP ASN.1 APER format is working properly. Related: OS#4945 Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d --- M configure.ac M tests/Makefile.am A tests/sbcap/Makefile.am A tests/sbcap/sbcap_test.c A tests/sbcap/sbcap_test.ok A tests/testsuite.at 6 files changed, 346 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/01/28601/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I5a26d008b7282da637c3781ae77435c6a69cf65d Gerrit-Change-Number: 28601 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-cbc[master]: Add sbcap library
by pespin 14 Jul '22

14 Jul '22

pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28600 ) Change subject: Add sbcap library ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: If76f8619a9b2d46af6d94b8ae49348b8514e53aa Gerrit-Change-Number: 28600 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 0

Change in osmo-cbc[master]: Add sbcap library
by pespin 14 Jul '22

14 Jul '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28600 ) Change subject: Add sbcap library ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: If76f8619a9b2d46af6d94b8ae49348b8514e53aa Gerrit-Change-Number: 28600 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 14:41:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...osmo_dia2gsup[master]: debian: add packaging
by pespin 14 Jul '22

14 Jul '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28605 ) Change subject: debian: add packaging ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ic55bca1260f992d0ed8583e7c7fe948ba0160d4d Gerrit-Change-Number: 28605 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 14:40:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: lint: ignore *.asn, *.cc
by pespin 14 Jul '22

14 Jul '22

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28606 ) Change subject: lint: ignore *.asn, *.cc ...................................................................... Patch Set 1: (1 comment) File lint/checkpatch/checkpatch_osmo.sh: https://gerrit.osmocom.org/c/osmo-ci/+/28606/comment/388fc96a_183667b9 PS1, Line 8: asn|cc > I don't think this is the right approach. We may have hand-written *.asn and *. […] I definetly wouldn't blacklist all .cc by default. I don't care that much for asn files. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3c00bde31f11d40719f014fa1eb3162930984c56 Gerrit-Change-Number: 28606 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 14:38:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: lint: ignore *.asn, *.cc
by fixeria 14 Jul '22

14 Jul '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28606 ) Change subject: lint: ignore *.asn, *.cc ...................................................................... Patch Set 1: (1 comment) File lint/checkpatch/checkpatch_osmo.sh: https://gerrit.osmocom.org/c/osmo-ci/+/28606/comment/73aab762_b81be883 PS1, Line 8: asn|cc I don't think this is the right approach. We may have hand-written *.asn and *.cc files in some projects and they'll be ignored by the linter. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3c00bde31f11d40719f014fa1eb3162930984c56 Gerrit-Change-Number: 28606 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jul 2022 14:36:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: lint: ignore *.asn, *.cc
by osmith 14 Jul '22

14 Jul '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28606 ) Change subject: lint: ignore *.asn, *.cc ...................................................................... lint: ignore *.asn, *.cc Related: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28603 Change-Id: I3c00bde31f11d40719f014fa1eb3162930984c56 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/06/28606/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index b0c3985..27369e9 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -4,8 +4,8 @@ PROJECT="$(basename "$PROJECT_DIR")" exclude_paths_common() { - # Test output - echo '--exclude \.(ok|err|ctrl|vty)$' + # Test output, generated files + echo '--exclude \.(asn|cc|ok|err|ctrl|vty)$' # Generated from commit log, which may contain spelling errors (OS#5232) echo '--exclude ^debian/changelog$' # Patch files -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3c00bde31f11d40719f014fa1eb3162930984c56 Gerrit-Change-Number: 28606 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2025

2024

2023

2022

gerrit-log