- gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: obs: run_in_docker_and_exit: --rm on extra line
by fixeria 05 Oct '22

05 Oct '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29596 ) Change subject: obs: run_in_docker_and_exit: --rm on extra line ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie7dea2734e7c47766dfe64b7091bc4f5f72d53a5 Gerrit-Change-Number: 29596 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 17:30:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: jobs/osmocom-obs: add job for master feed
by fixeria 05 Oct '22

05 Oct '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29595 ) Change subject: jobs/osmocom-obs: add job for master feed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I53a494f13f81ae837f2d362c54e1bdf13f121db3 Gerrit-Change-Number: 29595 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 17:29:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: obs: update_obs_project: add master feed
by fixeria 05 Oct '22

05 Oct '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29594 ) Change subject: obs: update_obs_project: add master feed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3b0b4f4876b8c1eeb61f20d903a6f2cac6e99638 Gerrit-Change-Number: 29594 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 17:27:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: ctrl: Introduce hopping-arfcn-{add,del} commands
by fixeria 05 Oct '22

05 Oct '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29632 ) Change subject: ctrl: Introduce hopping-arfcn-{add,del} commands ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib886cff70dd8940aa2f4095b84f9e60056c9588e Gerrit-Change-Number: 29632 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 16:56:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: Rearrange ctrl interface code
by fixeria 05 Oct '22

05 Oct '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29631 ) Change subject: Rearrange ctrl interface code ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I51a9b31780a4a8026aafb2d732369cdc10c8bb70 Gerrit-Change-Number: 29631 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 16:52:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: cosmetic: Fix typo in comment
by fixeria 05 Oct '22

05 Oct '22

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29630 ) Change subject: cosmetic: Fix typo in comment ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/29630/comment/b3b8dbdb_2cd859dc PS1, Line 7: comsetic > let's fight typos in comments with typos in commit log messages! 😊 Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I935ab303d2234656f8de0dbdb2de9f4254b02dce Gerrit-Change-Number: 29630 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 16:46:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: Rearrange ctrl interface code
by pespin 05 Oct '22

05 Oct '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/29631 to look at the new patch set (#3). Change subject: Rearrange ctrl interface code ...................................................................... Rearrange ctrl interface code Current organization is totally mess, there's actually no organization at all for lots of commands. Let's organize most commands based on CTRL node where they are applied: global, bts, trx, etc. Specific set of commands such as neighbor-related, rf-related, etc. are left in separate files as subsections inside the same node, so the hierarchy is still clear. Change-Id: I51a9b31780a4a8026aafb2d732369cdc10c8bb70 --- M include/osmocom/bsc/ctrl.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/Makefile.am A src/osmo-bsc/bsc_ctrl.c D src/osmo-bsc/bsc_ctrl_commands.c A src/osmo-bsc/bts_ctrl.c A src/osmo-bsc/bts_trx_ctrl.c D src/osmo-bsc/osmo_bsc_ctrl.c 8 files changed, 1,642 insertions(+), 1,595 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/31/29631/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I51a9b31780a4a8026aafb2d732369cdc10c8bb70 Gerrit-Change-Number: 29631 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-bsc[master]: Rearrange ctrl interface code
by Jenkins Builder 05 Oct '22

05 Oct '22

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29631 ) Change subject: Rearrange ctrl interface code ...................................................................... Patch Set 2: (11 comments) File src/osmo-bsc/bsc_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/062aebd4_894b7399 PS2, Line 371: struct gsm_network *net = (struct gsm_network*)cmd->node; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/19c6d907_731fc604 PS2, Line 392: struct gsm_network *net = (struct gsm_network*)cmd->node; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/a0620cca_35c39048 PS2, Line 670: * transferred, to permit caller to send the same CMD to several ASPs. please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/f2adc081_8344f3ff PS2, Line 671: * Caller must hence free 'cmd' itself. please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/d55a62ee_d3d29606 PS2, Line 857: } adding a line without newline at end of file File src/osmo-bsc/bts_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/01467bc9_6d668bb4 PS2, Line 70: LOGP(DCTRL, LOGL_DEBUG, "Found %i positions.\n", i); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/f0976b45_fe4d9745 PS2, Line 87: cmd->variable = talloc_asprintf(cmd, "bts.%i.location-state", bts->nr); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/85e212d1_5d83b14c PS2, Line 129: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/59a4b488_1cc89628 PS2, Line 649: rc =bsc_bts_trx_ctrl_cmds_install(); spaces required around that '=' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/ed04cd1f_f044428a PS2, Line 652: } adding a line without newline at end of file File src/osmo-bsc/bts_trx_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/04ba9752_bb2ed976 PS2, Line 119: } adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I51a9b31780a4a8026aafb2d732369cdc10c8bb70 Gerrit-Change-Number: 29631 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 14:36:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: cosmetic: Fix typo in comment
by pespin 05 Oct '22

05 Oct '22

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/29630 to look at the new patch set (#3). Change subject: cosmetic: Fix typo in comment ...................................................................... cosmetic: Fix typo in comment Change-Id: I935ab303d2234656f8de0dbdb2de9f4254b02dce --- M src/osmo-bsc/bsc_ctrl_commands.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/30/29630/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I935ab303d2234656f8de0dbdb2de9f4254b02dce Gerrit-Change-Number: 29630 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-bsc[master]: Rearrange ctrl interface code
by pespin 05 Oct '22

05 Oct '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/29631 to look at the new patch set (#2). Change subject: Rearrange ctrl interface code ...................................................................... Rearrange ctrl interface code Current organization is totally mess, there's actually no organization at all for lots of commands. Let's organize most commands based on CTRL node where they are applied: global, bts, trx, etc. Specific set of commands such as neighbor-related, rf-related, etc. are left in separate files as subsections inside the same node, so the hierarchy is still clear. Change-Id: I51a9b31780a4a8026aafb2d732369cdc10c8bb70 --- M include/osmocom/bsc/ctrl.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/Makefile.am A src/osmo-bsc/bsc_ctrl.c D src/osmo-bsc/bsc_ctrl_commands.c A src/osmo-bsc/bts_ctrl.c A src/osmo-bsc/bts_trx_ctrl.c D src/osmo-bsc/osmo_bsc_ctrl.c 8 files changed, 1,642 insertions(+), 1,595 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/31/29631/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I51a9b31780a4a8026aafb2d732369cdc10c8bb70 Gerrit-Change-Number: 29631 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log