- gerrit-log - lists.osmocom.org

Change in osmo-mgw[master]: osmux: Add claudators around IPv6 address to distinguish port in log ...
by pespin 06 Oct '22

06 Oct '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29640 ) Change subject: osmux: Add claudators around IPv6 address to distinguish port in log line ...................................................................... osmux: Add claudators around IPv6 address to distinguish port in log line Change-Id: I811ac5b4386f06c224f29f44f10dce4008fa7a4f --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/40/29640/1 diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 3be6d78..302fd4d 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -473,7 +473,7 @@ ret = mgcp_create_bind(cfg->osmux_addr_v6, &osmux_fd_v6, cfg->osmux_port, cfg->endp_dscp, cfg->endp_priority); if (ret < 0) { - LOGP(DOSMUX, LOGL_ERROR, "Cannot bind OSMUX IPv6 socket to %s:%u\n", + LOGP(DOSMUX, LOGL_ERROR, "Cannot bind OSMUX IPv6 socket to [%s]:%u\n", cfg->osmux_addr_v6, cfg->osmux_port); return ret; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I811ac5b4386f06c224f29f44f10dce4008fa7a4f Gerrit-Change-Number: 29640 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-mgw[master]: osmux: Change couple log lines to OSMUX category
by pespin 06 Oct '22

06 Oct '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29639 ) Change subject: osmux: Change couple log lines to OSMUX category ...................................................................... osmux: Change couple log lines to OSMUX category Change-Id: Ia04d08099f0b1e81707699d872779108f22522bf --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/39/29639/1 diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 46e1d6b..adfc448 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -741,10 +741,10 @@ { if (!endp->trunk->cfg->osmux_initialized) { if (osmux_init(OSMUX_ROLE_BSC, endp->trunk) < 0) { - LOGPENDP(endp, DLMGCP, LOGL_ERROR, "Cannot init OSMUX\n"); + LOGPENDP(endp, DOSMUX, LOGL_ERROR, "Cannot init OSMUX\n"); return -3; } - LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "OSMUX socket has been set up\n"); + LOGPENDP(endp, DOSMUX, LOGL_NOTICE, "OSMUX socket has been set up\n"); } return mgcp_parse_osmux_cid(line); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia04d08099f0b1e81707699d872779108f22522bf Gerrit-Change-Number: 29639 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ttcn3-hacks[master]: bts: Log unexpected RSL message
by pespin 06 Oct '22

06 Oct '22

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 ) Change subject: bts: Log unexpected RSL message ...................................................................... Patch Set 2: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582/comment/6f02d399_2853… PS2, Line 786: RSL PDU > But saying RSL PDU here? I thought you meant PDU as a generic thing so I put it here. I don't think it's really clarifying anything, in the end you end up looking at the code, the important part is printing the RSL message when available... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4 Gerrit-Change-Number: 29582 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Oct 2022 08:26:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: bts: Log unexpected RSL message
by fixeria 06 Oct '22

06 Oct '22

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 ) Change subject: bts: Log unexpected RSL message ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582/comment/b02712c6_38bb… PS2, Line 782: RSL_Message You're matching RSL PDU here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582/comment/01242d74_0c32… PS2, Line 786: RSL PDU But saying RSL PDU here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4 Gerrit-Change-Number: 29582 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Oct 2022 08:24:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: osmux: Use setsockopt(IPV6_V6ONLY) on IPv6 socket
by pespin 06 Oct '22

06 Oct '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29638 ) Change subject: osmux: Use setsockopt(IPV6_V6ONLY) on IPv6 socket ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Strange, when I run this in TTCN3 MGW_Tests docker setup, the sockopt fails with EINVAL: DOSMUX ERROR <0002> setsockopt(IPV6_V6ONLY, 1) failed on socket r=NULL<->l=fd02:db8:4::180:1984 errno=22 (mgcp_osmux.c:484) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0b120d016ff32369a8c077b601ec168928c38f0b Gerrit-Change-Number: 29638 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Oct 2022 08:22:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: usb: Add support for new GPSDO status field "Accumulated error"
by tnt 06 Oct '22

06 Oct '22

Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29618 ) Change subject: usb: Add support for new GPSDO status field "Accumulated error" ...................................................................... Patch Set 4: (2 comments) File src/ice1usb_proto.h: https://gerrit.osmocom.org/c/osmo-e1d/+/29618/comment/42d3e0ae_cc9420ce PS3, Line 68: int16_t err_acc; /*!< Accumulated error */ > I think it might make sense to add a comment that this field was added by firmware version `git desc […] I added a reference to the next (yet to be tagged/release) version (since it'll be the first to have it) and the exact commit. Note that this also means the ice1usb_proto.h here is different from the one in the firmware repo. Unless we add two commits for every ice1usb_proto.h change in the future (because you can't include the sha of the commit in the commit itself obviously unless you want to start looking for sha1 collisions ...) File src/usb.c: https://gerrit.osmocom.org/c/osmo-e1d/+/29618/comment/60ef83a1_92df85a4 PS3, Line 715: "Some values will be zeroed\n", > I don't think we want to send one NOTICE every status_cb. […] Yup notice is probably a bit much. Switched to DEBUG. Also added a wall of text explaining why this is needed and why the opposite case is not an issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846 Gerrit-Change-Number: 29618 Gerrit-PatchSet: 4 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 06 Oct 2022 08:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: usb: Add support for new GPSDO status field "Accumulated error"
by tnt 06 Oct '22

06 Oct '22

Attention is currently required from: tnt. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/29618 to look at the new patch set (#5). Change subject: usb: Add support for new GPSDO status field "Accumulated error" ...................................................................... usb: Add support for new GPSDO status field "Accumulated error" Because we want to handle older firmwares too, we need to excepect we might get a smaller structure ! (We can't get a larger one since the wLength we send is limited to the structure we know) Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846 --- M src/e1d.h M src/ice1usb_proto.h M src/intf_line.c M src/usb.c 4 files changed, 23 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/18/29618/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846 Gerrit-Change-Number: 29618 Gerrit-PatchSet: 5 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newpatchset

1 0

Change in osmo-mgw[master]: osmux: Use setsockopt(IPV6_V6ONLY) on IPv6 socket
by pespin 06 Oct '22

06 Oct '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29638 to look at the new patch set (#4). Change subject: osmux: Use setsockopt(IPV6_V6ONLY) on IPv6 socket ...................................................................... osmux: Use setsockopt(IPV6_V6ONLY) on IPv6 socket We for sure don't want to mix stuff and send IPv4 stuff over IPv6, so let's make sure we block that possibility. This helps in avoiding configuration problems where same port allocated by an IPv6 address cannot be used by an IPv4 one. Change-Id: I0b120d016ff32369a8c077b601ec168928c38f0b --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/38/29638/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0b120d016ff32369a8c077b601ec168928c38f0b Gerrit-Change-Number: 29638 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-e1d[master]: vty: Add option to disable GPS-DO loop and use manual tuning values
by tnt 06 Oct '22

06 Oct '22

Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29635 ) Change subject: vty: Add option to disable GPS-DO loop and use manual tuning values ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: Fixed wording File src/vty.c: https://gerrit.osmocom.org/c/osmo-e1d/+/29635/comment/20c5a766_9fecfbae PS1, Line 307: "Sets the GPS-DO to manual with the provided tune values\n" > manual *mode* ... […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I8668fe42e4c399f08696e497887120e501341f5a Gerrit-Change-Number: 29635 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 06 Oct 2022 08:14:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: osmux: Use setsockopt(IPV6_V6ONLY) on IPv6 socket
by pespin 06 Oct '22

06 Oct '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29638 to look at the new patch set (#3). Change subject: osmux: Use setsockopt(IPV6_V6ONLY) on IPv6 socket ...................................................................... osmux: Use setsockopt(IPV6_V6ONLY) on IPv6 socket We for sure don't want to mix stuff and send IPv4 stuff over IPv6, so let's make sure we block that possibility. This helps in avoiding configuration problems where same port allocated by an IPv6 address cannot be used by an IPv4 one. Change-Id: I0b120d016ff32369a8c077b601ec168928c38f0b --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/38/29638/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0b120d016ff32369a8c077b601ec168928c38f0b Gerrit-Change-Number: 29638 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log