- gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: jobs/gerrit-lint: run as part of pipeline
by msuraev 08 Oct '22

08 Oct '22

Attention is currently required from: osmith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29670 ) Change subject: jobs/gerrit-lint: run as part of pipeline ...................................................................... Patch Set 1: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/29670/comment/3866a61b_942285f8 PS1, Line 77: pipeline_build: false Should this be "pipeline_lint: false"? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5f1340248cd116c5fa5134eee3fae50baf7ef851 Gerrit-Change-Number: 29670 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Oct 2022 19:26:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: jobs/gerrit-binpkgs: new job for deb, rpm packages
by msuraev 08 Oct '22

08 Oct '22

Attention is currently required from: osmith, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29604 ) Change subject: jobs/gerrit-binpkgs: new job for deb, rpm packages ...................................................................... Patch Set 4: (2 comments) File jobs/gerrit-binpkgs.yml: https://gerrit.osmocom.org/c/osmo-ci/+/29604/comment/8aa47af7_83ddfd83 PS4, Line 16: node: osmocom-gerrit-debian10 || osmocom-gerrit-debian11 What's the reason for using Debian 10? I though the plan is to migrate everything we can to Debian 11. https://gerrit.osmocom.org/c/osmo-ci/+/29604/comment/1ff99b79_829c32ed PS4, Line 86: rpm) distro="centos:8" ;; That's EoL as well - see https://www.centos.org/centos-linux-eol/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7ca8869c2e9f2e7c74a360933be12b5c2b47c2fc Gerrit-Change-Number: 29604 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Oct 2022 19:23:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: jobs/gerrit-verifications: wrap in pipeline job
by msuraev 08 Oct '22

08 Oct '22

Attention is currently required from: osmith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29668 ) Change subject: jobs/gerrit-verifications: wrap in pipeline job ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ica208a5177739655cdd493d461da146d440cd542 Gerrit-Change-Number: 29668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Oct 2022 19:15:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: jobs/gerrit-verifications: write summary comment
by msuraev 08 Oct '22

08 Oct '22

Attention is currently required from: osmith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29671 ) Change subject: jobs/gerrit-verifications: write summary comment ...................................................................... Patch Set 1: (2 comments) File jobs/gerrit-pipeline-result.yml: https://gerrit.osmocom.org/c/osmo-ci/+/29671/comment/ae341e30_acd70913 PS1, Line 12: node: osmocom-gerrit-debian10 || osmocom-gerrit-debian11 What's the reason for using Debian 10? I though the plan is to migrate everything we can to Debian 11. File scripts/jenkins-gerrit/pipeline_summary.py: https://gerrit.osmocom.org/c/osmo-ci/+/29671/comment/399112c5_f5fc2401 PS1, Line 174: def main(): Why extra function? You can just move it directly below where main() is called. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idcab969e1b5ca4e0f1383bee8f36f2d1aac4f624 Gerrit-Change-Number: 29671 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Oct 2022 19:10:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: obs: support Osmocom projects without prefix
by msuraev 08 Oct '22

08 Oct '22

Attention is currently required from: osmith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29672 ) Change subject: obs: support Osmocom projects without prefix ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I09304b219e7002495bd3fcce61bc68c34d5ffcd8 Gerrit-Change-Number: 29672 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Oct 2022 18:57:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-sgsn[master]: GMM: permit E_GMM_COMMON_PROC_SUCCESS in normal state
by msuraev 08 Oct '22

08 Oct '22

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29676 ) Change subject: GMM: permit E_GMM_COMMON_PROC_SUCCESS in normal state ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29676 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia97b50aac6c665812ddca9010de7f97b17b78bd5 Gerrit-Change-Number: 29676 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 08 Oct 2022 18:45:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-sgsn[master]: SNDCP: log more details on failure
by msuraev 08 Oct '22

08 Oct '22

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29675 ) Change subject: SNDCP: log more details on failure ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iad3ebbc28909a827db7b3a0ae2d3e1de7991210f Gerrit-Change-Number: 29675 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Sat, 08 Oct 2022 17:39:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: Better handling of send() error
by msuraev 08 Oct '22

08 Oct '22

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29555 ) Change subject: Better handling of send() error ...................................................................... Better handling of send() error Avoid logging confusion when -1 == ENOTSUP. Change-Id: Iaa7e16e717c56466c5d9a64deb438776ca88022e --- M src/stream.c 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/stream.c b/src/stream.c index 8cb3ad0..7b41ce1 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1328,11 +1328,12 @@ } break; default: - ret = -ENOTSUP; + ret = -1; + errno = ENOTSUP; } - if (ret < 0) { /* send(): On error , -1 is returned, and errno is set appropriately */ - LOGP(DLINP, LOGL_ERROR, "error to send: %s\n", (ret == -1) ? strerror(errno) : strerror(-ret)); - } + if (ret == -1) /* send(): On error -1 is returned, and errno is set appropriately */ + LOGP(DLINP, LOGL_ERROR, "error to send: %s\n", strerror(errno)); + msgb_free(msg); if (llist_empty(&conn->tx_queue) && (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY)) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29555 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iaa7e16e717c56466c5d9a64deb438776ca88022e Gerrit-Change-Number: 29555 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmocore[master]: Add osmo_sock_get_name_multiaddr_buf()
by msuraev 08 Oct '22

08 Oct '22

Attention is currently required from: neels, fixeria. Hello Jenkins Builder, neels, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/28997 to look at the new patch set (#14). Change subject: Add osmo_sock_get_name_multiaddr_buf() ...................................................................... Add osmo_sock_get_name_multiaddr_buf() It's similar to osmo_sock_get_name_buf() but supports multi-homed SCTP sockets bound to several addresses. Related: OS#5581 Change-Id: If76595ebd1cf26ba904887a36c4cc14a1b5c4521 --- M include/osmocom/core/socket.h M src/socket.c M tests/socket/socket_sctp_test.c M tests/socket/socket_sctp_test.ok 4 files changed, 101 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/97/28997/14 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If76595ebd1cf26ba904887a36c4cc14a1b5c4521 Gerrit-Change-Number: 28997 Gerrit-PatchSet: 14 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: Add osmo_sock_get_name_multiaddr_buf()
by msuraev 08 Oct '22

08 Oct '22

Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28997 ) Change subject: Add osmo_sock_get_name_multiaddr_buf() ...................................................................... Patch Set 13: (5 comments) File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/3086a90e_83e4b237 PS10, Line 266: LOGL_DEBUG > LOGL_ERROR? No, see the adjacent comment. https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/af79bde1_306b1c7e PS10, Line 271: LOGL_DEBUG > LOGL_ERROR? Same as above. https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/b1f6db36_290933c7 PS10, Line 276: LOGL_DEBUG > LOGL_NOTICE? Done https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/79ab3c52_bb311971 PS10, Line 329: assemble > This comment should go below, you're not assembling anything here yet. Done File tests/socket/socket_sctp_test.c: https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/aee1d093_93056d3d PS10, Line 76: OSMO_SOCK_NAME_MAXLEN * OSMO_SOCK_MAX_ADDRS > sizeof(buf) here and below Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If76595ebd1cf26ba904887a36c4cc14a1b5c4521 Gerrit-Change-Number: 28997 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Oct 2022 16:39:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log