- gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Split code to sua_gen_cldr() helper function
by pespin 27 Nov '25

27 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41519?usp=email ) Change subject: Split code to sua_gen_cldr() helper function ...................................................................... Split code to sua_gen_cldr() helper function This will be used to send back UDTS to originator of TCAP msg during TCAP loadshare routing if no ASP serving a given TID is found. Change-Id: I171381991308e3bb54f76afc92ccad3fcae6dcbb --- M src/sccp_sclc.c M src/sua.c M src/xua_internal.h 3 files changed, 51 insertions(+), 41 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/19/41519/1 diff --git a/src/sccp_sclc.c b/src/sccp_sclc.c index 0a47cd9..704c4bb 100644 --- a/src/sccp_sclc.c +++ b/src/sccp_sclc.c @@ -344,47 +344,7 @@ const struct xua_msg *xua_in, uint32_t ret_cause) { - struct xua_msg *xua_out = xua_msg_alloc(); - struct osmo_sccp_addr called; - - xua_out->hdr = XUA_HDR(SUA_MSGC_CL, SUA_CL_CLDR); - xua_msg_add_u32(xua_out, SUA_IEI_ROUTE_CTX, inst->route_ctx); - xua_msg_add_u32(xua_out, SUA_IEI_CAUSE, - SUA_CAUSE_T_RETURN | ret_cause); - /* Swap Calling and Called Party */ - xua_msg_copy_part(xua_out, SUA_IEI_SRC_ADDR, xua_in, SUA_IEI_DEST_ADDR); - xua_msg_copy_part(xua_out, SUA_IEI_DEST_ADDR, xua_in, SUA_IEI_SRC_ADDR); - /* TODO: Optional: Hop Count */ - /* Optional: Importance */ - xua_msg_copy_part(xua_out, SUA_IEI_IMPORTANCE, - xua_in, SUA_IEI_IMPORTANCE); - /* Optional: Message Priority */ - xua_msg_copy_part(xua_out, SUA_IEI_MSG_PRIO, xua_in, SUA_IEI_MSG_PRIO); - /* Optional: Correlation ID */ - xua_msg_copy_part(xua_out, SUA_IEI_CORR_ID, xua_in, SUA_IEI_CORR_ID); - /* Optional: Segmentation */ - xua_msg_copy_part(xua_out, SUA_IEI_SEGMENTATION, - xua_in, SUA_IEI_SEGMENTATION); - /* Optional: Data */ - xua_msg_copy_part(xua_out, SUA_IEI_DATA, xua_in, SUA_IEI_DATA); - - OSMO_ASSERT(sua_addr_parse(&called, xua_out, SUA_IEI_DEST_ADDR) == 0); - - /* Route on PC + SSN ? */ - if (called.ri == OSMO_SCCP_RI_SSN_PC) { - /* if no PC, copy OPC into called addr */ - if (!(called.presence & OSMO_SCCP_ADDR_T_PC)) { - struct osmo_sccp_addr calling; - OSMO_ASSERT(sua_addr_parse(&calling, xua_out, SUA_IEI_SRC_ADDR) == 0); - called.presence |= OSMO_SCCP_ADDR_T_PC; - called.pc = calling.pc; - /* Re-encode / replace called address */ - xua_msg_free_tag(xua_out, SUA_IEI_DEST_ADDR); - xua_msg_add_sccp_addr(xua_out, SUA_IEI_DEST_ADDR, - &called); - } - } - return xua_out; + return sua_gen_cldr(xua_in, inst->route_ctx, ret_cause); } /*! \brief SCRC -> SCLC (Routing Failure diff --git a/src/sua.c b/src/sua.c index e157f31..e81590d 100644 --- a/src/sua.c +++ b/src/sua.c @@ -262,6 +262,54 @@ return xua; } +/* generate a return/refusal message (SUA CLDR == SCCP UDTS) based on + * the incoming message. We need to flip all identities between sender + * and receiver */ +struct xua_msg *sua_gen_cldr(const struct xua_msg *xua_in, uint32_t route_ctx, uint32_t ret_cause) +{ + struct xua_msg *xua_out = xua_msg_alloc(); + struct osmo_sccp_addr called; + + xua_out->hdr = XUA_HDR(SUA_MSGC_CL, SUA_CL_CLDR); + xua_msg_add_u32(xua_out, SUA_IEI_ROUTE_CTX, route_ctx); + xua_msg_add_u32(xua_out, SUA_IEI_CAUSE, + SUA_CAUSE_T_RETURN | ret_cause); + /* Swap Calling and Called Party */ + xua_msg_copy_part(xua_out, SUA_IEI_SRC_ADDR, xua_in, SUA_IEI_DEST_ADDR); + xua_msg_copy_part(xua_out, SUA_IEI_DEST_ADDR, xua_in, SUA_IEI_SRC_ADDR); + /* TODO: Optional: Hop Count */ + /* Optional: Importance */ + xua_msg_copy_part(xua_out, SUA_IEI_IMPORTANCE, + xua_in, SUA_IEI_IMPORTANCE); + /* Optional: Message Priority */ + xua_msg_copy_part(xua_out, SUA_IEI_MSG_PRIO, xua_in, SUA_IEI_MSG_PRIO); + /* Optional: Correlation ID */ + xua_msg_copy_part(xua_out, SUA_IEI_CORR_ID, xua_in, SUA_IEI_CORR_ID); + /* Optional: Segmentation */ + xua_msg_copy_part(xua_out, SUA_IEI_SEGMENTATION, + xua_in, SUA_IEI_SEGMENTATION); + /* Optional: Data */ + xua_msg_copy_part(xua_out, SUA_IEI_DATA, xua_in, SUA_IEI_DATA); + + OSMO_ASSERT(sua_addr_parse(&called, xua_out, SUA_IEI_DEST_ADDR) == 0); + + /* Route on PC + SSN ? */ + if (called.ri == OSMO_SCCP_RI_SSN_PC) { + /* if no PC, copy OPC into called addr */ + if (!(called.presence & OSMO_SCCP_ADDR_T_PC)) { + struct osmo_sccp_addr calling; + OSMO_ASSERT(sua_addr_parse(&calling, xua_out, SUA_IEI_SRC_ADDR) == 0); + called.presence |= OSMO_SCCP_ADDR_T_PC; + called.pc = calling.pc; + /* Re-encode / replace called address */ + xua_msg_free_tag(xua_out, SUA_IEI_DEST_ADDR); + xua_msg_add_sccp_addr(xua_out, SUA_IEI_DEST_ADDR, + &called); + } + } + return xua_out; +} + /*********************************************************************** * Transmitting SUA messages to SCTP ***********************************************************************/ diff --git a/src/xua_internal.h b/src/xua_internal.h index a6cb961..54172ff 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -37,6 +37,8 @@ void sua_tx_dupu(struct osmo_ss7_asp *asp, const uint32_t *rctx, unsigned int num_rctx, uint32_t dpc, uint16_t user, uint16_t cause, const char *info_str); +struct xua_msg *sua_gen_cldr(const struct xua_msg *xua_in, uint32_t route_ctx, uint32_t ret_cause); + int m3ua_hmdc_rx_from_l2(struct osmo_ss7_instance *inst, struct xua_msg *xua); struct msgb *m3ua_to_msg(struct xua_msg *xua); int m3ua_tx_xua_as(struct osmo_ss7_as *as, struct xua_msg *xua); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41519?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I171381991308e3bb54f76afc92ccad3fcae6dcbb Gerrit-Change-Number: 41519 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-gsm-manuals[master]: GSUP: add missing Current RAT Type IE
by pespin 27 Nov '25

27 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email ) Change subject: GSUP: add missing Current RAT Type IE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iba841856806b7dbd4b6aa3675e0cc6dff2485da0 Gerrit-Change-Number: 41518 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 11:56:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-gsm-manuals[master]: GSUP: add missing Current RAT Type IE
by osmith 27 Nov '25

27 Nov '25

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email ) Change subject: GSUP: add missing Current RAT Type IE ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Noticed that this is not documented while reviewing https://github.com/nickvsnetworking/pyhss/pull/283 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iba841856806b7dbd4b6aa3675e0cc6dff2485da0 Gerrit-Change-Number: 41518 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 27 Nov 2025 11:05:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-gsm-manuals[master]: GSUP: add missing Current RAT Type IE
by osmith 27 Nov '25

27 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email ) Change subject: GSUP: add missing Current RAT Type IE ...................................................................... GSUP: add missing Current RAT Type IE This IE has been introduced here: https://gerrit.osmocom.org/c/libosmocore/+/12452 Used only by osmo_dia2gsup so far: https://gitea.osmocom.org/erlang/osmo_dia2gsup/commit/388d387dcc9a565b82c70… Change-Id: Iba841856806b7dbd4b6aa3675e0cc6dff2485da0 --- M common/chapters/gsup.adoc 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/18/41518/1 diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index 33d35da..46139f8 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -363,6 +363,7 @@ |26|AUTS|<<gsup-ie-auts>>|C|TLV|18 |20|RAND|<<gsup-ie-rand>>|C|TLV|18 |05|PDP info|<<gsup-ie-pdpinfo>>|C|TLV|2-N +|2a|Current RAT Type|<<gsup-ie-current-rat-type>>|O|TLV|3 |=== The conditional 'AUTS' and 'RAND' IEs are both present in case the SIM @@ -1736,6 +1737,20 @@ This IE indicates why an event is happening on the BSSAP interface. See 3GPP TS 48.008 3.2.2.5 for reference. +[[gsup-ie-current-rat-type]] +==== Current RAT Type + +This IE contains the current RAT Type. + +.Current RAT Type values +[options="header",cols="15%,85%"] +|=== +|Type|Description +|0x01|GERAN +|0x02|UTRAN +|0x03|EUTRAN +|=== + [[gsup-ie-cause-sm]] ==== Session Management Cause -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iba841856806b7dbd4b6aa3675e0cc6dff2485da0 Gerrit-Change-Number: 41518 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: ASCI: Fix establishment of calls when ciphering is enabled
by pespin 27 Nov '25

27 Nov '25

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email ) Change subject: ASCI: Fix establishment of calls when ciphering is enabled ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e Gerrit-Change-Number: 41504 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 09:22:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: ASCI: Fix establishment of calls when ciphering is enabled
by jolly 27 Nov '25

27 Nov '25

Attention is currently required from: fixeria, laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email ) Change subject: ASCI: Fix establishment of calls when ciphering is enabled ...................................................................... Patch Set 2: (1 comment) File src/libvlr/vlr_access_req_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/41504/comment/fa87bb2f_a06ad371?usp… : PS2, Line 306: * cipering has not been completely specified. The SIM does not support key storage. */ > typo: cipering Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e Gerrit-Change-Number: 41504 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 09:19:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: ASCI: Fix establishment of calls when ciphering is enabled
by jolly 27 Nov '25

27 Nov '25

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ASCI: Fix establishment of calls when ciphering is enabled ...................................................................... ASCI: Fix establishment of calls when ciphering is enabled We do not support any VGCS/VBS ciphering. If the CM Service Request indicates VGCS or VBS service, encryption is not enabled for the channel to be set up. There will be no Ciphering Command sent to the ME. Authentication is still performed with the initiator of the call, if authentication is enabled. Only authenticated subscribers will then be able to initiate ASCI calls. Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e --- M src/libvlr/vlr_access_req_fsm.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/04/41504/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e Gerrit-Change-Number: 41504 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: ASCI: Fix establishment of calls when ciphering is enabled
by pespin 27 Nov '25

27 Nov '25

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email ) Change subject: ASCI: Fix establishment of calls when ciphering is enabled ...................................................................... Patch Set 2: (1 comment) File src/libvlr/vlr_access_req_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/41504/comment/2509d7f1_1c679b8b?usp… : PS2, Line 306: * cipering has not been completely specified. The SIM does not support key storage. */ typo: cipering -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e Gerrit-Change-Number: 41504 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 09:11:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_ue_ctx_release_req(): add a quirk for -latest
by fixeria 27 Nov '25

27 Nov '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41517?usp=email ) Change subject: s1gw: f_ConnHdlr_ue_ctx_release_req(): add a quirk for -latest ...................................................................... s1gw: f_ConnHdlr_ue_ctx_release_req(): add a quirk for -latest We're hitting a crash in Eclipse TITAN when running S1GW_Tests.TC_uemux_ue_ctx_release_req against the -latest version of osmo-s1gw, which is sending PFCP Session Deletion Request that we no longer expect to receive. This results in an empty junit-xml file due to early termination of the runtime. Re-introduce the f_ConnHdlr_session_delete(), only for the -latest. Change-Id: I90c44955ad3aabfe7ca9198b3ec9b6b97a46c0ae Related: 8e315ed6 ("s1gw: correct handling of UE CONTEXT RELEASE REQUEST") Related: osmo-s1gw.git If467162e871b7989f0578be30c04d1c32c263c99 Related: OS#6888, SYS#7738, SYS#7599 --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index b850f55..ec6d08a 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -1662,6 +1662,10 @@ log("[eNB -> S1GW] -> MME: UE CONTEXT RELEASE REQUEST"); f_ConnHdlr_tx_s1ap_from_enb(ts_S1AP_UeContextReleaseReq(mme_ue_id, enb_ue_id, cause)); + /* XXX: remove this quirk when osmo-s1gw > 0.3.0 is released */ + if (Misc_Helpers.f_osmo_repo_is("latest")) { + f_ConnHdlr_session_delete(erabs); + } log("eNB -> [S1GW -> MME]: UE CONTEXT RELEASE REQUEST"); f_ConnHdlr_rx_s1ap_from_enb(pdu, tr_S1AP_UeContextReleaseReq(mme_ue_id, enb_ue_id, cause)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41517?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90c44955ad3aabfe7ca9198b3ec9b6b97a46c0ae Gerrit-Change-Number: 41517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: ASCI: Fix establishment of calls when ciphering is enabled
by jolly 27 Nov '25

27 Nov '25

Attention is currently required from: fixeria, laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email ) Change subject: ASCI: Fix establishment of calls when ciphering is enabled ...................................................................... Patch Set 1: (1 comment) File src/libvlr/vlr_access_req_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/41504/comment/0c89c576_1fe8e896?usp… : PS1, Line 305: * Also continue without ciphering, if ASCI call was requested. */ > may be worth leaving a comment here regarding why we don't enable ciphering for ASCI calls. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e Gerrit-Change-Number: 41504 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 08:20:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log