- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: bts: create all components alive
by osmith 10 Dec '25

10 Dec '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41643?usp=email ) Change subject: bts: create all components alive ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68929b45d66d60617079a4f92d40ffea439bf4be Gerrit-Change-Number: 41643 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Dec 2025 15:41:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: fix unbound variable in as_rsl_fail_err()
by osmith 10 Dec '25

10 Dec '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41644?usp=email ) Change subject: bts: fix unbound variable in as_rsl_fail_err() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifcbdfb8b5a0e08ca3f8e610ca4940a2bdafa3cac Gerrit-Change-Number: 41644 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Dec 2025 15:41:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: fix unbound variable in as_rsl_fail_err()
by pespin 10 Dec '25

10 Dec '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41644?usp=email ) Change subject: bts: fix unbound variable in as_rsl_fail_err() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifcbdfb8b5a0e08ca3f8e610ca4940a2bdafa3cac Gerrit-Change-Number: 41644 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Dec 2025 15:24:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: fix unbound variable in as_rsl_fail_err()
by fixeria 10 Dec '25

10 Dec '25

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41644?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: bts: fix unbound variable in as_rsl_fail_err() ...................................................................... bts: fix unbound variable in as_rsl_fail_err() Change-Id: Ifcbdfb8b5a0e08ca3f8e610ca4940a2bdafa3cac --- M bts/BTS_Tests_LAPDm.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/41644/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifcbdfb8b5a0e08ca3f8e610ca4940a2bdafa3cac Gerrit-Change-Number: 41644 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: create all components alive
by pespin 10 Dec '25

10 Dec '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41643?usp=email ) Change subject: bts: create all components alive ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68929b45d66d60617079a4f92d40ffea439bf4be Gerrit-Change-Number: 41643 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Dec 2025 15:08:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: fix unbound variable in as_rsl_fail_err()
by fixeria 10 Dec '25

10 Dec '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41644?usp=email ) Change subject: bts: fix unbound variable in as_rsl_fail_err() ...................................................................... bts: fix unbound variable in as_rsl_fail_err() Change-Id: Ifcbdfb8b5a0e08ca3f8e610ca4940a2bdafa3cac --- M bts/BTS_Tests_LAPDm.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/41644/1 diff --git a/bts/BTS_Tests_LAPDm.ttcn b/bts/BTS_Tests_LAPDm.ttcn index 5b33795..8b091f7 100644 --- a/bts/BTS_Tests_LAPDm.ttcn +++ b/bts/BTS_Tests_LAPDm.ttcn @@ -507,7 +507,7 @@ /* fail if we receive an RSL ERROR IND */ private altstep as_rsl_fail_err() runs on ConnHdlr { var RSL_Message rx_rsl; - [] RSL.receive(tr_RSL_ERROR_IND(g_chan_nr, ?, ?)) { + [] RSL.receive(tr_RSL_ERROR_IND(g_chan_nr, ?, ?)) -> rx_rsl { setverdict(fail, "Received RSL ERROR IND ", rx_rsl); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifcbdfb8b5a0e08ca3f8e610ca4940a2bdafa3cac Gerrit-Change-Number: 41644 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: create all components alive
by fixeria 10 Dec '25

10 Dec '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41643?usp=email ) Change subject: bts: create all components alive ...................................................................... bts: create all components alive This mitigates sporadic dynamic-testcase errors triggered by messages being sent to components that have terminated before receiving them. Change-Id: I68929b45d66d60617079a4f92d40ffea439bf4be --- M bts/BTS_Tests.ttcn M bts/BTS_Tests_LAPDm.ttcn 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/43/41643/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index de02359..455e696 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -241,8 +241,8 @@ var ASP_RSL_Unitdata rx_ud; timer T; - vc_IPA := IPA_Emulation_CT.create(id & "-RSL-IPA"); - vc_RSL := RSL_Emulation_CT.create(id & "-RSL"); + vc_IPA := IPA_Emulation_CT.create(id & "-RSL-IPA") alive; + vc_RSL := RSL_Emulation_CT.create(id & "-RSL") alive; map(vc_IPA:IPA_PORT, system:IPA_CODEC_PT); connect(vc_IPA:IPA_RSL_PORT, vc_RSL:IPA_PT); @@ -695,7 +695,7 @@ var charstring id := testcasename(); var ConnHdlr vc_conn; - vc_conn := ConnHdlr.create(id); + vc_conn := ConnHdlr.create(id) alive; /* connect to RSL Emulation main component */ connect(vc_conn:RSL, vc_RSL:CLIENT_PT); connect(vc_conn:RSL_PROC, vc_RSL:RSL_PROC); @@ -2626,7 +2626,7 @@ uint7_t rtp_pt := 0) runs on ConnHdlr { /* Step 0: initialize, connect and start the emulation component */ - vc_RTPEM := RTP_Emulation_CT.create(testcasename() & "-RTPEM"); + vc_RTPEM := RTP_Emulation_CT.create(testcasename() & "-RTPEM") alive; map(vc_RTPEM:RTP, system:RTP); map(vc_RTPEM:RTCP, system:RTCP); connect(vc_RTPEM:CTRL, self:RTPEM_CTRL); @@ -2676,7 +2676,7 @@ var OsmuxTxHandle tx_hdl; var OsmuxRxHandle rx_hdl; /* Step 0: initialize, connect and start the emulation component */ - vc_OsmuxEM := OSMUX_Emulation_CT.create(testcasename() & "-OsmuxEM"); + vc_OsmuxEM := OSMUX_Emulation_CT.create(testcasename() & "-OsmuxEM") alive; map(vc_OsmuxEM:OSMUX, system:OSMUX); connect(vc_OsmuxEM:CTRL, self:OsmuxEM_CTRL); connect(vc_OsmuxEM:DATA, self:OsmuxEM_DATA); diff --git a/bts/BTS_Tests_LAPDm.ttcn b/bts/BTS_Tests_LAPDm.ttcn index 7dda8b8..5b33795 100644 --- a/bts/BTS_Tests_LAPDm.ttcn +++ b/bts/BTS_Tests_LAPDm.ttcn @@ -24,7 +24,7 @@ function f_lapdm_init() runs on lapdm_test_CT { /* create the LAPDm component */ - lapdm_component := lapdm_CT.create; + lapdm_component := lapdm_CT.create alive; /* connect our own LAPDM port to the LAPDM Service Provider of the LAPDm component */ connect(self:LAPDM, lapdm_component:LAPDM_SP); /* connect the LAPDm compoent's lower-side port to the system L1CTL port (which is internally -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68929b45d66d60617079a4f92d40ffea439bf4be Gerrit-Change-Number: 41643 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: setup.py: Align cmd2 minimum version with requirements.txt
by osmith 10 Dec '25

10 Dec '25

Attention is currently required from: dexter, laforge, neels. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41642?usp=email ) Change subject: setup.py: Align cmd2 minimum version with requirements.txt ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I believe it's worth mentioning that `debian:trixie` provides `2.5. […] Good points. I think we need to figure out which versions of cmd2 we want to support. We could do e.g. the following: 1) Use this patch as-is and just require cmd2 >= 2.6.2 for PySim. We can then remove the backwards compatibility code you mentioned in a follow-up patch. The big advantage is that users won't have ancient cmd2 versions, against which we potentially might have incompatibilities over time without realizing it. It would make sense to update the description in README.md for installing pysim to rely on pip packages instead of debian packages: ``` $ python3 -m venv .venv $ . .venv/bin/activate $ pip install -r requirements.txt ``` 2) Require cmd2 >= 1.5 (as before) in both setup.py and requirements.txt, and force in contrib/jenkins.sh that cmd2 >= 2.6.2 is installed similar to https://gitea.osmocom.org/sim-card/pysim/commit/004b06eab1d89ba2b29d7de9b77…. This has the advantage that people can still use their older versions from distro packages. We don't build pysim in the Osmocom OBS. Personally I would be fine with 1), but maybe others have different opinions. Thoughts? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71cee0ec3ed2abec68ec567beaab13c868721dad Gerrit-Change-Number: 41642 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Dec 2025 14:40:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by fixeria 10 Dec '25

10 Dec '25

Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email ) Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901/comment/6a49d79a_2d79… : PS3, Line 150: io_lib:format > I agree with fixeria Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 10 Dec 2025 14:24:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in pysim[master]: setup.py: Align cmd2 minimum version with requirements.txt
by fixeria 10 Dec '25

10 Dec '25

Attention is currently required from: dexter, laforge, neels. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41642?usp=email ) Change subject: setup.py: Align cmd2 minimum version with requirements.txt ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I believe it's worth mentioning that `debian:trixie` provides `2.5.11`, and `pySim-shell` still works fine with that older version. The only problem was artifacts in auto-generated documentation (https://osmocom.org/issues/6776). The version was bumped here: https://gerrit.osmocom.org/c/pysim/+/40952 and honestly I am not sure if this alone is a strong reason to require `2.6.2`. Another thing I wanted to bring up with backwards compatibility quirks in `pySim-shell.py` (grep for `cmd2.__version__`). If we go for bumping the minimum version to `2.6.2`, it no longer makes sense to have the quirks for `<2.3.0` and `<2.0.0`. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71cee0ec3ed2abec68ec567beaab13c868721dad Gerrit-Change-Number: 41642 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Dec 2025 14:20:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log