- gerrit-log - lists.osmocom.org

[M] Change in libosmo-abis[master]: trau2rtp: rm defunct AMR WIP code
by falconia 21 Dec '25

21 Dec '25

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41744?usp=email ) Change subject: trau2rtp: rm defunct AMR WIP code ...................................................................... trau2rtp: rm defunct AMR WIP code When the present TRAU<->RTP conversion module was initially introduced in 2020, there was a WIP plan to eventually extend it to support AMR in addition to FR/HR/EFR. Defunct code for a beginning of trau2rtp implementation for AMR has sat in trau_rtp_conv.c under '#if 0' all these years - but it never became anything beyond dead code. When the time came to implement AMR TRAU support for real, the existing TRAU<->RTP API from 2020 design turned out to be insufficient; the AMR support that was merged just before 2025-12 major release takes the form of an entirely new AMR TRAU frame interworking facility with its own API. As a result of these developments, the original defunct AMR code from 2020 now only adds confusion - remove it. Change-Id: Ieeee8eb6dbf9c753458a91e13f2bf22311936259 --- M src/trau/trau_rtp_conv.c 1 file changed, 0 insertions(+), 136 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/44/41744/1 diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index 9b1dc58..56cc109 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -1121,142 +1121,6 @@ return 0; } -#if 0 -static inline memcpy_inc(uint8_t *out, const uint8_t *in, size_t len, unsigned int *idx) -{ - memcpy_inc(out, in, len); - *idx += len; -} - -static int amr_speech_extract_sbits(ubit_t *s_bits, const struct osmo_trau_frame *tf, - enum osmo_amr_mode mode) -{ - unsigned int s_idx = 0; - - switch (mode) { - case AMR_4_75: - memcpy_inc(s_bits + s_idx, tf->d_bits + 44, 67 - 44, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 67, 92 - 67, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 95, 108 - 95, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 111, 132 - 111, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 135, 148 - 135, &s_idx); - break; - case AMR_5_15: - memcpy_inc(s_bits + s_idx, tf->d_bits + 46, 96 - 46, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 69, 92 - 69, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 95, 114 - 95, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 117, 136 - 117, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 139, 158 - 139, &s_idx); - break; - case AMR_5_90: - memcpy_inc(s_bits + s_idx, tf->d_bits + 41, 67 - 41, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 67, 92 - 67, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 95, 116 - 95, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 119, 144 - 119, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 147, 168 - 147, &s_idx); - break; - case AMR_6_70: - memcpy_inc(s_bits + s_idx, tf->d_bits + 37, 63 - 37, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 63, 92 - 63, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 95, 120 - 95, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 123, 152 - 123, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 155, 180 - 155, &s_idx); - break; - case AMR_7_40: - memcpy_inc(s_bits + s_idx, tf->d_bits + 34, 60 - 34, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 60, 92 - 60, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 95, 124 - 95, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 127, 159 - 127, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 162, 191 - 162, &s_idx); - break; - case AMR_7_95: - memcpy_inc(s_bits + s_idx, tf->d_bits + 31, 58 - 31, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 58, 92 - 58, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 95, 127 - 95, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 130, 164 - 130, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 167, 199 - 167, &s_idx); - break; - case AMR_10_2: - memcpy_inc(s_bits + s_idx, tf->d_bits + 20, 46 - 20, &s_idx); /* D21..D46 */ - memcpy_inc(s_bits + s_idx, tf->d_bits + 46, 92 - 46, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 95, 138 - 95, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 141, 187 - 141, &s_idx); - memcpy_inc(s_bits + s_idx, tf->d_bits + 190, 233 - 190, &s_idx); - break; - case AMR_12_2: - memcpy_inc(s_bits + s_idx, tf->d_bits + 0, 38 - 0, &s_idx); /* D1..D38 */ - memcpy_inc(s_bits + s_idx, tf->d_bits + 38, 91 - 38, &s_idx); /* D39..D91 */ - memcpy_inc(s_bits + s_idx, tf->d_bits + 94, 144 - 94, &s_idx); /* D95..D144 */ - memcpy_inc(s_bits + s_idx, tf->d_bits + 147, 200 - 147, &s_idx);/* D148..D200 */ - memcpy_inc(s_bits + s_idx, tf->d_bits + 203, 253 - 203, &s_idx);/* D204..D253 */ - break; - } - - return s_idx; -} - -/* TS 48.060 Section 5.5.1.2.2 */ -static int trau2rtp_16(uint8_t *out, const struct osmo_trau_frame *tf, enum osmo_amr_mode last_cmi) -{ - enum osmo_amr_mode mode = last_cmi; - uint8_t frame_class = tf->c_bits[21] << 1 | tf->c_bits[20]; - uint8_t cmr_cmi = tf->c_bits[23] << 2 | tf->c_bits[24] << 1 | tf->cb_bits[25]; - uint8_t no_speech_cls; - uint8_t s_bits[242]; - uint8_t d_bits[242]; - unsigned int s_idx = 0; - ubit_t rif = FIXME; - - if (tf->type != OSMO_TRAU16_FT_AMR) - return -EINVAL; - - if (rif == 0) - mode = cmr_cmi; - - switch (frame_class) { - case 0: // no speech - no_speech_cls = tf->d_bits[32] << 2 | tf->d_bits[33] << 1 | tf->d_bits[34]; - cmi_abs = tf->d_bits[35] << 2 | tf->d_bits[36] < 1 || tf->d_bits[37]; - cmr_abs = tf->d_bits[38] << 2 | tf->d_bits[39] < 1 || tf->d_bits[40]; - switch (no_speech_cls) { - case 7: // sid first - break; - case 6: // onset - break; - case 5: // sid_update - break; - case 4: // sid_bad - break; - case 0: // no_data - break; - } - break; - case 1: // speech bad - break; - case 2: - case 3: - /* Extract the s-bits from the TRAU frame */ - amr_speech_extract_sbits(s_bits, tf, mode); - /* Convert the s-bits to d-bits */ - osmo_amr_s_to_d(d_bits, s_bits, mode); - break; - } -} - -int trau2rtp_amr(uint8_t *out, const struct osmo_trau_frame *tf, enum osmo_amr_mode last_cmi)) -{ - switch (tf->type) { - case OSMO_TRAU16_FT_AMR: - return trau2rtp_16(out, tf, last_cmi); - case OSMO_TRAU8_AMR_LOW: - case OSMO_TRAU8_AMR_6k7: - case OSMO_TRAU8_AMR_7k4: - default: - return -EINVAL; - } -} -#endif - /* * CSD support: converting TRAU frames of type 'data' to 64 kbit/s * like the RA part of TRAU, using RTP clearmode representation. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ieeee8eb6dbf9c753458a91e13f2bf22311936259 Gerrit-Change-Number: 41744 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[M] Change in osmo-ttcn3-hacks[master]: gbproxy: Fix several tests on titan 11
by fixeria 20 Dec '25

20 Dec '25

Attention is currently required from: daniel, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email ) Change subject: gbproxy: Fix several tests on titan 11 ...................................................................... Patch Set 1: (7 comments) File gbproxy/GBProxy_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/0c35e867_6a52… : PS1, Line 2722: [] pt.receive(BssgpStatusIndication:?) { repeat; } cosmetic: shift right https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/7864bff9_e46f… : PS1, Line 2744: defaults It's only one now. Also, don't you still need to `deactivate()` it? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/cb8d86d4_6628… : PS1, Line 2753: PESPIN debugging leftovers https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/4d541fa4_9535… : PS1, Line 2764: log2str I still find it so clumsy: why not just keeping the `setverdict(...)` as-is and simply adding `Misc_Helpers.f_shutdown(__BFILE__, __LINE__)` if you want to stop the testcase here? No! We want one overloaded statement doing everything in one go, requiring `log2str()`, and resulting in code moving further to the right side of the screen... https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/9146ba64_9c3a… : PS1, Line 2921: f_get_pcu_idx_ct BTW, you can use `__SCOPE__` to print an function/altstep name, i.e. `log(__SCOPE__, "(): ...)`. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/964f1c45_f2e6… : PS1, Line 2954: defaults Likewise, don't you need to `deactivate()` it anymore? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/5aa9f7b9_98ea… : PS1, Line 2956: /* Activate one altsteps for all PCU NSE */ : var default d := activate(as_count_bvc0_block(g_roi)); : : f_sleep(3.0); : : d Does not look like we need to activate altsteps in background here? ```suggestion T.start(3.0); alt { [] as_count_bvc0_block(g_roi); /* repeats */ [] T.timeout { } } ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib17c7dcb3d224a6b9e75ce5f9121a05126f81909 Gerrit-Change-Number: 41740 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Dec 2025 21:27:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: pysim/log: also accept ANSI strings to specify the log message colors
by laforge 20 Dec '25

20 Dec '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41713?usp=email ) Change subject: pysim/log: also accept ANSI strings to specify the log message colors ...................................................................... pysim/log: also accept ANSI strings to specify the log message colors the PySimLogger class currently only accepts cmd2 color enum values. This is what we need for pySim-shell.py. However, in case we want to use the PySimLogger in stand-alone programs that do not use cmd2, this is a bit bulky. Let's add some flexibility to PySimLogger, so that we can specify the colors as raw ANSI strings as well. Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921 Related: SYS#7725 --- M pySim/log.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/log.py b/pySim/log.py index 997627f..a2325a6 100644 --- a/pySim/log.py +++ b/pySim/log.py @@ -108,7 +108,10 @@ formatted_message = logging.Formatter.format(PySimLogger.__formatter, record) color = PySimLogger.colors.get(record.levelno) if color: - PySimLogger.print_callback(style(formatted_message, fg = color)) + if isinstance(color, str): + PySimLogger.print_callback(color + formatted_message + "\033[0m") + else: + PySimLogger.print_callback(style(formatted_message, fg = color)) else: PySimLogger.print_callback(formatted_message) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921 Gerrit-Change-Number: 41713 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pysim/log: also accept ANSI strings to specify the log message colors
by laforge 20 Dec '25

20 Dec '25

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41713?usp=email ) Change subject: pysim/log: also accept ANSI strings to specify the log message colors ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921 Gerrit-Change-Number: 41713 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 23:26:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by laforge 20 Dec '25

20 Dec '25

Attention is currently required from: daniel, dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email ) Change subject: card_key_provider: add PostgreSQL support ...................................................................... Patch Set 8: Code-Review+1 (2 comments) File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/93e6a195_f50a4150?usp=em… : PS8, Line 37: PQSQL PGSQL or PSQL are usual acronyms for postgres. But not PQSQL https://gerrit.osmocom.org/c/pysim/+/41508/comment/16159947_6e3bcf78?usp=em… : PS8, Line 261: str(Path.home()) + "/.osmocom/pysim/card_data_pqsql.cfg" Not critical, but I guess the clean/pythonic way would be to use `os.path.join() to concatenate paths. Furthermore, you can use `os.path.expanduser("~/.osmocom/pysim/card_data_pgsql.cfg")` to avoid nany manual concatenation whatsoever. If that is needed at all? Why should the help print the absolute path instad the ~/... referring to the users home? Keeping the "~" would make he help output consistent across systems, and not expose user names (through directory names) if someone copy+pastes something into a bug report or mailing list / forum post. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 23:26:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: gbproxy: Fix several tests on titan 11
by laforge 20 Dec '25

20 Dec '25

Attention is currently required from: daniel, fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email ) Change subject: gbproxy: Fix several tests on titan 11 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: i'm not sure if the new variant is cleaner, but well, it's workign while the old isn't 😊 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib17c7dcb3d224a6b9e75ce5f9121a05126f81909 Gerrit-Change-Number: 41740 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Dec 2025 23:16:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: bts: properly set BTS_Tests.mp_trx_pars for hopping cfg
by fixeria 19 Dec '25

19 Dec '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41697?usp=email ) Change subject: bts: properly set BTS_Tests.mp_trx_pars for hopping cfg ...................................................................... bts: properly set BTS_Tests.mp_trx_pars for hopping cfg The pchan assignment is *different* for the hopping and non-hopping configurations, so let's override it in the BTS_Tests_FH.cfg. Change-Id: Ib8861c3eee5157436fb213da212f22477639883f --- M bts/BTS_Tests_FH.cfg 1 file changed, 55 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/bts/BTS_Tests_FH.cfg b/bts/BTS_Tests_FH.cfg index 9adb812..5f5508e 100644 --- a/bts/BTS_Tests_FH.cfg +++ b/bts/BTS_Tests_FH.cfg @@ -4,6 +4,7 @@ [LOGGING] /* The following hopping configuration corresponds to osmo-bsc-fh.confmerge. * See https://gerrit.osmocom.org/c/docker-playground/+/19160/ for more details. + * NOTE: the pchan assignment here is *different* from BTS_Tests.default. * * == Physical channel configuration (FDMA) == * @@ -131,3 +132,57 @@ } } } +BTS_Tests.mp_trx_pars := { + { # TRX0 + arfcn := 871, + ts := { + { config := GSM_PCHAN_CCCH_SDCCH4 }, + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_SDCCH8 }, + { config := GSM_PCHAN_PDCH } + } + }, + { # TRX1 + arfcn := 873, + ts := { + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_SDCCH8 }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_PDCH }, + { config := GSM_PCHAN_PDCH } + } + }, + { # TRX2 + arfcn := 875, + ts := { + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_SDCCH8 }, + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_PDCH }, + { config := GSM_PCHAN_PDCH } + } + }, + { # TRX3 + arfcn := 877, + ts := { + { config := GSM_PCHAN_TCHF }, + { config := GSM_PCHAN_SDCCH8 }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH_TCHF_PDCH }, + { config := GSM_PCHAN_TCHH }, + { config := GSM_PCHAN_SDCCH8 }, + { config := GSM_PCHAN_PDCH } + } + } +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41697?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8861c3eee5157436fb213da212f22477639883f Gerrit-Change-Number: 41697 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: Fix more odd-length digit sequences via PaddedBcdAdapter
by laforge 19 Dec '25

19 Dec '25

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41742?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Fix more odd-length digit sequences via PaddedBcdAdapter ...................................................................... Fix more odd-length digit sequences via PaddedBcdAdapter There are more files where trailing digits are indicated using 'f' and should be stripped during decode, including EF.MSISDN and EF.VGCS This is not just a presentation issue, but actually rendered wrong data before, see the modified test output where our "read_record_uicc.ok" file contained "bcd_len: 7" but then only 6 BCD digits due to this bug. Change-Id: I4571482da924a3d645caa297108279d182448d21 --- M pySim/ts_31_102.py M pySim/ts_51_011.py M tests/pySim-shell_test/file_content/test_record_uicc.ok 3 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/41742/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4571482da924a3d645caa297108279d182448d21 Gerrit-Change-Number: 41742 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: pySim.esim.saip.personalization: Support for EF.SMSP personalization
by laforge 19 Dec '25

19 Dec '25

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41735?usp=email to look at the new patch set (#4). Change subject: pySim.esim.saip.personalization: Support for EF.SMSP personalization ...................................................................... pySim.esim.saip.personalization: Support for EF.SMSP personalization It's a not-too-uncommon requirement to modify the SMSC address stored in EF.SMSP. This adds a ConfigurableParameter for this purpose. Change-Id: I6b0776c2e753e0a6d158a8cf65cb030977782ec2 --- M pySim/esim/saip/personalization.py 1 file changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/41735/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6b0776c2e753e0a6d158a8cf65cb030977782ec2 Gerrit-Change-Number: 41735 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: some more use of PaddedBcdAdapter
by laforge 19 Dec '25

19 Dec '25

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41742?usp=email ) Change subject: some more use of PaddedBcdAdapter ...................................................................... some more use of PaddedBcdAdapter There are more files where trailing digits are indicated using 'f' and should be stripped during decode, including EF.MSISDN and EF.VGCS Change-Id: I4571482da924a3d645caa297108279d182448d21 --- M pySim/ts_31_102.py M pySim/ts_51_011.py 2 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/41742/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 3ae178c..a93f1e8 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -596,7 +596,7 @@ self._construct = Struct('alpha_id'/Bytes(this._.total_len-28), 'len_of_bcd_contents'/Int8ub, 'ton_npi'/Int8ub, - 'call_number'/BcdAdapter(Bytes(10)), + 'call_number'/PaddedBcdAdapter(Rpad(Bytes(10))), 'cap_cfg2_record_id'/Int8ub, 'ext5_record_id'/Int8ub, 'date_and_time'/BcdAdapter(Bytes(7)), @@ -612,7 +612,7 @@ self._construct = Struct('alpha_id'/Bytes(this._.total_len-27), 'len_of_bcd_contents'/Int8ub, 'ton_npi'/Int8ub, - 'call_number'/BcdAdapter(Bytes(10)), + 'call_number'/PaddedBcdAdapter(Rpad(Bytes(10))), 'cap_cfg2_record_id'/Int8ub, 'ext5_record_id'/Int8ub, 'date_and_time'/BcdAdapter(Bytes(7)), @@ -1118,7 +1118,7 @@ # responsibility of home network operator but BCD coding shall be used. If a network # operator decides to assign less than 4 digits to Routing Indicator, the remaining digits # shall be coded as "1111" to fill the 4 digits coding of Routing Indicator - self._construct = Struct('routing_indicator'/Rpad(BcdAdapter(Bytes(2)), 'f', 2), + self._construct = Struct('routing_indicator'/PaddedBcdAdapter(Rpad(Bytes(2))), 'rfu'/Bytes(2)) # TS 31.102 Section 4.4.11.13 (Rel 16) diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index d37715f..70c38b1 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -152,7 +152,7 @@ self._construct = Struct('alpha_id'/COptional(GsmOrUcs2Adapter(Rpad(Bytes(this._.total_len-14)))), 'len_of_bcd'/Int8ub, 'ton_npi'/TonNpi, - 'dialing_nr'/ExtendedBcdAdapter(BcdAdapter(Rpad(Bytes(10)))), + 'dialing_nr'/ExtendedBcdAdapter(PaddedBcdAdapter(Rpad(Bytes(10)))), 'cap_conf_id'/Int8ub, ext_name/Int8ub) @@ -193,11 +193,11 @@ ( 'ffffffffffffffffffffffffffffffffffffffff04b12143f5ffffffffffffffffff', {"alpha_id": "", "len_of_bcd": 4, "ton_npi": {"ext": True, "type_of_number": "network_specific", "numbering_plan_id": "isdn_e164"}, - "dialing_nr": "12345f"}), + "dialing_nr": "12345"}), ( '456967656e65205275666e756d6d6572ffffffff0891947172199181f3ffffffffff', {"alpha_id": "Eigene Rufnummer", "len_of_bcd": 8, "ton_npi": {"ext": True, "type_of_number": "international", "numbering_plan_id": "isdn_e164"}, - "dialing_nr": "4917279119183f"}), + "dialing_nr": "4917279119183"}), ] # Ensure deprecated representations still work @@ -215,7 +215,7 @@ self._construct = Struct('alpha_id'/COptional(GsmOrUcs2Adapter(Rpad(Bytes(this._.total_len-14)))), 'len_of_bcd'/Int8ub, 'ton_npi'/TonNpi, - 'dialing_nr'/ExtendedBcdAdapter(BcdAdapter(Rpad(Bytes(10)))), + 'dialing_nr'/ExtendedBcdAdapter(PaddedBcdAdapter(Rpad(Bytes(10)))), Padding(2, pattern=b'\xff')) # Maintain compatibility with deprecated representations @@ -661,12 +661,12 @@ # TS 51.011 Section 10.3.20 / 10.3.22 class EF_VGCS(TransRecEF): _test_de_encode = [ - ( "92f9ffff", "299fffff" ), + ( "92f9ffff", "299" ), ] def __init__(self, fid='6fb1', sfid=None, name='EF.VGCS', size=(4, 200), rec_len=4, desc='Voice Group Call Service', **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, rec_len=rec_len, **kwargs) - self._construct = BcdAdapter(Bytes(4)) + self._construct = PaddedBcdAdapter(Rpad(Bytes(4))) # TS 51.011 Section 10.3.21 / 10.3.23 class EF_VGCSS(TransparentEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4571482da924a3d645caa297108279d182448d21 Gerrit-Change-Number: 41742 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log