- gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: personalization: fix SdKey.apply_val() implementation
by neels 07 Jan '26

07 Jan '26

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40203?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: personalization: fix SdKey.apply_val() implementation ...................................................................... personalization: fix SdKey.apply_val() implementation 'securityDomain' elements are decoded to ProfileElementSD instances, which keep higher level representations of the key data apart from the decoded[] lists. So far, apply_val() was dropping binary values in decoded[], which does not work, because ProfileElementSD._pre_encode() overwrites self.decoded[] from the higher level representation. Implement using - ProfileElementSD.find_key() and SecurityDomainKeyComponent to modify an exsiting entry, or - ProfileElementSD.add_key() to create a new entry. Before this patch, SdKey parameters seemed to patch PES successfully, but their modifications did not end up in the encoded DER. (BTW, this does not fix any other errors that may still be present in the various SdKey subclasses, patches coming up.) Related: SYS#6768 Change-Id: I07dfc378705eba1318e9e8652796cbde106c6a52 --- M pySim/esim/saip/__init__.py M pySim/esim/saip/personalization.py 2 files changed, 40 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/03/40203/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I07dfc378705eba1318e9e8652796cbde106c6a52 Gerrit-Change-Number: 40203 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: esim param_source: add is_abstract flag
by neels 07 Jan '26

07 Jan '26

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40206?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: esim param_source: add is_abstract flag ...................................................................... esim param_source: add is_abstract flag Allow omitting some ParamSource subclassed from ParamSource.get_all_implementations(). My previous attempts at automagically detecting abstract classes failed conceptually, and the easiest, most explicit way is already used in ConfigurableParameter: add an is_abstract flag. Prep for Ie7171c152a7b478736f8825050305606b5af5735 Change-Id: Icfccdd0a8ecb5e0e9d22afa490d73c9f1849a64c --- M pySim/esim/saip/param_source.py M pySim/esim/saip/personalization.py 2 files changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/06/40206/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icfccdd0a8ecb5e0e9d22afa490d73c9f1849a64c Gerrit-Change-Number: 40206 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: param_source: allow input val expansion like '0 * 32'
by neels 07 Jan '26

07 Jan '26

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40207?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: param_source: allow input val expansion like '0 * 32' ...................................................................... param_source: allow input val expansion like '0 * 32' Working with keys, we often generate 4, 8, 16, 32 digit wide random values. Those then typically have default input values like 00000000000000000000000000000000 it is hard for humans to count the number of digits. Much easier: 00*16 Teach the ParamSource subclasses dealing with random values to understand an expansion like this. Any expansion is carried out before all other input value handling. Use this expansion also in the default_value of ConfigurableParameter subclasses that have a default_source pointing at a ParamSource that now understand this expansion. Related: SYS#6768 Change-Id: Ie7171c152a7b478736f8825050305606b5af5735 --- M pySim/esim/saip/param_source.py M pySim/esim/saip/personalization.py 2 files changed, 33 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/07/40207/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie7171c152a7b478736f8825050305606b5af5735 Gerrit-Change-Number: 40207 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[M] Change in pysim[master]: personalization: implement UppAudit and BatchAudit
by neels 07 Jan '26

07 Jan '26

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40208?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: personalization: implement UppAudit and BatchAudit ...................................................................... personalization: implement UppAudit and BatchAudit Change-Id: Iaab336ca91b483ecdddd5c6c8e08dc475dc6bd0a --- M pySim/esim/saip/personalization.py 1 file changed, 224 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/08/40208/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaab336ca91b483ecdddd5c6c8e08dc475dc6bd0a Gerrit-Change-Number: 40208 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization audit: optionally audit all (unknown) SD keys
by neels 07 Jan '26

07 Jan '26

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40209?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: personalization audit: optionally audit all (unknown) SD keys ...................................................................... personalization audit: optionally audit all (unknown) SD keys By a flag, allow to audit also all Security Domain KVN that we have *not* created ConfigurableParameter subclasses for. For example, SCP80 has reserved kvn 0x01..0x0f, but we offer only Scp80Kvn01, Scp80Kvn02, Scp80Kvn03. So we would not show kvn 0x03..0x0f in an audit. This patch includes audits of all SD key kvn there may be in the UPP. This will help to spot SD keys that may already be present in a UPP template, with unexpected / unusual kvn. Change-Id: Icaf6f7b589f117868633c0968a99f2f0252cf612 --- M pySim/esim/saip/personalization.py 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/09/40209/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icaf6f7b589f117868633c0968a99f2f0252cf612 Gerrit-Change-Number: 40209 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: add lint_ruff.sh
by neels 07 Jan '26

07 Jan '26

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40740?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: add lint_ruff.sh ...................................................................... add lint_ruff.sh Change-Id: I9ca385eef9e6831a49f61456aa24492d4fa2ec17 --- A lint_ruff.sh A ruff.toml 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/40740/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ca385eef9e6831a49f61456aa24492d4fa2ec17 Gerrit-Change-Number: 40740 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: saip: rework file sizes for "half-defined" template files
by neels 06 Jan '26

06 Jan '26

Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41686?usp=email ) Change subject: saip: rework file sizes for "half-defined" template files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7c4a0914aef1049a416e6b091f23daab39a1dd9c Gerrit-Change-Number: 41686 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 06 Jan 2026 22:42:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: saip: calculate the number of records for LF and CY
by neels 06 Jan '26

06 Jan '26

Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41687?usp=email ) Change subject: saip: calculate the number of records for LF and CY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5ec1757d6852eb24d3662ec1c3fc88365e90a616 Gerrit-Change-Number: 41687 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 06 Jan 2026 22:42:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_*
by laforge 06 Jan '26

06 Jan '26

Attention is currently required from: dexter, pespin. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email ) Change subject: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_* ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/core/msgb.c: https://gerrit.osmocom.org/c/libosmocore/+/36324/comment/dd69d148_4a1a6844?… : PS1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb part is not copied. > I wonder how much the performance impact of copying the cb buffer would be. […] let's update the documentation and get this merged. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5 Gerrit-Change-Number: 36324 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jan 2026 21:42:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: cosmetic: fix company name in copyright header.
by laforge 06 Jan '26

06 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41767?usp=email ) Change subject: cosmetic: fix company name in copyright header. ...................................................................... cosmetic: fix company name in copyright header. The correct abbreviated version of the company name is "sysmocom - s.f.m.c. GmbH", i.e. lowercase and with dash. Change-Id: Id768d2f4b78162ff83320a800e4e66f1bd324d6d --- M pySim/card_handler.py M pySim/card_key_provider.py M pySim/global_platform/install_param.py M pySim/javacard.py M pySim/log.py M pySim/profile.py M tests/pySim-prog_test/pySim-prog_test.sh M tests/pySim-trace_test/pySim-trace_test.sh M tests/unittests/test_log.py 9 files changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/card_handler.py b/pySim/card_handler.py index e7884ad..f081b90 100644 --- a/pySim/card_handler.py +++ b/pySim/card_handler.py @@ -7,7 +7,7 @@ """ # -# (C) 2019 by Sysmocom s.f.m.c. GmbH +# (C) 2019 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # This program is free software: you can redistribute it and/or modify diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py index f614edc..227046c 100644 --- a/pySim/card_key_provider.py +++ b/pySim/card_key_provider.py @@ -10,7 +10,7 @@ operation with pySim-shell. """ -# (C) 2021-2025 by Sysmocom s.f.m.c. GmbH +# (C) 2021-2025 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # Author: Philipp Maier, Harald Welte diff --git a/pySim/global_platform/install_param.py b/pySim/global_platform/install_param.py index ec0ef66..89e6c7f 100644 --- a/pySim/global_platform/install_param.py +++ b/pySim/global_platform/install_param.py @@ -1,6 +1,6 @@ # GlobalPlatform install parameter generator # -# (C) 2024 by Sysmocom s.f.m.c. GmbH +# (C) 2024 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # This program is free software: you can redistribute it and/or modify diff --git a/pySim/javacard.py b/pySim/javacard.py index 2d4fd34..2c97fac 100644 --- a/pySim/javacard.py +++ b/pySim/javacard.py @@ -1,6 +1,6 @@ # JavaCard related utilities # -# (C) 2024 by Sysmocom s.f.m.c. GmbH +# (C) 2024 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # This program is free software: you can redistribute it and/or modify diff --git a/pySim/log.py b/pySim/log.py index a2325a6..c7e5239 100644 --- a/pySim/log.py +++ b/pySim/log.py @@ -4,7 +4,7 @@ """ # -# (C) 2025 by Sysmocom s.f.m.c. GmbH +# (C) 2025 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # Author: Philipp Maier <pmaier(a)sysmocom.de> diff --git a/pySim/profile.py b/pySim/profile.py index 360aa46..22db21c 100644 --- a/pySim/profile.py +++ b/pySim/profile.py @@ -4,7 +4,7 @@ """ # -# (C) 2021 by Sysmocom s.f.m.c. GmbH +# (C) 2021 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # This program is free software: you can redistribute it and/or modify diff --git a/tests/pySim-prog_test/pySim-prog_test.sh b/tests/pySim-prog_test/pySim-prog_test.sh index 9279c6c..6541acb 100755 --- a/tests/pySim-prog_test/pySim-prog_test.sh +++ b/tests/pySim-prog_test/pySim-prog_test.sh @@ -2,7 +2,7 @@ # Utility to verify the functionality of pySim-prog.py # -# (C) 2018 by Sysmocom s.f.m.c. GmbH +# (C) 2018 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # Author: Philipp Maier diff --git a/tests/pySim-trace_test/pySim-trace_test.sh b/tests/pySim-trace_test/pySim-trace_test.sh index ec23ad3..0a9fb47 100755 --- a/tests/pySim-trace_test/pySim-trace_test.sh +++ b/tests/pySim-trace_test/pySim-trace_test.sh @@ -2,7 +2,7 @@ # Utility to verify the functionality of pySim-trace.py # -# (C) 2023 by Sysmocom s.f.m.c. GmbH +# (C) 2023 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # Author: Philipp Maier diff --git a/tests/unittests/test_log.py b/tests/unittests/test_log.py index cc67b78..6a0f7ff 100755 --- a/tests/unittests/test_log.py +++ b/tests/unittests/test_log.py @@ -1,6 +1,6 @@ #!/usr/bin/env python3 -# (C) 2025 by Sysmocom s.f.m.c. GmbH +# (C) 2025 by sysmocom - s.f.m.c. GmbH # All Rights Reserved # # Author: Philipp Maier <pmaier(a)sysmocom.de> -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41767?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id768d2f4b78162ff83320a800e4e66f1bd324d6d Gerrit-Change-Number: 41767 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022