- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: Print SMSC in read mode
by phcoder 09 Jan '26

09 Jan '26

phcoder has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email ) Change subject: Print SMSC in read mode ...................................................................... Print SMSC in read mode Change-Id: I17067b68086316d51fd71ba77049874605594e3f --- M pySim-read.py M pySim/legacy/utils.py 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/41786/1 diff --git a/pySim-read.py b/pySim-read.py index 9829a15..ab2049b 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -43,7 +43,7 @@ from pySim.exceptions import SwMatchError from pySim.legacy.cards import card_detect, SimCard, UsimCard, IsimCard from pySim.utils import dec_imsi, dec_iccid -from pySim.legacy.utils import format_xplmn_w_act, dec_st, dec_msisdn +from pySim.legacy.utils import format_xplmn_w_act, dec_st, dec_msisdn, dec_smsc_from_smsp option_parser = argparse.ArgumentParser(description='Legacy tool for reading some parts of a SIM card', formatter_class=argparse.ArgumentDefaultsHelpFormatter) @@ -141,6 +141,7 @@ (res, sw) = card.read_record('SMSP', 1) if sw == '9000': print("SMSP: %s" % (res,)) + print("SMSC: %s" % (dec_smsc_from_smsp(res),)) else: print("SMSP: Can't read, response code = %s" % (sw,)) diff --git a/pySim/legacy/utils.py b/pySim/legacy/utils.py index 49c8633..f96e318 100644 --- a/pySim/legacy/utils.py +++ b/pySim/legacy/utils.py @@ -334,6 +334,16 @@ return s +def dec_smsc_from_smsp(smsp): + y = (len(smsp) // 2) - 28 + if y <= 0: + return (None, sw) + tp_sca = smsp[((y+14)*2):((y+25)*2)] + prefix = '+' if tp_sca[0:2] == '91' else '' + + return prefix + swap_nibbles(tp_sca[2:]).rstrip('f') + + def dec_msisdn(ef_msisdn: Hexstr) -> Optional[Tuple[int, int, Optional[str]]]: """ Decode MSISDN from EF.MSISDN or EF.ADN (same structure). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 1 Gerrit-Owner: phcoder <phcoder(a)gmail.com>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by laforge 08 Jan '26

08 Jan '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email ) Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 20:25:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by pespin 08 Jan '26

08 Jan '26

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email to look at the new patch set (#2). Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl Fix following sporadic race condition: TTCN-MS IUTS-BTS TTCN-BSC | |<----CHAN_ACT------| |<--SACCH(A)-- | | | |<--MS_PWR_CTRL(B)- | |<--SACCH(B)---| Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 --- M bts/BTS_Tests.ttcn 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/41785/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporafic failure in TC_rsl_ms_pwr_ctrl
by pespin 08 Jan '26

08 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email ) Change subject: bts: Fix sporafic failure in TC_rsl_ms_pwr_ctrl ...................................................................... bts: Fix sporafic failure in TC_rsl_ms_pwr_ctrl Fix following sporadic race condition: TTCN-MS IUTS-BTS TTCN-BSC | |<----CHAN_ACT------| |<--SACCH(A)-- | | | |<--MS_PWR_CTRL(B)- | |<--SACCH(B)---| Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 --- M bts/BTS_Tests.ttcn 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/41785/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 26fe18d..b2d7252 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -3834,6 +3834,7 @@ private function f_tc_rsl_ms_pwr_ctrl(charstring id) runs on ConnHdlr { var SacchL1Header l1h; var uint5_t power_level := 0; + var boolean first_after_wait := true; f_l1_tune(L1CTL); RSL.clear; @@ -3849,10 +3850,18 @@ alt { [] as_l1_sacch_l1h(l1h, do_apply := false) { if (l1h.ms_power_lvl != power_level) { - setverdict(fail, "Power level := ", l1h.ms_power_lvl, "does not ", - "match the signaled (RSL) power level := ", power_level); - Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + if (first_after_wait) { + /* It may happen that BTS transmits SACCH before it receives our RSL MS POWER CONTROL: */ + log("Power level := ", l1h.ms_power_lvl, " does not ", + "match the signaled (RSL) power level := ", power_level); + first_after_wait := false; + repeat; + } + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Power level := ", l1h.ms_power_lvl, " does not ", + "match the signaled (RSL) power level := ", power_level)); } + first_after_wait := true; /* Signal a new power level via RSL for the next turn. */ if (power_level < 31) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: set example input values
by laforge 08 Jan '26

08 Jan '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40094?usp=email ) Change subject: personalization: set example input values ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2672fedcbc32cb7a6cb0c233a4a22112bd9aae03 Gerrit-Change-Number: 40094 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 15:02:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: personalization: refactor SmspTpScAddr
by laforge 08 Jan '26

08 Jan '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41779?usp=email ) Change subject: personalization: refactor SmspTpScAddr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2600369e195e9f5aed7f4e6ff99ae273ed3ab3bf Gerrit-Change-Number: 41779 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 15:01:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: personalization: refactor SmspTpScAddr
by laforge 08 Jan '26

08 Jan '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41779?usp=email ) Change subject: personalization: refactor SmspTpScAddr ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41779/comment/cff9854e_eccc28d3?usp=em… : PS1, Line 362: val must be a tuple (international[bool], digits[str]) this should be given as type annotation instead of a comment. I realize that the original code didn't have it, but if you're adding that missing annotation, please do it in a way that benefits both linters and the human developer instead of just the latter. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2600369e195e9f5aed7f4e6ff99ae273ed3ab3bf Gerrit-Change-Number: 41779 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 14:57:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in pysim[master]: personalization: refactor ConfigurableParameter, Iccid, Imsi
by laforge 08 Jan '26

08 Jan '26

Attention is currently required from: dexter, fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 14: -Code-Review (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/b7cf3efb_5b554be9?usp=em… : PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the > abc has no purpose and it doesn't work. My gist was that it doesn't solve exactly the problem you are trying to solve, but that doesn't mean it has no porpose and doesn't work. > The first time this comment came up, I tried to use abc to determine which ConfigurableParameter classes are abstract. This did not work at all. Sadly code review (particularly dragging on over the better part of a year so everyone forgets about what exactly was discussed before) is not a method of how you could demonstrate what exactly was not working in which way exactly. In such instances I would appreciate a "this is the branch containing what I tried, and it does not do XYZ while I'm trying to achieve ABC". > Adding empty cruft to code is not what I do. You sound like adding type annotations is also empty cruft? If a class is not supposed to be used directly, but only inherited by other classes (one of which finally being none-abstract), it's an abstract base class. Adding the annotation by inheriting from abc.ABC shows that at the very least to whoever is reading the code, and ideally also allows the python runtime to raise meaningful exceptions if someone ever should try to instantiate the ABC directly. If you don't do that, people could just instantiate your class. > the logical reason to change the patch is simply not present. I would love to accept your point, but explain to me why exactly you want to see abc in there. The logical point is simply: there is a python standard library method of declaring "this class is abstract and shall not be instantiated directly". If your class falls into that category, it should be declared that way. Furthermore, the code contains abc.abstractmethod decorator on a class that is not an ABC. According to the documentation this violates the abc module requirements: ``` A decorator indicating abstract methods. Using this decorator requires that the class’s metaclass is ABCMeta or is derived from it. See https://docs.python.org/3/library/abc.html#abc.abstractmethod ``` > If the reason is cosmetic, then let me know. > I will disagree and i will still have to use a simple boolean flag to make it work as it should, You may need to do that, to solve your specific problem (different from what abc may solve). But to this point, after lots of code review I still don't fully understand the full picture, especially as I have no example/branch of "what doesn't work". I'm not trying to undestand everything in the review of this specific patch, but I'm merely saying * if the class is abstract it should be labelled as such * if you use abc.abstractmethod, the python standard library documentation says you must also mark the class as ABC I'm not saying the above is solving all of your problems in the way you are trying to solve them. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 14 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 14:54:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: expected-results.xml: Add missing BTS_Tests_OML entries
by pespin 08 Jan '26

08 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41775?usp=email ) Change subject: bts: expected-results.xml: Add missing BTS_Tests_OML entries ...................................................................... bts: expected-results.xml: Add missing BTS_Tests_OML entries Change-Id: Ie72350a313743e0b65d14fc75be9139e513111b4 --- M bts/expected-results.xml 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/bts/expected-results.xml b/bts/expected-results.xml index ca5ad2f..88afda9 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -268,4 +268,20 @@ <testcase classname='BTS_Tests_ASCI' name='TC_vgcs_talker_fail' time='MASKED'/> <testcase classname='BTS_Tests_ASCI' name='TC_vgcs_talker_est_rel' time='MASKED'/> <testcase classname='BTS_Tests_ASCI' name='TC_vgcs_listener_det' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_wrong_mdisc' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_short_length' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_long_length' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_wrong_placement' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_wrong_seq' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_wrong_obj_class' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_wrong_bts_nr' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_wrong_trx_nr' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_radio_carrier_opstart_noattr' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_bts_opstart' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_bts_opstart_noattr' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_ts_opstart' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_ts_opstart_noattr' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_initial_state_reports' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_ipa_osmo_pcu_anr_fwd' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_ipa_rsl_connect_nack' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41775?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie72350a313743e0b65d14fc75be9139e513111b4 Gerrit-Change-Number: 41775 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count
by laforge 08 Jan '26

08 Jan '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email ) Change subject: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I887bd80a90e3ef8142cc29acde2ac9a3ea4869d6 Gerrit-Change-Number: 41783 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 14:38:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log