pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email )
Change subject: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering
......................................................................
bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering
One can see with the following failing output below that the Tguard is
too low:
"""
13:36:12.459089 5684 BTS_Tests.ttcn:2836 Reached full power, wating a bit more until success
13:36:12.459097 5684 BTS_Tests.ttcn:2837 Start timer T: 2 s
13:36:14.358525 5684 Misc_Helpers.ttcn:35 setverdict(fail): pass -> fail reason: ""BTS_Tests.ttcn:729 : Tguard timeout"", new component reason: ""BTS_Tests.ttcn:729 : Tguard timeout""
"""
Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb
---
M bts/BTS_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index c681da9..b060cbd 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -3035,7 +3035,7 @@
var ConnHdlr vc_conn;
var ConnHdlrPars pars;
f_init();
- pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN));
+ pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, t_guard := 60.0));
vc_conn := f_start_handler(refers(f_TC_tx_power_ramp_adm_state_change), pars,
pcu_comp := false, trxc_comp := true);
vc_conn.done;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb
Gerrit-Change-Number: 41809
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email )
Change subject: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering
......................................................................
Patch Set 1:
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809/comment/907b66a3_4ec1… :
PS1, Line 3038: pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, t_guard := 60.0));
> 60s seems very high. […]
No, the current value of Tguard is 20-30 seconds.
Setting it to 60s is totally fine since that time amount should only be wasted in the event this test fails due to Tguard timeout, which shouldn't usually happen.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb
Gerrit-Change-Number: 41809
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Jan 2026 12:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email )
Change subject: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero initialized
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/41773/comment/369451dc_1d02a81f?usp… :
PS1, Line 7: struct input_signal_data is zero initialized
What's the goal of doing that? Keep in mind that only the actual struct fields are initialized when using designated initializers, but not padding. So ASAN/UBSAN may still complain when `memcpy()ing` this structure.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c
Gerrit-Change-Number: 41773
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Jan 2026 12:31:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email )
Change subject: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809/comment/91020a42_c08c… :
PS1, Line 3038: pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, t_guard := 60.0));
60s seems very high. If the current value is 2s, maybe set it to 10s instead?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb
Gerrit-Change-Number: 41809
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Jan 2026 12:29:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes