- gerrit-log - lists.osmocom.org

[XS] Change in osmo-pcu[master]: csn1.h: Fix missing include stddef.h for offsetof()
by fixeria 20 Jan '26

20 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcu/+/41886?usp=email ) Change subject: csn1.h: Fix missing include stddef.h for offsetof() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/41886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3ddd10dd67e7850ace36ac996598cbfd4bbaa40e Gerrit-Change-Number: 41886 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jan 2026 13:03:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-trx[master]: Drop logging of stderr loglvel at startup
by pespin 20 Jan '26

20 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/41889?usp=email ) Change subject: Drop logging of stderr loglvel at startup ...................................................................... Drop logging of stderr loglvel at startup Nowadays there's far better ways to figure out logging, like checking through VTY. For instnace, that loglevel is the general log level of the stderr target, but says nothing about specific categories, or other log targets, etc. Furthermore, this way we get rid of only access to struct log_target from libosmocore, which should be private. Change-Id: Ibaf1bdc09ddfa0ece86da42685ced2f2504d970d --- M Transceiver52M/osmo-trx.cpp 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/89/41889/1 diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index c460e98..342c9eb 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -547,7 +547,6 @@ std::ostringstream ost(""); ost << "Config Settings" << std::endl; - ost << " Log Level............... " << (unsigned int) osmo_stderr_target->loglevel << std::endl; ost << " Device args............. " << charp2str(trx->cfg.dev_args) << std::endl; ost << " TRX Base Port........... " << trx->cfg.base_port << std::endl; ost << " TRX Address............. " << charp2str(trx->cfg.bind_addr) << std::endl; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/41889?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ibaf1bdc09ddfa0ece86da42685ced2f2504d970d Gerrit-Change-Number: 41889 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-gbproxy[master]: Avoid accessing struct log_target members directly
by pespin 20 Jan '26

20 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/41888?usp=email ) Change subject: Avoid accessing struct log_target members directly ...................................................................... Avoid accessing struct log_target members directly Use newly available APIs instead. Depends: libosmocore.git Change-Id Ie48e7e635feb91509b9c034394df4fb16cb931a3 Change-Id: I3d33a8d80d13835be21742f98d2357a3447c8374 --- M TODO-RELEASE M src/gb_proxy_vty.c 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/88/41888/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..fb115da 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmocore >1.12.0 log_get_context(), log_{get,set}_filter(_data)() diff --git a/src/gb_proxy_vty.c b/src/gb_proxy_vty.c index e5f53e2..80daac3 100644 --- a/src/gb_proxy_vty.c +++ b/src/gb_proxy_vty.c @@ -474,11 +474,11 @@ { if (bvci) { uintptr_t bvci_filter = *bvci | BVC_LOG_CTX_FLAG; - target->filter_map |= (1 << LOG_FLT_GB_BVC); - target->filter_data[LOG_FLT_GB_BVC] = (void *)bvci_filter; - } else if (target->filter_data[LOG_FLT_GB_BVC]) { - target->filter_map = ~(1 << LOG_FLT_GB_BVC); - target->filter_data[LOG_FLT_GB_BVC] = NULL; + log_set_filter(target, LOG_FLT_GB_BVC, true); + log_set_filter_data(target, LOG_FLT_GB_BVC, (void *)bvci_filter); + } else if (log_get_filter(target, LOG_FLT_GB_BVC)) { + log_set_filter(target, LOG_FLT_GB_BVC, false); + log_set_filter_data(target, LOG_FLT_GB_BVC, NULL); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/41888?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I3d33a8d80d13835be21742f98d2357a3447c8374 Gerrit-Change-Number: 41888 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use HAVE_IN6...
by Timur Davydov 20 Jan '26

20 Jan '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41887?usp=email ) Change subject: Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use HAVE_IN6_ADDR_S6_ADDR32 instead of __linux__. ...................................................................... Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use HAVE_IN6_ADDR_S6_ADDR32 instead of __linux__. No functional changes intended, this is a preparatory refactor to keep follow-up patches focused and easier to review. Change-Id: I29385fde0f1e6c6cc73cd1488befdef9040cc28e --- M configure.ac M src/core/socket.c 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/41887/1 diff --git a/configure.ac b/configure.ac index 64690f9..4a6a474 100644 --- a/configure.ac +++ b/configure.ac @@ -86,6 +86,13 @@ AC_CHECK_LIB(execinfo, backtrace, BACKTRACE_LIB=-lexecinfo, BACKTRACE_LIB=) AC_SUBST(BACKTRACE_LIB) +# check for struct in6_addr has s6_addr32 field +AC_CHECK_MEMBER([struct in6_addr.s6_addr32], + [AC_DEFINE([HAVE_IN6_ADDR_S6_ADDR32], [1], + [Define if struct in6_addr has s6_addr32 field])], + [], + [[#include <netinet/in.h>]]) + # check for pthread (PTHREAD_CFLAGS, PTHREAD_LIBS) AX_PTHREAD diff --git a/src/core/socket.c b/src/core/socket.c index bb32185..2de4bb3 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -1695,7 +1695,7 @@ static unsigned int in6_addr_netmask_to_prefixlen(const struct in6_addr *netmask) { - #if defined(__linux__) + #if (HAVE_IN6_ADDR_S6_ADDR32) #define ADDRFIELD(i) s6_addr32[i] #else #define ADDRFIELD(i) __u6_addr.__u6_addr32[i] -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41887?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I29385fde0f1e6c6cc73cd1488befdef9040cc28e Gerrit-Change-Number: 41887 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in osmo-pcu[master]: Avoid accessing struct log_target members directly
by osmith 20 Jan '26

20 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcu/+/41881?usp=email ) Change subject: Avoid accessing struct log_target members directly ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/41881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib6e34e948e4ad9b8a8883febf54b31345c3bcd97 Gerrit-Change-Number: 41881 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jan 2026 12:57:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcu[master]: csn1.h: Fix missing include stddef.h for offsetof()
by osmith 20 Jan '26

20 Jan '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcu/+/41886?usp=email ) Change subject: csn1.h: Fix missing include stddef.h for offsetof() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/41886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3ddd10dd67e7850ace36ac996598cbfd4bbaa40e Gerrit-Change-Number: 41886 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jan 2026 12:56:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcu[master]: csn1.h: Fix missing include stddef.h for offsetof()
by pespin 20 Jan '26

20 Jan '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcu/+/41886?usp=email ) Change subject: csn1.h: Fix missing include stddef.h for offsetof() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is already fixed in the libosmo-gprs version of csn1.h. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/41886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3ddd10dd67e7850ace36ac996598cbfd4bbaa40e Gerrit-Change-Number: 41886 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jan 2026 12:55:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-pcu[master]: csn1.h: Fix missing include stddef.h for offsetof()
by pespin 20 Jan '26

20 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/41886?usp=email ) Change subject: csn1.h: Fix missing include stddef.h for offsetof() ...................................................................... csn1.h: Fix missing include stddef.h for offsetof() Fixes following compiler error: """ In file included from /osmo-pcu/src/gsm_rlcmac.c:32: /osmo-pcu/src/csn1.h:310:32: error: implicit declaration of function 'offsetof' [-Wimplicit-function-declaration] 310 | {CSN_UINT, _BITS, {0}, offsetof(_STRUCT, _MEMBER), FALSE, #_MEMBER, 0, NULL} | ^~~~~~~~ /osmo-pcu/src/gsm_rlcmac.c:43:3: note: in expansion of macro 'M_UINT' 43 | M_UINT (PLMN_t, MCC2, 4), | ^~~~~~ /osmo-pcu/src/gsm_rlcmac.c:38:1: note: 'offsetof' is defined in header '<stddef.h>'; this is probably fixable by adding '#include <stddef.h>' 37 | #include <gprs_debug.h> +++ |+#include <stddef.h> """ Change-Id: I3ddd10dd67e7850ace36ac996598cbfd4bbaa40e --- M src/csn1.h 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/86/41886/1 diff --git a/src/csn1.h b/src/csn1.h index 6607b02..66e67ba 100644 --- a/src/csn1.h +++ b/src/csn1.h @@ -24,6 +24,8 @@ #ifndef _PACKET_CSN1_H_ #define _PACKET_CSN1_H_ +#include <stddef.h> + #include <osmocom/core/bitvec.h> #include "wireshark_compat.h" -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/41886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3ddd10dd67e7850ace36ac996598cbfd4bbaa40e Gerrit-Change-Number: 41886 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: tests: Use log_set_category_filter() libosmocore API
by pespin 20 Jan '26

20 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41885?usp=email ) Change subject: tests: Use log_set_category_filter() libosmocore API ...................................................................... tests: Use log_set_category_filter() libosmocore API Change-Id: I70d885110d5dd8295136c16f2365efeed443ff1a --- M tests/handover/handover_test.c M tests/power/bs_power_loop_test.c M tests/power/ms_power_loop_test.c M tests/tx_power/tx_power_test.c 4 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/85/41885/1 diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index f1235f5..60496ad 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -70,7 +70,7 @@ msgb_talloc_ctx_init(tall_bts_ctx, 0); osmo_init_logging2(tall_bts_ctx, &bts_log_info); - osmo_stderr_target->categories[DHO].loglevel = LOGL_DEBUG; + log_set_category_filter(osmo_stderr_target, DHO, 1, LOGL_DEBUG); g_bts_sm = gsm_bts_sm_alloc(tall_bts_ctx); if (!g_bts_sm) { diff --git a/tests/power/bs_power_loop_test.c b/tests/power/bs_power_loop_test.c index c01aa5f..7042c34 100644 --- a/tests/power/bs_power_loop_test.c +++ b/tests/power/bs_power_loop_test.c @@ -490,8 +490,8 @@ msgb_talloc_ctx_init(tall_bts_ctx, 0); osmo_init_logging2(tall_bts_ctx, &bts_log_info); - osmo_stderr_target->categories[DLOOP].loglevel = LOGL_DEBUG; - osmo_stderr_target->categories[DL1C].loglevel = LOGL_DEBUG; + log_set_category_filter(osmo_stderr_target, DLOOP, 1, LOGL_DEBUG); + log_set_category_filter(osmo_stderr_target, DL1C, 1, LOGL_DEBUG); log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); log_set_use_color(osmo_stderr_target, 0); log_set_print_category(osmo_stderr_target, 0); diff --git a/tests/power/ms_power_loop_test.c b/tests/power/ms_power_loop_test.c index 55a70ed..cb394c8 100644 --- a/tests/power/ms_power_loop_test.c +++ b/tests/power/ms_power_loop_test.c @@ -413,8 +413,8 @@ msgb_talloc_ctx_init(tall_bts_ctx, 0); osmo_init_logging2(tall_bts_ctx, &bts_log_info); - osmo_stderr_target->categories[DLOOP].loglevel = LOGL_DEBUG; - osmo_stderr_target->categories[DL1C].loglevel = LOGL_DEBUG; + log_set_category_filter(osmo_stderr_target, DLOOP, 1, LOGL_DEBUG); + log_set_category_filter(osmo_stderr_target, DL1C, 1, LOGL_DEBUG); log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); log_set_use_color(osmo_stderr_target, 0); log_set_print_category(osmo_stderr_target, 0); diff --git a/tests/tx_power/tx_power_test.c b/tests/tx_power/tx_power_test.c index e0f88bc..a18a331 100644 --- a/tests/tx_power/tx_power_test.c +++ b/tests/tx_power/tx_power_test.c @@ -247,7 +247,7 @@ msgb_talloc_ctx_init(tall_bts_ctx, 0); osmo_init_logging2(tall_bts_ctx, &bts_log_info); - osmo_stderr_target->categories[DL1C].loglevel = LOGL_DEBUG; + log_set_category_filter(osmo_stderr_target, DL1C, 1, LOGL_DEBUG); log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); log_set_use_color(osmo_stderr_target, 0); log_set_print_category(osmo_stderr_target, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41885?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I70d885110d5dd8295136c16f2365efeed443ff1a Gerrit-Change-Number: 41885 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: build: move netns/tun conditionals to configure.ac Move Linux-/embedd...
by Timur Davydov 20 Jan '26

20 Jan '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email ) Change subject: build: move netns/tun conditionals to configure.ac Move Linux-/embedded-specific conditional compilation out of the sources and into configure.ac. ...................................................................... Patch Set 1: (5 comments) Patchset: PS1: > You are again mixing different unrelated stuff in the same patch, which is confusing when reviewing […] Got it. I'll rework this and resend it split into separate orthogonal commits. Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/ecdd1cef_93022584?… : PS1, Line 12: - Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use > This should be a separate commit, since it's not related at all to the other ones. Got it. I'll rework this and resend it split into separate orthogonal commits. File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/6f740b5a_8c5b3fab?… : PS1, Line 242: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes") > Why are you adding ENABLE_TUN? It's never set to "no". ENABLE_TUN is meant to be the inverse of EMBEDDED, so that tun.c is not built for --enable-embedded. I added it for readability and to make extending the condition easier later (e.g. Emscripten). File include/osmocom/core/netns.h: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/4b1a0aa0_944ca6a8?… : PS1, Line 5: #if (USE_NETNS) > if netns is not supported, modify Makefile.am to avoid adding this file to the buildset. Understood. I'll handle this in a separate patch. File src/core/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/8d202844_7c4aa79a?… : PS1, Line 83: if ENABLE_TUN > WHy this? AFAICT it can ever be false? ENABLE_TUN is meant to be the inverse of EMBEDDED, so that tun.c is not built for --enable-embedded. I added it for readability and to make extending the condition easier later (e.g. Emscripten). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jan 2026 12:50:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log