- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pySim-trace: pySim.apdu_source.stdin_hex
by laforge 21 Jan '26

21 Jan '26

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37925?usp=email ) Change subject: pySim-trace: pySim.apdu_source.stdin_hex ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/37925/comment/3cc5b738_e450ec9d?usp=em… : PS1, Line 7: pySim.apdu_source.stdin_hex > I think it would be good to write a sentence or two what this is patch is about and how it can be us […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jan 2026 07:17:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: saip.validation: Verify unused mandatory services in header
by laforge 21 Jan '26

21 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41835?usp=email ) Change subject: saip.validation: Verify unused mandatory services in header ...................................................................... saip.validation: Verify unused mandatory services in header This adds a new check method to the pySim.esim.saip.validation.CheckBasicStructure class, which ensures that no unused authentication algorithm related mandatory services are indicated in the ProfileHeader. So if a profile e.g. states in the header it requires usim-test-algorithm, but then the actual akaParameter instances do not actually use that algorithm, it would raise an exception. Change-Id: Id0e1988ae1936a321d04bc7c3c3a33262c767d30 Related: SYS#7826 --- M pySim/esim/saip/validation.py 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/esim/saip/validation.py b/pySim/esim/saip/validation.py index 5e0323a..bf974c8 100644 --- a/pySim/esim/saip/validation.py +++ b/pySim/esim/saip/validation.py @@ -103,6 +103,26 @@ if 'profile-a-p256' in m_svcs and not ('usim' in m_svcs or 'isim' in m_svcs): raise ProfileError('profile-a-p256 mandatory, but no usim or isim') + def check_mandatory_services_aka(self, pes: ProfileElementSequence): + """Ensure that no unnecessary authentication related services are marked as mandatory but not + actually used within the profile""" + m_svcs = pes.get_pe_for_type('header').decoded['eUICC-Mandatory-services'] + # list of tuples (algo_id, key_len_in_octets) for all the akaParameters in the PE Sequence + algo_id_klen = [(x.decoded['algoConfiguration'][1]['algorithmID'], + len(x.decoded['algoConfiguration'][1]['key'])) for x in pes.get_pes_for_type('akaParameter')] + # just a plain list of algorithm IDs in akaParameters + algorithm_ids = [x[0] for x in algo_id_klen] + if 'milenage' in m_svcs and not 1 in algorithm_ids: + raise ProfileError('milenage mandatory, but no related algorithm_id in akaParameter') + if 'tuak128' in m_svcs and not (2, 128/8) in algo_id_klen: + raise ProfileError('tuak128 mandatory, but no related algorithm_id in akaParameter') + if 'cave' in m_svcs and not pes.get_pe_for_type('cdmaParameter'): + raise ProfileError('cave mandatory, but no related cdmaParameter') + if 'tuak256' in m_svcs and (2, 256/8) in algo_id_klen: + raise ProfileError('tuak256 mandatory, but no related algorithm_id in akaParameter') + if 'usim-test-algorithm' in m_svcs and not 3 in algorithm_ids: + raise ProfileError('usim-test-algorithm mandatory, but no related algorithm_id in akaParameter') + def check_identification_unique(self, pes: ProfileElementSequence): """Ensure that each PE has a unique identification value.""" id_list = [pe.header['identification'] for pe in pes.pe_list if pe.header] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id0e1988ae1936a321d04bc7c3c3a33262c767d30 Gerrit-Change-Number: 41835 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: Fix esim.saip.ProfileElementSequence.remove_naas_of_type
by laforge 21 Jan '26

21 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41836?usp=email ) Change subject: Fix esim.saip.ProfileElementSequence.remove_naas_of_type ...................................................................... Fix esim.saip.ProfileElementSequence.remove_naas_of_type This method did not work at all at the moment, likely due to API churn over time. This change makes the following exception go away: Traceback (most recent call last): File "projects/git/pysim/contrib/saip-tool.py", line 473, in <module> do_remove_naa(pes, opts) ~~~~~~~~~~~~~^^^^^^^^^^^ File "projects/git/pysim/contrib/saip-tool.py", line 203, in do_remove_naa pes.remove_naas_of_type(naa) ~~~~~~~~~~~~~~~~~~~~~~~^^^^^ File "projects/git/pysim/contrib/pySim/esim/saip/__init__.py", line 1748, in remove_naas_of_type if template in hdr.decoded['eUICC-Mandatory-GFSTEList']: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "projects/git/pysim/contrib/pySim/esim/saip/oid.py", line 48, in __eq__ return (self.intlist == other.intlist) ^^^^^^^^^^^^^ AttributeError: 'str' object has no attribute 'intlist' A subsequent patch should introduce unit tests to avoid such breakage in the future. Change-Id: I88d862d751198c3d1648ab7f11d6e6a8fdbc41c9 --- M pySim/esim/saip/__init__.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: dexter: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 5ca87aa..6b6c01c 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -1751,8 +1751,7 @@ del hdr.decoded['eUICC-Mandatory-services'][service] # remove any associated mandatory filesystem templates for template in naa.templates: - if template in hdr.decoded['eUICC-Mandatory-GFSTEList']: - hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)] + hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)] # determine the ADF names (AIDs) of all NAA ADFs naa_adf_names = [] if naa.pe_types[0] in self.pe_by_type: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88d862d751198c3d1648ab7f11d6e6a8fdbc41c9 Gerrit-Change-Number: 41836 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in pysim[master]: Fix esim.saip.ProfileElementSequence.remove_naas_of_type
by laforge 21 Jan '26

21 Jan '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41836?usp=email ) Change subject: Fix esim.saip.ProfileElementSequence.remove_naas_of_type ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88d862d751198c3d1648ab7f11d6e6a8fdbc41c9 Gerrit-Change-Number: 41836 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 21 Jan 2026 07:15:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: saip.validation: Verify unused mandatory services in header
by laforge 21 Jan '26

21 Jan '26

Attention is currently required from: lynxis lazus, neels. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41835?usp=email ) Change subject: saip.validation: Verify unused mandatory services in header ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id0e1988ae1936a321d04bc7c3c3a33262c767d30 Gerrit-Change-Number: 41835 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 21 Jan 2026 07:15:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: Remove unused private API log_target_create_file_stream()
by laforge 21 Jan '26

21 Jan '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41893?usp=email ) Change subject: Remove unused private API log_target_create_file_stream() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia30c6b47cfcbb54e7c2c43b877cd9554dc596abf Gerrit-Change-Number: 41893 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jan 2026 06:43:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: core: always build osmo_sock_multiaddr_* helpers
by laforge 21 Jan '26

21 Jan '26

Attention is currently required from: Timur Davydov. laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email ) Change subject: core: always build osmo_sock_multiaddr_* helpers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3e70b7cd6cb4d022252e6ddc70a42ca5eea72bb1 Gerrit-Change-Number: 41895 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Jan 2026 06:42:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use HAVE_IN6...
by laforge 21 Jan '26

21 Jan '26

Attention is currently required from: Timur Davydov. laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41887?usp=email ) Change subject: Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use HAVE_IN6_ADDR_S6_ADDR32 instead of __linux__. ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41887?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I29385fde0f1e6c6cc73cd1488befdef9040cc28e Gerrit-Change-Number: 41887 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Jan 2026 06:42:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim.apdu_source.stdin_hex
by laforge 21 Jan '26

21 Jan '26

Attention is currently required from: fixeria, laforge. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37925?usp=email ) Change subject: pySim.apdu_source.stdin_hex ...................................................................... Patch Set 1: (2 comments) File pySim/apdu_source/stdin_hex.py: https://gerrit.osmocom.org/c/pysim/+/37925/comment/fef7e5fa_34b678fa?usp=em… : PS1, Line 35: command = None : response = None > Unneeded assignments? Done https://gerrit.osmocom.org/c/pysim/+/37925/comment/8ab0b894_76cf370c?usp=em… : PS1, Line 41: raise StopIteration > yeah, likely a copy+paste result. I'll revisit it. Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jan 2026 06:40:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim.apdu_source.stdin_hex
by laforge 21 Jan '26

21 Jan '26

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, dexter, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pySim.apdu_source.stdin_hex ...................................................................... pySim.apdu_source.stdin_hex Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 --- M pySim-trace.py A pySim/apdu_source/stdin_hex.py 2 files changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/25/37925/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log