- gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value
by pespin 21 Jan '26

21 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email ) Change subject: osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value ...................................................................... osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value Related: SYS#7842 Change-Id: I32822574db8997a02bf18b71bf6ab596e726cb82 --- M src/core/osmo_io.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/12/41912/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index d6cd57f..906e400 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -1068,6 +1068,7 @@ */ void osmo_iofd_set_alloc_info(struct osmo_io_fd *iofd, unsigned int size, unsigned int headroom) { + OSMO_ASSERT(size + headroom <= 0xffff); iofd->msgb_alloc.headroom = headroom; iofd->msgb_alloc.size = size; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I32822574db8997a02bf18b71bf6ab596e726cb82 Gerrit-Change-Number: 41912 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: osmo_io: Prevent abort allocating rx segment bigger than UINT16_MAX
by pespin 21 Jan '26

21 Jan '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email ) Change subject: osmo_io: Prevent abort allocating rx segment bigger than UINT16_MAX ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: I actually want to improve this patch by trying to create a new "pending msgb" up to UINT16_MAX - headroom, then caling segment callback and then if some stuff was processed, keeping copying the remaining into "pending msgb" and trying again until done. If segment_cb is returned with remaining size being UINT16_MAX - headroom, then throw an error to the user. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586 Gerrit-Change-Number: 41911 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jan 2026 18:01:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io: Reorder iofd_handle_segmented_read()
by pespin 21 Jan '26

21 Jan '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email ) Change subject: osmo_io: Reorder iofd_handle_segmented_read() ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88683334e77901776c806dad776ef46ea20b4480 Gerrit-Change-Number: 41910 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 21 Jan 2026 17:59:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in libosmocore[master]: osmo_io: Prevent abort allocating rx segment bigger than UINT16_MAX
by pespin 21 Jan '26

21 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email ) Change subject: osmo_io: Prevent abort allocating rx segment bigger than UINT16_MAX ...................................................................... osmo_io: Prevent abort allocating rx segment bigger than UINT16_MAX Avoid hitting iofd_msgb_alloc2() assert "OSMO_ASSERT(size + headroom <= 0xffff);". Our msgb implementation can only handle sizes up to 16bit in length, counting headroom + data length. Related: SYS#7842 Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586 --- M src/core/osmo_io.c 1 file changed, 18 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/11/41911/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index d6cd57f..5ef95e9 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -31,6 +31,7 @@ #include <string.h> #include <stdbool.h> #include <errno.h> +#include <inttypes.h> #include <osmocom/core/osmo_io.h> #include <osmocom/core/linuxlist.h> @@ -357,6 +358,12 @@ return IOFD_SEG_ACT_DEFER; } +static void _call_read_cb(struct osmo_io_fd *iofd, int rc, struct msgb *msg) +{ + talloc_steal(iofd->msgb_alloc.ctx, msg); + iofd->io_ops.read_cb(iofd, rc, msg); +} + /*! Restore message boundaries on read() and pass individual messages to the read callback */ void iofd_handle_segmented_read(struct osmo_io_fd *iofd, int rc, struct msgb *msg) @@ -367,8 +374,7 @@ OSMO_ASSERT(iofd->mode == OSMO_IO_FD_MODE_READ_WRITE); if (rc <= 0) { - talloc_steal(iofd->msgb_alloc.ctx, msg); - iofd->io_ops.read_cb(iofd, rc, msg); + _call_read_cb(iofd, rc, msg); return; } @@ -376,9 +382,17 @@ * If the pending message is not large enough, create a larger message. */ if (OSMO_UNLIKELY(iofd->pending)) { if (OSMO_UNLIKELY(msgb_tailroom(iofd->pending) < msgb_length(msg))) { + size_t new_len = msgb_length(iofd->pending) + msgb_length(msg); /* Data of msg does not fit into pending message. Allocate a new message that is larger. * This implies that msgb_length(iofd->pending) + msgb_length(msg) > iofd.msgb_alloc.size. */ - pending = iofd_msgb_alloc2(iofd, msgb_length(iofd->pending) + msgb_length(msg)); + if (new_len + iofd->msgb_alloc.headroom > UINT16_MAX) { + LOGPIO(iofd, LOGL_ERROR, + "Rx segmented msgb of %zu > (%u + %" PRIu16 ") bytes is unsupported, check your segment_cb!\n", + new_len, iofd->msgb_alloc.headroom, UINT16_MAX); + _call_read_cb(iofd, -EPROTO, msg); + return; + } + pending = iofd_msgb_alloc2(iofd, new_len); OSMO_ASSERT(pending); memcpy(msgb_put(pending, msgb_length(iofd->pending)), msgb_data(iofd->pending), msgb_length(iofd->pending)); @@ -398,8 +412,7 @@ /* It it expected as per API spec that we return the * return value of read here. The amount of bytes in msg is * available to the user in msg itself. */ - talloc_steal(iofd->msgb_alloc.ctx, msg); - iofd->io_ops.read_cb(iofd, rc, msg); + _call_read_cb(iofd, rc, msg); /* The user could unregister/close the iofd during read_cb() above. * Once that's done, it doesn't expect to receive any more events, * so discard it: */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586 Gerrit-Change-Number: 41911 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Reorder iofd_handle_segmented_read()
by pespin 21 Jan '26

21 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email ) Change subject: osmo_io: Reorder iofd_handle_segmented_read() ...................................................................... osmo_io: Reorder iofd_handle_segmented_read() All other similar functions have first the int rc and later the struct msgb; fix this one being different. Change-Id: I88683334e77901776c806dad776ef46ea20b4480 --- M src/core/osmo_io.c M src/core/osmo_io_internal.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/10/41910/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 1a55ff1..d6cd57f 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -359,7 +359,7 @@ /*! Restore message boundaries on read() and pass individual messages to the read callback */ -void iofd_handle_segmented_read(struct osmo_io_fd *iofd, struct msgb *msg, int rc) +void iofd_handle_segmented_read(struct osmo_io_fd *iofd, int rc, struct msgb *msg) { int res; struct msgb *pending; @@ -425,7 +425,7 @@ { switch (iofd->mode) { case OSMO_IO_FD_MODE_READ_WRITE: - iofd_handle_segmented_read(iofd, msg, rc); + iofd_handle_segmented_read(iofd, rc, msg); break; case OSMO_IO_FD_MODE_RECVFROM_SENDTO: talloc_steal(iofd->msgb_alloc.ctx, msg); diff --git a/src/core/osmo_io_internal.h b/src/core/osmo_io_internal.h index f425da2..781ae64 100644 --- a/src/core/osmo_io_internal.h +++ b/src/core/osmo_io_internal.h @@ -189,7 +189,7 @@ void iofd_handle_recv(struct osmo_io_fd *iofd, struct msgb *msg, int rc, struct iofd_msghdr *msghdr); void iofd_handle_send_completion(struct osmo_io_fd *iofd, int rc, struct iofd_msghdr *msghdr); -void iofd_handle_segmented_read(struct osmo_io_fd *iofd, struct msgb *msg, int rc); +void iofd_handle_segmented_read(struct osmo_io_fd *iofd, int rc, struct msgb *msg); int iofd_txqueue_enqueue(struct osmo_io_fd *iofd, struct iofd_msghdr *msghdr); void iofd_txqueue_enqueue_front(struct osmo_io_fd *iofd, struct iofd_msghdr *msghdr); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88683334e77901776c806dad776ef46ea20b4480 Gerrit-Change-Number: 41910 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: add and use l1sched_del_all_ts()
by pespin 21 Jan '26

21 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41905?usp=email ) Change subject: trxcon/l1sched: add and use l1sched_del_all_ts() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41905?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I35ce97459dcd0e2cac4ab8927f02fe0232aa6142 Gerrit-Change-Number: 41905 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jan 2026 13:21:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_rsl_chan_initial_ta: fix sporadic failures
by pespin 21 Jan '26

21 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41899?usp=email ) Change subject: bts: TC_rsl_chan_initial_ta: fix sporadic failures ...................................................................... Patch Set 1: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41899/comment/1618f81e_e758… : PS1, Line 3894: /* tell trxcon to use a given TA for UL bursts */ > > eg. f_trxc_set_ta() or similar […] whatever you see fits better, I'm just mentioning because all this block looks like a lot of trxcon blackmagic which is need to "set TA on trxcon", -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebb043ccc710750dff937e2281c23d343b85bda1 Gerrit-Change-Number: 41899 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jan 2026 13:19:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: TC_rsl_chan_initial_ta: misc improvements
by pespin 21 Jan '26

21 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41898?usp=email ) Change subject: bts: TC_rsl_chan_initial_ta: misc improvements ...................................................................... Patch Set 1: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41898/comment/44ebea3d_4bdb… : PS1, Line 3906: "the signaled (RSL) TA=", ta_to_test); > What do you mean by "the test continuing with uninteresting stuff"? Everything that follows this blo […] Well if that's necessary to avoid breaking follow-up tests then sure, otherwise I see no need for it after failure making it more difficult to debug, but as you see. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41898?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifc2c850104b3710679485042ab5b7a758d0ae000 Gerrit-Change-Number: 41898 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jan 2026 13:18:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: add and use l1sched_del_all_ts()
by fixeria 21 Jan '26

21 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41905?usp=email ) Change subject: trxcon/l1sched: add and use l1sched_del_all_ts() ...................................................................... Patch Set 2: (1 comment) File src/host/trxcon/src/sched_trx.c: https://gerrit.osmocom.org/c/osmocom-bb/+/41905/comment/e43f9418_8277d056?u… : PS1, Line 188: /* Reset UL SACCH cache */ > Ack, it's likely a rebase artifact. I'll update the patch. Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41905?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I35ce97459dcd0e2cac4ab8927f02fe0232aa6142 Gerrit-Change-Number: 41905 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jan 2026 13:09:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: l1sched_reset(): remove unused param
by fixeria 21 Jan '26

21 Jan '26

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/41903?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: trxcon/l1sched: l1sched_reset(): remove unused param ...................................................................... trxcon/l1sched: l1sched_reset(): remove unused param The l1sched no longer has its own clock source, so there's nothing to reset. This parameter is no-op and can be safely removed. Change-Id: I88dfa8770c9cd205006f569315b07f4d91cc08de --- M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h M src/host/trxcon/src/sched_trx.c M src/host/trxcon/src/trxcon_fsm.c 3 files changed, 8 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/03/41903/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I88dfa8770c9cd205006f569315b07f4d91cc08de Gerrit-Change-Number: 41903 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log