- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: bts: f_build_meas_res_tmpl(): expect specific L3 INFO
by fixeria 24 Jan '26

24 Jan '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41937?usp=email ) Change subject: bts: f_build_meas_res_tmpl(): expect specific L3 INFO ...................................................................... bts: f_build_meas_res_tmpl(): expect specific L3 INFO Change-Id: I1892d3ae3f72443ded6321487e9b191cd1948aac Related: OS#6933 --- M bts/BTS_Tests.ttcn 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/41937/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 27dd83f..efc7127 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2332,10 +2332,11 @@ reserved := 0, actual_ta := f_tolerance(l1p.ms_actual_ta, 0, 63, mp_tolerance_timing_offset_256syms/256) }; + var GsmRrL3Message meas_rep := valueof(ts_MEAS_REP(ts_MeasurementResults)); + var octetstring l3_info := f_pad_oct(enc_GsmRrL3Message(meas_rep), 18, '00'O); var uint8_t offs := toffs256s_to_rsl(l1p.timing_offset_256syms); var template uint8_t t_toffs := f_tolerance(offs, 0, 255, mp_tolerance_timing_offset_256syms/256); - return tr_RSL_MEAS_RES_OSMO(g_chan_nr, g_pars.rsl_meas_res_nr, ul_meas, bs_power, l1_info, - ?, t_toffs); + return tr_RSL_MEAS_RES_OSMO(g_chan_nr, g_pars.rsl_meas_res_nr, ul_meas, bs_power, l1_info, l3_info, t_toffs); } /* build a template for matching measurement results that do not contain any -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1892d3ae3f72443ded6321487e9b191cd1948aac Gerrit-Change-Number: 41937 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in libosmocore[master]: logging: Move log target file to its own file
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: logging: Move log target file to its own file ...................................................................... logging: Move log target file to its own file We already have all other log_target implementations each on its own file. Move the file (and stderr, a specific case of file) into its own file too, properly separating most file-specific logic from general logging logic. Change-Id: I8e32e31c75b66ff0649d92c2f469f8895689fbad --- M include/osmocom/core/logging_internal.h M src/core/Makefile.am M src/core/logging.c A src/core/logging_file.c 4 files changed, 382 insertions(+), 328 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/41894/8 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8e32e31c75b66ff0649d92c2f469f8895689fbad Gerrit-Change-Number: 41894 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in libosmocore[master]: logging: Move log target file to its own file
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email ) Change subject: logging: Move log target file to its own file ...................................................................... Patch Set 7: (2 comments) File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/41894/comment/959be6d7_4b3daaf2?… : PS7, Line 762: _output > This function no longer exists. Done File src/core/logging_file.c: https://gerrit.osmocom.org/c/libosmocore/+/41894/comment/aee709d5_00b3ba68?… : PS7, Line 2: Syslog > This is not really syslog? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8e32e31c75b66ff0649d92c2f469f8895689fbad Gerrit-Change-Number: 41894 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 21:46:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in libosmocore[master]: logging: Move log target file to its own file
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email ) Change subject: logging: Move log target file to its own file ...................................................................... Patch Set 7: (2 comments) File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/41894/comment/a3a19a49_7768587c?… : PS7, Line 762: _output This function no longer exists. File src/core/logging_file.c: https://gerrit.osmocom.org/c/libosmocore/+/41894/comment/aad51479_4ec903ad?… : PS7, Line 2: Syslog This is not really syslog? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8e32e31c75b66ff0649d92c2f469f8895689fbad Gerrit-Change-Number: 41894 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 21:27:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: configure.ac: Add arpa/inet.h to AC_CHECK_HEADERS
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41930?usp=email ) Change subject: configure.ac: Add arpa/inet.h to AC_CHECK_HEADERS ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib2d1fb3efb1dcb429b511698691249c257e00720 Gerrit-Change-Number: 41930 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 21:11:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: socket.h: Include netinet/in.h instead of arpa/inet.h
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41929?usp=email ) Change subject: socket.h: Include netinet/in.h instead of arpa/inet.h ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I03919c4adc962bbcfabc9030c6f12c0e10ff060c Gerrit-Change-Number: 41929 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 21:10:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io.h: Avoid including sys/socket.h
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: jolly, laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41927?usp=email ) Change subject: osmo_io.h: Avoid including sys/socket.h ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5bcba8f72a2be6161d7782a3100d25a7025341d0 Gerrit-Change-Number: 41927 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 21:10:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: remove references to define EMBEDDED in public headers
by pespin 23 Jan '26

23 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41932?usp=email ) Change subject: remove references to define EMBEDDED in public headers ...................................................................... remove references to define EMBEDDED in public headers It's not a good idea to base opt-in/out of code in public headers based on some specific non-standard define being set at compile time when calling the compiler. Get rid of those references; Now that osmocom/core/socket.h can be included thanks to improved osmocom/core/socket_compat.h, it shouldn't be a problem. Change-Id: I7a657d67077dfbe861959c6123eb9163bc791694 --- M include/osmocom/core/netdev.h M include/osmocom/core/netns.h M include/osmocom/core/tun.h M include/osmocom/gsm/gsup.h 4 files changed, 0 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/41932/1 diff --git a/include/osmocom/core/netdev.h b/include/osmocom/core/netdev.h index fb0f124..4d505fe 100644 --- a/include/osmocom/core/netdev.h +++ b/include/osmocom/core/netdev.h @@ -2,7 +2,6 @@ * network device (interface) convenience functions. */ #pragma once -#if (!EMBEDDED) #include <stddef.h> #include <stdint.h> @@ -47,5 +46,4 @@ uint8_t dst_prefixlen, const struct osmo_sockaddr *gw_addr); int osmo_netdev_ifupdown(struct osmo_netdev *netdev, bool ifupdown); -#endif /* (!EMBEDDED) */ /*! @} */ diff --git a/include/osmocom/core/netns.h b/include/osmocom/core/netns.h index 5bbf224..a6ed9e3 100644 --- a/include/osmocom/core/netns.h +++ b/include/osmocom/core/netns.h @@ -2,7 +2,6 @@ * Network namespace convenience functions. */ #pragma once -#if (!EMBEDDED) #if defined(__linux__) @@ -19,6 +18,4 @@ #endif /* defined(__linux__) */ - -#endif /* (!EMBEDDED) */ /*! @} */ diff --git a/include/osmocom/core/tun.h b/include/osmocom/core/tun.h index 21e7703..1351d04 100644 --- a/include/osmocom/core/tun.h +++ b/include/osmocom/core/tun.h @@ -2,7 +2,6 @@ * tunnel network device convenience functions. */ #pragma once -#if (!EMBEDDED) #include <stddef.h> #include <stdint.h> @@ -40,6 +39,4 @@ struct osmo_netdev *osmo_tundev_get_netdev(struct osmo_tundev *tundev); int osmo_tundev_send(struct osmo_tundev *tundev, struct msgb *msg); - -#endif /* (!EMBEDDED) */ /*! @} */ diff --git a/include/osmocom/gsm/gsup.h b/include/osmocom/gsm/gsup.h index 6ad72d2..3ef03a9 100644 --- a/include/osmocom/gsm/gsup.h +++ b/include/osmocom/gsm/gsup.h @@ -37,7 +37,6 @@ * */ #pragma once -#if (!EMBEDDED) #include <stdint.h> #include <osmocom/core/msgb.h> @@ -421,6 +420,4 @@ int osmo_gsup_encode(struct msgb *msg, const struct osmo_gsup_message *gsup_msg); int osmo_gsup_get_err_msg_type(enum osmo_gsup_message_type type_in) OSMO_DEPRECATED("Use OSMO_GSUP_TO_MSGT_ERROR() instead"); - -#endif /* (!EMBEDDED) */ /*! @} */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41932?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7a657d67077dfbe861959c6123eb9163bc791694 Gerrit-Change-Number: 41932 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io.h: add forward declaration of struct osmo_sockaddr
by pespin 23 Jan '26

23 Jan '26

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41928?usp=email ) Change subject: osmo_io.h: add forward declaration of struct osmo_sockaddr ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id7db4b081752a1034b95a92b4850484a26ec11c6 Gerrit-Change-Number: 41928 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in libosmocore[master]: socket_compat.h improvements to always have struct osmo_sockaddr avai...
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41931?usp=email to look at the new patch set (#3). Change subject: socket_compat.h improvements to always have struct osmo_sockaddr available ...................................................................... socket_compat.h improvements to always have struct osmo_sockaddr available Having a #if (!EMBEDDED) based on compiler defined variable is not a good idea. Instead, add minimal sys/socket.h and netient/in.h to always have the definition of struct osmo_sockaddr available. Change-Id: I5b10e09770727c72812af15360ab3385b957509b --- M configure.ac M include/osmocom/core/Makefile.am M include/osmocom/core/socket.h M include/osmocom/core/socket_compat.h.tpl 4 files changed, 73 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/41931/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41931?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b10e09770727c72812af15360ab3385b957509b Gerrit-Change-Number: 41931 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log