- gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by osmith 29 Jan '26

29 Jan '26

Attention is currently required from: Timur Davydov, fixeria, laforge, neels, pespin. osmith has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 24: Code-Review+1 (1 comment) Patchset: PS21: > Looks good to me. […] ^ still a lot of unresolved threads, please follow what was requested here, thanks! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 24 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Thu, 29 Jan 2026 10:47:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: transport/init: use PySimLogger to print messages
by dexter 29 Jan '26

29 Jan '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41812?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: transport/init: use PySimLogger to print messages ...................................................................... transport/init: use PySimLogger to print messages The module still uses print to output information. Let's replace those print calls with the more modern PySimLogger method calls. Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 --- M pySim/transport/__init__.py 1 file changed, 11 insertions(+), 8 deletions(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index f82f4df..f19790c 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -29,6 +29,9 @@ from pySim.exceptions import * from pySim.utils import SwHexstr, SwMatchstr, ResTuple, sw_match, parse_command_apdu from pySim.cat import ProactiveCommand, CommandDetails, DeviceIdentities, Result +from pySim.log import PySimLogger + +log = PySimLogger.get(__name__) class ApduTracer: def trace_command(self, cmd): @@ -43,11 +46,11 @@ class StdoutApduTracer(ApduTracer): """Minimalistic APDU tracer, printing commands to stdout.""" def trace_response(self, cmd, sw, resp): - print("-> %s %s" % (cmd[:10], cmd[10:])) - print("<- %s: %s" % (sw, resp)) + log.info("-> %s %s", cmd[:10], cmd[10:]) + log.info("<- %s: %s", sw, resp) def trace_reset(self): - print("-- RESET") + log.info("-- RESET") class ProactiveHandler(abc.ABC): """Abstract base class representing the interface of some code that handles @@ -174,7 +177,7 @@ if self.apdu_strict: raise ValueError(exeption_str) else: - print('Warning: %s' % exeption_str) + log.warning(exeption_str) return (data, sw) @@ -208,7 +211,7 @@ # parse the proactive command pcmd = ProactiveCommand() parsed = pcmd.from_tlv(h2b(fetch_rv[0])) - print("FETCH: %s (%s)" % (fetch_rv[0], type(parsed).__name__)) + log.info("FETCH: %s (%s)", fetch_rv[0], type(parsed).__name__) if self.proactive_handler: # Extension point: If this does return a list of TLV objects, # they could be appended after the Result; if the first is a @@ -358,13 +361,13 @@ from pySim.transport.modem_atcmd import ModemATCommandLink sl = ModemATCommandLink(opts, **kwargs) else: # Serial reader is default - print("No reader/driver specified; falling back to default (Serial reader)") + log.warning("No reader/driver specified; falling back to default (Serial reader)") from pySim.transport.serial import SerialSimLink sl = SerialSimLink(opts, **kwargs) if os.environ.get('PYSIM_INTEGRATION_TEST') == "1": - print("Using %s reader interface" % (sl.name)) + log.info("Using %s reader interface" % (sl.name)) else: - print("Using reader %s" % sl) + log.info("Using reader %s" % sl) return sl -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 Gerrit-Change-Number: 41812 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: pySimLogger: user __name__ of the module when creating a new logger
by dexter 29 Jan '26

29 Jan '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41890?usp=email ) Change subject: pySimLogger: user __name__ of the module when creating a new logger ...................................................................... pySimLogger: user __name__ of the module when creating a new logger At the moment we use random identifiers as names when we create a new logger for pySimLogger. Let's switch to consistently use the module name here. For the top level modules let's use the program name so that it will show up in the log instead of __init__. Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a --- M contrib/csv-to-pgsql.py M contrib/es2p_server.py M pySim-shell.py M pySim/card_key_provider.py M pySim/log.py M pySim/runtime.py M tests/unittests/test_log.py 7 files changed, 13 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/contrib/csv-to-pgsql.py b/contrib/csv-to-pgsql.py index 71a5b66..dad408d 100755 --- a/contrib/csv-to-pgsql.py +++ b/contrib/csv-to-pgsql.py @@ -12,7 +12,7 @@ from pySim.log import PySimLogger from packaging import version -log = PySimLogger.get("CSV2PGQSL") +log = PySimLogger.get(Path(__file__).stem) class CardKeyDatabase: def __init__(self, config_filename: str, table_name: str, create_table: bool = False, admin: bool = False): @@ -35,7 +35,6 @@ raise ValueError("user for role '%s' not set up in config file." % role) return user.get('name'), user.get('pass') - log = PySimLogger.get("PGSQL") self.table = table_name.lower() self.cols = None diff --git a/contrib/es2p_server.py b/contrib/es2p_server.py index 6d71689..3feadc0 100755 --- a/contrib/es2p_server.py +++ b/contrib/es2p_server.py @@ -31,8 +31,9 @@ from osmocom.utils import b2h from datetime import datetime from analyze_simaResponse import split_sima_response +from pathlib import Path -logger = logging.getLogger(__name__) +logger = logging.getLogger(Path(__file__).stem) parser = argparse.ArgumentParser(description=""" Utility to receive and log requests against the ES2+ API of an SM-DP+ according to GSMA SGP.22.""") diff --git a/pySim-shell.py b/pySim-shell.py index be6249d..50deea2 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -74,7 +74,7 @@ from pySim.app import init_card -log = PySimLogger.get("main") +log = PySimLogger.get(Path(__file__).stem) class Cmd2Compat(cmd2.Cmd): """Backwards-compatibility wrapper around cmd2.Cmd to support older and newer diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py index 07a55b5..a6cd7ea 100644 --- a/pySim/card_key_provider.py +++ b/pySim/card_key_provider.py @@ -38,7 +38,7 @@ import logging import yaml -log = PySimLogger.get("CARDKEY") +log = PySimLogger.get(__name__) card_key_providers = [] # type: List['CardKeyProvider'] diff --git a/pySim/log.py b/pySim/log.py index c7e5239..85397b6 100644 --- a/pySim/log.py +++ b/pySim/log.py @@ -44,7 +44,7 @@ """ LOG_FMTSTR = "%(levelname)s: %(message)s" - LOG_FMTSTR_VERBOSE = "%(module)s.%(lineno)d -- %(name)s - " + LOG_FMTSTR + LOG_FMTSTR_VERBOSE = "%(module)s.%(lineno)d -- " + LOG_FMTSTR __formatter = logging.Formatter(LOG_FMTSTR) __formatter_verbose = logging.Formatter(LOG_FMTSTR_VERBOSE) diff --git a/pySim/runtime.py b/pySim/runtime.py index 54f431b..6a5a9e0 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -26,7 +26,7 @@ from pySim.filesystem import * from pySim.log import PySimLogger -log = PySimLogger.get("RUNTIME") +log = PySimLogger.get(__name__) def lchan_nr_from_cla(cla: int) -> int: """Resolve the logical channel number from the CLA byte.""" diff --git a/tests/unittests/test_log.py b/tests/unittests/test_log.py index 6a0f7ff..a8e38dd 100755 --- a/tests/unittests/test_log.py +++ b/tests/unittests/test_log.py @@ -25,7 +25,7 @@ import sys from inspect import currentframe, getframeinfo -log = PySimLogger.get("TEST") +log = PySimLogger.get(__name__) TEST_MSG_DEBUG = "this is a debug message" TEST_MSG_INFO = "this is an info message" @@ -82,15 +82,15 @@ PySimLogger.setup(self._test_print_callback) PySimLogger.set_verbose(True) frame = currentframe() - expected_message = __name__ + "." + str(getframeinfo(frame).lineno + 1) + " -- TEST - DEBUG: " + TEST_MSG_DEBUG + expected_message = __name__ + "." + str(getframeinfo(frame).lineno + 1) + " -- DEBUG: " + TEST_MSG_DEBUG log.debug(TEST_MSG_DEBUG) - expected_message = __name__ + "." + str(getframeinfo(frame).lineno + 1) + " -- TEST - INFO: " + TEST_MSG_INFO + expected_message = __name__ + "." + str(getframeinfo(frame).lineno + 1) + " -- INFO: " + TEST_MSG_INFO log.info(TEST_MSG_INFO) - expected_message = __name__ + "." + str(getframeinfo(frame).lineno + 1) + " -- TEST - WARNING: " + TEST_MSG_WARNING + expected_message = __name__ + "." + str(getframeinfo(frame).lineno + 1) + " -- WARNING: " + TEST_MSG_WARNING log.warning(TEST_MSG_WARNING) - expected_message = __name__ + "." + str(getframeinfo(frame).lineno + 1) + " -- TEST - ERROR: " + TEST_MSG_ERROR + expected_message = __name__ + "." + str(getframeinfo(frame).lineno + 1) + " -- ERROR: " + TEST_MSG_ERROR log.error(TEST_MSG_ERROR) - expected_message = __name__ + "." + str(getframeinfo(frame).lineno + 1) + " -- TEST - CRITICAL: " + TEST_MSG_CRITICAL + expected_message = __name__ + "." + str(getframeinfo(frame).lineno + 1) + " -- CRITICAL: " + TEST_MSG_CRITICAL log.critical(TEST_MSG_CRITICAL) def test_04_level(self): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a Gerrit-Change-Number: 41890 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[S] Change in libosmocore[master]: core: guard TCP stats on availability of linux/tcp.h
by osmith 29 Jan '26

29 Jan '26

Attention is currently required from: Timur Davydov, fixeria, pespin. osmith has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email ) Change subject: core: guard TCP stats on availability of linux/tcp.h ...................................................................... Patch Set 3: Code-Review+2 (3 comments) File src/core/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/8e40e681_1c7c9d60?… : PS1, Line 315: osmo_timer_schedule(&stats_tcp_poll_timer, osmo_tcp_stats_config->interval, 0); > Done. I reworked it as suggested: the implementation is now wrapped in […] Done https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/8cf23948_81545932?… : PS1, Line 328: osmo_timer_setup(&stats_tcp_poll_timer, stats_tcp_poll_timer_cb, NULL); > Done. I reworked it as suggested: the implementation is now wrapped in […] Done File src/core/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/3086d411_a014370b?… : PS2, Line 47: #include <errno.h> > Done, moved it above the HAVE_LINUX_TCP_H guard. Done, marking as resolved (there is a checkbox for resolving threads, so future reviewers don't need to read through them as well). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd00f15131b0291f0b10eca51401c518b77cc39 Gerrit-Change-Number: 41922 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Thu, 29 Jan 2026 10:37:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-ci[master]: repo-install-test: test osmo-pfcp-tool in latest
by osmith 29 Jan '26

29 Jan '26

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ci/+/41976?usp=email ) Change subject: repo-install-test: test osmo-pfcp-tool in latest ...................................................................... repo-install-test: test osmo-pfcp-tool in latest osmo-pfcp-tool is available in latest for quite some time now, so adjust the check. Related: osmo-upf Icf4bb566d9b627ead370174e92629a9fccde755e Change-Id: Icca5a31270bca03596be8ed0104bfb7143fb1ede --- M scripts/repo-install-test/run-inside.sh 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/76/41976/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icca5a31270bca03596be8ed0104bfb7143fb1ede Gerrit-Change-Number: 41976 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[M] Change in osmo-ci[master]: repo-install-test: debian 10: osmo-gbproxy only
by osmith 29 Jan '26

29 Jan '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41977?usp=email ) Change subject: repo-install-test: debian 10: osmo-gbproxy only ...................................................................... repo-install-test: debian 10: osmo-gbproxy only The debian 10 repository has been officially disabled: https://osmocom.org/news/308 However we just re-enabled a subset of the packages, osmo-gbproxy + dependencies, because currently they are relevant for a customer. Adjust the repo-install-test to deal with this subset of packages for debian 10 to fix that it is currently failing. I have verified that repo-install-test works with this change for debian 10, 11 and 12. It currently doesn't run for debian 13 yet (OS#6934). Related: SYS#7859 Change-Id: Id8d8cda8e399719f06aeb1843eb8f5ab12a90e8f --- M scripts/repo-install-test/run-inside.sh 1 file changed, 50 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/77/41977/1 diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index 2d75e6a..d1054a6 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -14,7 +14,7 @@ # * osmo-remsim-client (exits immediately without USB device) # * osmo-trap2cgi (missing config: /etc/osmocom/%N.ini, OS#4108) # * osmo-trx-* (exits immediately without trx device) -# * osmo-upf (not available for debian 10, gets added in services_check()) +# * osmo-upf nightly needs a newer kernel (OS#5905) SERVICES=" osmo-bsc osmo-bts-virtual @@ -186,9 +186,7 @@ case "$DISTRO" in debian10) # libgnutls30: can't access https://osmocom.org otherwise - # ca-certificates-java: fails if installed after java apt-get install -y --no-install-recommends \ - ca-certificates-java \ libgnutls30 ;; esac @@ -237,6 +235,15 @@ } test_conflict_debian() { + # SYS#7859: the debian10 repository only has osmo-gbproxy + depends, so + # the conflict test doesn't work here, skip it + if [ "$DISTRO" = "debian10" ]; then + set +x + echo "Test skipped for debian10" + set -x + return + fi + apt-get -y install libosmocore configure_osmocom_repo_debian_remove "$PROJ" @@ -254,19 +261,9 @@ "requested an impossible situation" \ "^The following packages have unmet dependencies:" - case "$DISTRO" in - debian10) - find_patterns_or_exit \ - /tmp/out \ - "Depends: osmocom-" \ - "but it is not going to be installed" - ;; - debian11|debian12) - find_patterns_or_exit \ - /tmp/out \ - "Conflicts: osmocom-" - ;; - esac + find_patterns_or_exit \ + /tmp/out \ + "Conflicts: osmocom-" configure_osmocom_repo_debian_remove "$PROJ_CONFLICT" configure_osmocom_repo_debian "$PROJ" @@ -360,12 +357,19 @@ local packages echo "Installing all repository packages" - # Get a list of all packages from the repository. Reference: - # https://www.debian.org/doc/manuals/aptitude/ch02s04s05.en.html - packages="$(aptitude search -F%p \ - "?origin(.*$PROJ.*) ?architecture(native)" | sort)" - packages="$(filter_packages $packages)" - + case "$DISTRO" in + debian10) + # SYS#7859 + packages="osmo-gbproxy" + ;; + *) + # Get a list of all packages from the repository. Reference: + # https://www.debian.org/doc/manuals/aptitude/ch02s04s05.en.html + packages="$(aptitude search -F%p \ + "?origin(.*$PROJ.*) ?architecture(native)" | sort)" + packages="$(filter_packages $packages)" + ;; + esac apt-get install -y --no-install-recommends -- $packages } @@ -417,8 +421,15 @@ fi } +# Make sure that binares run at all and output a proper version test_binaries() { - # Make sure that binares run at all and output a proper version + # SYS#7859 + if [ "$DISTRO" = "debian10" ]; then + test_binaries_version \ + osmo-gbproxy + return + fi + test_binaries_version \ osmo-bsc \ osmo-bts-trx \ @@ -438,6 +449,7 @@ osmo-pcap-client \ osmo-pcap-server \ osmo-pcu \ + osmo-pfcp-tool \ osmo-remsim-bankd \ osmo-remsim-client-shell \ osmo-remsim-client-st2 \ @@ -448,7 +460,8 @@ osmo-stp \ osmo-trx-ipc \ osmo-trx-uhd \ - osmo-uecups-daemon + osmo-uecups-daemon \ + osmo-upf case "$DISTRO" in debian*) @@ -457,12 +470,6 @@ ;; esac - if [ "$DISTRO" != "debian10" ]; then - test_binaries_version \ - osmo-pfcp-tool \ - osmo-upf - fi - if [ "$FEED" = "nightly" ]; then test_binaries_version \ osmo-bsc-nat @@ -471,22 +478,21 @@ services_check() { local service - local services_feed="$SERVICES" + local services_feed local failed="" - if [ "$FEED" = "nightly" ]; then - services_feed="$services_feed $SERVICES_NIGHTLY" - fi - - # We don't build osmo-upf for debian 10 - if [ "$DISTRO" != "debian10" ]; then - # osmo-upf <= 0.1.1 needs GTP kernel module - if [ "$FEED" = "nightly" ]; then - # osmo-upf nightly needs a newer kernel (OS#5905) - # services_feed="$services_feed osmo-upf" - true - fi - fi + case "$DISTRO" in + "debian10") + # SYS#7859 + services_feed="osmo-gbproxy" + ;; + *) + services_feed="$SERVICES" + if [ "$FEED" = "nightly" ]; then + services_feed="$services_feed $SERVICES_NIGHTLY" + fi + ;; + esac systemctl start $services_feed sleep 2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id8d8cda8e399719f06aeb1843eb8f5ab12a90e8f Gerrit-Change-Number: 41977 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: scripts/repo-install-test: test osmo-pfcp-tool in latest
by osmith 29 Jan '26

29 Jan '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41976?usp=email ) Change subject: scripts/repo-install-test: test osmo-pfcp-tool in latest ...................................................................... scripts/repo-install-test: test osmo-pfcp-tool in latest osmo-pfcp-tool is available in latest for quite some time now, so adjust the check. Related: osmo-upf Icf4bb566d9b627ead370174e92629a9fccde755e Change-Id: Icca5a31270bca03596be8ed0104bfb7143fb1ede --- M scripts/repo-install-test/run-inside.sh 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/76/41976/1 diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index 0e549b0..2d75e6a 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -459,13 +459,8 @@ if [ "$DISTRO" != "debian10" ]; then test_binaries_version \ + osmo-pfcp-tool \ osmo-upf - - # OS#5817: not packaged for debian, needs osmo-upf release - if [ "$FEED" = "nightly" ] || [ "$DISTRO" = "centos8" ]; then - test_binaries_version \ - osmo-pfcp-tool - fi fi if [ "$FEED" = "nightly" ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icca5a31270bca03596be8ed0104bfb7143fb1ede Gerrit-Change-Number: 41976 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: logging_file: Fix log_target_file_switch_to_stream on stderr
by pespin 29 Jan '26

29 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41975?usp=email ) Change subject: logging_file: Fix log_target_file_switch_to_stream on stderr ...................................................................... logging_file: Fix log_target_file_switch_to_stream on stderr In stderr log target, the bfd of the wq was left registered despite freeing the wq, which ended up in the callback being called and the freed wq being used. Change-Id: I1c0d833fb8ae82d1dd54e44cc2fc8be80d5e1b4b --- M src/core/logging_file.c 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/41975/1 diff --git a/src/core/logging_file.c b/src/core/logging_file.c index 6e01c26..99a797c 100644 --- a/src/core/logging_file.c +++ b/src/core/logging_file.c @@ -213,11 +213,10 @@ } /* now that everything succeeded, we can finally close the old output fd */ - if (target->type == LOG_TGT_TYPE_FILE) { - osmo_fd_unregister(&wq->bfd); + osmo_fd_unregister(&wq->bfd); + if (target->type == LOG_TGT_TYPE_FILE) close(wq->bfd.fd); - wq->bfd.fd = -1; - } + wq->bfd.fd = -1; /* release the queue itself */ talloc_free(wq); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c0d833fb8ae82d1dd54e44cc2fc8be80d5e1b4b Gerrit-Change-Number: 41975 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: Modify the QoS length to ensure compatibility with some GPRS modules,...
by canghaiwuhen 29 Jan '26

29 Jan '26

canghaiwuhen has restored this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41942?usp=email ) Change subject: Modify the QoS length to ensure compatibility with some GPRS modules, such as Air20X. ...................................................................... Restored -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: restore Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iee49745809195fe7d0897dd1e9cba2427ff7008e Gerrit-Change-Number: 41942 Gerrit-PatchSet: 1 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: es9p_client: Fix type conversion in installation result notification
by laforge 28 Jan '26

28 Jan '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41973?usp=email ) Change subject: es9p_client: Fix type conversion in installation result notification ...................................................................... es9p_client: Fix type conversion in installation result notification The asn.1 encoder expects bytes-like objects, we cannot simply pass hex-strings to it without conversion Change-Id: I83ad047e043dc6b3462b188ce6dd0b2cc0e52e87 --- M contrib/es9p_client.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/73/41973/1 diff --git a/contrib/es9p_client.py b/contrib/es9p_client.py index da7a055..44a5a37 100755 --- a/contrib/es9p_client.py +++ b/contrib/es9p_client.py @@ -128,11 +128,11 @@ if self.opts.operation == 'download': pird = { - 'transactionId': self.opts.transaction_id, + 'transactionId': h2b(self.opts.transaction_id), 'notificationMetadata': ntf_metadata, 'finalResult': ('successResult', { - 'aid': self.opts.isdp_aid, - 'simaResponse': self.opts.sima_response, + 'aid': h2b(self.opts.isdp_aid), + 'simaResponse': h2b(self.opts.sima_response), }), } if self.opts.smdpp_oid: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I83ad047e043dc6b3462b188ce6dd0b2cc0e52e87 Gerrit-Change-Number: 41973 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log