- gerrit-log - lists.osmocom.org

[XS] Change in osmo-pcap[master]: server: wr_file: Request up to 8 iofd write buffers if available
by pespin 03 Feb '26

03 Feb '26

Attention is currently required from: daniel, fixeria, jolly, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email ) Change subject: server: wr_file: Request up to 8 iofd write buffers if available ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcap/+/42015/comment/dbb4954c_6d06323e?us… : PS1, Line 7: 8 > Could you explain why exactly 8? Preferably in form of a comment in code. Because 8 is g8, which is great 😊 That's basically the maximum amount of allowed buffers in osmo_io right now, and to start with seems like a good tradeoff between memory and performance. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 Gerrit-Change-Number: 42015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 16:56:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-pcap[master]: server: wr_file: Request up to 8 iofd write buffers if available
by fixeria 03 Feb '26

03 Feb '26

Attention is currently required from: daniel, jolly, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email ) Change subject: server: wr_file: Request up to 8 iofd write buffers if available ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcap/+/42015/comment/e7c38f30_7f4f7c2c?us… : PS1, Line 7: 8 Could you explain why exactly 8? Preferably in form of a comment in code. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 Gerrit-Change-Number: 42015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 16:51:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Assume SCCP peer available if rx BSSAP/RANAP Reset
by fixeria 03 Feb '26

03 Feb '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42024?usp=email ) Change subject: RAN_Emulation: Assume SCCP peer available if rx BSSAP/RANAP Reset ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9020320b61d89720e17e1024b629f0227445266 Gerrit-Change-Number: 42024 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 16:49:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: Fix race condition in TC_stat_stp_sctp_disconnected
by fixeria 03 Feb '26

03 Feb '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42023?usp=email ) Change subject: hnbgw: Fix race condition in TC_stat_stp_sctp_disconnected ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I15a6a9b9cf47f95d88bca75d0c6f88547f1dad40 Gerrit-Change-Number: 42023 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 16:43:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: vty: Prohibit configuring an ASP as IPSP in an SG node
by pespin 03 Feb '26

03 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42028?usp=email ) Change subject: vty: Prohibit configuring an ASP as IPSP in an SG node ...................................................................... vty: Prohibit configuring an ASP as IPSP in an SG node The spec explicitly prohibits it. Change-Id: I38bbd9226bad478f8068d02f7a4d7b3711596208 --- M src/ss7_asp_vty.c 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/28/42028/1 diff --git a/src/ss7_asp_vty.c b/src/ss7_asp_vty.c index b7af9c9..27b7462 100644 --- a/src/ss7_asp_vty.c +++ b/src/ss7_asp_vty.c @@ -414,14 +414,19 @@ { struct osmo_ss7_asp *asp = vty->index; - if (!strcmp(argv[0], "sg")) + if (!strcmp(argv[0], "sg")) { asp->cfg.role = OSMO_SS7_ASP_ROLE_SG; - else if (!strcmp(argv[0], "asp")) + } else if (!strcmp(argv[0], "asp")) { asp->cfg.role = OSMO_SS7_ASP_ROLE_ASP; - else if (!strcmp(argv[0], "ipsp")) + } else if (!strcmp(argv[0], "ipsp")) { + if (cs7_role == CS7_ROLE_SG) { + vty_out(vty, "IPSP role can't be used in an SG node since they are point-to-point%s", VTY_NEWLINE); + return CMD_WARNING; + } asp->cfg.role = OSMO_SS7_ASP_ROLE_IPSP; - else + } else { OSMO_ASSERT(0); + } asp->cfg.role_set_by_vty = true; return CMD_SUCCESS; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42028?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I38bbd9226bad478f8068d02f7a4d7b3711596208 Gerrit-Change-Number: 42028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: m3ua: Allow rx SCON in IPSP role
by pespin 03 Feb '26

03 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42029?usp=email ) Change subject: m3ua: Allow rx SCON in IPSP role ...................................................................... m3ua: Allow rx SCON in IPSP role Change-Id: I49838219aab912243a761ab9b5167095e363c72b --- M src/m3ua.c 1 file changed, 29 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/29/42029/1 diff --git a/src/m3ua.c b/src/m3ua.c index f2844fa..afe75de 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -1107,6 +1107,34 @@ return rc; } +/* received SNM message on IPSP side + * xua is owned by parent call m3ua_rx_snm() */ +static int m3ua_rx_snm_ipsp(struct osmo_ss7_asp *asp, struct xua_msg *xua) +{ + struct osmo_ss7_as *as = NULL; + struct xua_msg_part *rctx_ie; + int rc = 0; + + switch (xua->hdr.msg_type) { + case M3UA_SNM_SCON: + /* RFC4666 1.4.6: "The M3UA layer at an ASP or IPSP MAY indicate local congestion + * to an M3UA peer with an SCON message." + * An IPSP can only be connected against another IPSP, hence if an IPSP can send + * an SCON, it can be derived that it is expected it can receive it: */ + rctx_ie = xua_msg_find_tag(xua, M3UA_IEI_ROUTE_CTX); + rc = xua_find_as_for_asp(&as, asp, rctx_ie); + if (rc) + return rc; + xua_snm_rx_scon(asp, as, xua); + break; + default: + /* RFC 4666 Section 1.5.2: there is no MTP3 network management status information */ + return M3UA_ERR_UNSUPP_MSG_TYPE; + } + + return rc; +} + /* received SNM message * This function takes ownership of xua msg passed to it. */ static int m3ua_rx_snm(struct osmo_ss7_asp *asp, struct xua_msg *xua) @@ -1150,7 +1178,7 @@ rc = m3ua_rx_snm_asp(asp, xua); break; case OSMO_SS7_ASP_ROLE_IPSP: - /* RFC 4666 Section 1.5.2: there is no MTP3 network management status information */ + rc = m3ua_rx_snm_ipsp(asp, xua); default: rc = M3UA_ERR_UNSUPP_MSG_CLASS; break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I49838219aab912243a761ab9b5167095e363c72b Gerrit-Change-Number: 42029 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: cosmetic: xua_as_fsm.c: Improve spec documentation
by pespin 03 Feb '26

03 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42030?usp=email ) Change subject: cosmetic: xua_as_fsm.c: Improve spec documentation ...................................................................... cosmetic: xua_as_fsm.c: Improve spec documentation The specific spec paragraph talks about "Alternate ASP_Active" scenario in quotes, which I could find right away by grepping in the code. Improve the documentation so it can be easily matched in code. Change-Id: I79f5123d87dab79620657c2a2ebfd9fe22f178c3 --- M src/xua_as_fsm.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/30/42030/1 diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index fd44e70..092db55 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -310,8 +310,10 @@ return false; } -/* Tell other previously-active ASPs that a new ASP has been activated and mark - them as inactive. Used in override mode when an ASP becomes active. */ +/* RFC4666 4.3.4.3 "Alternate ASP_Active": + * Tell other previously-active ASPs that a new ASP has been activated and mark + * them as inactive. Used in override mode when an ASP becomes active." + * */ static void notify_any_other_active_asp_as_inactive(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp_cmp) { unsigned int i; @@ -612,7 +614,7 @@ break; case XUA_ASPAS_ASP_ACTIVE_IND: asp = data; - /* RFC466 sec 4.3.4.3 ASP Active Procedures*/ + /* RFC466 sec 4.3.4.3 ASP Active Procedures */ if (xafp->as->cfg.mode == OSMO_SS7_AS_TMOD_OVERRIDE) notify_any_other_active_asp_as_inactive(xafp->as, asp); /* SG role: No need to send DUNA for unknown destinations here -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42030?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I79f5123d87dab79620657c2a2ebfd9fe22f178c3 Gerrit-Change-Number: 42030 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: IPSP: don't route any incoming M3UA messages in IPSP case
by pespin 03 Feb '26

03 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42025?usp=email ) Change subject: IPSP: don't route any incoming M3UA messages in IPSP case ...................................................................... IPSP: don't route any incoming M3UA messages in IPSP case An IPSP is a point-to-point association, and we must not route any such messages. Change-Id: Iad7280619ec5814cda7a179418079048a5955976 --- M src/m3ua.c 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/25/42025/1 diff --git a/src/m3ua.c b/src/m3ua.c index e4173bd..a3235d6 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -41,6 +41,7 @@ #include <osmocom/sigtran/protocol/sua.h> #include "mtp3_hmdc.h" +#include "mtp3_hmdt.h" #include "xua_as_fsm.h" #include "xua_asp_fsm.h" #include "xua_internal.h" @@ -667,8 +668,14 @@ xua_msg_free_tag(xua, M3UA_IEI_ROUTE_CTX); } + /* an IPSP by definition is a peer-to-peer service that doesn't + * use a signaling gateway, and hence doesn't route messages. + * See RFC 4666 Section 1.4.3.4. */ /* xua ownership is passed here: */ - return mtp3_hmdc_rx_from_l2(asp->inst, xua); + if (asp->cfg.role == OSMO_SS7_ASP_ROLE_IPSP) + return mtp3_hmdt_message_for_distribution(asp->inst, xua); + else + return mtp3_hmdc_rx_from_l2(asp->inst, xua); ret_free: xua_msg_free(xua); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42025?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iad7280619ec5814cda7a179418079048a5955976 Gerrit-Change-Number: 42025 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmo-sigtran[master]: IPSP: Allow vty-configuration of IPSP role "ASPs"
by pespin 03 Feb '26

03 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42027?usp=email ) Change subject: IPSP: Allow vty-configuration of IPSP role "ASPs" ...................................................................... IPSP: Allow vty-configuration of IPSP role "ASPs" We should now have everything in place to support IPSP-SE, let's accept enabling IPSP role via the VTY. Change-Id: I0f0fa881471b87a4bb82a0211c6fb6e4c50b48ec --- M src/ss7_asp_vty.c 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/27/42027/1 diff --git a/src/ss7_asp_vty.c b/src/ss7_asp_vty.c index d54eb01..b7af9c9 100644 --- a/src/ss7_asp_vty.c +++ b/src/ss7_asp_vty.c @@ -414,15 +414,12 @@ { struct osmo_ss7_asp *asp = vty->index; - if (!strcmp(argv[0], "ipsp")) { - vty_out(vty, "IPSP role isn't supported yet%s", VTY_NEWLINE); - return CMD_WARNING; - } - if (!strcmp(argv[0], "sg")) asp->cfg.role = OSMO_SS7_ASP_ROLE_SG; else if (!strcmp(argv[0], "asp")) asp->cfg.role = OSMO_SS7_ASP_ROLE_ASP; + else if (!strcmp(argv[0], "ipsp")) + asp->cfg.role = OSMO_SS7_ASP_ROLE_IPSP; else OSMO_ASSERT(0); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0f0fa881471b87a4bb82a0211c6fb6e4c50b48ec Gerrit-Change-Number: 42027 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmo-sigtran[master]: IPSP: Add a comment that it's intentional to drop all M3UA SNM for IPSP
by pespin 03 Feb '26

03 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42026?usp=email ) Change subject: IPSP: Add a comment that it's intentional to drop all M3UA SNM for IPSP ...................................................................... IPSP: Add a comment that it's intentional to drop all M3UA SNM for IPSP An IPSP doesn't have MTP3 network management. Change-Id: I7b87bf03964e7e9aac683ad860e511f83a685821 --- M src/m3ua.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/26/42026/1 diff --git a/src/m3ua.c b/src/m3ua.c index a3235d6..f2844fa 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -1149,6 +1149,8 @@ case OSMO_SS7_ASP_ROLE_ASP: rc = m3ua_rx_snm_asp(asp, xua); break; + case OSMO_SS7_ASP_ROLE_IPSP: + /* RFC 4666 Section 1.5.2: there is no MTP3 network management status information */ default: rc = M3UA_ERR_UNSUPP_MSG_CLASS; break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42026?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7b87bf03964e7e9aac683ad860e511f83a685821 Gerrit-Change-Number: 42026 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022