- gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: esim/http_json_api: add alternative API interface
by dexter 04 Feb '26

04 Feb '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42043?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: esim/http_json_api: add alternative API interface ...................................................................... esim/http_json_api: add alternative API interface unfortunately the API changes introduced in change I277aa90fddb5171c4bf6c3436259aa371d30d092 broke the API interface of http_json_api.py. This was taken into account and necessary to introduce add the server functionality next to the already existing client functionality. The changes to the API were minimal and all code locations that use http_json_api.py were re-aligned. Unfortunately it was not clear at this point in time that there are out-of-tree projects that could be affected by API changes in http_json_api.py To mitigate the problem this patch introduces an alternative API interface to the JsonHttpApiFunction base class. This alternative API interface works like the old API interface when the class is instantiated in the original way. To make use of the revised client the API use has to pass an additional keyword argument that defines the role. Related: SYS#7866 Change-Id: I2a5d4b59b12e08d5eae7a1215814d3a69c8921f6 --- M pySim/esim/http_json_api.py 1 file changed, 53 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/43/42043/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2a5d4b59b12e08d5eae7a1215814d3a69c8921f6 Gerrit-Change-Number: 42043 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_asp_fsm: Remove duplicated role field
by fixeria 04 Feb '26

04 Feb '26

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42038?usp=email ) Change subject: xua_asp_fsm: Remove duplicated role field ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia6de131ce50f07261736645fe5b2ed1ad39eb01b Gerrit-Change-Number: 42038 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 12:44:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: apply 'max-initial' value before POWERON
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email ) Change subject: osmo-bts-trx: apply 'max-initial' value before POWERON ...................................................................... Patch Set 2: (2 comments) File src/osmo-bts-trx/trx_provision_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/01a50c10_38ae3a9d?usp… : PS2, Line 229: l1h->config.setpower_sent = true; Missing: "l1h->config.nomtxpower_acked = false;" At the moment we sent a new message in flight we consider the ack condition to be not fullfilled. Since all this is already complex enough with tons of stuff happening concurrently based on different inputs from upper and lowers layers, best to be safe and follow the guideline. It also helps when debugging. https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/3fd18593_1c4bec7e?usp… : PS2, Line 294: (l1h->config.setformat_acked) && This () can actually be dropped, instead of adding new ones 😊 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff03d4dcb74f67629a59c8d6f8bb60929d9f6ddd Gerrit-Change-Number: 42033 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 12:43:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: esim/http_json_api: add missing apidoc
by fixeria 04 Feb '26

04 Feb '26

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42042?usp=email ) Change subject: esim/http_json_api: add missing apidoc ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibf9cf06197c9e3203c7a3ea5d77004f0ca41cd3f Gerrit-Change-Number: 42042 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 12:39:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: trx_provision_fsm: do not send *_CNF events on failure
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42046?usp=email ) Change subject: osmo-bts-trx: trx_provision_fsm: do not send *_CNF events on failure ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id85fb19c6621f55a9c46882df24bec534864a9dc Gerrit-Change-Number: 42046 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 12:37:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: trx_provision_fsm: mark internal functions as static
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42045?usp=email ) Change subject: osmo-bts-trx: trx_provision_fsm: mark internal functions as static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0cf13e091938db2b991156189bf4ff7c523e24da Gerrit-Change-Number: 42045 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 12:35:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: apply 'max-initial' value before POWERON
by fixeria 04 Feb '26

04 Feb '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email ) Change subject: osmo-bts-trx: apply 'max-initial' value before POWERON ...................................................................... Patch Set 2: (6 comments) This change is ready for review. File src/osmo-bts-trx/trx_provision_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/0b587747_46f50441?usp… : PS1, Line 180: bts_model_change_power(pinst->trx, initial_mdBm); > AFAIU this calls get_p_max_out_mdBm(), which relies on knowing the nominal power of the device, whic […] Acknowledged https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/3e42d997_ac670808?usp… : PS1, Line 222: return 0; > I guess you should do something like this here? […] Done https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/ea30ec61_bf3daa58?usp… : PS1, Line 271: (l1h->config.setformat_acked)) { > l1h->config.setformat_acked && […] Done https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/0e8f0d2e_6495025a?usp… : PS1, Line 463: l1if_trx_set_nominal_power(trx, nominal_power); > See how nominal power is set here. Done https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/7de5acc2_fb2b6573?usp… : PS1, Line 491: case TRX_PROV_EV_OTHER_TRX_READY: > case TRX_PROV_EV_INITIAL_SETPOWER: […] Done https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/866922cf_40ba39a3?usp… : PS1, Line 529: ); > l1h->config. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff03d4dcb74f67629a59c8d6f8bb60929d9f6ddd Gerrit-Change-Number: 42033 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 12:32:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: trx_provision_fsm: do not send *_CNF events on failure
by fixeria 04 Feb '26

04 Feb '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42046?usp=email ) Change subject: osmo-bts-trx: trx_provision_fsm: do not send *_CNF events on failure ...................................................................... osmo-bts-trx: trx_provision_fsm: do not send *_CNF events on failure The trx_provision_fsm currently does not check the event data (rc), causing failed operations (rc != 0) to be treated as successful confirmations. Avoid emitting *_CNF events when a command fails, ensuring that only successful operations generate confirmation events. Change-Id: Id85fb19c6621f55a9c46882df24bec534864a9dc --- M src/osmo-bts-trx/trx_provision_fsm.c 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/42046/1 diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c index 05f3cdb..2b8a2d2 100644 --- a/src/osmo-bts-trx/trx_provision_fsm.c +++ b/src/osmo-bts-trx/trx_provision_fsm.c @@ -63,22 +63,30 @@ static void l1if_rxtune_cb(struct trx_l1h *l1h, int rc) { - osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_RXTUNE_CNF, (void*)(intptr_t)rc); + if (rc != 0) + return; + osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_RXTUNE_CNF, NULL); } static void l1if_txtune_cb(struct trx_l1h *l1h, int rc) { - osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_TXTUNE_CNF, (void*)(intptr_t)rc); + if (rc != 0) + return; + osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_TXTUNE_CNF, NULL); } static void l1if_settsc_cb(struct trx_l1h *l1h, int rc) { - osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_SETTSC_CNF, (void*)(intptr_t)rc); + if (rc != 0) + return; + osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_SETTSC_CNF, NULL); } static void l1if_setbsic_cb(struct trx_l1h *l1h, int rc) { - osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_SETBSIC_CNF, (void*)(intptr_t)rc); + if (rc != 0) + return; + osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_SETBSIC_CNF, NULL); } static void l1if_getnompower_cb(struct trx_l1h *l1h, int nominal_power, int rc) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id85fb19c6621f55a9c46882df24bec534864a9dc Gerrit-Change-Number: 42046 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: trx_provision_fsm: mark internal functions as static
by fixeria 04 Feb '26

04 Feb '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42045?usp=email ) Change subject: osmo-bts-trx: trx_provision_fsm: mark internal functions as static ...................................................................... osmo-bts-trx: trx_provision_fsm: mark internal functions as static Change-Id: I0cf13e091938db2b991156189bf4ff7c523e24da --- M src/osmo-bts-trx/trx_provision_fsm.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/45/42045/1 diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c index 4aa0783..05f3cdb 100644 --- a/src/osmo-bts-trx/trx_provision_fsm.c +++ b/src/osmo-bts-trx/trx_provision_fsm.c @@ -61,22 +61,22 @@ } -void l1if_rxtune_cb(struct trx_l1h *l1h, int rc) +static void l1if_rxtune_cb(struct trx_l1h *l1h, int rc) { osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_RXTUNE_CNF, (void*)(intptr_t)rc); } -void l1if_txtune_cb(struct trx_l1h *l1h, int rc) +static void l1if_txtune_cb(struct trx_l1h *l1h, int rc) { osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_TXTUNE_CNF, (void*)(intptr_t)rc); } -void l1if_settsc_cb(struct trx_l1h *l1h, int rc) +static void l1if_settsc_cb(struct trx_l1h *l1h, int rc) { osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_SETTSC_CNF, (void*)(intptr_t)rc); } -void l1if_setbsic_cb(struct trx_l1h *l1h, int rc) +static void l1if_setbsic_cb(struct trx_l1h *l1h, int rc) { osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_SETBSIC_CNF, (void*)(intptr_t)rc); } @@ -88,7 +88,7 @@ osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_NOMTXPOWER_CNF, (void*)(intptr_t)nominal_power); } -void l1if_setformat_cb(struct trx_l1h *l1h, int rc) +static void l1if_setformat_cb(struct trx_l1h *l1h, int rc) { osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_SETFORMAT_CNF, (void*)(intptr_t)rc); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0cf13e091938db2b991156189bf4ff7c523e24da Gerrit-Change-Number: 42045 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in pysim[master]: esim/http_json_api: add alternative API interface
by dexter 04 Feb '26

04 Feb '26

dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/pysim/+/42043?usp=email ) Change subject: esim/http_json_api: add alternative API interface ...................................................................... esim/http_json_api: add alternative API interface unfortunately the API changes introduced in change I277aa90fddb5171c4bf6c3436259aa371d30d092 broke the API interface of http_json_api.py. This was taken into account and necessary to introduce add the server functionality next to the already existing client functionality. The changes to the API were minimal and all code locations that use http_json_api.py were re-aligned. Unfortunately it was not clear at this point in time that there are out-of-tree projects that could be affected by API changes in http_json_api.py To mitigate the problem this patch introduces an alternative API interface to the JsonHttpApiFunction base class. This alternative API interface works like the old API interface when the class is instantiated in the original way. To make use of the revised client the API use has to pass an additional keyword argument that defines the role. Related: SYS#7866 Change-Id: I2a5d4b59b12e08d5eae7a1215814d3a69c8921f6 --- M pySim/esim/http_json_api.py 1 file changed, 53 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/43/42043/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2a5d4b59b12e08d5eae7a1215814d3a69c8921f6 Gerrit-Change-Number: 42043 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

2026

2025

2024

2023

2022

gerrit-log