- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: library: make ts_MEAS_REP accept MeasurementResults
by laforge 04 Feb '26

04 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41933?usp=email ) Change subject: library: make ts_MEAS_REP accept MeasurementResults ...................................................................... library: make ts_MEAS_REP accept MeasurementResults This reduces code duplication and makes ts_MEAS_REP easier to use. Change-Id: I12113360f52b0ce09aa9bc11472fdd04bf14f368 --- M bsc/BSC_Tests.ttcn M bts/BTS_Tests.ttcn M library/GSM_RR_Types.ttcn 3 files changed, 9 insertions(+), 31 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index d95a8c5..6b3aa96 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -6120,9 +6120,9 @@ var NcellReports neighbor_rep := { { rxlev := 20, bcch_freq := 0, bsic := 11 } }; - var octetstring l3_mr := enc_GsmRrL3Message(valueof(ts_MEAS_REP(true, 8, 8, reps := neighbor_rep))); + var GsmRrL3Message meas_rep := valueof(ts_MEAS_REP(ts_MeasurementResults(8, 8, reps := neighbor_rep))); RSL.send(ts_RSL_MEAS_RES(g_chan_nr, 0, ts_RSL_IE_UplinkMeas, ts_RSL_IE_BS_Power(0), ts_RSL_IE_L1Info, - l3_mr, 0)); + enc_GsmRrL3Message(meas_rep), 0)); RAN_CONN.receive(tr_BSSMAP_HandoverRequired(exp_oldToNewBSSIEs)); } @@ -12531,9 +12531,9 @@ { rxlev := 40, bcch_freq := 2, bsic := 14 }, /* ARFCN 1000, band 900, LAC 99 */ { rxlev := 0, bcch_freq := 3, bsic := 11 } /* ARFCN 0, band 900, LAC 96 */ }; - var octetstring l3_mr := enc_GsmRrL3Message(valueof(ts_MEAS_REP(true, 8, 8, reps := neighbor_rep))); + var GsmRrL3Message meas_rep := valueof(ts_MEAS_REP(ts_MeasurementResults(8, 8, reps := neighbor_rep))); RSL.send(ts_RSL_MEAS_RES(g_chan_nr, 0, ts_RSL_IE_UplinkMeas, ts_RSL_IE_BS_Power(0), ts_RSL_IE_L1Info, - l3_mr, 0)); + enc_GsmRrL3Message(meas_rep), 0)); /* Expect a handover to the third entry. If the BSC parsed the report * correctly, the third entry has LAC 99. */ diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 5275cff..559adf3 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -823,10 +823,7 @@ var octetstring l2; /* RR Measurement Report to be sent */ - var GsmRrL3Message meas_rep := { - header := valueof(t_RrL3Header(MEASUREMENT_REPORT)), - payload := { meas_rep := { meas_res := valueof(meas_res) } } - }; + var GsmRrL3Message meas_rep := valueof(ts_MEAS_REP(meas_res)); /* According to 3GPP TS 44.018, section 10.5.2.20, we should pad with zeroes. * TITAN has weird (and often unusable) padding model, so we pad here manaully. */ @@ -846,10 +843,7 @@ timer T; /* RR Measurement Report to be sent */ - var GsmRrL3Message meas_rep := { - header := valueof(t_RrL3Header(MEASUREMENT_REPORT)), - payload := { meas_rep := { meas_res := valueof(meas_res) } } - }; + var GsmRrL3Message meas_rep := valueof(ts_MEAS_REP(meas_res)); /* TITAN has weird (and often unusable) padding model, so we pad here manaully */ l3 := f_pad_oct(enc_GsmRrL3Message(meas_rep), 18, '00'O); diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn index 464d060..963ad0c 100644 --- a/library/GSM_RR_Types.ttcn +++ b/library/GSM_RR_Types.ttcn @@ -895,28 +895,12 @@ ncell_reports := reps }; - template (value) GsmRrL3Message ts_MEAS_REP(boolean valid, - template (value) uint6_t rxl_f, - template (value) uint6_t rxl_s, - template (value) uint3_t rxq_f := 0, - template (value) uint3_t rxq_s := 0, - template (omit) NcellReports reps := omit) := { + template (value) GsmRrL3Message + ts_MEAS_REP(template (value) MeasurementResults meas_res := ts_MeasurementResults) := { header := t_RrL3Header(MEASUREMENT_REPORT), payload := { meas_rep := { - meas_res := { - ba_used := '0'B, - dtx_used := '0'B, - rxlev_full_srv_cell := rxl_f, - threeg_ba_used := '0'B, - meas_valid := bool2bit(not valid), - rxlev_sub_srv_cell := rxl_s, - si23_ba_used := '0'B, - rxqual_full_srv_cell := rxq_f, - rxqual_sub_srv_cell := rxq_s, - no_ncell_m := 0, - ncell_reports := reps - } + meas_res := meas_res } } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41933?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I12113360f52b0ce09aa9bc11472fdd04bf14f368 Gerrit-Change-Number: 41933 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: f_build_meas_res_tmpl(): expect specific L3 INFO
by laforge 04 Feb '26

04 Feb '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41937?usp=email ) Change subject: bts: f_build_meas_res_tmpl(): expect specific L3 INFO ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1892d3ae3f72443ded6321487e9b191cd1948aac Gerrit-Change-Number: 41937 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 14:04:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: library: make ts_MEAS_REP accept MeasurementResults
by laforge 04 Feb '26

04 Feb '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41933?usp=email ) Change subject: library: make ts_MEAS_REP accept MeasurementResults ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41933?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I12113360f52b0ce09aa9bc11472fdd04bf14f368 Gerrit-Change-Number: 41933 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 14:04:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: f_est_dchan(): populate UL SACCH cache
by laforge 04 Feb '26

04 Feb '26

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41936?usp=email ) Change subject: bts: f_est_dchan(): populate UL SACCH cache ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4781fe7539e64e77d594e84f905646c127f46b64 Gerrit-Change-Number: 41936 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 14:02:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: f_est_dchan(): also reset g_rsl_meas_res_nr
by laforge 04 Feb '26

04 Feb '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42012?usp=email ) Change subject: bts: f_est_dchan(): also reset g_rsl_meas_res_nr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42012?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia26413339c8c056e21661ae29bb2618b4a05ec70 Gerrit-Change-Number: 42012 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 14:02:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: as_rsl_meas_res(): move chan_est to ConnHdlr
by laforge 04 Feb '26

04 Feb '26

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42011?usp=email ) Change subject: bts: as_rsl_meas_res(): move chan_est to ConnHdlr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a31532494e123935fb2aede0e67e4271962ab5f Gerrit-Change-Number: 42011 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 14:02:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: as_rsl_meas_res(): move chan_est to ConnHdlr
by laforge 04 Feb '26

04 Feb '26

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42011?usp=email ) Change subject: bts: as_rsl_meas_res(): move chan_est to ConnHdlr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a31532494e123935fb2aede0e67e4271962ab5f Gerrit-Change-Number: 42011 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 14:02:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcap[master]: server: wr_file: Request up to 8 iofd write buffers if available
by laforge 04 Feb '26

04 Feb '26

Attention is currently required from: daniel, fixeria, jolly, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email ) Change subject: server: wr_file: Request up to 8 iofd write buffers if available ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 Gerrit-Change-Number: 42015 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 14:00:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by laforge 04 Feb '26

04 Feb '26

Attention is currently required from: Timur Davydov, fixeria, neels, osmith, pespin. laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 27: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 27 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 04 Feb 2026 13:58:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-cbc[master]: rest_api: Fix encoded payload length check
by laforge 04 Feb '26

04 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/41997?usp=email ) Change subject: rest_api: Fix encoded payload length check ...................................................................... rest_api: Fix encoded payload length check Change-Id: I4224102dd924dfded59e3a489079d02ca0237983 --- M src/rest_api.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/rest_api.c b/src/rest_api.c index 3af50e6..6834dca 100644 --- a/src/rest_api.c +++ b/src/rest_api.c @@ -348,8 +348,9 @@ return -EINVAL; } hexstr = json_string_value(jpage); - if (strlen(hexstr) > 88 * 2) { - *errstr = "'pages' array must contain strings up to 88 hex nibbles"; + /* The total page length is 88, but the header is 6 bytes length */ + if (strlen(hexstr) > sizeof(out->cbs.data[i]) * 2) { + *errstr = "'pages' actual data array must contain strings up to 82 hex nibbles"; return -EINVAL; } len = osmo_hexparse(hexstr, out->cbs.data[i], sizeof(out->cbs.data[i])); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/41997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I4224102dd924dfded59e3a489079d02ca0237983 Gerrit-Change-Number: 41997 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log