- gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: doc: fix default 'max-initial' value
by fixeria 04 Feb '26

04 Feb '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email ) Change subject: doc: fix default 'max-initial' value ...................................................................... doc: fix default 'max-initial' value The default value is set in gsm_bts_trx_alloc() and it's actually 0. Change-Id: I178e0664f6818d0eda15701b57bb030916b06006 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index f6ca75e..ddaa113 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -197,7 +197,7 @@ configuration file. De-activating power-ramping can be performed by setting the max-initial value -to the nominal power. The default max-initial value is 23 dBm. +to the nominal power. The default max-initial value is 0 dBm. ==== Running multiple instances -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I178e0664f6818d0eda15701b57bb030916b06006 Gerrit-Change-Number: 42031 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: osmo-bts-trx: add missing \n to a logging message
by fixeria 04 Feb '26

04 Feb '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42032?usp=email ) Change subject: osmo-bts-trx: add missing \n to a logging message ...................................................................... osmo-bts-trx: add missing \n to a logging message Change-Id: I5b3091b5ed96e28ae056272398c5eddbdef4b8b5 --- M src/osmo-bts-trx/trx_provision_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c index 7ed617a..4aa0783 100644 --- a/src/osmo-bts-trx/trx_provision_fsm.c +++ b/src/osmo-bts-trx/trx_provision_fsm.c @@ -204,7 +204,7 @@ l1h->config.setformat_sent = true; if (plink->u.osmotrx.trxd_pdu_ver_max == 0) { LOGPPHI(pinst, DL1C, LOGL_INFO, - "No need to negotiate max TRXD version 0"); + "No need to negotiate max TRXD version 0\n"); l1h->config.trxd_pdu_ver_use = 0; l1h->config.setformat_acked = true; } else { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5b3091b5ed96e28ae056272398c5eddbdef4b8b5 Gerrit-Change-Number: 42032 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: trx_provision_fsm: mark internal functions as static
by fixeria 04 Feb '26

04 Feb '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42045?usp=email ) Change subject: osmo-bts-trx: trx_provision_fsm: mark internal functions as static ...................................................................... osmo-bts-trx: trx_provision_fsm: mark internal functions as static Change-Id: I0cf13e091938db2b991156189bf4ff7c523e24da --- M src/osmo-bts-trx/trx_provision_fsm.c 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c index 4aa0783..05f3cdb 100644 --- a/src/osmo-bts-trx/trx_provision_fsm.c +++ b/src/osmo-bts-trx/trx_provision_fsm.c @@ -61,22 +61,22 @@ } -void l1if_rxtune_cb(struct trx_l1h *l1h, int rc) +static void l1if_rxtune_cb(struct trx_l1h *l1h, int rc) { osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_RXTUNE_CNF, (void*)(intptr_t)rc); } -void l1if_txtune_cb(struct trx_l1h *l1h, int rc) +static void l1if_txtune_cb(struct trx_l1h *l1h, int rc) { osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_TXTUNE_CNF, (void*)(intptr_t)rc); } -void l1if_settsc_cb(struct trx_l1h *l1h, int rc) +static void l1if_settsc_cb(struct trx_l1h *l1h, int rc) { osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_SETTSC_CNF, (void*)(intptr_t)rc); } -void l1if_setbsic_cb(struct trx_l1h *l1h, int rc) +static void l1if_setbsic_cb(struct trx_l1h *l1h, int rc) { osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_SETBSIC_CNF, (void*)(intptr_t)rc); } @@ -88,7 +88,7 @@ osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_NOMTXPOWER_CNF, (void*)(intptr_t)nominal_power); } -void l1if_setformat_cb(struct trx_l1h *l1h, int rc) +static void l1if_setformat_cb(struct trx_l1h *l1h, int rc) { osmo_fsm_inst_dispatch(l1h->provision_fi, TRX_PROV_EV_SETFORMAT_CNF, (void*)(intptr_t)rc); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0cf13e091938db2b991156189bf4ff7c523e24da Gerrit-Change-Number: 42045 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: doc: fix default 'max-initial' value
by fixeria 04 Feb '26

04 Feb '26

Attention is currently required from: Hoernchen, laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email ) Change subject: doc: fix default 'max-initial' value ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > the initial default should be 0dBm. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I178e0664f6818d0eda15701b57bb030916b06006 Gerrit-Change-Number: 42031 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 04 Feb 2026 18:08:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: Lb: Handle SCCP N-NOTICE.ind
by pespin 04 Feb '26

04 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email ) Change subject: Lb: Handle SCCP N-NOTICE.ind ...................................................................... Lb: Handle SCCP N-NOTICE.ind Change-Id: I689bf2f2c4311fbc1da92f02c27078a1c00dda1a --- M src/osmo-bsc/lb.c 1 file changed, 49 insertions(+), 0 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index d4f645a..63ab92b 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -21,6 +21,8 @@ * */ +#include <osmocom/sccp/sccp_types.h> + #include <osmocom/bsc/lb.h> #include <osmocom/gsm/bssmap_le.h> @@ -131,6 +133,48 @@ } } +/* Find an SMLC by its remote SCCP address */ +static struct smlc_config *get_smlc_by_addr(const struct osmo_sccp_addr *smlc_addr) +{ + struct smlc_config *smlc = bsc_gsmnet->smlc; + if (osmo_sccp_addr_ri_cmp(smlc_addr, &smlc->smlc_addr) == 0) + return smlc; + LOGP(DMSC, LOGL_ERROR, "Unable to find SMLC data under address: %s\n", + osmo_sccp_addr_dump(smlc_addr)); + return NULL; +} + +static int handle_notice_ind(const struct osmo_scu_notice_param *ni) +{ + int rc = 0; + struct smlc_config *smlc = get_smlc_by_addr(&ni->calling_addr); + if (!smlc) { + LOGP(DLCS, LOGL_DEBUG, "(calling_addr=%s) N-NOTICE.ind cause=%u='%s' importance=%u didn't match SMLC, ignoring\n", + osmo_sccp_addr_dump(&ni->calling_addr), + ni->cause, osmo_sccp_return_cause_name(ni->cause), + ni->importance); + return -EINVAL; + } + + LOGP(DLCS, LOGL_NOTICE, "(calling_addr=%s) N-NOTICE.ind cause=%u='%s' importance=%u\n", + osmo_sccp_addr_dump(&ni->calling_addr), + ni->cause, osmo_sccp_return_cause_name(ni->cause), + ni->importance); + + switch (ni->cause) { + case SCCP_RETURN_CAUSE_SUBSYSTEM_CONGESTION: + case SCCP_RETURN_CAUSE_NETWORK_CONGESTION: + /* Transient failures (hopefully), keep going. */ + return rc; + default: + break; + } + + /* Messages are not arriving to SMLC. Kick the BSSMAP back to DISC state. */ + bssmap_reset_set_disconnected(smlc->bssmap_reset); + return rc; +} + static int sccp_sap_up(struct osmo_prim_hdr *oph, void *_scu) { struct osmo_scu_prim *scu_prim = (struct osmo_scu_prim *)oph; @@ -147,6 +191,11 @@ rc = handle_unitdata_from_smlc(&scu_prim->u.unitdata.calling_addr, oph->msg, scu); break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_NOTICE, PRIM_OP_INDICATION): + DEBUGP(DMSC, "N-NOTICE.ind(%s)\n", osmo_hexdump(msgb_l2(oph->msg), msgb_l2len(oph->msg))); + rc = handle_notice_ind(&scu_prim->u.notice); + break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_CONNECT, PRIM_OP_INDICATION): /* Handle inbound connections. A Location Request is always started on the A interface, and OsmoBSC * forwards this to the SMLC by performing an N-CONNECT from BSC -> SMLC. This is the reverse -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I689bf2f2c4311fbc1da92f02c27078a1c00dda1a Gerrit-Change-Number: 41992 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: Lb: Handle N-PCSTATE.ind
by pespin 04 Feb '26

04 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41993?usp=email ) Change subject: Lb: Handle N-PCSTATE.ind ...................................................................... Lb: Handle N-PCSTATE.ind Change-Id: I16900b9c2b840d4c7d8471c1f69b19601e892b2d --- M src/osmo-bsc/lb.c 1 file changed, 104 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index 63ab92b..aac34a8 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -144,6 +144,17 @@ return NULL; } +/* Find an SMLC by its remote sigtran point code on a given cs7 instance. */ +static struct smlc_config *get_smlc_by_pc(uint32_t pc) +{ + struct smlc_config *smlc = bsc_gsmnet->smlc; + if ((smlc->smlc_addr.presence & OSMO_SCCP_ADDR_T_PC) == 0) + return NULL; + if (smlc->smlc_addr.pc != pc) + return NULL; + return smlc; +} + static int handle_notice_ind(const struct osmo_scu_notice_param *ni) { int rc = 0; @@ -175,6 +186,95 @@ return rc; } +static void handle_pcstate_ind(struct osmo_ss7_instance *cs7, const struct osmo_scu_pcstate_param *pcst) +{ + struct smlc_config *smlc; + bool connected; + bool disconnected; + + LOGP(DLCS, LOGL_DEBUG, "N-PCSTATE ind: affected_pc=%u=%s sp_status=%s remote_sccp_status=%s\n", + pcst->affected_pc, osmo_ss7_pointcode_print(cs7, pcst->affected_pc), + osmo_sccp_sp_status_name(pcst->sp_status), + osmo_sccp_rem_sccp_status_name(pcst->remote_sccp_status)); + + /* If we don't care about that point-code, ignore PCSTATE. */ + smlc = get_smlc_by_pc(pcst->affected_pc); + if (!smlc) + return; + + /* See if this marks the point code to have become available, or to have been lost. + * + * I want to detect two events: + * - connection event (both indicators say PC is reachable). + * - disconnection event (at least one indicator says the PC is not reachable). + * + * There are two separate incoming indicators with various possible values -- the incoming events can be: + * + * - neither connection nor disconnection indicated -- just indicating congestion + * connected == false, disconnected == false --> do nothing. + * - both incoming values indicate that we are connected + * --> trigger connected + * - both indicate we are disconnected + * --> trigger disconnected + * - one value indicates 'connected', the other indicates 'disconnected' + * --> trigger disconnected + * + * Congestion could imply that we're connected, but it does not indicate that a PC's reachability changed, so no need to + * trigger on that. + */ + connected = false; + disconnected = false; + + switch (pcst->sp_status) { + case OSMO_SCCP_SP_S_ACCESSIBLE: + connected = true; + break; + case OSMO_SCCP_SP_S_INACCESSIBLE: + disconnected = true; + break; + default: + case OSMO_SCCP_SP_S_CONGESTED: + /* Neither connecting nor disconnecting */ + break; + } + + switch (pcst->remote_sccp_status) { + case OSMO_SCCP_REM_SCCP_S_AVAILABLE: + if (!disconnected) + connected = true; + break; + case OSMO_SCCP_REM_SCCP_S_UNAVAILABLE_UNKNOWN: + case OSMO_SCCP_REM_SCCP_S_UNEQUIPPED: + case OSMO_SCCP_REM_SCCP_S_INACCESSIBLE: + disconnected = true; + connected = false; + break; + default: + case OSMO_SCCP_REM_SCCP_S_CONGESTED: + /* Neither connecting nor disconnecting */ + break; + } + + if (disconnected && bssmap_reset_is_conn_ready(smlc->bssmap_reset)) { + LOGP(DLCS, LOGL_NOTICE, + "now unreachable: N-PCSTATE ind: pc=%u=%s sp_status=%s remote_sccp_status=%s\n", + pcst->affected_pc, osmo_ss7_pointcode_print(cs7, pcst->affected_pc), + osmo_sccp_sp_status_name(pcst->sp_status), + osmo_sccp_rem_sccp_status_name(pcst->remote_sccp_status)); + /* A previously usable MSC has disconnected. Kick the BSSMAP back to DISC state. */ + bssmap_reset_set_disconnected(smlc->bssmap_reset); + } else if (connected && !bssmap_reset_is_conn_ready(smlc->bssmap_reset)) { + LOGP(DLCS, LOGL_NOTICE, + "now available: N-PCSTATE ind: pc=%u=%s sp_status=%s remote_sccp_status=%s\n", + pcst->affected_pc, osmo_ss7_pointcode_print(cs7, pcst->affected_pc), + osmo_sccp_sp_status_name(pcst->sp_status), + osmo_sccp_rem_sccp_status_name(pcst->remote_sccp_status)); + /* A previously unusable MSC has become reachable. Trigger immediate BSSMAP RESET -- we would resend a + * RESET either way, but we might as well do it now to speed up connecting. */ + bssmap_reset_resend_reset(smlc->bssmap_reset); + } +} + static int sccp_sap_up(struct osmo_prim_hdr *oph, void *_scu) { struct osmo_scu_prim *scu_prim = (struct osmo_scu_prim *)oph; @@ -257,6 +357,10 @@ } break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_PCSTATE, PRIM_OP_INDICATION): + handle_pcstate_ind(osmo_sccp_get_ss7(sccp), &scu_prim->u.pcstate); + break; + default: LOGP(DLCS, LOGL_ERROR, "Unhandled SIGTRAN primitive %s.%s\n", osmo_scu_prim_type_name(oph->primitive), -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I16900b9c2b840d4c7d8471c1f69b19601e892b2d Gerrit-Change-Number: 41993 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: assignment_fsm: Fix use-after-free of lchan->conn
by pespin 04 Feb '26

04 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42010?usp=email ) Change subject: assignment_fsm: Fix use-after-free of lchan->conn ...................................................................... assignment_fsm: Fix use-after-free of lchan->conn Scenario: * A DYNAMIC/OSMOCOM TS in PDCH mode is selected to be used for TCH/F, hence the TS is being switched to TCH/F: RF Channel Release is being transmitted and waiting to receive RF Channel release ACK. Hence, lchan is in state LCHAN_ST_WAIT_TS_READY, and there's a conn with an assignment FSM pointing to it in conn->assignment.new_lchan. lchan->conn also points to the related conn. * The BSSMAP SCCP link goes down (link lost), which will terminate the conn->fi of all conns related to the MSC peer going down. During that teardown, first gscon_pre_term()->gscon_release_lchans()-> assignment_reset() is called, which sets conn->assignment.new_lchan=NULL and calls lchan_release(). This path leaves conn->assignment.new_lchan->conn untouched! * Later in the call path, when finally the bsc_subscr is put() to 0 references and associated lchan gets its lchan_forget_conn() called, it will access lchan->conn which was not freed in the previous step mentioned above during assignment_reset(). This patch fixes the issue by adding a lchan_forget_conn() after the lchan_release() in assignment_reset(), to make sure the conn is no longer user by the lchan afterwards. Related: OS#6936 Change-Id: Ifbb9a61cd8a40d953ef5c2b52f9be9ef0dffefa4 --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index f0a2781..e5392f6 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -127,6 +127,7 @@ struct gsm_lchan *lchan = conn->assignment.new_lchan; conn->assignment.new_lchan = NULL; lchan_release(lchan, false, true, RSL_ERR_EQUIPMENT_FAIL, NULL); + lchan_forget_conn(lchan); } if (conn->assignment.created_ci_for_msc) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifbb9a61cd8a40d953ef5c2b52f9be9ef0dffefa4 Gerrit-Change-Number: 42010 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: Lb: Handle N-PCSTATE.ind
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41993?usp=email ) Change subject: Lb: Handle N-PCSTATE.ind ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I16900b9c2b840d4c7d8471c1f69b19601e892b2d Gerrit-Change-Number: 41993 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 17:01:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: Lb: Handle SCCP N-NOTICE.ind
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: fixeria, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email ) Change subject: Lb: Handle SCCP N-NOTICE.ind ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I689bf2f2c4311fbc1da92f02c27078a1c00dda1a Gerrit-Change-Number: 41992 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 17:01:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: Lb: Handle N-PCSTATE.ind
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41993?usp=email ) Change subject: Lb: Handle N-PCSTATE.ind ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/lb.c: https://gerrit.osmocom.org/c/osmo-bsc/+/41993/comment/fb45d842_fb627efa?usp… : PS2, Line 147: /* Find an SMLC by its remote sigtran point code on a given cs7 instance. */ > Done Yes, because so far we only support one smlc, but I thought it was good to leave this encapsulation in place since we have similar code to handle the A interface in osmo_bsc_sigtran, this way both can be modified similarly. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I16900b9c2b840d4c7d8471c1f69b19601e892b2d Gerrit-Change-Number: 41993 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 17:01:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log