September 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: contrib/generate_build_dep.sh: pass '-n' to mv

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41109?usp=email ) Change subject: contrib/generate_build_dep.sh: pass '-n' to mv ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I9a95afcac54dec9684f34224a912574bb387e96c Gerrit-Change-Number: 41109 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Sep 2025 10:09:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 days, 22 hours

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: debian: add osmo-s1gw.install

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41110?usp=email ) Change subject: debian: add osmo-s1gw.install ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia396351a73b665cbb9927b525e01ab451a6b0f78 Gerrit-Change-Number: 41110 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Sep 2025 10:08:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 days, 22 hours

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: contrib/generate_build_dep.sh: pass '-n' to mv

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41109?usp=email ) Change subject: contrib/generate_build_dep.sh: pass '-n' to mv ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I9a95afcac54dec9684f34224a912574bb387e96c Gerrit-Change-Number: 41109 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 15 Sep 2025 09:43:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

6 days, 22 hours

1
0
0 0

[S] Change in ...osmo-s1gw[master]: enb_registry: fetch_enb_list/0: return sorted list

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41102?usp=email ) Change subject: enb_registry: fetch_enb_list/0: return sorted list ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > why do you need it sorted? at first hand this looks like a waste of cpu time because afaiu that's no […] Well, because `maps` in Erlang do not guarantee a specific order of elements, so without sorting you get a list in random order. Sorted list, on the other hand, clearly reflects the lifetime of eNBs (older ones first). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41102?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I51cc55982dda5f88e967b63433fb7e5be292aca1 Gerrit-Change-Number: 41102 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Sep 2025 09:43:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 days, 22 hours

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: README.md: mention 'make analyze'

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41107?usp=email ) Change subject: README.md: mention 'make analyze' ...................................................................... README.md: mention 'make analyze' Change-Id: I5af11dc51ccb514918dd145975bed55381d4b76b --- M README.md 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/README.md b/README.md index d26c505..cfb6f52 100644 --- a/README.md +++ b/README.md @@ -93,6 +93,12 @@ $ make check ``` +Additionally, you can run the static analyser (Dialyzer): + +``` +$ make analyze +``` + Running ------- -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5af11dc51ccb514918dd145975bed55381d4b76b Gerrit-Change-Number: 41107 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 days, 22 hours

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: README.md: cosmetic: s/osmo_s1gw/OsmoS1GW/

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41106?usp=email ) Change subject: README.md: cosmetic: s/osmo_s1gw/OsmoS1GW/ ...................................................................... README.md: cosmetic: s/osmo_s1gw/OsmoS1GW/ Change-Id: I0346123cccf78c85d36ce71e68e83204178a5ee9 --- M README.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/README.md b/README.md index b85bbbc..d26c505 100644 --- a/README.md +++ b/README.md @@ -97,7 +97,7 @@ Running ------- -Once `osmo_s1gw` is built, you can start it this way: +Once OsmoS1GW is built, you can start it this way: ``` $ make run -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I0346123cccf78c85d36ce71e68e83204178a5ee9 Gerrit-Change-Number: 41106 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 days, 22 hours

1
0
0 0

[S] Change in ...osmo-s1gw[master]: README.md: document installation

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41108?usp=email ) Change subject: README.md: document installation ...................................................................... README.md: document installation Change-Id: I383d1d0aa89e6c3c68985464f727aaadbb7d35ce --- M README.md 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/README.md b/README.md index cfb6f52..e1723e9 100644 --- a/README.md +++ b/README.md @@ -110,6 +110,29 @@ ``` +Installation +------------ + +OsmoS1GW is built for common versions of Debian, Ubuntu and other distributions as a part of +the [Osmocom binary packages](https://osmocom.org/projects/cellular-infrastructure/wiki/Binary_…. +If you're not doing development, it is suggested to simply use those binary packages, rather +than building from source. Otherwise, you can invoke the `install` target: + +``` +$ sudo make install +``` + +This will install the following: + +* `/usr/lib/osmo-s1gw` - complete OTP release package +* `/usr/bin/osmo-s1gw` - convenience script for running `osmo-s1gw` +* `/lib/systemd/system/osmo-s1gw.service` - systemd unit file +* `/etc/osmocom/osmo-s1gw.config` - the configuration file + +The installation paths can be adjusted using `DESTDIR`, `LIBDIR`, `BINDIR`, +`CONFDIR`, and `SYSTEMDUNITDIR` variables. + + Configuration ------------- -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I383d1d0aa89e6c3c68985464f727aaadbb7d35ce Gerrit-Change-Number: 41108 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 days, 22 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: S1GW: Add test case to test release of e-RABs during handover prepera...

by jolly

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094?usp=email ) Change subject: S1GW: Add test case to test release of e-RABs during handover preperation ...................................................................... Patch Set 3: (6 comments) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/7ddd48f2_a839… : PS2, Line 1210: in ERabIdxList erabs_release := {}) > For `ERabIdxList`, yes, we don't really need `in/out`. […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/17025b7e_7f51… : PS2, Line 1247: in ERabIdxList erabs_release := {}) > I vote for stopping adding more "in" churn :D Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/cf3a35e9_6fd7… : PS2, Line 1720: in ERabIdxList erabs_forward, > Why are you so obsessed with this? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/b79698c9_4429… : PS2, Line 1718: function f_ConnHdlr_handover_cmd(MME_UE_S1AP_ID mme_ue_id, : ENB_UE_S1AP_ID enb_ue_id, : in ERabIdxList erabs_forward, : > Nitpick: in the existing API, arguments `mme_ue_id` and `enb_ue_id` usually follow `ERabList`/`ERabI […] Done File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/36a7ea75_6834… : PS2, Line 911: for (var integer i := 0; i < lengthof(erabs_forward); i := i + 1) { > I see this logic repeated in several places, so I think it's worth having a function in `S1GW_ConnHd […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/bcbe3fa7_39a3… : PS2, Line 912: > tabs vs spaces Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic70ba19c0a6e349f63aae124607d075b6d19e779 Gerrit-Change-Number: 41094 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Sep 2025 08:56:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 days, 23 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: S1GW: Add test case to test release of failed e-RABs during handover ...

by jolly

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095?usp=email ) Change subject: S1GW: Add test case to test release of failed e-RABs during handover resource allocation ...................................................................... Patch Set 2: (7 comments) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/a0d9c58d_8fe5… : PS2, Line 1131: in ERabIdxList erabs_failed := {}) > No more "in" churn please. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/dcdb6b75_1e21… : PS2, Line 1706: var ERabIdxList erabs_admitted; : for (var integer i := 0; i < lengthof(g_pars.erabs); i := i + 1) { : erabs_admitted[i] := i; : } > See my comment about `f_ERabList_compose()` in previous patch. We cannot use f_ERabList_compose(), because we create an index list here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/5b6b506b_5655… : PS2, Line 1720: f_ConnHdlr_tx_handover_ack(erabs_admitted, mme_ue_id, enb_ue_id, erabs_failed); : log("[eNB -> S1GW] -> MME: HANDOVER REQUEST ACKNOWLEDGE"); > We usually log first: […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/2a36c20c_c245… : PS2, Line 1726: for (var integer i := 0; i < lengthof(erabs_admitted); i := i + 1) { : var ERabIdx idx := erabs_admitted[i]; : erabs[i] := g_pars.erabs[idx]; : } > See my comment about `f_ERabList_compose()` in previous patch. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/c084fd0a_b165… : PS2, Line 1736: for (var integer i := 0; i < lengthof(erabs_failed); i := i + 1) { : var ERabIdx idx := erabs_failed[i]; : erabs[i] := g_pars.erabs[idx]; : > See my comment about `f_ERabList_compose()` in previous patch. Done File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/0d8aa37b_31d1… : PS2, Line 955: f_ConnHdlr_handover_ack( > no need for this extra line in params. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/8d5e10a0_ea8e… : PS2, Line 962: for (var integer i := 0; i < lengthof(erabs_admitted); i := i + 1) { : var ERabIdx idx := erabs_admitted[i]; : erabs_left[i] := g_pars.erabs[idx]; : > See my comment about `f_ERabList_compose()` in previous patch. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic14f560ae16b8386e58ac85f8af53b19d7c7a5c9 Gerrit-Change-Number: 41095 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Sep 2025 08:56:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

6 days, 23 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: S1GW: Add test case to test release of failed e-RABs during handover ...

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: S1GW: Add test case to test release of failed e-RABs during handover resource allocation ...................................................................... S1GW: Add test case to test release of failed e-RABs during handover resource allocation HANDOVER REQUEST ACKNOWLEDGE indicates admitted and failed eRABs. The test provides two lists and expects osmo-s1gw to release only those e-RABs that are included int the "E-RABs Failed to Setup List" IE. Related: SYS#7309 Change-Id: Ic14f560ae16b8386e58ac85f8af53b19d7c7a5c9 --- M library/s1ap/S1AP_Templates.ttcn M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn M s1gw/expected-results.xml 4 files changed, 97 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/41095/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic14f560ae16b8386e58ac85f8af53b19d7c7a5c9 Gerrit-Change-Number: 41095 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

6 days, 23 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025