September 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup: fix speech bearer capabilities

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email ) Change subject: gsm48_cc_tx_setup: fix speech bearer capabilities ...................................................................... gsm48_cc_tx_setup: fix speech bearer capabilities Send the bearer capability IE from 3GPP TS 24.008 § D.1.2 for speech instead of the result from gsm48_cc_tx_setup_set_bearer_cap() for the network to MS direction. This is needed, because: - We shall send spare bits for the radio channel requirement in the network to MS direction, see 3GPP TS 24.008 § D.1.1 and Table 10.5.102). - We could in theory send a speech version list that MS are then supposed to ignore (end of Table 10.5.103), but this causes bugs in some MS so it is better to not send it (OS#6656). Related: OS#6657, OS#6655, OS#6656 Related: osmo-ttcn3-hacks I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 Depends: libosmocore I97101c977104eae82e4850d40f9abd15aa03e33e Change-Id: I7046e9244fd9d4301ee2c4df1147a619f753739c --- M TODO-RELEASE M src/libmsc/gsm_04_08_cc.c M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err 4 files changed, 42 insertions(+), 27 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..6fb5213 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmocore > 1.11.0 uses new GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS (I97101c977104eae82e4850d40f9abd15aa03e33e) diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 3968fbe..46ab176 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -911,8 +911,7 @@ /* Compose Bearer Capability information that reflects only the codecs (Speech * Versions) / CSD bearer services remaining after intersecting MS, BSS and - * remote call leg restrictions. To store in trans for later use, and to - * include in the outgoing CC Setup message. */ + * remote call leg restrictions. To store in trans for later use. */ static int gsm48_cc_tx_setup_set_bearer_cap(struct gsm_trans *trans, const struct gsm_mncc *setup) { int rc; @@ -978,11 +977,30 @@ return 0; } -static struct msgb *gsm48_cc_tx_setup_encode_msg(const struct gsm_mncc_bearer_cap *bearer_cap, +static struct msgb *gsm48_cc_tx_setup_encode_msg(const struct gsm_mncc_bearer_cap *bearer_cap_orig, const struct gsm_mncc *setup) { struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 CC SETUP"); struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_put(msg, sizeof(*gh)); + const struct gsm_mncc_bearer_cap *bearer_cap = bearer_cap_orig; + + /* Send the bearer capability IE from 3GPP TS 24.008 § D.1.2 for speech + * instead of the result from gsm48_cc_tx_setup_set_bearer_cap() for + * the network to MS direction. This is needed, because: + * - We shall send spare bits for the radio channel requirement in the + * network to MS direction (3GPP TS 24.008 § D.1.1 and Table + * 10.5.102). + * - We could in theory send a speech version list that MS are then + * supposed to ignore (end of Table 10.5.103), but this causes bugs + * in some MS so it is better to not send it (OS#6656). */ + static const struct gsm_mncc_bearer_cap bcap_speech = { + .transfer = GSM48_BCAP_ITCAP_SPEECH, + .radio = GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS, + .speech_ver = { -1 }, + }; + + if (bearer_cap->transfer == GSM48_BCAP_ITCAP_SPEECH) + bearer_cap = &bcap_speech; gh->msg_type = GSM48_MT_CC_SETUP; diff --git a/tests/msc_vlr/msc_vlr_test_call.c b/tests/msc_vlr/msc_vlr_test_call.c index 14c8ea3..376a8c7 100644 --- a/tests/msc_vlr/msc_vlr_test_call.c +++ b/tests/msc_vlr/msc_vlr_test_call.c @@ -386,7 +386,7 @@ VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); btw("MS sends SecurityModeControl acceptance, VLR accepts, sends CC Setup"); - dtap_expect_tx("0305" /* CC: Setup */ "04 04 60 04 05 8b" /* Bearer Cap, speech ver of AMR-FR and AMR-HR */); + dtap_expect_tx("0305" /* CC: Setup */ "04 01 a0" /* Bearer Cap, TS 24.008 § D.1.2 (OS#6657) */); ms_sends_security_mode_complete(1); btw("MS confirms call, we create a RAN-side RTP and forward MNCC_CALL_CONF_IND"); @@ -524,7 +524,7 @@ VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); btw("MS sends SecurityModeControl acceptance, VLR accepts, sends CC Setup"); - dtap_expect_tx("0305" /* CC: Setup */ "04 04 60 04 05 8b" /* Bearer Cap, speech ver of AMR-FR and AMR-HR */); + dtap_expect_tx("0305" /* CC: Setup */ "04 01 a0" /* Bearer Cap, TS 24.008 § D.1.2 (OS#6657) */); ms_sends_security_mode_complete(1); btw("MS confirms call, we create a RAN-side RTP and forward MNCC_CALL_CONF_IND"); @@ -1510,17 +1510,13 @@ return; } - btw("VLR accepts, MSC sends CC Setup with Bearer Capability = %s", - bcap_name(t->mt_tx_cc_setup_bcap)); - char *cc_setup_bcap = talloc_asprintf(msc_vlr_tests_ctx, "0305%s", - bcap_hexstr(t->mt_tx_cc_setup_bcap)); - dtap_expect_tx(cc_setup_bcap); + btw("VLR accepts, MSC sends CC Setup with Bearer Capability = TS 24.008 § D.1.2"); + dtap_expect_tx("0305" /* CC: Setup */ "04 01 a0" /* Bearer Cap, TS 24.008 § D.1.2 (OS#6657) */); ms_sends_compl_l3("062707" "03575886" /* classmark 2 */ "089910070000106005" /* IMSI */, codec_list(t->mt_rx_compl_l3_codec_list_bss_supported)); OSMO_ASSERT(dtap_tx_confirmed); - talloc_free(cc_setup_bcap); btw("MS confirms call, we create a RAN-side RTP and forward MNCC_CALL_CONF_IND"); expect_crcx(RTP_TO_CN); diff --git a/tests/msc_vlr/msc_vlr_test_call.err b/tests/msc_vlr/msc_vlr_test_call.err index ffef105..b7929b7 100644 --- a/tests/msc_vlr/msc_vlr_test_call.err +++ b/tests/msc_vlr/msc_vlr_test_call.err @@ -800,7 +800,7 @@ DCC trans(CC:NULL IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) new state NULL -> CALL_PRESENT DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: Sending DTAP: CC GSM48_MT_CC_SETUP DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: RAN encode: DTAP on UTRAN-Iu -- DTAP --UTRAN-Iu--> MS: GSM48_MT_CC_SETUP: 030504046004058b +- DTAP --UTRAN-Iu--> MS: GSM48_MT_CC_SETUP: 03050401a0 - DTAP matches expected message DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DVLR VLR subscr IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 - Paging: now used by 3 (attached,CC,active-conn) @@ -1320,7 +1320,7 @@ DCC trans(CC:NULL IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) new state NULL -> CALL_PRESENT DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: Sending DTAP: CC GSM48_MT_CC_SETUP DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_COMMUNICATING}: RAN encode: DTAP on UTRAN-Iu -- DTAP --UTRAN-Iu--> MS: GSM48_MT_CC_SETUP: 030504046004058b +- DTAP --UTRAN-Iu--> MS: GSM48_MT_CC_SETUP: 03050401a0 - DTAP matches expected message DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DVLR VLR subscr IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 - Paging: now used by 3 (attached,CC,active-conn) @@ -2875,7 +2875,7 @@ DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - mncc_tx_to_gsm_cc: now used by 3 (attached,CC,Paging) paging_sent == 1 - MS replies with Paging Response, with Codec List (BSS Supported) = FR1 FR2 FR3 HR1 HR3 -- VLR accepts, MSC sends CC Setup with Bearer Capability = AMR AMR AMR GSM-EFR GSM GSM-HR-08 +- VLR accepts, MSC sends CC Setup with Bearer Capability = TS 24.008 § D.1.2 MSC <--GERAN-A-- MS: GSM48_MT_RR_PAG_RESP new conn DMSC msub_fsm{active}: Allocated @@ -2923,7 +2923,7 @@ DCC trans(CC:NULL IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP callref-0x423 tid-0) new state NULL -> CALL_PRESENT DBSSAP msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: Sending DTAP: CC GSM48_MT_CC_SETUP DMSC msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: RAN encode: DTAP on GERAN-A -- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 030504076004050b020081 +- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 03050401a0 - DTAP matches expected message DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - Paging: now used by 4 (attached,CC,proc_arq_vlr_fn_init,active-conn) @@ -3490,7 +3490,7 @@ DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - mncc_tx_to_gsm_cc: now used by 3 (attached,CC,Paging) paging_sent == 1 - MS replies with Paging Response, with Codec List (BSS Supported) = FR1 FR2 FR3 HR1 HR3 -- VLR accepts, MSC sends CC Setup with Bearer Capability = GSM +- VLR accepts, MSC sends CC Setup with Bearer Capability = TS 24.008 § D.1.2 MSC <--GERAN-A-- MS: GSM48_MT_RR_PAG_RESP new conn DMSC msub_fsm{active}: Allocated @@ -3538,7 +3538,7 @@ DCC trans(CC:NULL IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP callref-0x423 tid-0) new state NULL -> CALL_PRESENT DBSSAP msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: Sending DTAP: CC GSM48_MT_CC_SETUP DMSC msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: RAN encode: DTAP on GERAN-A -- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 030504022080 +- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 03050401a0 - DTAP matches expected message DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - Paging: now used by 4 (attached,CC,proc_arq_vlr_fn_init,active-conn) @@ -4093,7 +4093,7 @@ DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - mncc_tx_to_gsm_cc: now used by 3 (attached,CC,Paging) paging_sent == 1 - MS replies with Paging Response, with Codec List (BSS Supported) = FR1 FR2 FR3 HR1 HR3 -- VLR accepts, MSC sends CC Setup with Bearer Capability = GSM +- VLR accepts, MSC sends CC Setup with Bearer Capability = TS 24.008 § D.1.2 MSC <--GERAN-A-- MS: GSM48_MT_RR_PAG_RESP new conn DMSC msub_fsm{active}: Allocated @@ -4141,7 +4141,7 @@ DCC trans(CC:NULL IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP callref-0x423 tid-0) new state NULL -> CALL_PRESENT DBSSAP msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: Sending DTAP: CC GSM48_MT_CC_SETUP DMSC msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: RAN encode: DTAP on GERAN-A -- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 030504022080 +- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 03050401a0 - DTAP matches expected message DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - Paging: now used by 4 (attached,CC,proc_arq_vlr_fn_init,active-conn) @@ -4723,7 +4723,7 @@ DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - mncc_tx_to_gsm_cc: now used by 3 (attached,CC,Paging) paging_sent == 1 - MS replies with Paging Response, with Codec List (BSS Supported) = FR1 -- VLR accepts, MSC sends CC Setup with Bearer Capability = GSM +- VLR accepts, MSC sends CC Setup with Bearer Capability = TS 24.008 § D.1.2 MSC <--GERAN-A-- MS: GSM48_MT_RR_PAG_RESP new conn DMSC msub_fsm{active}: Allocated @@ -4771,7 +4771,7 @@ DCC trans(CC:NULL IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP callref-0x423 tid-0) new state NULL -> CALL_PRESENT DBSSAP msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: Sending DTAP: CC GSM48_MT_CC_SETUP DMSC msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: RAN encode: DTAP on GERAN-A -- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 030504022080 +- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 03050401a0 - DTAP matches expected message DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - Paging: now used by 4 (attached,CC,proc_arq_vlr_fn_init,active-conn) @@ -5353,7 +5353,7 @@ DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - mncc_tx_to_gsm_cc: now used by 3 (attached,CC,Paging) paging_sent == 1 - MS replies with Paging Response, with Codec List (BSS Supported) = FR1 FR2 FR3 HR1 HR3 -- VLR accepts, MSC sends CC Setup with Bearer Capability = AMR AMR AMR GSM-EFR GSM GSM-HR-08 +- VLR accepts, MSC sends CC Setup with Bearer Capability = TS 24.008 § D.1.2 MSC <--GERAN-A-- MS: GSM48_MT_RR_PAG_RESP new conn DMSC msub_fsm{active}: Allocated @@ -5401,7 +5401,7 @@ DCC trans(CC:NULL IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP callref-0x423 tid-0) new state NULL -> CALL_PRESENT DBSSAP msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: Sending DTAP: CC GSM48_MT_CC_SETUP DMSC msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: RAN encode: DTAP on GERAN-A -- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 030504076004050b020081 +- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 03050401a0 - DTAP matches expected message DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - Paging: now used by 4 (attached,CC,proc_arq_vlr_fn_init,active-conn) @@ -5980,7 +5980,7 @@ DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - mncc_tx_to_gsm_cc: now used by 3 (attached,CC,Paging) paging_sent == 1 - MS replies with Paging Response, with Codec List (BSS Supported) = FR1 FR2 FR3 HR1 HR3 -- VLR accepts, MSC sends CC Setup with Bearer Capability = AMR AMR AMR GSM-EFR GSM GSM-HR-08 +- VLR accepts, MSC sends CC Setup with Bearer Capability = TS 24.008 § D.1.2 MSC <--GERAN-A-- MS: GSM48_MT_RR_PAG_RESP new conn DMSC msub_fsm{active}: Allocated @@ -6028,7 +6028,7 @@ DCC trans(CC:NULL IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP callref-0x423 tid-0) new state NULL -> CALL_PRESENT DBSSAP msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: Sending DTAP: CC GSM48_MT_CC_SETUP DMSC msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: RAN encode: DTAP on GERAN-A -- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 030504076004050b020081 +- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 03050401a0 - DTAP matches expected message DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - Paging: now used by 4 (attached,CC,proc_arq_vlr_fn_init,active-conn) @@ -6619,7 +6619,7 @@ DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - mncc_tx_to_gsm_cc: now used by 3 (attached,CC,Paging) paging_sent == 1 - MS replies with Paging Response, with Codec List (BSS Supported) = FR1 FR2 FR3 HR1 HR3 -- VLR accepts, MSC sends CC Setup with Bearer Capability = AMR AMR AMR GSM-EFR GSM GSM-HR-08 +- VLR accepts, MSC sends CC Setup with Bearer Capability = TS 24.008 § D.1.2 MSC <--GERAN-A-- MS: GSM48_MT_RR_PAG_RESP new conn DMSC msub_fsm{active}: Allocated @@ -6667,7 +6667,7 @@ DCC trans(CC:NULL IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP callref-0x423 tid-0) new state NULL -> CALL_PRESENT DBSSAP msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: Sending DTAP: CC GSM48_MT_CC_SETUP DMSC msc_a(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){MSC_A_ST_COMMUNICATING}: RAN encode: DTAP on GERAN-A -- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 030504076004050b020081 +- DTAP --GERAN-A--> MS: GSM48_MT_CC_SETUP: 03050401a0 - DTAP matches expected message DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-46071:GERAN-A:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DVLR VLR subscr IMSI-901700000010650:MSISDN-46071 - Paging: now used by 4 (attached,CC,proc_arq_vlr_fn_init,active-conn) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7046e9244fd9d4301ee2c4df1147a619f753739c Gerrit-Change-Number: 41043 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 week

1
0
0 0

[XS] Change in libosmo-asn1-tcap[master]: gitreview: new file

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41059?usp=email ) Change subject: gitreview: new file ...................................................................... gitreview: new file Make "grd" (git review download) from osmo-dev work. Change-Id: I73e6d15b80c95d5a576bd1d0fb47c1e7baac2cba --- A .gitreview 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: osmith: Verified laforge: Looks good to me, approved diff --git a/.gitreview b/.gitreview new file mode 100644 index 0000000..1dd82d0 --- /dev/null +++ b/.gitreview @@ -0,0 +1,3 @@ +[gerrit] +host=gerrit.osmocom.org +project=libosmo-asn1-tcap -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41059?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I73e6d15b80c95d5a576bd1d0fb47c1e7baac2cba Gerrit-Change-Number: 41059 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 week

1
0
0 0

[XS] Change in libosmocore[master]: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email ) Change subject: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS ...................................................................... gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS From network to MS, we must send spare bits that are encoded the same as GSM48_BCAP_RRQ_FR_ONLY. Add a define, so it is obvious that those are spare bits. Related: OS#6657 Related: osmo-msc I7046e9244fd9d4301ee2c4df1147a619f753739c Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index aad50d6..27182b6 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -2154,6 +2154,9 @@ GSM48_BCAP_RRQ_FR_ONLY = 1, GSM48_BCAP_RRQ_DUAL_HR = 2, GSM48_BCAP_RRQ_DUAL_FR = 3, +/* GSM 04.08 Table 10.72: In network to MS direction, the network must send + * spare bits that are encoded the same as FR_ONLY. */ +#define GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS GSM48_BCAP_RRQ_FR_ONLY }; /* GSM 04.08 Bearer Capability: Rate Adaption */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e Gerrit-Change-Number: 41056 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 week

1
0
0 0

[XS] Change in libosmocore[master]: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email ) Change subject: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS ...................................................................... Patch Set 2: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/41056/comment/4f9bd5f2_61639a95?… : PS1, Line 2158: /* GSM 04.08 Table 10.72: In network to MS direction, the network must send > I really had to use CTRL+F to actually find the enum, so not close enough ;) […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e Gerrit-Change-Number: 41056 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Sep 2025 06:33:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 week

1
0
0 0

[XS] Change in libosmo-asn1-tcap[master]: Fix decoding of TCAP messages

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email ) Change subject: Fix decoding of TCAP messages ...................................................................... Fix decoding of TCAP messages Recent versions of asn1c fail while decoding the DialoguePortion of a TCAP message - probably because Tag APPLICATION 11 is sent as constructed tag and the WS adaptation expects a primitive one. Not sure if this ever worked with an older asn1c version, maybe it ignored this discrepancy. The described behavior also happens with mouse07410/asn1c 2c06555 used in the next patch to regenerate the code. In any case the correct encoding of the DialoguePortion is as EXTERNAL. Support for proper EXTERNAL asn1c decoding is missing in all versions of asn1c except https://github.com/mouse07410/asn1c (See PR #3/#5) so use that when regenerating. Related: SYS#7486 Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65 --- M asn/tcap.asn 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve osmith: Verified diff --git a/asn/tcap.asn b/asn/tcap.asn index 9df2e5b..2b967cd 100644 --- a/asn/tcap.asn +++ b/asn/tcap.asn @@ -66,11 +66,11 @@ -- APDU, or by the TC-User in which case it could be either an ABRT APDU or data in some user-defined -- abstract syntax. ---DialoguePortion ::= [APPLICATION 11] EXPLICIT EXTERNAL +DialoguePortion ::= [APPLICATION 11] EXPLICIT EXTERNAL -- WS adaptation -DialoguePortion ::= [APPLICATION 11] IMPLICIT DialogueOC -DialogueOC ::= OCTET STRING +--DialoguePortion ::= [APPLICATION 11] IMPLICIT DialogueOC +--DialogueOC ::= OCTET STRING -- The dialogue portion carries the dialogue control PDUs as value of the external data type. -- The direct reference should be set to { ccitt recommendation q 773 as (1) dialogue-as (1) version (1) } -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65 Gerrit-Change-Number: 41021 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de>

1 week

1
0
0 0

[M] Change in ...osmo-s1gw[master]: [REST] osmo-s1gw-cli.py skeleton

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41097?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: [REST] osmo-s1gw-cli.py skeleton ...................................................................... [REST] osmo-s1gw-cli.py skeleton This is an interactive shell based on Python's cmd2 library, providing an alternative to the traditional VTY interface used in many Osmocom projects. It communicates with the main process via the REST interface. Currently there's only one command fetching the OpenAPI specification. More commands will be introduced in follow-up commits. Change-Id: I05600f2fa6d213b9cee28871761231722ff5b876 Related: SYS#7066 --- M Makefile M README.md A contrib/osmo-s1gw-cli.py M debian/control M debian/copyright A debian/osmo-s1gw-cli.install 6 files changed, 212 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/97/41097/5 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I05600f2fa6d213b9cee28871761231722ff5b876 Gerrit-Change-Number: 41097 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 week

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: debian: add missing libsctp dependency

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41111?usp=email ) Change subject: debian: add missing libsctp dependency ...................................................................... debian: add missing libsctp dependency This dependency is *not* added automatically by `${shlibs:Depends}` because it's not a dependency of `erlang-base`: it's listed as a recommendation (in `Recommends`). The `osmo-s1gw` package needs to depend on libsctp explicitly; otherwise it will not work in a clean environment. Change-Id: I9add00e501110b54447faf89fce0f18432663463 --- M debian/control 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/11/41111/1 diff --git a/debian/control b/debian/control index b0bb9b4..45c3847 100644 --- a/debian/control +++ b/debian/control @@ -15,7 +15,8 @@ Package: osmo-s1gw Architecture: any Depends: ${shlibs:Depends}, - ${misc:Depends} + ${misc:Depends}, + ${libsctp:Version} Multi-Arch: foreign Description: Osmocom S1 gateway This can be used on the S1 interface between eNB and MME/CN, and -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I9add00e501110b54447faf89fce0f18432663463 Gerrit-Change-Number: 41111 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 week

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: debian: add osmo-s1gw.install

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41110?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: debian: add osmo-s1gw.install ...................................................................... debian: add osmo-s1gw.install The `*.install` files give precise control over what gets packaged, allowing to exclude files and/or include additional ones. This will be needed in a follow-up patches adding misc files. Change-Id: Ia396351a73b665cbb9927b525e01ab451a6b0f78 --- A debian/osmo-s1gw.install M debian/rules 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/10/41110/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia396351a73b665cbb9927b525e01ab451a6b0f78 Gerrit-Change-Number: 41110 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 week

1
0
0 0

[M] Change in ...osmo-s1gw[master]: [REST] OpenAPI specification skeleton

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41096?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: [REST] OpenAPI specification skeleton ...................................................................... [REST] OpenAPI specification skeleton Change-Id: I84e6ef5cc67cd26b11f7bed8510420e43e18c69b Related: SYS#7066 --- M Makefile M README.md A contrib/openapi.yaml A contrib/yaml2json.py M debian/copyright M debian/osmo-s1gw.install A priv/openapi.json 7 files changed, 57 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/96/41096/5 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I84e6ef5cc67cd26b11f7bed8510420e43e18c69b Gerrit-Change-Number: 41096 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 week, 1 day

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: debian: add osmo-s1gw.install

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41110?usp=email ) Change subject: debian: add osmo-s1gw.install ...................................................................... debian: add osmo-s1gw.install The `*.install` files give precise control over what gets packaged, allowing to exclude files and/or include additional ones. This will be needed in a follow-up patches adding misc files. Change-Id: Ia396351a73b665cbb9927b525e01ab451a6b0f78 --- A debian/osmo-s1gw.install 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/10/41110/1 diff --git a/debian/osmo-s1gw.install b/debian/osmo-s1gw.install new file mode 100644 index 0000000..b52efe2 --- /dev/null +++ b/debian/osmo-s1gw.install @@ -0,0 +1,4 @@ +usr/bin/osmo-s1gw +usr/lib/osmo-s1gw +etc/osmocom/osmo-s1gw.config +lib/systemd/system/osmo-s1gw.service -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia396351a73b665cbb9927b525e01ab451a6b0f78 Gerrit-Change-Number: 41110 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 week, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025