Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40818?usp=email )
Change subject: NGAP_Templates: Fixes and improvements for UEContextReleaseComplete
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File library/ngap/NGAP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40818/comment/7c183f64_e7d2… :
PS1, Line 2012: protocolIEs
Godness, more spaces! Let's hit the overscan area of a screen :D
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40818?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I50da7cd4cb15d8e6b2c68b21a4e4be93e3973593
Gerrit-Change-Number: 40818
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Aug 2025 17:06:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40812?usp=email )
Change subject: Adopt iu_client from osmo-iuh
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'll fix linter issues in a following commit.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40812?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I9c0d9667ddcb57b52eae34da942acfc1688c1418
Gerrit-Change-Number: 40812
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Aug 2025 15:51:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40819?usp=email )
Change subject: 5gc: Implement UE-initiated de-registration procedure
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This and previous patches are ready to merge from my PoV, so feel free to merge whenever they get +2.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40819?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iab438d5a7cc5f2ba58943e4568c1fb5e5f41f99d
Gerrit-Change-Number: 40819
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Aug 2025 15:14:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40819?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: 5gc: Implement UE-initiated de-registration procedure
......................................................................
5gc: Implement UE-initiated de-registration procedure
Change-Id: Iab438d5a7cc5f2ba58943e4568c1fb5e5f41f99d
Related: SYS#7073
---
M 5gc/C5G_Tests.ttcn
M 5gc/ConnHdlr.ttcn
M deps/Makefile
M library/NG_NAS_Osmo_Templates.ttcn
4 files changed, 60 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/40819/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40819?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iab438d5a7cc5f2ba58943e4568c1fb5e5f41f99d
Gerrit-Change-Number: 40819
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40816?usp=email )
Change subject: {S1AP,NGAP}_Emulation: Fix using the value of an optional field containing omit
......................................................................
{S1AP,NGAP}_Emulation: Fix using the value of an optional field containing omit
This was triggered in NGAP_Emulation during run of C5G_Tests complete
testusite, when running TC_ng_register_ping4_256.
Titan apparently doesn't like using a field set as omit in a field of a
record during match().
Same fix is applied for S1AP_Emulation since they basically use the same
logic.
Change-Id: I4812c2e9eeeadc26ad057cd8019f7570e4a16155
---
M library/NGAP_Emulation.ttcn
M library/S1AP_Emulation.ttcn
2 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/NGAP_Emulation.ttcn b/library/NGAP_Emulation.ttcn
index cd71395..7b7d93d 100644
--- a/library/NGAP_Emulation.ttcn
+++ b/library/NGAP_Emulation.ttcn
@@ -264,6 +264,9 @@
runs on NGAP_Emulation_CT return integer {
var integer i;
for (i := 0; i < sizeof(NGapAssociationTable); i := i+1) {
+ if (not isvalue(NGapAssociationTable[i].ran_ue_ngap_id)) {
+ continue;
+ }
if (istemplatekind(ran_id, "omit") or
match(NGapAssociationTable[i].ran_ue_ngap_id, ran_id)) {
if (istemplatekind(amf_id, "omit")) {
diff --git a/library/S1AP_Emulation.ttcn b/library/S1AP_Emulation.ttcn
index d1ac243..55a3380 100644
--- a/library/S1AP_Emulation.ttcn
+++ b/library/S1AP_Emulation.ttcn
@@ -209,6 +209,9 @@
runs on S1AP_Emulation_CT return integer {
var integer i;
for (i := 0; i < sizeof(S1apAssociationTable); i := i+1) {
+ if (not isvalue(S1apAssociationTable[i].enb_ue_s1ap_id)) {
+ continue;
+ }
if (istemplatekind(enb_id, "omit") or
match(S1apAssociationTable[i].enb_ue_s1ap_id, enb_id)) {
if (istemplatekind(mme_id, "omit")) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40816?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4812c2e9eeeadc26ad057cd8019f7570e4a16155
Gerrit-Change-Number: 40816
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40818?usp=email )
Change subject: NGAP_Templates: Fixes and improvements for UEContextReleaseComplete
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40818?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I50da7cd4cb15d8e6b2c68b21a4e4be93e3973593
Gerrit-Change-Number: 40818
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Aug 2025 14:56:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes