lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

July 2025

  • 1 participants
  • 1492 discussions
[S] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix wrong IEs passed to InitialContextSetupResponse
by osmith 22 Jul '25

22 Jul '25
Attention is currently required from: Andrey Velikiy, fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40727?usp=email ) Change subject: NGAP_Templates: Fix wrong IEs passed to InitialContextSetupResponse ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b385456e45505cb4655adda5ad5aba36fc96a4b Gerrit-Change-Number: 40727 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Andrey Velikiy <agreat22(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Andrey Velikiy <agreat22(a)gmail.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Jul 2025 06:24:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix wrong IEs passed to InitialContextSetupResponse
by pespin 21 Jul '25

21 Jul '25
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40727?usp=email ) Change subject: NGAP_Templates: Fix wrong IEs passed to InitialContextSetupResponse ...................................................................... NGAP_Templates: Fix wrong IEs passed to InitialContextSetupResponse Change-Id: I7b385456e45505cb4655adda5ad5aba36fc96a4b --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/40727/1 diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index dde7844..697709b 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -1445,12 +1445,12 @@ template (value) SuccessfulOutcome m_n2_InitialContextSetupResponse( in template (value) AMF_UE_NGAP_ID p_amfUeNgapID := PX_AMF_UE_NGAP_ID, in template (value) RAN_UE_NGAP_ID p_ranUeNgapID := PX_RAN_UE_NGAP_ID, - in template (value) PDUSessionResourceSetupListSURes p_pDUSessionResourceSetupListSURes + in template (value) PDUSessionResourceSetupListCxtRes p_pDUSessionResourceSetupListCxtRes ) := { procedureCode := id_InitialContextSetup, criticality := reject, value_ := { - PDUSessionResourceSetupResponse := { + InitialContextSetupResponse := { protocolIEs := { { id := id_AMF_UE_NGAP_ID, @@ -1463,9 +1463,9 @@ value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } }, { - id := id_PDUSessionResourceSetupListSURes, + id := id_PDUSessionResourceSetupListCxtRes, criticality := ignore, - value_ := { PDUSessionResourceSetupListSURes := p_pDUSessionResourceSetupListSURes } + value_ := { PDUSessionResourceSetupListCxtRes := p_pDUSessionResourceSetupListCxtRes } } } } @@ -1482,12 +1482,12 @@ template (present) SuccessfulOutcome mw_n2_InitialContextSetupResponse( template (present) AMF_UE_NGAP_ID p_amfUeNgapID := ?, template (present) RAN_UE_NGAP_ID p_ranUeNgapID := ?, - template (present) PDUSessionResourceSetupListSURes p_pDUSessionResourceSetupListSURes := ? + template (present) PDUSessionResourceSetupListCxtRes p_pDUSessionResourceSetupListCxtRes := ? ) := { procedureCode := id_InitialContextSetup, criticality := reject, value_ := { - PDUSessionResourceSetupResponse := { + InitialContextSetupResponse := { protocolIEs := { { id := id_AMF_UE_NGAP_ID, @@ -1500,9 +1500,9 @@ value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } }, { - id := id_PDUSessionResourceSetupListSURes, + id := id_PDUSessionResourceSetupListCxtRes, criticality := ignore, - value_ := { PDUSessionResourceSetupListSURes := p_pDUSessionResourceSetupListSURes } + value_ := { PDUSessionResourceSetupListCxtRes := p_pDUSessionResourceSetupListCxtRes } } } } @@ -1515,12 +1515,12 @@ template (present) SuccessfulOutcome mw_n2_InitialContextSetupResponse_Failed( template (present) AMF_UE_NGAP_ID p_amfUeNgapID := ?, template (present) RAN_UE_NGAP_ID p_ranUeNgapID := ?, - template (present) PDUSessionResourceFailedToSetupListSURes p_pDUSessionResourceFailedToSetupListURes := ? + template (present) PDUSessionResourceFailedToSetupListCxtRes p_pDUSessionResourceFailedToSetupListCxtRes := ? ) := { procedureCode := id_InitialContextSetup, criticality := reject, value_ := { - PDUSessionResourceSetupResponse := { + InitialContextSetupResponse := { protocolIEs := { { id := id_AMF_UE_NGAP_ID, @@ -1533,9 +1533,9 @@ value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } }, { - id := id_PDUSessionResourceFailedToSetupListSURes, + id := id_PDUSessionResourceFailedToSetupListCxtRes, criticality := ignore, - value_ := { PDUSessionResourceFailedToSetupListSURes := p_pDUSessionResourceFailedToSetupListURes } + value_ := { PDUSessionResourceFailedToSetupListCxtRes := p_pDUSessionResourceFailedToSetupListCxtRes } } } } @@ -1549,7 +1549,7 @@ procedureCode := id_InitialContextSetup, criticality := reject, value_ := { - PDUSessionResourceSetupResponse := { + InitialContextSetupResponse := { protocolIEs := { { id := id_AMF_UE_NGAP_ID, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b385456e45505cb4655adda5ad5aba36fc96a4b Gerrit-Change-Number: 40727 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ccid-firmware[master]: timers: fix them
by Hoernchen 21 Jul '25

21 Jul '25
Attention is currently required from: laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40722?usp=email ) Change subject: timers: fix them ...................................................................... Patch Set 2: (1 comment) File sysmoOCTSIM/main.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40722/comment/bbfe3cb4_af… : PS2, Line 546: SysTick->CTRL &= ~SysTick_CTRL_ENABLE_Msk; // no clock ticks for osmo timers > is the comment now still valid? it seems a bit contradictory to me now, eanbling systick timer but s […] It temporarily disables the systick to ensure there are no clock ticks for the timers when doing the usb reset dance. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0a9ba7a9097fe09614beceeae7541bd7b82b9087 Gerrit-Change-Number: 40722 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 21 Jul 2025 15:46:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
1 0
0 0
[S] Change in osmo-ccid-firmware[master]: 7816 fsm: drop inverse convention lut for arm
by laforge 21 Jul '25

21 Jul '25
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721?usp=email ) Change subject: 7816 fsm: drop inverse convention lut for arm ...................................................................... 7816 fsm: drop inverse convention lut for arm 3 instructions is more reliable than precious bytes and awfully slow memory. Change-Id: I1c6f1c4b733074201cb02c0b9e7cf80a9f8dca7c --- M ccid_common/iso7816_fsm.c 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ccid_common/iso7816_fsm.c b/ccid_common/iso7816_fsm.c index 0aa9571..7b0ea5f 100644 --- a/ccid_common/iso7816_fsm.c +++ b/ccid_common/iso7816_fsm.c @@ -149,6 +149,19 @@ static struct osmo_fsm tpdu_fsm; static struct osmo_fsm pps_fsm; +#if defined(__arm__) +#define invert_flip_uint8(XX) \ + do { \ + _Static_assert(__builtin_types_compatible_p(__typeof__(XX), uint8_t), \ + "invert_flip_uint8 argument must be uint8_t"); \ + /* xor to flip done by the compiler, since it might be a mvns instead of eor if convenient, so don't force it manually*/ \ + XX = ~XX; \ + __asm__ volatile("rbit %0, %0\n\t" \ + "uxtb.w %0, %0, ror #24\n\t" \ + : "+r"(XX)::/* lsr clobbers cc, uxtb does not */ \ + ); \ + } while (0) +#else /* look-up table for bit-wise inversion to convert from "inverse convention" to normal */ static const uint8_t convention_convert_lut[256] = { 0xff, 0x7f, 0xbf, 0x3f, 0xdf, 0x5f, 0x9f, 0x1f, 0xef, 0x6f, 0xaf, 0x2f, 0xcf, 0x4f, 0x8f, 0x0f, @@ -168,6 +181,13 @@ 0xf8, 0x78, 0xb8, 0x38, 0xd8, 0x58, 0x98, 0x18, 0xe8, 0x68, 0xa8, 0x28, 0xc8, 0x48, 0x88, 0x08, 0xf0, 0x70, 0xb0, 0x30, 0xd0, 0x50, 0x90, 0x10, 0xe0, 0x60, 0xa0, 0x20, 0xc0, 0x40, 0x80, 0x00, }; +#define invert_flip_uint8(XX) \ + do { \ + _Static_assert(__builtin_types_compatible_p(__typeof__(XX), uint8_t), \ + "invert_flip_uint8 argument must be uint8_t"); \ + XX = convention_convert_lut[XX]; \ + } while (0) +#endif struct atr_fsm_priv { uint8_t hist_len; /*!< store the number of expected historical bytes */ @@ -656,7 +676,7 @@ /* apply inverse convention */ if (ip->convention_convert) - byte = convention_convert_lut[byte]; + invert_flip_uint8(byte); return byte; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1c6f1c4b733074201cb02c0b9e7cf80a9f8dca7c Gerrit-Change-Number: 40721 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
1 0
0 0
[S] Change in osmo-ccid-firmware[master]: 7816 fsm: ensure errors always return a msgb
by laforge 21 Jul '25

21 Jul '25
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40703?usp=email ) Change subject: 7816 fsm: ensure errors always return a msgb ...................................................................... 7816 fsm: ensure errors always return a msgb This should always be safe to do, since I introduced statically allocated (but useless in this case) msgbs for the fsm years ago, and this was just leftover code from before that. The only exception is the internal ISO7816_E_TPDU_CLEAR_REQ. Change-Id: If32484675a0a10f1504477f5eea00c879ec78f1e --- M ccid_common/iso7816_fsm.c 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ccid_common/iso7816_fsm.c b/ccid_common/iso7816_fsm.c index f6d2185..0aa9571 100644 --- a/ccid_common/iso7816_fsm.c +++ b/ccid_common/iso7816_fsm.c @@ -668,7 +668,7 @@ if (!msgb_tailroom(atp->atr)) { LOGPFSML(fi, LOGL_ERROR, "ATR overflow !?!"); - osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_SW_ERR_IND, NULL); + osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_SW_ERR_IND, atp->atr); return -1; } msgb_put_u8(atp->atr, byte); @@ -726,15 +726,15 @@ default: LOGPFSML(fi, LOGL_ERROR, "Invalid TS received: 0x%02X\n", byte); /* FIXME: somehow indiicate to user */ - osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_SW_ERR_IND, NULL); + osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_SW_ERR_IND, atp->atr); break; } atp->i = 0; /* first interface byte sub-group is coming (T0 is kind of TD0) */ break; case ISO7816_E_WTIME_EXP: - osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_ATR_ERR_IND, NULL); + osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_ATR_ERR_IND, atp->atr); break; - default: + default: OSMO_ASSERT(0); } } @@ -840,7 +840,7 @@ osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_ATR_DONE_IND, atp->atr); break; default: - osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_ATR_ERR_IND, NULL); + osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_ATR_ERR_IND, atp->atr); break; } break; @@ -1507,14 +1507,14 @@ static void tpdu_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) { - OSMO_ASSERT(fi->fsm == &tpdu_fsm); + struct tpdu_fsm_priv *tfp = get_tpdu_fsm_priv(fi); switch (event) { case ISO7816_E_RX_ERR_IND: case ISO7816_E_TX_ERR_IND: /* FIXME: handle this in some different way */ osmo_fsm_inst_state_chg(fi, TPDU_S_DONE, 0, 0); - osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_TPDU_FAILED_IND, NULL); + osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_TPDU_FAILED_IND, tfp->tpdu); break; case ISO7816_E_TPDU_CLEAR_REQ: osmo_fsm_inst_state_chg(fi, TPDU_S_INIT, 0, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: If32484675a0a10f1504477f5eea00c879ec78f1e Gerrit-Change-Number: 40703 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ccid-firmware[master]: 7816 fsm: drop inverse convention lut for arm
by laforge 21 Jul '25

21 Jul '25
Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721?usp=email ) Change subject: 7816 fsm: drop inverse convention lut for arm ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1c6f1c4b733074201cb02c0b9e7cf80a9f8dca7c Gerrit-Change-Number: 40721 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Jul 2025 14:29:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ccid-firmware[master]: 7816 fsm: ensure errors always return a msgb
by laforge 21 Jul '25

21 Jul '25
Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40703?usp=email ) Change subject: 7816 fsm: ensure errors always return a msgb ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: If32484675a0a10f1504477f5eea00c879ec78f1e Gerrit-Change-Number: 40703 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Jul 2025 14:29:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in libosmocore[master]: Avoid reusing pending buffer; append incoming data instead
by laforge 21 Jul '25

21 Jul '25
Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40584?usp=email ) Change subject: Avoid reusing pending buffer; append incoming data instead ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I08df9736ccc5e9a7df61ca6dcf94629ee010752f Gerrit-Change-Number: 40584 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Jul 2025 14:29:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmocore[master]: Allow io_uring_submit batching just ahead of poll/select
by laforge 21 Jul '25

21 Jul '25
Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email ) Change subject: Allow io_uring_submit batching just ahead of poll/select ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/787d1e42_b06e82d7?… : PS2, Line 186: if (!g_io_uring_batch) maybe use the OSMO_LIKELY macro for branch prediction optimizaton, as we assume the default is the classic behaviour, i.e. that this branch is taken. https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/bee2f024_7cf70e7d?… : PS2, Line 329: if (!g_io_uring_batch) same here and further below -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id34fe2ced32c63d15b14810e145744f7509064cc Gerrit-Change-Number: 40489 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Jul 2025 14:28:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmocore[master]: linuxlist.h: add llist_last_entry_or_null macro
by laforge 21 Jul '25

21 Jul '25
Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40724?usp=email ) Change subject: linuxlist.h: add llist_last_entry_or_null macro ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaa5c8900434fe327a9c8b072182624a7fbfb369c Gerrit-Change-Number: 40724 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 21 Jul 2025 14:26:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 50
  • 51
  • 52
  • 53
  • 54
  • 55
  • 56
  • ...
  • 150
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.