July 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: library/ngap: Use titan native APER enc/dec

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40730?usp=email ) Change subject: library/ngap: Use titan native APER enc/dec ...................................................................... library/ngap: Use titan native APER enc/dec Related: OS#6490 Change-Id: I07b604fbd5d3665fdb48c4193ab58cffa7dd709a --- M 5gc/regen_makefile.sh M library/ngap/NGAP_EncDec.cc 2 files changed, 8 insertions(+), 42 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/40730/1 diff --git a/5gc/regen_makefile.sh b/5gc/regen_makefile.sh index be45468..5634e21 100755 --- a/5gc/regen_makefile.sh +++ b/5gc/regen_makefile.sh @@ -22,4 +22,4 @@ . ../_buildsystem/regen_makefile.inc.sh -sed -i -e 's/^LINUX_LIBS = -lxml2 -lsctp/LINUX_LIBS = -lxml2 -lsctp -lfftranscode -lgnutls/' Makefile +sed -i -e 's/^LINUX_LIBS = -lxml2 -lsctp/LINUX_LIBS = -lxml2 -lsctp -lgnutls/' Makefile diff --git a/library/ngap/NGAP_EncDec.cc b/library/ngap/NGAP_EncDec.cc index 55430f5..c54868a 100644 --- a/library/ngap/NGAP_EncDec.cc +++ b/library/ngap/NGAP_EncDec.cc @@ -3,62 +3,28 @@ #include <stdarg.h> #include "NGAP_PDU_Descriptions.hh" -extern "C" { -#include <fftranscode/transcode.h> -} - namespace NGAP__Types { TTCN_Module NGAP__EncDec("NGAP_EncDec", __DATE__, __TIME__); OCTETSTRING enc__NGAP__PDU(const NGAP__PDU__Descriptions::NGAP__PDU &pdu) { - uint8_t *aper_buf; - int aper_buf_len; TTCN_Buffer TTCN_buf; TTCN_buf.clear(); - - /* Encode from abstract data type into BER/DER */ pdu.encode(NGAP__PDU__Descriptions::NGAP__PDU_descr_, TTCN_buf, - TTCN_EncDec::CT_BER, BER_ENCODE_DER); - - aper_buf_len = fftranscode_ber2aper(FFTRANSC_T_NGAP, &aper_buf, TTCN_buf.get_data(), TTCN_buf.get_len()); - if (aper_buf_len < 0) { - TTCN_error("fftranscode failed."); - } - - /* make octetstring from output buffer */ - OCTETSTRING ret_val(aper_buf_len, aper_buf); - - /* release dynamically-allocated output buffer */ - fftranscode_free(aper_buf); - - return ret_val; + TTCN_EncDec::CT_PER, PER_ALIGNED); + return OCTETSTRING(TTCN_buf.get_len(), TTCN_buf.get_data()); } NGAP__PDU__Descriptions::NGAP__PDU dec__NGAP__PDU(const OCTETSTRING &stream) { - uint8_t *ber_buf; - int ber_buf_len; - - /* First, decode APER + re-encode as BER */ - ber_buf_len = fftranscode_aper2ber(FFTRANSC_T_NGAP, &ber_buf, (const unsigned char *)stream, stream.lengthof()); - if (ber_buf_len < 0) { - TTCN_error("fftranscode failed."); - } - - /* Then, re-encode from BER to TITAN representation */ - NGAP__PDU__Descriptions::NGAP__PDU ret_dcc; + NGAP__PDU__Descriptions::NGAP__PDU pdu; TTCN_Buffer TTCN_buf; TTCN_buf.clear(); - TTCN_buf.put_s(ber_buf_len, ber_buf); - - ret_dcc.decode(NGAP__PDU__Descriptions::NGAP__PDU_descr_, TTCN_buf, - TTCN_EncDec::CT_BER, BER_ACCEPT_ALL); - - fftranscode_free(ber_buf); - - return ret_dcc; + TTCN_buf.put_os(stream); + pdu.decode(NGAP__PDU__Descriptions::NGAP__PDU_descr_, TTCN_buf, + TTCN_EncDec::CT_PER, PER_ALIGNED); + return pdu; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I07b604fbd5d3665fdb48c4193ab58cffa7dd709a Gerrit-Change-Number: 40730 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: ngap: Fix deviation in ASN1 from TS 38.413 version 17.5.0

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40729?usp=email ) Change subject: ngap: Fix deviation in ASN1 from TS 38.413 version 17.5.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7d127998ea162a392f3381ebb1d198ad3c783a56 Gerrit-Change-Number: 40729 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Jul 2025 11:47:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 5 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: ngap: Fix deviation in ASN1 from TS 38.413 version 17.5.0

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40729?usp=email ) Change subject: ngap: Fix deviation in ASN1 from TS 38.413 version 17.5.0 ...................................................................... ngap: Fix deviation in ASN1 from TS 38.413 version 17.5.0 I originally copied the ASN1 files from https://forge.etsi.org/rep/int/5g-core/ngap.git directory ttcn/LibNGAP/lib/asn1, commit fa43d01e202379a969e991a9454d9c6c6930b5b5. Apparently one file contained a deviation from the 3GPP content and it was also fixed in ngap.git in 47e7239dd80f2f12a4cbcdd7977ca0a32356f3be. I found out this problem when trying to use this ASN1 file to generate new libfftranscode, which then failed to properly decode DownlinkNASTransport due to the deviation. Change-Id: I7d127998ea162a392f3381ebb1d198ad3c783a56 --- M library/ngap/NGAP_PDU_Descriptions.asn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/40729/1 diff --git a/library/ngap/NGAP_PDU_Descriptions.asn b/library/ngap/NGAP_PDU_Descriptions.asn index d8dbd98..dcf4704 100644 --- a/library/ngap/NGAP_PDU_Descriptions.asn +++ b/library/ngap/NGAP_PDU_Descriptions.asn @@ -266,7 +266,7 @@ InitiatingMessage ::= SEQUENCE { procedureCode NGAP-ELEMENTARY-PROCEDURE.&procedureCode ({NGAP-ELEMENTARY-PROCEDURES}), criticality NGAP-ELEMENTARY-PROCEDURE.&criticality ({NGAP-ELEMENTARY-PROCEDURES}{@procedureCode}), - value NGAP-ELEMENTARY-PROCEDURE.&InitiatingMessage ({NGAP-ELEMENTARY-PROCEDURES}{@procedureCode}) OPTIONAL + value NGAP-ELEMENTARY-PROCEDURE.&InitiatingMessage ({NGAP-ELEMENTARY-PROCEDURES}{@procedureCode}) } SuccessfulOutcome ::= SEQUENCE { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7d127998ea162a392f3381ebb1d198ad3c783a56 Gerrit-Change-Number: 40729 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[XS] Change in osmo-ccid-firmware[master]: timers: fix them

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40722?usp=email ) Change subject: timers: fix them ...................................................................... timers: fix them Since they are barely used at all they silently broke during the usb fixing attempts, which in turn broke ATR timeouts for cards that don't play well with 5V. Change-Id: I0a9ba7a9097fe09614beceeae7541bd7b82b9087 --- M sysmoOCTSIM/main.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index b0c0229..7d81853 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -543,7 +543,7 @@ void reset_all_stuff_irq(void) { - SysTick->CTRL = 0; // no clock ticks for osmo timers + SysTick->CTRL &= ~SysTick_CTRL_ENABLE_Msk; // no clock ticks for osmo timers Sercom *const sercom_modules[] = SERCOM_INSTS; for (uint32_t i = 0; i < SERCOM_INST_NUM; i++) { @@ -605,7 +605,7 @@ #endif } - SysTick->CTRL = 1; + SysTick->CTRL |= SysTick_CTRL_ENABLE_Msk; // while (!ccid_df_is_enabled()) // ; -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0a9ba7a9097fe09614beceeae7541bd7b82b9087 Gerrit-Change-Number: 40722 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

2 weeks, 5 days

1
0
0 0

[XS] Change in osmo-ccid-firmware[master]: timers: fix them

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40722?usp=email ) Change subject: timers: fix them ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File sysmoOCTSIM/main.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40722/comment/fda5aa0b_50… : PS2, Line 546: SysTick->CTRL &= ~SysTick_CTRL_ENABLE_Msk; // no clock ticks for osmo timers > It temporarily disables the systick to ensure there are no clock ticks for the timers when doing the […] ah, nevermind. How could I miss the negation... -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0a9ba7a9097fe09614beceeae7541bd7b82b9087 Gerrit-Change-Number: 40722 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Jul 2025 08:22:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

2 weeks, 5 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix wrong IEs passed to InitialContextSetupResponse

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40727?usp=email ) Change subject: NGAP_Templates: Fix wrong IEs passed to InitialContextSetupResponse ...................................................................... NGAP_Templates: Fix wrong IEs passed to InitialContextSetupResponse Change-Id: I7b385456e45505cb4655adda5ad5aba36fc96a4b --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index dde7844..697709b 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -1445,12 +1445,12 @@ template (value) SuccessfulOutcome m_n2_InitialContextSetupResponse( in template (value) AMF_UE_NGAP_ID p_amfUeNgapID := PX_AMF_UE_NGAP_ID, in template (value) RAN_UE_NGAP_ID p_ranUeNgapID := PX_RAN_UE_NGAP_ID, - in template (value) PDUSessionResourceSetupListSURes p_pDUSessionResourceSetupListSURes + in template (value) PDUSessionResourceSetupListCxtRes p_pDUSessionResourceSetupListCxtRes ) := { procedureCode := id_InitialContextSetup, criticality := reject, value_ := { - PDUSessionResourceSetupResponse := { + InitialContextSetupResponse := { protocolIEs := { { id := id_AMF_UE_NGAP_ID, @@ -1463,9 +1463,9 @@ value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } }, { - id := id_PDUSessionResourceSetupListSURes, + id := id_PDUSessionResourceSetupListCxtRes, criticality := ignore, - value_ := { PDUSessionResourceSetupListSURes := p_pDUSessionResourceSetupListSURes } + value_ := { PDUSessionResourceSetupListCxtRes := p_pDUSessionResourceSetupListCxtRes } } } } @@ -1482,12 +1482,12 @@ template (present) SuccessfulOutcome mw_n2_InitialContextSetupResponse( template (present) AMF_UE_NGAP_ID p_amfUeNgapID := ?, template (present) RAN_UE_NGAP_ID p_ranUeNgapID := ?, - template (present) PDUSessionResourceSetupListSURes p_pDUSessionResourceSetupListSURes := ? + template (present) PDUSessionResourceSetupListCxtRes p_pDUSessionResourceSetupListCxtRes := ? ) := { procedureCode := id_InitialContextSetup, criticality := reject, value_ := { - PDUSessionResourceSetupResponse := { + InitialContextSetupResponse := { protocolIEs := { { id := id_AMF_UE_NGAP_ID, @@ -1500,9 +1500,9 @@ value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } }, { - id := id_PDUSessionResourceSetupListSURes, + id := id_PDUSessionResourceSetupListCxtRes, criticality := ignore, - value_ := { PDUSessionResourceSetupListSURes := p_pDUSessionResourceSetupListSURes } + value_ := { PDUSessionResourceSetupListCxtRes := p_pDUSessionResourceSetupListCxtRes } } } } @@ -1515,12 +1515,12 @@ template (present) SuccessfulOutcome mw_n2_InitialContextSetupResponse_Failed( template (present) AMF_UE_NGAP_ID p_amfUeNgapID := ?, template (present) RAN_UE_NGAP_ID p_ranUeNgapID := ?, - template (present) PDUSessionResourceFailedToSetupListSURes p_pDUSessionResourceFailedToSetupListURes := ? + template (present) PDUSessionResourceFailedToSetupListCxtRes p_pDUSessionResourceFailedToSetupListCxtRes := ? ) := { procedureCode := id_InitialContextSetup, criticality := reject, value_ := { - PDUSessionResourceSetupResponse := { + InitialContextSetupResponse := { protocolIEs := { { id := id_AMF_UE_NGAP_ID, @@ -1533,9 +1533,9 @@ value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } }, { - id := id_PDUSessionResourceFailedToSetupListSURes, + id := id_PDUSessionResourceFailedToSetupListCxtRes, criticality := ignore, - value_ := { PDUSessionResourceFailedToSetupListSURes := p_pDUSessionResourceFailedToSetupListURes } + value_ := { PDUSessionResourceFailedToSetupListCxtRes := p_pDUSessionResourceFailedToSetupListCxtRes } } } } @@ -1549,7 +1549,7 @@ procedureCode := id_InitialContextSetup, criticality := reject, value_ := { - PDUSessionResourceSetupResponse := { + InitialContextSetupResponse := { protocolIEs := { { id := id_AMF_UE_NGAP_ID, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b385456e45505cb4655adda5ad5aba36fc96a4b Gerrit-Change-Number: 40727 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix wrong IEs passed to InitialContextSetupResponse

by fixeria

Attention is currently required from: Andrey Velikiy, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40727?usp=email ) Change subject: NGAP_Templates: Fix wrong IEs passed to InitialContextSetupResponse ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b385456e45505cb4655adda5ad5aba36fc96a4b Gerrit-Change-Number: 40727 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Andrey Velikiy <agreat22(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Andrey Velikiy <agreat22(a)gmail.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Jul 2025 07:34:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 5 days

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: rebar.lock: update enftables commit to latest

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40728?usp=email ) Change subject: rebar.lock: update enftables commit to latest ...................................................................... rebar.lock: update enftables commit to latest Update the enftables dependency to the latest commit "Add missing include of string.h", which is right after the one currently listed in rebar.lock. This should fix the build failing for ubuntu 24.10 in the Osmocom OBS: [ 281s] /usr/src/packages/BUILD/_checkouts/enftables/c_src/enftables.c:68:28: error: implicit declaration of function 'strlen' [-Wimplicit-function-declaration] [ 281s] 68 | bin.size = strlen(obuf); [ 281s] | ^~~~~~ [ 281s] /usr/src/packages/BUILD/_checkouts/enftables/c_src/enftables.c:16:1: note: include '<string.h>' or provide a declaration of 'strlen' Related: https://gitea.osmocom.org/erlang/enftables/commit/8b9b4acd624b9d0d3a58d725f… Change-Id: Iffd691bc5010d913728a9d683946e39f80c5655b --- M rebar.lock 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/rebar.lock b/rebar.lock index c5a90df..0c6730a 100644 --- a/rebar.lock +++ b/rebar.lock @@ -2,7 +2,7 @@ [{<<"cut">>,{pkg,<<"cut">>,<<"1.0.3">>},1}, {<<"enftables">>, {git,"https://gitea.osmocom.org/erlang/enftables.git", - {ref,"be23c8ebac948aa1eea450b368af437d12a7173a"}}, + {ref,"8b9b4acd624b9d0d3a58d725f11afa96d31fe5d7"}}, 0}, {<<"exometer_core">>, {git,"https://github.com/Feuerlabs/exometer_core.git", -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iffd691bc5010d913728a9d683946e39f80c5655b Gerrit-Change-Number: 40728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: rebar.lock: update enftables commit to latest

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40728?usp=email ) Change subject: rebar.lock: update enftables commit to latest ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Thank you! Somehow I forgot to update osmo-s1gw.git. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iffd691bc5010d913728a9d683946e39f80c5655b Gerrit-Change-Number: 40728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Jul 2025 07:34:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 5 days

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: rebar.lock: update enftables commit to latest

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40728?usp=email ) Change subject: rebar.lock: update enftables commit to latest ...................................................................... rebar.lock: update enftables commit to latest Update the enftables dependency to the latest commit "Add missing include of string.h", which is right after the one currently listed in rebar.lock. This should fix the build failing for ubuntu 24.10 in the Osmocom OBS: [ 281s] /usr/src/packages/BUILD/_checkouts/enftables/c_src/enftables.c:68:28: error: implicit declaration of function 'strlen' [-Wimplicit-function-declaration] [ 281s] 68 | bin.size = strlen(obuf); [ 281s] | ^~~~~~ [ 281s] /usr/src/packages/BUILD/_checkouts/enftables/c_src/enftables.c:16:1: note: include '<string.h>' or provide a declaration of 'strlen' Related: https://gitea.osmocom.org/erlang/enftables/commit/8b9b4acd624b9d0d3a58d725f… Change-Id: Iffd691bc5010d913728a9d683946e39f80c5655b --- M rebar.lock 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/28/40728/1 diff --git a/rebar.lock b/rebar.lock index c5a90df..0c6730a 100644 --- a/rebar.lock +++ b/rebar.lock @@ -2,7 +2,7 @@ [{<<"cut">>,{pkg,<<"cut">>,<<"1.0.3">>},1}, {<<"enftables">>, {git,"https://gitea.osmocom.org/erlang/enftables.git", - {ref,"be23c8ebac948aa1eea450b368af437d12a7173a"}}, + {ref,"8b9b4acd624b9d0d3a58d725f11afa96d31fe5d7"}}, 0}, {<<"exometer_core">>, {git,"https://github.com/Feuerlabs/exometer_core.git", -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iffd691bc5010d913728a9d683946e39f80c5655b Gerrit-Change-Number: 40728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025