July 2025 - gerrit-log - lists.osmocom.org

[XS] Change in docker-playground[master]: osmo-s1gw-master: align with the upstream

by fixeria

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/40769?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by osmith The change is no longer submittable: Code-Review is unsatisfied now. Change subject: osmo-s1gw-master: align with the upstream ...................................................................... osmo-s1gw-master: align with the upstream Change-Id: I3c694af378c500002752c208c8fcc040fdac5587 Related: osmo-s1gw.git I5681ca103daf1c497218b4513b0ca97b1aae03d3 Related: SYS#7332 --- M osmo-s1gw-master/Dockerfile 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/69/40769/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40769?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3c694af378c500002752c208c8fcc040fdac5587 Gerrit-Change-Number: 40769 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[XS] Change in docker-playground[master]: Makefile: add missing OSMO_S1GW_BRANCH

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/40768?usp=email ) Change subject: Makefile: add missing OSMO_S1GW_BRANCH ...................................................................... Makefile: add missing OSMO_S1GW_BRANCH Change-Id: I952fd357ccc1d8ceaf51700134f8786c4dbc96e6 --- M make/Makefile 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/make/Makefile b/make/Makefile index 71f8c5f..b320ba9 100644 --- a/make/Makefile +++ b/make/Makefile @@ -38,6 +38,7 @@ OSMO_NITB_BRANCH?=master OSMO_PCU_BRANCH?=master OSMO_REMSIM_BRANCH?=master +OSMO_S1GW_BRANCH?=master OSMO_SGSN_BRANCH?=master OSMO_SIP_BRANCH?=master OSMO_STP_BRANCH?=master @@ -123,6 +124,7 @@ --build-arg OSMO_NITB_BRANCH=$(OSMO_NITB_BRANCH) \ --build-arg OSMO_PCU_BRANCH=$(OSMO_PCU_BRANCH) \ --build-arg OSMO_REMSIM_BRANCH=$(OSMO_REMSIM_BRANCH) \ + --build-arg OSMO_S1GW_BRANCH=$(OSMO_S1GW_BRANCH) \ --build-arg OSMO_SGSN_BRANCH=$(OSMO_SGSN_BRANCH) \ --build-arg OSMO_SIP_BRANCH=$(OSMO_SIP_BRANCH) \ --build-arg OSMO_STP_BRANCH=$(OSMO_STP_BRANCH) \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I952fd357ccc1d8ceaf51700134f8786c4dbc96e6 Gerrit-Change-Number: 40768 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[S] Change in libosmocore[master]: osmo-io: Put together message buffers when dequeued from tx queue

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40760?usp=email ) Change subject: osmo-io: Put together message buffers when dequeued from tx queue ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40760/comment/66fa67bf_625e6e93?… : PS1, Line 276: iofd_msghdr_free(next); > msghdr has no msgbs as talloc children. All msgb we alloc for read, belog to iofd, not msghdr. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I97c366211dd266fd58ec252890ec017d6d334534 Gerrit-Change-Number: 40760 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 29 Jul 2025 11:22:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[XS] Change in docker-playground[master]: osmo-s1gw-master: align with the upstream

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/40769?usp=email ) Change subject: osmo-s1gw-master: align with the upstream ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40769?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3c694af378c500002752c208c8fcc040fdac5587 Gerrit-Change-Number: 40769 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Jul 2025 11:21:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[XS] Change in docker-playground[master]: Makefile: add missing OSMO_S1GW_BRANCH

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/40768?usp=email ) Change subject: Makefile: add missing OSMO_S1GW_BRANCH ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I952fd357ccc1d8ceaf51700134f8786c4dbc96e6 Gerrit-Change-Number: 40768 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Jul 2025 11:21:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[XS] Change in docker-playground[master]: Makefile: add missing OSMO_S1GW_BRANCH

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/40768?usp=email ) Change subject: Makefile: add missing OSMO_S1GW_BRANCH ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I952fd357ccc1d8ceaf51700134f8786c4dbc96e6 Gerrit-Change-Number: 40768 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Jul 2025 11:21:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[XS] Change in docker-playground[master]: osmo-s1gw-master: align with the upstream

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/40769?usp=email ) Change subject: osmo-s1gw-master: align with the upstream ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40769?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3c694af378c500002752c208c8fcc040fdac5587 Gerrit-Change-Number: 40769 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Jul 2025 11:21:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[M] Change in libosmocore[master]: Add multiple messages buffers to io_uring read operations

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email ) Change subject: Add multiple messages buffers to io_uring read operations ...................................................................... Patch Set 8: (2 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/d5db67e8_2e81ff47?… : PS8, Line 152: talloc_steal(iofd, msg); Is this code path meaningful/being used? Or can we absorbe the msg param above into being allocated below with the rest? https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/d0cbc3ad_1561d2b3?… : PS8, Line 166: * Only READ may have multiple buffers, because packets will only be written to the first buffer. */ > code indent should use tabs where possible Please fix. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic4544b8fcbad5a266db748d6864d3ae93ee06bce Gerrit-Change-Number: 40492 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 29 Jul 2025 11:21:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month, 3 weeks

1
0
0 0

[XS] Change in docker-playground[master]: osmo-s1gw-master: align with the upstream

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/40769?usp=email ) Change subject: osmo-s1gw-master: align with the upstream ...................................................................... osmo-s1gw-master: align with the upstream Change-Id: I3c694af378c500002752c208c8fcc040fdac5587 Related: SYS#7332 --- M osmo-s1gw-master/Dockerfile 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/69/40769/1 diff --git a/osmo-s1gw-master/Dockerfile b/osmo-s1gw-master/Dockerfile index 34028f8..8a4a2f2 100644 --- a/osmo-s1gw-master/Dockerfile +++ b/osmo-s1gw-master/Dockerfile @@ -4,6 +4,9 @@ # Arguments used after FROM must be specified again ARG DISTRO +# build and run the project as root +USER root + WORKDIR /tmp ARG OSMO_S1GW_BRANCH="master" @@ -15,10 +18,10 @@ git fetch && git checkout $OSMO_S1GW_BRANCH && \ (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_S1GW_BRANCH || exit 1); \ git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ - make build + make && make install VOLUME /data COPY osmo-s1gw.config /data/osmo-s1gw.config -CMD ["/bin/sh", "-c", "ERL_FLAGS='-config /data/osmo-s1gw.config' /tmp/osmo-s1gw/_build/default/bin/osmo-s1gw > /data/osmo-s1gw.log 2>&1"] +CMD ["/bin/sh", "-c", "osmo-s1gw -c /data/osmo-s1gw.config > /data/osmo-s1gw.log 2>&1"] -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40769?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3c694af378c500002752c208c8fcc040fdac5587 Gerrit-Change-Number: 40769 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[XS] Change in docker-playground[master]: Makefile: add missing OSMO_S1GW_BRANCH

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/40768?usp=email ) Change subject: Makefile: add missing OSMO_S1GW_BRANCH ...................................................................... Makefile: add missing OSMO_S1GW_BRANCH Change-Id: I952fd357ccc1d8ceaf51700134f8786c4dbc96e6 --- M make/Makefile 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/68/40768/1 diff --git a/make/Makefile b/make/Makefile index 71f8c5f..b320ba9 100644 --- a/make/Makefile +++ b/make/Makefile @@ -38,6 +38,7 @@ OSMO_NITB_BRANCH?=master OSMO_PCU_BRANCH?=master OSMO_REMSIM_BRANCH?=master +OSMO_S1GW_BRANCH?=master OSMO_SGSN_BRANCH?=master OSMO_SIP_BRANCH?=master OSMO_STP_BRANCH?=master @@ -123,6 +124,7 @@ --build-arg OSMO_NITB_BRANCH=$(OSMO_NITB_BRANCH) \ --build-arg OSMO_PCU_BRANCH=$(OSMO_PCU_BRANCH) \ --build-arg OSMO_REMSIM_BRANCH=$(OSMO_REMSIM_BRANCH) \ + --build-arg OSMO_S1GW_BRANCH=$(OSMO_S1GW_BRANCH) \ --build-arg OSMO_SGSN_BRANCH=$(OSMO_SGSN_BRANCH) \ --build-arg OSMO_SIP_BRANCH=$(OSMO_SIP_BRANCH) \ --build-arg OSMO_STP_BRANCH=$(OSMO_STP_BRANCH) \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I952fd357ccc1d8ceaf51700134f8786c4dbc96e6 Gerrit-Change-Number: 40768 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025