Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40770?usp=email )
Change subject: gen_makefile: support new Osmocom erlang makefiles
......................................................................
Patch Set 1:
(1 comment)
File gen_makefile.py:
https://gerrit.osmocom.org/c/osmo-dev/+/40770/comment/389a309f_12c9aa60?usp… :
PS1, Line 375: for i in {build_proj}/default/bin/*; do \\
: if [ -e "$$i" ]; then \\
: install -v -Dm755 "$$i" -t {shlex.quote(args.install_prefix)}/bin/; \\
Does this really pick the right if-branch in the case of osmo-s1gw?
```
$ make release
...
$ ls -la _build/default/bin/
total 104
drwxr-xr-x 2 fixeria fixeria 4096 июл 29 20:14 .
drwxr-xr-x 6 fixeria fixeria 4096 июл 29 20:17 ..
-rwxr-xr-x 1 fixeria fixeria 95317 июл 29 20:14 setup_gen
```
IIUC, this code will just copy `setup_gen` and not execute `make install`?
Maybe be something like this instead?
```
if grep -q "^install:" Makefile; then
# make install as you do in the else branch
else
for i in {build_proj}/default/bin/*; do
install -v -Dm755 "$$i" -t {shlex.quote(args.install_prefix)}/bin/; \\
fi
fi
```
Feels like I am missing something.
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40770?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I92d6fc6eb5a11068d4b3baca55dfb3abdedbbbf1
Gerrit-Change-Number: 40770
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Jul 2025 13:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40766?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: contrib/osmo-s1gw.sh: add help
......................................................................
contrib/osmo-s1gw.sh: add help
Change-Id: Id6ff9af8b7ec6602b4d8316d9ba499b59a483271
---
M contrib/osmo-s1gw.sh
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/66/40766/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40766?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Id6ff9af8b7ec6602b4d8316d9ba499b59a483271
Gerrit-Change-Number: 40766
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, osmith, pespin.
Hello Jenkins Builder, osmith, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40757?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Code-Review+2 by osmith, Verified+1 by Jenkins Builder
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: Makefile: 'run' becomes an alias of 'shell'
......................................................................
Makefile: 'run' becomes an alias of 'shell'
Running osmo-s1gw in form of an escript executable is prone to errors.
* Move away from escript and make 'run' an alias of 'shell'.
* Move `rebar3 escriptize` to a dedicated 'escript' recipe.
* Add 'run-escript' recipe in case its ever needed.
Change-Id: I8b34c11cc9361d8b65316401f67a5038544b27ac
Related: SYS#7332
---
M Makefile
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/57/40757/5
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40757?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8b34c11cc9361d8b65316401f67a5038544b27ac
Gerrit-Change-Number: 40757
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
Hello Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40765?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: debian: add copyright file
......................................................................
debian: add copyright file
Change-Id: I95d9314f7f858c02a6ac10641c958bbf13677814
---
A debian/copyright
1 file changed, 47 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/65/40765/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40765?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I95d9314f7f858c02a6ac10641c958bbf13677814
Gerrit-Change-Number: 40765
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40775?usp=email )
Change subject: testenv: Dockerfile: use debian archive for deb10 libssl pkg
......................................................................
testenv: Dockerfile: use debian archive for deb10 libssl pkg
As Debian 10 is EOL, this debian 10 package we are still using here to
make mongodb work is getting removed from the mirrors. Currently some
still have it, some have deleted it already. Use the archive instead.
Related: docker-playground Ia447d850d38c662aac567aa88685d984c0b42238
Change-Id: I1a81e8e1485c810396f1714e6ef0485878fab6ec
---
M _testenv/data/podman/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/40775/1
diff --git a/_testenv/data/podman/Dockerfile b/_testenv/data/podman/Dockerfile
index e94812a..4a5e965 100644
--- a/_testenv/data/podman/Dockerfile
+++ b/_testenv/data/podman/Dockerfile
@@ -162,7 +162,7 @@
mkdir -p /tmp/mongodb && \
cd /tmp/mongodb && \
wget "https://pgp.mongodb.com/server-5.0.asc" -O "/mongodb.key" && \
- wget "http://security.debian.org/debian-security/pool/updates/main/o/openssl/libs…" && \
+ wget "http://archive.debian.org/debian-security/pool/updates/main/o/openssl/libss…" && \
dpkg -i "libssl1.1_1.1.1n-0+deb10u6_amd64.deb" && \
echo "deb [signed-by=/mongodb.key] http://repo.mongodb.org/apt/debian bullseye/mongodb-org/5.0 main" \
> /etc/apt/sources.list.d/mongodb-org.list && \
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40775?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1a81e8e1485c810396f1714e6ef0485878fab6ec
Gerrit-Change-Number: 40775
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>