April 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: buildsystem/gen_links: rename ignore_pp_results

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40031?usp=email ) Change subject: buildsystem/gen_links: rename ignore_pp_results ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a1a79f1a3ff18fe4b51e4c72c3e9b56c571935e Gerrit-Change-Number: 40031 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 09:18:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: buildsystem/gen_links: move set -e to users

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40030?usp=email ) Change subject: buildsystem/gen_links: move set -e to users ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40030?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4caf445bef716161526a213d6a06ecc9d30f78cb Gerrit-Change-Number: 40030 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 09:16:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: buildsystem/regen_makefile: modernize

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40029?usp=email ) Change subject: buildsystem/regen_makefile: modernize ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File _buildsystem/regen_makefile.inc.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40029/comment/b9fdf7bd_7904… : PS1, Line 53: if command -v ccache >/dev/null; then AFAIU you are dropping the feature here to disable ccache by passing USE_CCACHE=0 here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a7dcd6171c6a370928ebedafc5ed318384dd8dd Gerrit-Change-Number: 40029 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 09:16:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: buildsystem: remove ttcn3_compiler workaround

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40028?usp=email ) Change subject: buildsystem: remove ttcn3_compiler workaround ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File _buildsystem/regen_makefile.inc.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40028/comment/1fdfadd0_c3bc… : PS1, Line 73: sed -i -e 's/\/bin\/compiler/\/bin\/ttcn3_compiler/' Makefile FYI My current eclipse-titan Archlinux package has both: /opt/eclipse-titan/bin/compiler /opt/eclipse-titan/bin/ttcn3_compiler ttcn3_compiler is actually a symlink to "compiler". https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40028/comment/cc9a27dd_3908… : PS1, Line 62: sed -i -e 's/TTCN3_DIR = $/TTCN3_DIR = \/usr\/ttcn3/' Makefile This is probably not needed anymore, I don't see any /usr/ttcn3 in my dir. eclipse-titan pkg seems to install under /opt/eclipse-titan/ nowadays. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40028?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia50aa3caffeaa85eefba10695096aa23dcb69c93 Gerrit-Change-Number: 40028 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 09:14:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: buildsystem/regen_makefile: change to inc script

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40027?usp=email ) Change subject: buildsystem/regen_makefile: change to inc script ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10a41671e857024be6a5e8577c2aaca83228793e Gerrit-Change-Number: 40027 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 09:09:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: buildsystem: move related scripts to subdir

by pespin

Attention is currently required from: dexter, fixeria, jolly, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40026?usp=email ) Change subject: buildsystem: move related scripts to subdir ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40026?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieeefdfd74b2698794fb12fec4ed32565dc9f36a6 Gerrit-Change-Number: 40026 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 09:08:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in pysim[master]: [1/6] personalization: refactor: drop ClassVarMeta use

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email ) Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... Patch Set 9: Code-Review-1 (2 comments) Patchset: PS9: I retain my position that I don't understand why this change is made in the first place, and where it improves upon the existing code. "Not using metaclasses" is not something I understand as an improvement, and clearly the readability has also not improved. I'm also a bit dissatisfied by the fact that this is the first change you introduce as part of your work on this task. It's not a functional change or anything that adds a feature, but it's a change that is mostly cosmetic and alters the existing code to be more to your personal preference without rendering a [AFAICT, and apparently fixeria agrees] clear advantage. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39741/comment/6f7d2351_753b426c?usp=em… : PS9, Line 37: class ConfigurableParameter: why is the new ConfugirableParameter not an ABC anymore? Can it be used directly, without further inheriting from it? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 08:57:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in pysim[master]: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi

by laforge

Attention is currently required from: dexter, fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 9: Code-Review+1 (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/be49d769_ab10cb9e?usp=em… : PS7, Line 100: allow_types = (str, int, ) > no, the trailing comma does not add a third item. […] Thanks for your explanation. If I was in your shoes, I'd be a bit more hesitant in intoducing personal coding style preferences into a pre-existing large code base that AFAICT doesn't use this anywhere so far. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 08:53:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 3 weeks

1
0
0 0

[L] Change in pysim[master]: personalization: add param_source.py, implement batch personalization

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email ) Change subject: personalization: add param_source.py, implement batch personalization ...................................................................... Patch Set 3: (3 comments) File pySim/esim/saip/param_source.py: https://gerrit.osmocom.org/c/pysim/+/40096/comment/53b4167f_f48d274a?usp=em… : PS3, Line 33: abstract if it's abstract, should it be an abc.ABC ? https://gerrit.osmocom.org/c/pysim/+/40096/comment/9aa7501a_9cbcced8?usp=em… : PS3, Line 132: RandomDigitSource IMHO it's a bit unintuitive that the IncDigit inherits from RandomDigit. Maybe add a DigitSource from which both IncDigit + RandomDigit inherits? https://gerrit.osmocom.org/c/pysim/+/40096/comment/ddc198b0_c5058a11?usp=em… : PS3, Line 133: 'incrementing sequence of digits' cosmetic: the docstring here uses single-quotes, below for the method it uses double-quotes. This looks a bit inconsistent. In the existing code base, I think we always use multi-line """ style comments for this, irrespective if the actual comment is just a single line. That makes it easier to expand it later on without having to change quoting style. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I497c60c101ea0eea980e8b1a4b1f36c0eda39002 Gerrit-Change-Number: 40096 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 08:48:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: personalization: discover all useful ConfigurableParameter subclasses

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40095?usp=email ) Change subject: personalization: discover all useful ConfigurableParameter subclasses ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40095/comment/5ae2b002_e9c557b9?usp=em… : PS2, Line 497: is_abstract = False I guess a minor syntactic improvement would be implementation via a decorator instead of a class variable? Not critical at all, just my two cents. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4970657294130b6b65d50ff19ffbb9ebab3be609 Gerrit-Change-Number: 40095 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 08:43:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025