April 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: buildsystem/regen_makefile: modernize

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40029?usp=email ) Change subject: buildsystem/regen_makefile: modernize ...................................................................... buildsystem/regen_makefile: modernize Apply various small changes to make this file more readable. Change-Id: I5a7dcd6171c6a370928ebedafc5ed318384dd8dd --- M _buildsystem/regen_makefile.inc.sh 1 file changed, 19 insertions(+), 33 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/_buildsystem/regen_makefile.inc.sh b/_buildsystem/regen_makefile.inc.sh index 31dd491..5534ff5 100644 --- a/_buildsystem/regen_makefile.inc.sh +++ b/_buildsystem/regen_makefile.inc.sh @@ -1,19 +1,6 @@ # Copyright 2017-2019 Harald Welte -# Copyright 2018 sysmocom - s.f.m.c. GmbH -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - - +# Copyright 2018-2025 sysmocom - s.f.m.c. GmbH +# SPDX-License-Identifier: Apache-2.0 # Wrapper around the TITAN make file generator if [ -z "$NAME" ]; then @@ -26,16 +13,9 @@ exit 1 fi -test -x "$(which ttcn3_makefilegen 2>/dev/null)" || { echo "ERROR: ttcn3_makefilegen not in PATH"; exit 1; } - -# Enable ccache if it can be found in path. -# This speeds up repeated builds of the TTCN3 tests by an order of magnitude -# since most of the generated C++ source files don't change very often. -# Roughly, for an initial build which takes N minutes, a complete rebuild -# after 'make clean' will only take N seconds with ccache. -# Note that ccache cannot speed up compilation of .o files to .so files. -if [ -z "$USE_CCACHE" ] && which ccache 2>/dev/null; then - USE_CCACHE=1 +if ! command -v ttcn3_makefilegen >/dev/null; then + echo "ERROR: ttcn3_makefilegen not in PATH" + exit 1 fi ttcn3_makefilegen -g -p -l -U 8 -f -e "$NAME" $FILES @@ -43,31 +23,37 @@ sed -i -e 's/# TTCN3_DIR = /TTCN3_DIR = \/usr/' Makefile sed -i -e 's/LDFLAGS = /LDFLAGS = -L \/usr\/lib\/titan/' Makefile sed -i -e 's/LINUX_LIBS = -lxml2/LINUX_LIBS = -lxml2 -lsctp -lssl/' Makefile -#sed -i -e 's/TTCN3_LIB = ttcn3-parallel/TTCN3_LIB = ttcn3/' Makefile # The -DMAKEDEPEND_RUN is a workaround for Debian packaging issue, # see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=879816 for details sed -i -e 's/CPPFLAGS = -D$(PLATFORM)/CPPFLAGS = -D$(PLATFORM) -DMAKEDEPEND_RUN -DUSE_SCTP -DLKSCTP_MULTIHOMING_ENABLED -DAS_USE_SSL/' Makefile -#remove -Wall from CXXFLAGS: we're not interested in generic warnings for autogenerated code cluttering the logs +# Remove -Wall from CXXFLAGS: we're not interested in generic warnings for +# autogenerated code cluttering the logs sed -i -e 's/-Wall//' Makefile -if [ "x$CPPFLAGS_TTCN3" != "x" ]; then +if [ -n "$CPPFLAGS_TTCN3" ]; then CPPFLAGS_TTCN3="$(echo "$CPPFLAGS_TTCN3" | tr -d '\n' | tr '\t' ' ')" sed -i -e "s/CPPFLAGS_TTCN3 =/CPPFLAGS_TTCN3 = $CPPFLAGS_TTCN3/" Makefile fi -# for TITAN 6.3.0 +# For TITAN 6.3.0 if cat /etc/issue | grep "Arch Linux" >/dev/null 2>&1; then sed -i -e 's/TTCN3_DIR = $/TTCN3_DIR = \/usr\/ttcn3/' Makefile else sed -i -e 's/TTCN3_DIR = $/TTCN3_DIR = \/usr/' Makefile fi -if [ "x$USE_CCACHE" = "x1" ]; then - # enable ccache +# Enable ccache if it can be found in path. This speeds up repeated builds of +# the TTCN3 tests by an order of magnitude since most of the generated C++ +# source files don't change very often. Roughly, for an initial build which +# takes N minutes, a complete rebuild after 'make clean' will only take N +# seconds with ccache. Note that ccache cannot speed up compilation of .o files +# to .so files. +if [ "$USE_CCACHE" != 0 ] && command -v ccache >/dev/null; then sed -i -e 's/^CXX = g++ $/CXX = env CCACHE_SLOPPINESS=time_macros ccache g++/' Makefile - # Append the -D option to compiler flags. This option disables timestamps - # inside comments in the generated C++ code which interfere with ccache. + # Append the -D option to compiler flags. This option disables + # timestamps inside comments in the generated C++ code which interfere + # with ccache. sed -i -e 's/^COMPILER_FLAGS = $.*$/& -D/' Makefile fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a7dcd6171c6a370928ebedafc5ed318384dd8dd Gerrit-Change-Number: 40029 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: buildsystem/gen_links: rename ignore_pp_results

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40031?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: buildsystem/gen_links: rename ignore_pp_results ...................................................................... buildsystem/gen_links: rename ignore_pp_results Rename ignore_pp_results to gen_links_finish in preparation for the next patch where the function will be used for generating more symlinks instead of writing to a gitignore file. This is a separate commit to make the next one more readable. Change-Id: I6a1a79f1a3ff18fe4b51e4c72c3e9b56c571935e --- M SCCP_Test/gen_links.sh M _buildsystem/gen_links.inc.sh M asterisk/gen_links.sh M bsc-nat/gen_links.sh M bsc/gen_links.sh M bts/gen_links.sh M cbc/gen_links.sh M ccid/gen_links.sh M dia2gsup/gen_links.sh M eim/gen_links.sh M epdg/gen_links.sh M fr-net/gen_links.sh M fr/gen_links.sh M gbproxy/gen_links.sh M ggsn_tests/gen_links.sh M hlr/gen_links.sh M hnbgw/gen_links.sh M hnodeb/gen_links.sh M hss/gen_links.sh M ipad/gen_links.sh M mgw/gen_links.sh M mme/gen_links.sh M msc/gen_links.sh M ns/gen_links.sh M pcap-client/gen_links.sh M pcrf/gen_links.sh M pcu/gen_links.sh M pgw/gen_links.sh M remsim/gen_links.sh M s1gw/gen_links.sh M sccp/gen_links.sh M selftest/gen_links.sh M sgsn/gen_links.sh M simtrace/gen_links.sh M sip/gen_links.sh M smlc/gen_links.sh M stp/gen_links.sh M sysinfo/gen_links.sh M upf/gen_links.sh 39 files changed, 39 insertions(+), 39 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/SCCP_Test/gen_links.sh b/SCCP_Test/gen_links.sh index f6b5591..8b33c1a 100755 --- a/SCCP_Test/gen_links.sh +++ b/SCCP_Test/gen_links.sh @@ -45,4 +45,4 @@ Native_Functions.ttcn Native_FunctionDefs.cc SCCP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/_buildsystem/gen_links.inc.sh b/_buildsystem/gen_links.inc.sh index c21bcd6..5701f0f 100644 --- a/_buildsystem/gen_links.inc.sh +++ b/_buildsystem/gen_links.inc.sh @@ -35,7 +35,7 @@ done } -ignore_pp_results() { +gen_links_finish() { # Avoid using the pattern itself if no file is found in globbing below: shopt -s nullglob for pp in *.ttcnpp; do diff --git a/asterisk/gen_links.sh b/asterisk/gen_links.sh index f61052e..4113965 100755 --- a/asterisk/gen_links.sh +++ b/asterisk/gen_links.sh @@ -48,4 +48,4 @@ FILES+="SIP_Emulation.ttcn SIP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/bsc-nat/gen_links.sh b/bsc-nat/gen_links.sh index 8e0f9c1..fa7e868 100755 --- a/bsc-nat/gen_links.sh +++ b/bsc-nat/gen_links.sh @@ -55,4 +55,4 @@ FILES="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn GSM_Types.ttcn IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp L3_Templates.ttcn RLCMAC_CSN1_Templates.ttcn RLCMAC_CSN1_Types.ttcn BSSMAP_Templates.ttcn RAN_Emulation.ttcnpp SDP_Templates.ttcn MGCP_Types.ttcn MGCP_Templates.ttcn MGCP_CodecPort.ttcn MGCP_CodecPort_CtrlFunct.ttcn MGCP_CodecPort_CtrlFunctDef.cc Osmocom_CTRL_Types.ttcn Osmocom_VTY_Functions.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn BSSAP_CodecPort.ttcn Native_Functions.ttcn Native_FunctionDefs.cc" gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/bsc/gen_links.sh b/bsc/gen_links.sh index e6ff0fd..7e31117 100755 --- a/bsc/gen_links.sh +++ b/bsc/gen_links.sh @@ -76,4 +76,4 @@ gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/bts/gen_links.sh b/bts/gen_links.sh index 4e952d2..b04a876 100755 --- a/bts/gen_links.sh +++ b/bts/gen_links.sh @@ -52,4 +52,4 @@ FILES+="IPA_Testing.ttcn" gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/cbc/gen_links.sh b/cbc/gen_links.sh index 9e7e2d0..129de44 100755 --- a/cbc/gen_links.sh +++ b/cbc/gen_links.sh @@ -60,4 +60,4 @@ FILES+="SCTP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/ccid/gen_links.sh b/ccid/gen_links.sh index a0ffc87..dac7ffe 100755 --- a/ccid/gen_links.sh +++ b/ccid/gen_links.sh @@ -18,4 +18,4 @@ FILES+="Native_Functions.ttcn Native_FunctionDefs.cc " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/dia2gsup/gen_links.sh b/dia2gsup/gen_links.sh index a159862..75d165d 100755 --- a/dia2gsup/gen_links.sh +++ b/dia2gsup/gen_links.sh @@ -44,4 +44,4 @@ FILES+="SCTP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/eim/gen_links.sh b/eim/gen_links.sh index 48f2129..c633311 100755 --- a/eim/gen_links.sh +++ b/eim/gen_links.sh @@ -44,4 +44,4 @@ FILES+="HTTP_Server_Emulation.ttcn HTTP_Adapter.ttcn" gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/epdg/gen_links.sh b/epdg/gen_links.sh index 9eeb691..889cb9a 100755 --- a/epdg/gen_links.sh +++ b/epdg/gen_links.sh @@ -66,4 +66,4 @@ FILES+="SCTP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/fr-net/gen_links.sh b/fr-net/gen_links.sh index ce84938..64e5b43 100755 --- a/fr-net/gen_links.sh +++ b/fr-net/gen_links.sh @@ -52,4 +52,4 @@ FILES+="LLC_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/fr/gen_links.sh b/fr/gen_links.sh index ce84938..64e5b43 100755 --- a/fr/gen_links.sh +++ b/fr/gen_links.sh @@ -52,4 +52,4 @@ FILES+="LLC_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/gbproxy/gen_links.sh b/gbproxy/gen_links.sh index 25a5f59..c71f049 100755 --- a/gbproxy/gen_links.sh +++ b/gbproxy/gen_links.sh @@ -95,4 +95,4 @@ GTPv1C_Templates.ttcn IPCP_Types.ttcn IPCP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/ggsn_tests/gen_links.sh b/ggsn_tests/gen_links.sh index 18b5113..4bbe462 100755 --- a/ggsn_tests/gen_links.sh +++ b/ggsn_tests/gen_links.sh @@ -68,4 +68,4 @@ FILES+="SCTP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/hlr/gen_links.sh b/hlr/gen_links.sh index e7697fb..a077937 100755 --- a/hlr/gen_links.sh +++ b/hlr/gen_links.sh @@ -54,4 +54,4 @@ gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/hnbgw/gen_links.sh b/hnbgw/gen_links.sh index 1c1b1b5..a6a2f54 100755 --- a/hnbgw/gen_links.sh +++ b/hnbgw/gen_links.sh @@ -108,4 +108,4 @@ FILES+="Mutex.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/hnodeb/gen_links.sh b/hnodeb/gen_links.sh index dcb5379..118bb8b 100755 --- a/hnodeb/gen_links.sh +++ b/hnodeb/gen_links.sh @@ -69,4 +69,4 @@ FILES+="SCTP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/hss/gen_links.sh b/hss/gen_links.sh index 74a9db8..5fcd559 100755 --- a/hss/gen_links.sh +++ b/hss/gen_links.sh @@ -37,4 +37,4 @@ FILES+="HTTP_Adapter.ttcn Prometheus_Checker.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/ipad/gen_links.sh b/ipad/gen_links.sh index 8daadaf..f47bc6e 100755 --- a/ipad/gen_links.sh +++ b/ipad/gen_links.sh @@ -40,4 +40,4 @@ FILES+="VPCD_Adapter.ttcn HTTP_Server_Emulation.ttcn" gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/mgw/gen_links.sh b/mgw/gen_links.sh index 69d61fc..f185902 100755 --- a/mgw/gen_links.sh +++ b/mgw/gen_links.sh @@ -52,4 +52,4 @@ gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/mme/gen_links.sh b/mme/gen_links.sh index 3f0b63a..98194ad 100755 --- a/mme/gen_links.sh +++ b/mme/gen_links.sh @@ -84,4 +84,4 @@ FILES+="SCTP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/msc/gen_links.sh b/msc/gen_links.sh index 92e979c..63d90fc 100755 --- a/msc/gen_links.sh +++ b/msc/gen_links.sh @@ -105,4 +105,4 @@ FILES+="SCTP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/ns/gen_links.sh b/ns/gen_links.sh index a726824..e1e9895 100755 --- a/ns/gen_links.sh +++ b/ns/gen_links.sh @@ -57,4 +57,4 @@ FILES+="LLC_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/pcap-client/gen_links.sh b/pcap-client/gen_links.sh index 82c5f99..5e4cd93 100755 --- a/pcap-client/gen_links.sh +++ b/pcap-client/gen_links.sh @@ -28,4 +28,4 @@ FILES+="OPCAP_CodecPort.ttcn OPCAP_CodecPort_CtrlFunct.ttcn OPCAP_CodecPort_CtrlFunctdef.cc OPCAP_Adapter.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/pcrf/gen_links.sh b/pcrf/gen_links.sh index 1e708e4..12ae9f7 100755 --- a/pcrf/gen_links.sh +++ b/pcrf/gen_links.sh @@ -37,4 +37,4 @@ FILES+="HTTP_Adapter.ttcn Prometheus_Checker.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/pcu/gen_links.sh b/pcu/gen_links.sh index dea0ed6..cf3c124 100755 --- a/pcu/gen_links.sh +++ b/pcu/gen_links.sh @@ -60,4 +60,4 @@ FILES+="Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/pgw/gen_links.sh b/pgw/gen_links.sh index 9da4406..314050e 100755 --- a/pgw/gen_links.sh +++ b/pgw/gen_links.sh @@ -68,4 +68,4 @@ FILES+="SCTP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/remsim/gen_links.sh b/remsim/gen_links.sh index 1ceab7b..e013a77 100755 --- a/remsim/gen_links.sh +++ b/remsim/gen_links.sh @@ -48,4 +48,4 @@ VPCD_Adapter.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/s1gw/gen_links.sh b/s1gw/gen_links.sh index ab85bee..6328ab8 100755 --- a/s1gw/gen_links.sh +++ b/s1gw/gen_links.sh @@ -35,4 +35,4 @@ FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcnpp " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/sccp/gen_links.sh b/sccp/gen_links.sh index 55f171b..693f66f 100755 --- a/sccp/gen_links.sh +++ b/sccp/gen_links.sh @@ -59,4 +59,4 @@ FILES+="SCCP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/selftest/gen_links.sh b/selftest/gen_links.sh index 249baf3..e6dcfbd 100755 --- a/selftest/gen_links.sh +++ b/selftest/gen_links.sh @@ -42,4 +42,4 @@ FILES="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn GSM_Types.ttcn IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp L3_Templates.ttcn BSSMAP_Templates.ttcn RLCMAC_CSN1_Templates.ttcn RLCMAC_CSN1_Types.ttcn GSM_RR_Types.ttcn GSM_RestOctets.ttcn RSL_Types.ttcn BSSAP_CodecPort.ttcn Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn PCO_Types.ttcn GSUP_Types.ttcn Native_Functions.ttcn Native_FunctionDefs.cc" gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/sgsn/gen_links.sh b/sgsn/gen_links.sh index 23fcb83..992e757 100755 --- a/sgsn/gen_links.sh +++ b/sgsn/gen_links.sh @@ -99,4 +99,4 @@ FILES+="GTP_Emulation.ttcn IPCP_Types.ttcn IPCP_Templates.ttcn RAW_NS.ttcnpp " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/simtrace/gen_links.sh b/simtrace/gen_links.sh index 63be15e..62b4346 100755 --- a/simtrace/gen_links.sh +++ b/simtrace/gen_links.sh @@ -18,4 +18,4 @@ FILES+="SIMTRACE_Types.ttcn SIMTRACE_Templates.ttcn SIMTRACE_Emulation.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/sip/gen_links.sh b/sip/gen_links.sh index 99536cf..72c5122 100755 --- a/sip/gen_links.sh +++ b/sip/gen_links.sh @@ -49,4 +49,4 @@ FILES+="SIP_Emulation.ttcn SIP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/smlc/gen_links.sh b/smlc/gen_links.sh index 0626a53..4aeedd8 100755 --- a/smlc/gen_links.sh +++ b/smlc/gen_links.sh @@ -72,4 +72,4 @@ gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/stp/gen_links.sh b/stp/gen_links.sh index 17000ed..625a3de 100755 --- a/stp/gen_links.sh +++ b/stp/gen_links.sh @@ -55,4 +55,4 @@ FILES+="SCTP_Templates.ttcn " gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/sysinfo/gen_links.sh b/sysinfo/gen_links.sh index 12d6615..95bb0ee 100755 --- a/sysinfo/gen_links.sh +++ b/sysinfo/gen_links.sh @@ -28,4 +28,4 @@ FILES="GSMTAP_PortType.ttcn GSMTAP_Types.ttcn GSM_SystemInformation.ttcn GSM_RestOctets.ttcn GSM_RR_Types.ttcn RLCMAC_CSN1_Templates.ttcn RLCMAC_CSN1_Types.ttcn GSM_Types.ttcn IPL4_GSMTAP_CtrlFunct.ttcn IPL4_GSMTAP_CtrlFunctDef.cc Osmocom_Types.ttcn Native_Functions.ttcn Native_FunctionDefs.cc Misc_Helpers.ttcn General_Types.ttcn Osmocom_VTY_Functions.ttcn" gen_links $DIR $FILES -ignore_pp_results +gen_links_finish diff --git a/upf/gen_links.sh b/upf/gen_links.sh index 62e8c56..2a65368 100755 --- a/upf/gen_links.sh +++ b/upf/gen_links.sh @@ -33,4 +33,4 @@ FILES+="PFCP_CodecPort.ttcn PFCP_CodecPort_CtrlFunct.ttcn PFCP_CodecPort_CtrlFunctDef.cc PFCP_Emulation.ttcn PFCP_Templates.ttcn" gen_links $DIR $FILES -ignore_pp_results +gen_links_finish -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a1a79f1a3ff18fe4b51e4c72c3e9b56c571935e Gerrit-Change-Number: 40031 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: buildsystem/gen_links: move set -e to users

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40030?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: buildsystem/gen_links: move set -e to users ...................................................................... buildsystem/gen_links: move set -e to users Make it more obvious that the various gen_links.sh scripts are running with "set -e" by adding it to the #! line instead of setting it through an included file. Change-Id: I4caf445bef716161526a213d6a06ecc9d30f78cb --- M SCCP_Test/gen_links.sh M _buildsystem/gen_links.inc.sh M asterisk/gen_links.sh M bsc-nat/gen_links.sh M bsc/gen_links.sh M bts/gen_links.sh M cbc/gen_links.sh M ccid/gen_links.sh M dia2gsup/gen_links.sh M eim/gen_links.sh M epdg/gen_links.sh M fr-net/gen_links.sh M fr/gen_links.sh M gbproxy/gen_links.sh M ggsn_tests/gen_links.sh M hlr/gen_links.sh M hnbgw/gen_links.sh M hnodeb/gen_links.sh M hss/gen_links.sh M ipad/gen_links.sh M mgw/gen_links.sh M mme/gen_links.sh M msc/gen_links.sh M ns/gen_links.sh M pcap-client/gen_links.sh M pcrf/gen_links.sh M pcu/gen_links.sh M pgw/gen_links.sh M remsim/gen_links.sh M s1gw/gen_links.sh M sccp/gen_links.sh M selftest/gen_links.sh M sgsn/gen_links.sh M simtrace/gen_links.sh M sip/gen_links.sh M smlc/gen_links.sh M stp/gen_links.sh M sysinfo/gen_links.sh M upf/gen_links.sh 39 files changed, 38 insertions(+), 40 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/SCCP_Test/gen_links.sh b/SCCP_Test/gen_links.sh index 7bae850..f6b5591 100755 --- a/SCCP_Test/gen_links.sh +++ b/SCCP_Test/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/_buildsystem/gen_links.inc.sh b/_buildsystem/gen_links.inc.sh index f134427..c21bcd6 100644 --- a/_buildsystem/gen_links.inc.sh +++ b/_buildsystem/gen_links.inc.sh @@ -16,8 +16,6 @@ # See the License for the specific language governing permissions and # limitations under the License. -set -e - rm -f .gitignore gen_link() { diff --git a/asterisk/gen_links.sh b/asterisk/gen_links.sh index afd6a8d..f61052e 100755 --- a/asterisk/gen_links.sh +++ b/asterisk/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/bsc-nat/gen_links.sh b/bsc-nat/gen_links.sh index aa9fb54..8e0f9c1 100755 --- a/bsc-nat/gen_links.sh +++ b/bsc-nat/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/bsc/gen_links.sh b/bsc/gen_links.sh index 30bfba7..e6ff0fd 100755 --- a/bsc/gen_links.sh +++ b/bsc/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/bts/gen_links.sh b/bts/gen_links.sh index 1f16334..4e952d2 100755 --- a/bts/gen_links.sh +++ b/bts/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/cbc/gen_links.sh b/cbc/gen_links.sh index 314de12..9e7e2d0 100755 --- a/cbc/gen_links.sh +++ b/cbc/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/ccid/gen_links.sh b/ccid/gen_links.sh index 99698e6..a0ffc87 100755 --- a/ccid/gen_links.sh +++ b/ccid/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/dia2gsup/gen_links.sh b/dia2gsup/gen_links.sh index eb65263..a159862 100755 --- a/dia2gsup/gen_links.sh +++ b/dia2gsup/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/eim/gen_links.sh b/eim/gen_links.sh index 2e73c7c..48f2129 100755 --- a/eim/gen_links.sh +++ b/eim/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/epdg/gen_links.sh b/epdg/gen_links.sh index abc0287..9eeb691 100755 --- a/epdg/gen_links.sh +++ b/epdg/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/fr-net/gen_links.sh b/fr-net/gen_links.sh index 71370e2..ce84938 100755 --- a/fr-net/gen_links.sh +++ b/fr-net/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/fr/gen_links.sh b/fr/gen_links.sh index 71370e2..ce84938 100755 --- a/fr/gen_links.sh +++ b/fr/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/gbproxy/gen_links.sh b/gbproxy/gen_links.sh index 7320c57..25a5f59 100755 --- a/gbproxy/gen_links.sh +++ b/gbproxy/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/ggsn_tests/gen_links.sh b/ggsn_tests/gen_links.sh index 9aad2d7..18b5113 100755 --- a/ggsn_tests/gen_links.sh +++ b/ggsn_tests/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/hlr/gen_links.sh b/hlr/gen_links.sh index 3326e96..e7697fb 100755 --- a/hlr/gen_links.sh +++ b/hlr/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/hnbgw/gen_links.sh b/hnbgw/gen_links.sh index f0c81fe..1c1b1b5 100755 --- a/hnbgw/gen_links.sh +++ b/hnbgw/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/hnodeb/gen_links.sh b/hnodeb/gen_links.sh index 86e1299..dcb5379 100755 --- a/hnodeb/gen_links.sh +++ b/hnodeb/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/hss/gen_links.sh b/hss/gen_links.sh index 63ec5e3..74a9db8 100755 --- a/hss/gen_links.sh +++ b/hss/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/ipad/gen_links.sh b/ipad/gen_links.sh index 73901de..8daadaf 100755 --- a/ipad/gen_links.sh +++ b/ipad/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/mgw/gen_links.sh b/mgw/gen_links.sh index 571c2cb..69d61fc 100755 --- a/mgw/gen_links.sh +++ b/mgw/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/mme/gen_links.sh b/mme/gen_links.sh index b5c6db6..3f0b63a 100755 --- a/mme/gen_links.sh +++ b/mme/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/msc/gen_links.sh b/msc/gen_links.sh index c1478c2..92e979c 100755 --- a/msc/gen_links.sh +++ b/msc/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/ns/gen_links.sh b/ns/gen_links.sh index 16cf2e4..a726824 100755 --- a/ns/gen_links.sh +++ b/ns/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/pcap-client/gen_links.sh b/pcap-client/gen_links.sh index 6423df8..82c5f99 100755 --- a/pcap-client/gen_links.sh +++ b/pcap-client/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/pcrf/gen_links.sh b/pcrf/gen_links.sh index 7001432..1e708e4 100755 --- a/pcrf/gen_links.sh +++ b/pcrf/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/pcu/gen_links.sh b/pcu/gen_links.sh index bf4d7f3..dea0ed6 100755 --- a/pcu/gen_links.sh +++ b/pcu/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/pgw/gen_links.sh b/pgw/gen_links.sh index 45114a5..9da4406 100755 --- a/pgw/gen_links.sh +++ b/pgw/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/remsim/gen_links.sh b/remsim/gen_links.sh index 992ed8e..1ceab7b 100755 --- a/remsim/gen_links.sh +++ b/remsim/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/s1gw/gen_links.sh b/s1gw/gen_links.sh index 0f7d8ed..ab85bee 100755 --- a/s1gw/gen_links.sh +++ b/s1gw/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/sccp/gen_links.sh b/sccp/gen_links.sh index fb30488..55f171b 100755 --- a/sccp/gen_links.sh +++ b/sccp/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/selftest/gen_links.sh b/selftest/gen_links.sh index d1307ac..249baf3 100755 --- a/selftest/gen_links.sh +++ b/selftest/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/sgsn/gen_links.sh b/sgsn/gen_links.sh index 54e5fe1..23fcb83 100755 --- a/sgsn/gen_links.sh +++ b/sgsn/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/simtrace/gen_links.sh b/simtrace/gen_links.sh index fa588fc..63be15e 100755 --- a/simtrace/gen_links.sh +++ b/simtrace/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/sip/gen_links.sh b/sip/gen_links.sh index 85d441a..99536cf 100755 --- a/sip/gen_links.sh +++ b/sip/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/smlc/gen_links.sh b/smlc/gen_links.sh index a4e8e3f..0626a53 100755 --- a/smlc/gen_links.sh +++ b/smlc/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/stp/gen_links.sh b/stp/gen_links.sh index 519b450..17000ed 100755 --- a/stp/gen_links.sh +++ b/stp/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/sysinfo/gen_links.sh b/sysinfo/gen_links.sh index 01e69eb..12d6615 100755 --- a/sysinfo/gen_links.sh +++ b/sysinfo/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps diff --git a/upf/gen_links.sh b/upf/gen_links.sh index 5ca92be..62e8c56 100755 --- a/upf/gen_links.sh +++ b/upf/gen_links.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e BASEDIR=../deps -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40030?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4caf445bef716161526a213d6a06ecc9d30f78cb Gerrit-Change-Number: 40030 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: run: add --bisect argument

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40040?usp=email ) Change subject: testenv: run: add --bisect argument ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I941064c1c704560e0f7351c82e810481cd72b6da Gerrit-Change-Number: 40040 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 09:36:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: refactor run --until-nok code

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40039?usp=email ) Change subject: testenv: refactor run --until-nok code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a8fc83c6833f0d2a8be9c0d7ddaea0546859988 Gerrit-Change-Number: 40039 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 09:35:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: buildsystem/regen_makefile: modernize

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40029?usp=email ) Change subject: buildsystem/regen_makefile: modernize ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS2: re-applying +2 File _buildsystem/regen_makefile.inc.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40029/comment/df4e4f81_37cd… : PS1, Line 53: if command -v ccache >/dev/null; then > AFAIU you are dropping the feature here to disable ccache by passing USE_CCACHE=0 here? right, fixed that this is possible again -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a7dcd6171c6a370928ebedafc5ed318384dd8dd Gerrit-Change-Number: 40029 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Apr 2025 09:35:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: buildsystem/gen_links: move set -e to users

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40030?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: buildsystem/gen_links: move set -e to users ...................................................................... buildsystem/gen_links: move set -e to users Make it more obvious that the various gen_links.sh scripts are running with "set -e" by adding it to the #! line instead of setting it through an included file. Change-Id: I4caf445bef716161526a213d6a06ecc9d30f78cb --- M SCCP_Test/gen_links.sh M _buildsystem/gen_links.inc.sh M asterisk/gen_links.sh M bsc-nat/gen_links.sh M bsc/gen_links.sh M bts/gen_links.sh M cbc/gen_links.sh M ccid/gen_links.sh M dia2gsup/gen_links.sh M eim/gen_links.sh M epdg/gen_links.sh M fr-net/gen_links.sh M fr/gen_links.sh M gbproxy/gen_links.sh M ggsn_tests/gen_links.sh M hlr/gen_links.sh M hnbgw/gen_links.sh M hnodeb/gen_links.sh M hss/gen_links.sh M ipad/gen_links.sh M mgw/gen_links.sh M mme/gen_links.sh M msc/gen_links.sh M ns/gen_links.sh M pcap-client/gen_links.sh M pcrf/gen_links.sh M pcu/gen_links.sh M pgw/gen_links.sh M remsim/gen_links.sh M s1gw/gen_links.sh M sccp/gen_links.sh M selftest/gen_links.sh M sgsn/gen_links.sh M simtrace/gen_links.sh M sip/gen_links.sh M smlc/gen_links.sh M stp/gen_links.sh M sysinfo/gen_links.sh M upf/gen_links.sh 39 files changed, 38 insertions(+), 40 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/40030/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40030?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4caf445bef716161526a213d6a06ecc9d30f78cb Gerrit-Change-Number: 40030 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: buildsystem/regen_makefile: modernize

by osmith

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40029?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+2 by pespin, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: buildsystem/regen_makefile: modernize ...................................................................... buildsystem/regen_makefile: modernize Apply various small changes to make this file more readable. Change-Id: I5a7dcd6171c6a370928ebedafc5ed318384dd8dd --- M _buildsystem/regen_makefile.inc.sh 1 file changed, 19 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/40029/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a7dcd6171c6a370928ebedafc5ed318384dd8dd Gerrit-Change-Number: 40029 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: buildsystem/gen_links: rename ignore_pp_results

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40031?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: buildsystem/gen_links: rename ignore_pp_results ...................................................................... buildsystem/gen_links: rename ignore_pp_results Rename ignore_pp_results to gen_links_finish in preparation for the next patch where the function will be used for generating more symlinks instead of writing to a gitignore file. This is a separate commit to make the next one more readable. Change-Id: I6a1a79f1a3ff18fe4b51e4c72c3e9b56c571935e --- M SCCP_Test/gen_links.sh M _buildsystem/gen_links.inc.sh M asterisk/gen_links.sh M bsc-nat/gen_links.sh M bsc/gen_links.sh M bts/gen_links.sh M cbc/gen_links.sh M ccid/gen_links.sh M dia2gsup/gen_links.sh M eim/gen_links.sh M epdg/gen_links.sh M fr-net/gen_links.sh M fr/gen_links.sh M gbproxy/gen_links.sh M ggsn_tests/gen_links.sh M hlr/gen_links.sh M hnbgw/gen_links.sh M hnodeb/gen_links.sh M hss/gen_links.sh M ipad/gen_links.sh M mgw/gen_links.sh M mme/gen_links.sh M msc/gen_links.sh M ns/gen_links.sh M pcap-client/gen_links.sh M pcrf/gen_links.sh M pcu/gen_links.sh M pgw/gen_links.sh M remsim/gen_links.sh M s1gw/gen_links.sh M sccp/gen_links.sh M selftest/gen_links.sh M sgsn/gen_links.sh M simtrace/gen_links.sh M sip/gen_links.sh M smlc/gen_links.sh M stp/gen_links.sh M sysinfo/gen_links.sh M upf/gen_links.sh 39 files changed, 39 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/40031/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a1a79f1a3ff18fe4b51e4c72c3e9b56c571935e Gerrit-Change-Number: 40031 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: buildsystem: build out-of-tree

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40032?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: buildsystem: build out-of-tree ...................................................................... buildsystem: build out-of-tree The buildsystem used to create symlinks to dependency source files in the testsuite directories, and then building inside that source directory. This lead to many unrelated files being in the source directory. Change the logic to create symlinks to all sources in a separate $BUILDDIR instead (default: _build) and do the build there. Advantages: * Source directories are not cluttered with other files anymore. * Clean up logic becomes much simpler and faster (rm -rf _build instead of generating a Makefile and running "make clean" in every testsuite directory). * No need to generate gitignore files on the fly anymore. * Using a separate $BUILDDIR is now possible, this will be used by testenv in a follow-up patch when running with podman, to make sure that build artifacts from podman and not using podman are not mixed as they are incompatible. Related: OS#6599 Change-Id: If18aaf2a2a0d55bb617e5cb1b73f6ee4b1952494 --- M .gitignore M Makefile M _buildsystem/gen_links.inc.sh M _buildsystem/regen_makefile.inc.sh D _buildsystem/rmlinks.sh M _testenv/testenv/testsuite.py M start-testsuite.sh 7 files changed, 89 insertions(+), 58 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/40032/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If18aaf2a2a0d55bb617e5cb1b73f6ee4b1952494 Gerrit-Change-Number: 40032 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025