April 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-hlr[osmith/1.9.1]: db: flush after changing schema version

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39893?usp=email ) Change subject: db: flush after changing schema version ...................................................................... db: flush after changing schema version Flush the cache after changing the version, to make the scenario less likely that after an unclean shutdown the DB gets restored with the right table layout but wrong version. When that happens, osmo-hlr tries to upgrade the database layout again and fails with errors like "duplicate column name". Related: SYS#7394 Change-Id: I5943a1cb3447c038c6e7972f68f9656b73a9248b (cherry picked from commit 1a71e73fdc40ba712ab61a299c9d4a048df539a2) --- M src/db.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/93/39893/1 diff --git a/src/db.c b/src/db.c index 7b8a415..4ce5aa0 100644 --- a/src/db.c +++ b/src/db.c @@ -595,6 +595,7 @@ int rc; bool has_sqlite_config_sqllog = false; int version; + bool version_changed = false; LOGP(DDB, LOGL_NOTICE, "using database: %s\n", fname); LOGP(DDB, LOGL_INFO, "Compiled against SQLite3 lib version %s\n", SQLITE_VERSION); @@ -672,6 +673,7 @@ goto out_free; } version = CURRENT_SCHEMA_VERSION; + version_changed = true; } LOGP(DDB, LOGL_NOTICE, "Database '%s' has HLR DB schema version %d\n", dbc->fname, version); @@ -686,6 +688,7 @@ } LOGP(DDB, LOGL_NOTICE, "Database '%s' has been upgraded to HLR DB schema version %d\n", dbc->fname, version+1); + version_changed = true; } if (version != CURRENT_SCHEMA_VERSION) { @@ -702,6 +705,12 @@ goto out_free; } + /* Flush the cache after changing the version, to make the scenario + * less likely that after an unclean shutdown the DB gets restored + * with the right table layout but wrong version (SYS#7394). */ + if (version_changed) + sqlite3_db_cacheflush(dbc->db); + /* prepare all SQL statements */ for (i = 0; i < ARRAY_SIZE(dbc->stmt); i++) { rc = sqlite3_prepare_v2(dbc->db, stmt_sql[i], -1, -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: I5943a1cb3447c038c6e7972f68f9656b73a9248b Gerrit-Change-Number: 39893 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-hlr[osmith/1.9.1]: Bump version: 1.9.0.1-aa8594 → 1.9.0

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39894?usp=email ) Change subject: Bump version: 1.9.0.1-aa8594 → 1.9.0 ...................................................................... Bump version: 1.9.0.1-aa8594 → 1.9.0 Change-Id: I56d3eeb320e175d6d1d6b50d939bbe7fd98e3ad5 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/94/39894/1 diff --git a/debian/changelog b/debian/changelog index dbf1ec1..b1c3c88 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,5 +1,11 @@ osmo-hlr (1.9.0) unstable; urgency=medium + * db: flush after changing schema version + + -- Oliver Smith <osmith(a)sysmocom.de> Wed, 02 Apr 2025 09:54:51 +0200 + +osmo-hlr (1.9.0) unstable; urgency=medium + [ Vadim Yanitskiy ] * subscriber-create-on-demand: rework configuration * subscriber-create-on-demand: add mode for MSISDN=IMSI -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: osmith/1.9.1 Gerrit-Change-Id: I56d3eeb320e175d6d1d6b50d939bbe7fd98e3ad5 Gerrit-Change-Number: 39894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list

by laforge

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 3: (1 comment) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39863/comment/2c73979f_400e49a4?usp=em… : PS3, Line 106: action there is a way (I forgot how exactly, maybet he "choices" argument?) to tell the parser which strings are permitted here. Please try to figure out how to get that from the asn1 parser. This way we can * catch invalid/unsupported input already within argparse * the user sees which services they can add/remove in --help -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:39:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 1 week

1
0
0 0

[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list

by laforge

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 3: (1 comment) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39863/comment/1aeeab4f_0675acba?usp=em… : PS3, Line 104: set "set" sounds like it is setting (overwriting) the list. Add/remove however are incremental operations, so I think it's a bit of a misnomer. I'd suggest to rename to edit-mandatory-service-list, edit-mand-service-list or something like that, or "modify" instead of "edit". or if you think it's too long, {edit,modify}-mand-srv-list? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:37:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 1 week

1
0
0 0

[L] Change in pysim[master]: saip-tool: add features to add, remove and inspect application PEs

by laforge

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39860?usp=email ) Change subject: saip-tool: add features to add, remove and inspect application PEs ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I41db96f2f0ccc29c1725a92215ce6b17d87b76ce Gerrit-Change-Number: 39860 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:36:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in pysim[master]: saip-tool: add ProfileElement class for application PE

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39883?usp=email ) Change subject: saip-tool: add ProfileElement class for application PE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaa43036d388fbf1714c53cab1fc21092c4667a21 Gerrit-Change-Number: 39883 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:33:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in osmo-e1d[master]: contrib/e1-prbs-test: Note osmo-e1d capability in README

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/39892?usp=email ) Change subject: contrib/e1-prbs-test: Note osmo-e1d capability in README ...................................................................... contrib/e1-prbs-test: Note osmo-e1d capability in README Change-Id: I76b72359267014c7df431699698c5c4e2c0cd53d --- M contrib/e1-prbs-test/README 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved tnt: Looks good to me, but someone else must approve diff --git a/contrib/e1-prbs-test/README b/contrib/e1-prbs-test/README index 903cc39..891fe7f 100644 --- a/contrib/e1-prbs-test/README +++ b/contrib/e1-prbs-test/README @@ -1,5 +1,5 @@ -e1-prbs-test - Utility to test for bit errors on E1 lines using DAHDI -====================================================================== +e1-prbs-test - Utility to test for bit errors on E1 lines +========================================================= e1-prbs-test can be used to test for bit errors in E1 transmission lines. It consists of a sender and a receiver, which should be used @@ -8,8 +8,9 @@ Transmitter and receiver can be on the same machine, or on different machines. -The code currently works directly on DAHDI, so only DAHDI-supported E1 -cards are supported at this point. +The code currently works directly on DAHDI or via osmo-e1d, so both +DAHDI-supported E1 interfaces as well as osmo-e1d supported ones +are supported at this point. The test works by sending timeslot-specific PRBS sequences of 512 bit (64byte) length on the transmit side, and by correlating to those PRBS @@ -25,6 +26,9 @@ The test will run indefinitely. +For using osmo-e1d, use "e1d:0:0" and "e1d:0:1" for interface 0 line 0 + 1 +instead of the /dev/dahdi/chan/xxx notation. + If you'd like to get an interim report, send a SIGHUP to e1-prbs-test. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/39892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I76b72359267014c7df431699698c5c4e2c0cd53d Gerrit-Change-Number: 39892 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com>

4 months, 1 week

1
0
0 0

[S] Change in osmo-e1d[master]: contrib/e1-prbs-test: Note osmo-e1d capability in README

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-e1d/+/39892?usp=email ) Change subject: contrib/e1-prbs-test: Note osmo-e1d capability in README ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/39892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I76b72359267014c7df431699698c5c4e2c0cd53d Gerrit-Change-Number: 39892 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:32:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: Bump version: 0.3.2

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39891?usp=email ) Change subject: Bump version: 0.3.2 ...................................................................... Bump version: 0.3.2 Change-Id: I8d3a546b755db92834b64f3451d166b0a97331bc --- M debian/changelog 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 4d56e35..eaa669e 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +osmo-diameter2gsup (0.3.2) unstable; urgency=medium + + [ Vadim Yanitskiy ] + * gsup_client: disable gen_server event tracing + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 01 Apr 2025 17:21:03 +0200 + osmo-diameter2gsup (0.3.1) unstable; urgency=medium * examples/*.config: change diameter_ip to 127.0.0.8 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I8d3a546b755db92834b64f3451d166b0a97331bc Gerrit-Change-Number: 39891 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in osmo-e1d[master]: contrib/e1-prbs-test: Note osmo-e1d capability in README

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-e1d/+/39892?usp=email ) Change subject: contrib/e1-prbs-test: Note osmo-e1d capability in README ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/39892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I76b72359267014c7df431699698c5c4e2c0cd53d Gerrit-Change-Number: 39892 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 01 Apr 2025 21:12:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025