March 2025 - gerrit-log - lists.osmocom.org

[L] Change in docker-playground[master]: nplab-{m3ua,sua}-test: Record pcap of all testsuite run

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/39770?usp=email ) Change subject: nplab-{m3ua,sua}-test: Record pcap of all testsuite run ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/docker-playground/+/39770/comment/2ff61613_143… : PS3, Line 8: maybe note here that tcpdump-{start,stop}.sh were imported from osmo-ttcn3-hacks.git -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39770?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If4ea74c07d5aaca1278811ce8398dff23c386c10 Gerrit-Change-Number: 39770 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Mar 2025 07:24:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 4 weeks

1
0
0 0

[L] Change in docker-playground[master]: nplab-{m3ua,sua}-test: Record pcap of all testsuite run

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/39770?usp=email ) Change subject: nplab-{m3ua,sua}-test: Record pcap of all testsuite run ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39770?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If4ea74c07d5aaca1278811ce8398dff23c386c10 Gerrit-Change-Number: 39770 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Mar 2025 07:23:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 4 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: trau: new function osmo_trau2rtp_ufe()

by falconia

Attention is currently required from: fixeria, laforge. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email ) Change subject: trau: new function osmo_trau2rtp_ufe() ...................................................................... Patch Set 2: (3 comments) File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/8d0f6488_f62a05c9… : PS1, Line 458: static int trau2rtp_efr(uint8_t *out, size_t out_len, const struct osmo_trau_frame *tf, bool emit_twts001) > likewise Done https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/b9346341_9f3f56c4… : PS1, Line 247: * \param[in] tf input TRAU frame in decoded form > the new ufe output argument should be documented here in the comment. Done https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/3047209b_3211b07c… : PS1, Line 346: * \param[in] emit_twts002 self-explanatory > likewise Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a90eca296b17b1211e5c2125fb1496cd362e1c9 Gerrit-Change-Number: 39731 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Mar 2025 23:36:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 4 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: trau: new function osmo_trau2rtp_ufe()

by falconia

Attention is currently required from: falconia, fixeria. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: trau: new function osmo_trau2rtp_ufe() ...................................................................... trau: new function osmo_trau2rtp_ufe() TRAU frame formats for newer codecs (HR, EFR, AMR) include a UFE (uplink frame error) indicator bit in the DL direction. TRAUs are expected to set this bit to active error state (0 for HR/EFR/AMR or 1 for D144 E-TRAU) if frame synchronization is lost in the UL direction, or if received TRAU-UL frames have bad CRC or invalid control bits - errors that indicate corruption on terrestrial circuits or faults in the CCU, rather than radio Rx errors. In Osmocom implementation, TRAU frame CRC and control bit patterns are checked during conversion to RTP, as part of the work done by osmo_trau2rtp() - but there is no separate return indication from that function that distinguishes these errors from ordinary BFIs due to radio errors or FACCH stealing etc. Solution: add a new API function that indicates UFE conditions separately. Related: OS#6614 Change-Id: I7a90eca296b17b1211e5c2125fb1496cd362e1c9 --- M include/osmocom/trau/trau_rtp.h M src/trau/trau_rtp_conv.c 2 files changed, 89 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/31/39731/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a90eca296b17b1211e5c2125fb1496cd362e1c9 Gerrit-Change-Number: 39731 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 4 weeks

1
0
0 0

[XS] Change in libosmo-netif[master]: stream_{cli,srv}: fix copy-paste in API docs

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39775?usp=email ) Change subject: stream_{cli,srv}: fix copy-paste in API docs ...................................................................... stream_{cli,srv}: fix copy-paste in API docs Change-Id: I8ec783b8db36a017dc3fe111b0ca0938488ae03d --- M src/stream_cli.c M src/stream_srv.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/75/39775/1 diff --git a/src/stream_cli.c b/src/stream_cli.c index fa3ac76..0028dcc 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -873,10 +873,10 @@ return 0; } -/*! Set the socket type for the stream server link. +/*! Set the socket domain for the stream client link. * Any changes to this setting will only become active upon next (re)connect. * \param[in] cli Stream Client to modify - * \param[in] type Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...) + * \param[in] domain Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...) * \returns zero on success, negative -errno on error. */ int osmo_stream_cli_set_domain(struct osmo_stream_cli *cli, int domain) diff --git a/src/stream_srv.c b/src/stream_srv.c index 366fe64..50efbb8 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -366,10 +366,10 @@ return 0; } -/*! Set the socket type for the stream server link. +/*! Set the socket domain for the stream server link. * Any changes to this setting will only become active upon next (re)connect. * \param[in] link Stream Server Link to modify - * \param[in] type Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...) + * \param[in] domain Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...) * \returns zero on success, negative on error. */ int osmo_stream_srv_link_set_domain(struct osmo_stream_srv_link *link, int domain) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39775?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I8ec783b8db36a017dc3fe111b0ca0938488ae03d Gerrit-Change-Number: 39775 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 4 weeks

1
0
0 0

[L] Change in docker-playground[master]: nplab-{m3ua,sua}-test: Record pcap of all testsuite run

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/39770?usp=email ) Change subject: nplab-{m3ua,sua}-test: Record pcap of all testsuite run ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39770?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If4ea74c07d5aaca1278811ce8398dff23c386c10 Gerrit-Change-Number: 39770 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Mar 2025 21:54:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 4 weeks

1
0
0 0

[XL] Change in osmo-ccid-firmware[master]: Make ch9 usb tests work

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email ) Change subject: Make ch9 usb tests work ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Icadaee9d8cbe24bd3cac002cc4f710dcf846a32b Gerrit-Change-Number: 39759 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Mar 2025 21:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 4 weeks

1
0
0 0

[S] Change in osmo-ccid-firmware[master]: add ext power detect & dev reset

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email ) Change subject: add ext power detect & dev reset ...................................................................... Patch Set 10: Code-Review+1 (1 comment) File sysmoOCTSIM/main.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447/comment/fe639119_ec… : PS7, Line 334: { > i really don't think we need one line of comments for a 2 line function that is called extpower_dete […] not everyone ever lookin at that code in the future is as smart as you and knows that a change from self-powered to bus-powered needs to be reflected in he USB descriptor and that in turn needs [at least] a USB reset. I'm able to interpret as much into it now, but I usually assume people reading such code have lower knowledge level or experience in the specific codebase/product/problem area. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ied62450670dba2227daa96cbcd162cfe8414445a Gerrit-Change-Number: 39447 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Mar 2025 21:51:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 4 weeks

1
0
0 0

[M] Change in osmo-ccid-firmware[master]: fix usb usb reset handling by delayed soft reset

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445?usp=email ) Change subject: fix usb usb reset handling by delayed soft reset ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File sysmoOCTSIM/hpl/core/hpl_init.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445/comment/1f106f0f_fa… : PS3, Line 63: // _oscctrl_init_referenced_generators(); > ping? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0939930a42f3009abf7e670561a123963bbd3845 Gerrit-Change-Number: 39445 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Mar 2025 21:49:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 4 weeks

1
0
0 0

[S] Change in osmo-ccid-firmware[master]: tame the linter

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39441?usp=email ) Change subject: tame the linter ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I84f8637b47047bb9b8c217b0869a486ceee7243f Gerrit-Change-Number: 39441 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Mar 2025 21:48:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025