March 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ccid-firmware[master]: clean up slot reset hack

by Hoernchen

Hoernchen has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39760?usp=email ) Change subject: clean up slot reset hack ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iebde945661569882d136406b8c11fa9653323d37 Gerrit-Change-Number: 39760 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org>

3 months, 4 weeks

1
0
0 0

[XS] Change in osmo-ccid-firmware[master]: strict prototypes

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39443?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: strict prototypes ...................................................................... strict prototypes Change-Id: Ic2915a9182dc64ac1e3fba7da18a71ff9fe91944 --- M sysmoOCTSIM/command.c M sysmoOCTSIM/gcc/Makefile M sysmoOCTSIM/hpl/port/hpl_gpio_base.h M sysmoOCTSIM/main.c 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/43/39443/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39443?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic2915a9182dc64ac1e3fba7da18a71ff9fe91944 Gerrit-Change-Number: 39443 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

3 months, 4 weeks

1
0
0 0

[S] Change in osmo-ccid-firmware[master]: tame the linter

by Hoernchen

Attention is currently required from: Hoernchen, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39441?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: tame the linter ...................................................................... tame the linter Change-Id: I84f8637b47047bb9b8c217b0869a486ceee7243f --- A .checkpatch.conf 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/41/39441/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I84f8637b47047bb9b8c217b0869a486ceee7243f Gerrit-Change-Number: 39441 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

3 months, 4 weeks

1
0
0 0

[XS] Change in osmo-ccid-firmware[master]: fix up usb version string, not 0 terminated

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39442?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: fix up usb version string, not 0 terminated ...................................................................... fix up usb version string, not 0 terminated Change-Id: I198f0a55c5c5853ea58f20ad4124a909952a3074 --- M sysmoOCTSIM/main.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/42/39442/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39442?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I198f0a55c5c5853ea58f20ad4124a909952a3074 Gerrit-Change-Number: 39442 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

3 months, 4 weeks

1
0
0 0

[XS] Change in osmo-ccid-firmware[master]: ccid dev: fix sizeof abuse

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39444?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ccid dev: fix sizeof abuse ...................................................................... ccid dev: fix sizeof abuse Change-Id: Ia96247af6f2a887d3c894a65983e795b9e5a7cbe --- M ccid_common/ccid_device.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/44/39444/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia96247af6f2a887d3c894a65983e795b9e5a7cbe Gerrit-Change-Number: 39444 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

3 months, 4 weeks

1
0
0 0

[XS] Change in osmo-ccid-firmware[master]: usb desc: use per-interface dev class instead of CDC

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39446?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: usb desc: use per-interface dev class instead of CDC ...................................................................... usb desc: use per-interface dev class instead of CDC Change-Id: I9d4f88b973f0c16d2c1241343d416496b35019a0 --- M sysmoOCTSIM/usb_descriptors.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/46/39446/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39446?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I9d4f88b973f0c16d2c1241343d416496b35019a0 Gerrit-Change-Number: 39446 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

3 months, 4 weeks

1
0
0 0

[XS] Change in osmo-ccid-firmware[master]: out ep: fix swapped error handling

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39501?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: out ep: fix swapped error handling ...................................................................... out ep: fix swapped error handling Change-Id: I2833f0aca3ffebfceaaf2a0681a9f8242817e722 --- M sysmoOCTSIM/main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/01/39501/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I2833f0aca3ffebfceaaf2a0681a9f8242817e722 Gerrit-Change-Number: 39501 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

3 months, 4 weeks

1
0
0 0

[XL] Change in osmo-ccid-firmware[master]: Make ch9 usb tests work

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email ) Change subject: Make ch9 usb tests work ...................................................................... Patch Set 2: (4 comments) File sysmoOCTSIM/main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22023): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/bc0054ef_32… : PS2, Line 593: continue; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22023): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/44457597_3f… : PS2, Line 610: // ; please, no space before tabs File sysmoOCTSIM/usb/class/ccid/device/ccid_df.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22023): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/91793d14_03… : PS2, Line 228: // return ERR_NOT_FOUND; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22023): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/6fb174d6_56… : PS2, Line 242: // return ERR_NONE; please, no space before tabs -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Icadaee9d8cbe24bd3cac002cc4f710dcf846a32b Gerrit-Change-Number: 39759 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 11 Mar 2025 17:47:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 4 weeks

1
0
0 0

[XL] Change in osmo-ccid-firmware[master]: Make ch9 usb tests work

by Hoernchen

Attention is currently required from: laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email ) Change subject: Make ch9 usb tests work ...................................................................... Patch Set 2: (4 comments) File contrib/ch9_epstall.py: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/c1ebedac_68… : PS1, Line 3: ch9 usb ep halt test > Does that test have a name/number? If so, it would be good to add as a spec reference. Done File contrib/gdb_clocktree.py: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/4f1d368a_b8… : PS1, Line 1: import gdb > please add copyright/author and at least a brief summary. Done File contrib/gdb_sercom.py: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/794b71d1_c8… : PS1, Line 1: import gdb > a line with author / copyright information is missing, and at least a very high-level description of […] Done File contrib/gdb_usb.py: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/34c176e3_45… : PS1, Line 3: > same here: copyright/author/brief description there will not be a description because i specifically said snippets which means collection of random code fragments that might or might not be useful. nothing is useful as is. i just don't want to poke google every time some arcane gdb python bullshit acts up again. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Icadaee9d8cbe24bd3cac002cc4f710dcf846a32b Gerrit-Change-Number: 39759 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 11 Mar 2025 17:47:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 4 weeks

1
0
0 0

[S] Change in osmo-ccid-firmware[master]: add ext power detect & dev reset

by Hoernchen

Attention is currently required from: laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email ) Change subject: add ext power detect & dev reset ...................................................................... Patch Set 8: (1 comment) File sysmoOCTSIM/main.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447/comment/63e1ecf6_3a… : PS7, Line 334: { > the purpose here is to reset the board if it switches from bus-powered to self-powered? might be goo […] i really don't think we need one line of comments for a 2 line function that is called extpower_detect and calls systemreset... -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ied62450670dba2227daa96cbcd162cfe8414445a Gerrit-Change-Number: 39447 Gerrit-PatchSet: 8 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 11 Mar 2025 17:47:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025